python-trio transient test failures

  • Open
  • quality assurance status badge
Details
2 participants
  • Josselin Poiret
  • Sharlatan Hellseher
Owner
unassigned
Submitted by
Josselin Poiret
Severity
normal
J
J
Josselin Poiret wrote on 14 Feb 15:19 +0100
(address . bug-guix@gnu.org)
87jzn76sdg.fsf@jpoiret.xyz
Hi everyone,

python-trio sometimes exhibits test failures, as in the following

Toggle snippet (49 lines)
=================================== FAILURES ===================================
____________________ test_wait_reapable_fails[open_process] ____________________
[gw15] linux -- Python 3.10.7 /gnu/store/375350pi1l1izgnx6dnsqmg4xjyprx8q-python-wrapper-3.10.7/bin/python

background_process = <function open_process_then_kill at 0x7ffff40fed40>

@pytest.mark.skipif(not posix, reason="POSIX specific")
@background_process_param
async def test_wait_reapable_fails(background_process):
> old_sigchld = signal.signal(signal.SIGCHLD, signal.SIG_IGN)

trio/tests/test_subprocess.py:449:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

signalnum = <Signals.SIGCHLD: 17>, handler = <Handlers.SIG_IGN: 1>

@_wraps(_signal.signal)
def signal(signalnum, handler):
> handler = _signal.signal(_enum_to_int(signalnum), _enum_to_int(handler))
E ValueError: signal only works in main thread of the main interpreter

/gnu/store/91wasjkmy50p8fq0rf9jby80mnmq1fxr-python-3.10.7/lib/python3.10/signal.py:56: ValueError
_______________ test_wait_reapable_fails[run_process in nursery] _______________
[gw15] linux -- Python 3.10.7 /gnu/store/375350pi1l1izgnx6dnsqmg4xjyprx8q-python-wrapper-3.10.7/bin/python

background_process = <function run_process_in_nursery at 0x7ffff40fee60>

@pytest.mark.skipif(not posix, reason="POSIX specific")
@background_process_param
async def test_wait_reapable_fails(background_process):
> old_sigchld = signal.signal(signal.SIGCHLD, signal.SIG_IGN)

trio/tests/test_subprocess.py:449:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

signalnum = <Signals.SIGCHLD: 17>, handler = <Handlers.SIG_IGN: 1>

@_wraps(_signal.signal)
def signal(signalnum, handler):
> handler = _signal.signal(_enum_to_int(signalnum), _enum_to_int(handler))
E ValueError: signal only works in main thread of the main interpreter

/gnu/store/91wasjkmy50p8fq0rf9jby80mnmq1fxr-python-3.10.7/lib/python3.10/signal.py:56: ValueError
=========================== short test summary info ============================
FAILED trio/tests/test_subprocess.py::test_wait_reapable_fails[open_process]
FAILED trio/tests/test_subprocess.py::test_wait_reapable_fails[run_process in nursery]
================== 2 failed, 371 passed, 17 skipped in 3.82s ===================

Note that I am on Linux 6.8-rc3 currently. Can anyone reproduce?

Best,
--
Josselin Poiret
-----BEGIN PGP SIGNATURE-----

iQHEBAEBCAAuFiEEOSSM2EHGPMM23K8vUF5AuRYXGooFAmXMy9sQHGRldkBqcG9p
cmV0Lnh5egAKCRBQXkC5Fhcaij5yDACn8CjsqA2ftRFoDV/4BQqQZSrGntKOPdmK
w3haKzUCQOuuYAF3mUHaD4CgsJkLM8sRAbD3k4KkkNF+4GaaP9ojgzzUVoP22HwC
D+3mdbYyUrO4YBcmbxSxyAB+WspRC3d2J1KEVSkKMBDARPx495lDZwT86Il2lIrs
RhQXLDV9oHyD/WZ97MYmk2F1sFx45ru/HfN0GvcXR71NzwtDyy2O2RdXbr9MFqL4
0mulMUakWAhhSuDELqU21hQHwAklzUAD5XDt0jTxNnUmIfEhm+TzJhkbVDNGtN4T
GAZlDdhDncxP9loSz4EXtFze+w0j+eAZ3kqsVDcB+VjeWnq1jSYyGhiYp6qanP9Z
czvCfbhovgEKSr1pYUjrLf839QdK1bN/D4krVBrzYAAXx5fQ+5u6vtTroIATYU6W
ogMCSfl5FMTd1HNQBlW6OYPMR0RS0J1/C6ULMeuNmzIJueYWiLGRTrk8aE+HQB5E
x9mYHSuROnozOFbUJr7wbZFxmv6D0Qo=
=iKby
-----END PGP SIGNATURE-----

S
J
J
Josselin Poiret wrote on 15 Feb 12:09 +0100
(name . Sharlatan Hellseher)(address . sharlatanus@gmail.com)
87r0heasrn.fsf@jpoiret.xyz
Hi Oleg,

Sharlatan Hellseher <sharlatanus@gmail.com> writes:

Toggle quote (4 lines)
> Maybe it's time to update it or disable some shaky tests.
>
> WDYT?

I agree, I was looking into this on core-updates but didn't want to
commit to updating this as it also needs some dependency upgrades.

Best,
--
Josselin Poiret
-----BEGIN PGP SIGNATURE-----

iQHEBAEBCAAuFiEEOSSM2EHGPMM23K8vUF5AuRYXGooFAmXN8NwQHGRldkBqcG9p
cmV0Lnh5egAKCRBQXkC5FhcaigGjC/0ZN13TvJgf834cC2n0qwRjeJysV6bXQqdT
7Prs+BcCxX4jsxKO06P+o4F/9hqXORcNA+nUOHheq8f8G/rxa1eTcj4LzahnD1DH
CUZTGB5W7uOuwaakuCm9H9m1CGWEwRlZdrGAFlUPI1ESuksvlUPW6eSRXuLdSepj
Y2ZqM41Sh5FnQgXd8zL7aOqjksDvXRoKXwYkHEgZCEdwVeyiQb4Llts/3W5bzo7q
m3fkfd7bKtxhNoN4js6MGWH9IWg8KSpXcLRYDU2088jvonbXXiF98EXQY8S2RW2T
u1vMsGsvyfDBWYDXh87G1gRsieNqTz5PRMPEUf6oSSRN2WS07tvig4NThXcC7NtK
x96Y6I/6utQjpGwMKEN5V9Aob/KEQ9Os9zTRbYs6oQgxg1V++w/YcJQmoRYsHklY
Ww4ifv5oz/S+TIWH9Pj0O5WBfaN+SPsc2UmmxeF1Cp//aXscE5ab/3qbHdQ9XziP
9MSVGYPr9VVX4pOS59Ntpq+y/keRewM=
=DIml
-----END PGP SIGNATURE-----

?