[PATCH] gnu: tmux: Update to 3.4.

Done

Details

4 participants

ashish.is
Dale Mellor
Christopher Baines
Skyler Ferris

Owner: unassigned

Submitted by: ashish.is

Severity: normal

ashish.is wrote on 13 Feb 23:10 +0100

Recipients:(address . guix-patches@gnu.org)(name . Ashish SHUKLA)(address . ashish.is@lostca.se)

Message-ID:20240213221101.624345-1-ashish.is@lostca.se

* gnu/packages/tmux.scm (tmux): Update to 3.4.

Signed-off-by: Ashish SHUKLA <ashish.is@lostca.se>

---

gnu/packages/tmux.scm | 7 +++++--

1 file changed, 5 insertions(+), 2 deletions(-)

Toggle diff (37 lines)diff --git a/gnu/packages/tmux.scm b/gnu/packages/tmux.scm
index 4d9dea2396..96d95da0cb 100644
--- a/gnu/packages/tmux.scm
+++ b/gnu/packages/tmux.scm
@@ -36,6 +36,7 @@ (define-module (gnu packages tmux)
   #:use-module (guix build-system python)
   #:use-module (gnu packages)
   #:use-module (gnu packages bash)
+  #:use-module (gnu packages bison)
   #:use-module (gnu packages check)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages libevent)
@@ -45,7 +46,7 @@ (define-module (gnu packages tmux)
 (define-public tmux
   (package
     (name "tmux")
-    (version "3.3a")
+    (version "3.4")
     (source (origin
              (method url-fetch)
              (uri (string-append
@@ -53,10 +54,12 @@ (define-public tmux
                     version "/tmux-" version ".tar.gz"))
              (sha256
               (base32
-               "0gzrrm6imhcp3sr5vw8g71x9n40bbdidwvcdyk2741xx8dw39zg4"))))
+               "1ahr7si3akr55hadyms3p36f1pbwavpkbfxpsq55ql5zl3gbh6jm"))))
     (build-system gnu-build-system)
     (inputs
      (list libevent ncurses))
+    (native-inputs
+     (list bison))
     (home-page "https://github.com/tmux/tmux/wiki")
     (synopsis "Terminal multiplexer")
     (description
-- 
2.41.0

Skyler Ferris wrote on 14 Feb 03:10 +0100

Recipients:

Message-ID:620fedda-ae51-4959-9935-1d684e49aa47@protonmail.com

Hi Ashish,

I'm adding some review notes to this issue. To avoid any confusion, I

want to be clear that I am not a committer, but I hope that these notes

will help a committer process this patch more quickly.

There is no cryptographic signature hosted on GitHub. My computer

downloaded a file from the specified location with the same hash as

specified in the patch.

I applied the patch to commit ac470c516e19f194228edf9e348bdbc7fc10f97a

and it applied cleanly.

I built the new version of tmux for an x86_64 machine and successfully

ran it from the store (my machine is technically a Xen guest, running on

x86_64 hardware).

I also built it with `--rounds=2` and no differences were reported.

The output of `guix refresh --list-dependent tmux` indicated that there

are 2 dependency leaves: `zsh-autosuggestions` and `python-daemux`. The

former built successfully. The latter triggered a build of

`python-libtmux` which built successfully. The build of `python-daemux`

failed, but this seems unrelated. I am seeing the same error that is

shown in the most recent x86_64 build:

http://ci.guix.gnu.org/build/2678780/log

Regards,

Skyler

Ashish wrote on 14 Feb 12:16 +0100

Recipients:(name . Skyler Ferris)(address . skyvine@protonmail.com)(address . 69109@debbugs.gnu.org)

Message-ID:maefkitylhfnndkricdkytmrzi4rmulqnhr4ajiv3azm3yl2g4@cfdkfzteng2u

Hi Skyler,

Thanks for taking time to review the patch.

On Wed, Feb 14, 2024 at 02:10:53AM +0000, Skyler Ferris wrote:

Toggle quote (10 lines)> Hi Ashish,
> 
> I'm adding some review notes to this issue. To avoid any confusion, I 
> want to be clear that I am not a committer, but I hope that these notes 
> will help a committer process this patch more quickly.
> 
> There is no cryptographic signature hosted on GitHub. My computer 
> downloaded a file from the specified location with the same hash as 
> specified in the patch.

I assumed GitHub doesn't tamper the archives, and since the archive was downloaded over HTTPS, the possibility of MITM tampering it is almost zero. I'll ofcourse keep in mind to use the upstream hashes/signatures when provided.

Toggle quote (17 lines)> I applied the patch to commit ac470c516e19f194228edf9e348bdbc7fc10f97a 
> and it applied cleanly.
> 
> I built the new version of tmux for an x86_64 machine and successfully 
> ran it from the store (my machine is technically a Xen guest, running on 
> x86_64 hardware).
> 
> I also built it with `--rounds=2` and no differences were reported.
> 
> The output of `guix refresh --list-dependent tmux` indicated that there 
> are 2 dependency leaves: `zsh-autosuggestions` and `python-daemux`. The 
> former built successfully. The latter triggered a build of 
> `python-libtmux` which built successfully. The build of `python-daemux` 
> failed, but this seems unrelated. I am seeing the same error that is 
> shown in the most recent x86_64 build: 
> http://ci.guix.gnu.org/build/2678780/log

Indeed, it looks the same to me.

Ashish | GPG: F682 CDCC 39DC 0FEA E116 20B6 C746 CFA9 E74F A4B0

"If I destroy you, what business is it of yours ?" (Dark Forest, Liu Cixin)

Dale Mellor wrote on 8 May 15:27 +0200

[PATCH v2] gnu: tmux: Update to 3.4.

Recipients:(address . 69109@debbugs.gnu.org)

Message-ID:20240508132710.1820796-1-guix-devel-0brg6a@rdmp.org

* gnu/packages/tmux.scm (tmux): Update to 3.4.

Review:

* Addresses issue 69109

* Minimal change needed for version bump, plus new native dependence

on bison.

* Applies cleanly to current master HEAD.

* guix lint/build-check/build-source-check all clean

* other review discussion (issue 69109) asserts no new damage to dependents

* it works for me on X86_64 architecture

Reviewed-by: Dale Mellor <guix-devel-0brg6a@rdmp.org>

Signed-off-by: Ashish SHUKLA <ashish.is@lostca.se>

---

gnu/packages/tmux.scm | 7 +++++--

1 file changed, 5 insertions(+), 2 deletions(-)

Toggle diff (37 lines)diff --git a/gnu/packages/tmux.scm b/gnu/packages/tmux.scm
index 4d9dea2396..96d95da0cb 100644
--- a/gnu/packages/tmux.scm
+++ b/gnu/packages/tmux.scm
@@ -36,6 +36,7 @@ (define-module (gnu packages tmux)
   #:use-module (guix build-system python)
   #:use-module (gnu packages)
   #:use-module (gnu packages bash)
+  #:use-module (gnu packages bison)
   #:use-module (gnu packages check)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages libevent)
@@ -45,7 +46,7 @@ (define-module (gnu packages tmux)
 (define-public tmux
   (package
     (name "tmux")
-    (version "3.3a")
+    (version "3.4")
     (source (origin
              (method url-fetch)
              (uri (string-append
@@ -53,10 +54,12 @@ (define-public tmux
                     version "/tmux-" version ".tar.gz"))
              (sha256
               (base32
-               "0gzrrm6imhcp3sr5vw8g71x9n40bbdidwvcdyk2741xx8dw39zg4"))))
+               "1ahr7si3akr55hadyms3p36f1pbwavpkbfxpsq55ql5zl3gbh6jm"))))
     (build-system gnu-build-system)
     (inputs
      (list libevent ncurses))
+    (native-inputs
+     (list bison))
     (home-page "https://github.com/tmux/tmux/wiki")
     (synopsis "Terminal multiplexer")
     (description
-- 
2.41.0

Christopher Baines wrote 4 days ago

Re: [bug#69109] Re: [bug#69109] [PATCH] gnu: tmux: Update to 3.4.

Recipients:(name . Ashish)(address . ashish.is@lostca.se)

Message-ID:87zfsu7uyh.fsf@cbaines.net

Ashish via Guix-patches via <guix-patches@gnu.org> writes:

Toggle quote (4 lines)

> Hi Skyler,

> Thanks for taking time to review the patch.

Thanks both, I've pushed this to master as

0dac1307ccc9a04df49080f3c76b1018268d7d68.

Chris

Closed

Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 69109@debbugs.gnu.org

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date