[PATCH] gnu: lightning: Update to 2.2.3

  • Open
  • quality assurance status badge
Details
3 participants
  • Andy Tai
  • John Kehayias
  • Tanguy LE CARROUR
Owner
unassigned
Submitted by
Andy Tai
Severity
normal
A
A
Andy Tai wrote on 9 Feb 08:21 +0100
(address . guix-patches@gnu.org)(name . Andy Tai)(address . atai@atai.org)
3044aa80738402ba092cc29422a27e265e0b6acf.1707463217.git.atai@atai.org
* gnu/packages/assembly.scm (lightning): Update to 2.2.3

Change-Id: Iddd550f1521b447acf4f119ddc9c2567a091427d
---
gnu/packages/assembly.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (25 lines)
diff --git a/gnu/packages/assembly.scm b/gnu/packages/assembly.scm
index 3bfe0bd3e0..9fcfba2f6c 100644
--- a/gnu/packages/assembly.scm
+++ b/gnu/packages/assembly.scm
@@ -196,14 +196,14 @@ (define-public yasm
(define-public lightning
(package
(name "lightning")
- (version "2.2.2")
+ (version "2.2.3")
(source (origin
(method url-fetch)
(uri (string-append "mirror://gnu/lightning/lightning-"
version ".tar.gz"))
(sha256
(base32
- "1qmkfg7br543kqy82hhpr1n8bsm9wrwb1z5w2whxc5xdvr185jha"))))
+ "0ab89k0xn1mdgabrbfk2993jx6835i8glrhhn7zgpbq07aiwfif0"))))
(build-system gnu-build-system)
(native-inputs (list zlib))
(arguments

base-commit: 570ef13a87bb54d3410c431700ba78316a2641e2
--
2.41.0
A
A
Andy Tai wrote on 10 Feb 05:14 +0100
Re: QA review for 68997
(name . Tanguy LE CARROUR)(address . tanguy@bioneland.org)(address . 68997@debbugs.gnu.org)
CAJsg1E-neCTyVS9Wp12TBrtHxVtV-cLcT5s9WYSg5ekeSoj4tA@mail.gmail.com
I just take a look of QA, it seems to pass but a downstream package
GNU smalltalk which uses ligntning fails to build. That has always
failed to build for many years on x86-64 so not a new problem.
On Fri, Feb 9, 2024 at 9:35?AM Andy Tai <atai@atai.org> wrote:
Toggle quote (56 lines)
>
> Thanks. On my (Guix x86-64 machine), all tests did pass
>
> On Fri, Feb 9, 2024 at 7:29?AM Tanguy LE CARROUR <tanguy@bioneland.org> wrote:
>>
>> Hi Andy,
>>
>> Thanks for the patch.
>> For what it’s worth, it LGTM, but… it fails to pass the tests on my machine.
>> It’s still in WIP on QA, so… it could only be my machine.
>>
>> ```
>> ===============================================
>> GNU lightning 2.2.3: check/test-suite.log
>> ===============================================
>>
>> # TOTAL: 135
>> # PASS: 133
>> # SKIP: 0
>> # XFAIL: 0
>> # FAIL: 2
>> # XPASS: 0
>> # ERROR: 0
>>
>>
>> .. contents:: :depth: 2
>>
>> FAIL: bit
>> =========
>>
>> 1d0
>> &lt; ok
>> FAIL bit (exit status: 1)
>>
>> FAIL: bit.nodata
>> ================
>>
>> 1d0
>> &lt; ok
>> FAIL bit.nodata (exit status: 1)
>> ```
>>
>> Regards
>>
>> --
>> Tanguy
>>
>> Items marked as checked: Commit messages
>
>
>
> --
> Andy Tai, atai@atai.org, Skype: licheng.tai, Line: andy_tai, WeChat: andytai1010
> Year 2023 ??112?
> ????????????
> ????????????
--
Andy Tai, atai@atai.org, Skype: licheng.tai, Line: andy_tai, WeChat: andytai1010
Year 2023 ??112?
????????????
????????????
T
T
Tanguy LE CARROUR wrote on 12 Feb 16:04 +0100
(name . Andy Tai)(address . atai@atai.org)(address . 68997@debbugs.gnu.org)
170775029152.7976.12046362726223535452@bioneland.org
Hi,


Quoting Andy Tai (2024-02-10 05:14:43)
Toggle quote (4 lines)
> I just take a look of QA, it seems to pass but a downstream package
> GNU smalltalk which uses ligntning fails to build. That has always
> failed to build for many years on x86-64 so not a new problem.

It does build on my computer at work! And CI looks OK, except for the
problem with smalltalk on x86_64 that you mentioned.

Tobias did the last update and commit for this package. This might be
the right person to ping if no committer picks up your patch.

Regards,

--
Tanguy
J
J
John Kehayias wrote on 14 Feb 21:38 +0100
Re: [bug#68997] QA review for 68997
(name . Tanguy LE CARROUR)(address . tanguy@bioneland.org)
87le7mn5lz.fsf@protonmail.com
Hello,

On Mon, Feb 12, 2024 at 04:04 PM, Tanguy LE CARROUR wrote:

Toggle quote (9 lines)
> Hi,
>
>
> Quoting Andy Tai (2024-02-10 05:14:43)
>> I just take a look of QA, it seems to pass but a downstream package
>> GNU smalltalk which uses ligntning fails to build. That has always
>> failed to build for many years on x86-64 so not a new problem.
>

For smalltalk (on master, x86_64): I do see it failing on Berlin
(ci.guix.gnu.org) but there is a substitute from Bordeaux.

Toggle quote (4 lines)
> It does build on my computer at work! And CI looks OK, except for the
> problem with smalltalk on x86_64 that you mentioned.
>

This patch for lightning builds for me locally as well. But smalltalk
then fails.

So it would be good to see why (fails tests) and if that can be fixed.
I'm not familiar at all with smalltalk so I didn't take a look, maybe
someone that knows the package can be CC'ed.

Toggle quote (5 lines)
> Tobias did the last update and commit for this package. This might be
> the right person to ping if no committer picks up your patch.
>
> Regards,

John
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 68997@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 68997
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch