New home-dotfiles-service-type creates extra toplevel directories

  • Done
  • quality assurance status badge
Details
3 participants
  • Giacomo
  • Janneke Nieuwenhuizen
  • Ludovic Courtès
Owner
unassigned
Submitted by
Janneke Nieuwenhuizen
Severity
normal
J
J
Janneke Nieuwenhuizen wrote on 31 Jan 13:17 +0100
(address . bug-guix@gnu.org)
87cythy9wq.fsf@gnu.org
Hi,

When I follow the documentation, and have

dotfiles/guix/.config/guix/channels.scm

that shows suing tree -a ./dotfiles

dotfiles
??? guix
??? .config
??? guix
??? channels.scm

similar to the documentaion, and using

(service home-dotfiles-service-type
(home-dotfiles-configuration
(directories (list "./dotfiles"))))

creates

~/guix/.config/guix/channels.scm

an extra toplevel `guix" directory!

What gives?

Greetings,
Janneke

--
Janneke Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com| Avatar® https://AvatarAcademy.com
G
G
Giacomo wrote on 31 Jan 13:31 +0100
D29097E8-217F-491E-8BD4-6FD15C1F162E@autistici.org
Hi Janneke, thank you for the report. I already pointed out this at https://issues.guix.gnu.org/60521. there was a fix that was removed by a misunderstanding on the requirements of the service since the code contradicts documentation as you pointed out . It should be pretty easy to apply the fix from 60521.

Thank you

Giacomo

Il 31 gennaio 2024 13:17:25 CET, Janneke Nieuwenhuizen <janneke@gnu.org> ha scritto:
Toggle quote (34 lines)
>Hi,
>
>When I follow the documentation, and have
>
> dotfiles/guix/.config/guix/channels.scm
>
>that shows suing tree -a ./dotfiles
>
> dotfiles
> ??? guix
> ??? .config
> ??? guix
> ??? channels.scm
>
>similar to the documentaion, and using
>
> (service home-dotfiles-service-type
> (home-dotfiles-configuration
> (directories (list "./dotfiles"))))
>
>creates
>
> ~/guix/.config/guix/channels.scm
>
>an extra toplevel `guix" directory!
>
>What gives?
>
>Greetings,
>Janneke
>
>--
>Janneke Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond https://LilyPond.org
>Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com
Attachment: file
P
P
paul wrote on 31 Jan 23:15 +0100
gnu: home: dotfiles: Avoid creating extra directory in $HOME.
(address . guix-patches@gnu.org)
14bc720d-7fdc-516a-3018-58294c1cafcd@autistici.org
Hello,

I'm sending a patch supposed to fix https://issues.guix.gnu.org/68848 .
Please let me know if this is ok for you and fixes your issues.


Thank you,


giacomo
L
L
Ludovic Courtès wrote on 6 Mar 23:15 +0100
(name . Giacomo Leidi)(address . goodoldpaul@autistici.org)
87v85z6m8o.fsf_-_@gnu.org
Hi,

Giacomo Leidi <goodoldpaul@autistici.org> skribis:

Toggle quote (21 lines)
> The current implementation of the home-dotfiles-service-type contradicts
> the Guix manual (see https://issues.guix.gnu.org/68848 ). This patch
> properly implements both the plain and Stow dotfiles directory layouts.
>
> It does so by refactoring home-dotfiles-configuration adding a new
> packages field to support GNU Stow's users workflow and introducing
> a new layout field to switch between the two directory layouts.
>
> * gnu/home/services/dotfiles (home-dotfiles-configuration): Migrate to
> (gnu services configuration);
> [packages]: new field;
> [layout]: new field;
> (strip-stow-dotfile): new variable;
> (strip-plain-dotfile): new variable;
> (home-dotfiles-configuration->files): use the new fields;
> [directory-contents]: allow for
> selecting a subset of application dotfile directories;
> * doc/guix.texi: document the new layouts.
>
> Change-Id: I2e96037608353e360828290f055ec5271cfdfd48

Applied, thanks again!

Ludo’.
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 68848@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 68848
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch