[PATCH gnome-team] gnu: gnome-desktop: Propagate gnome-remote-desktop and gnome-connections.

  • Done
  • quality assurance status badge
Details
3 participants
  • Liliana Marie Prikler
  • Maxim Cournoyer
  • Vivien Kraus
Owner
unassigned
Submitted by
Vivien Kraus
Severity
normal

Debbugs page

Vivien Kraus wrote 1 years ago
(address . guix-patches@gnu.org)
3493fd05a83c57fa4782e30e7247abab92ef102f.1705527021.git.vivien@planete-kraus.eu
* gnu/packages/gnome.scm (gnome) [propagated-inputs]: Add gnome-connections
and gnome-remote-desktop.

Change-Id: I218cf0c3c4d52d9f611275737accb0f723fe94b5
---
gnu/packages/gnome.scm | 2 ++
1 file changed, 2 insertions(+)

Toggle diff (24 lines)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index d17676f53b..04a87626d9 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -10183,6 +10183,7 @@ (define-public gnome
gnome-calendar
gnome-characters
gnome-clocks
+ gnome-connections
gnome-console
gnome-contacts
gnome-disk-utility
@@ -10190,6 +10191,7 @@ (define-public gnome
gnome-maps
gnome-music
gnome-photos
+ gnome-remote-desktop
gnome-screenshot
gnome-system-monitor
gnome-text-editor

base-commit: 2cbb1a6e1e2679c7db74b6b906d223fb3661d09f
--
2.41.0
Liliana Marie Prikler wrote 1 years ago
4971c2a0fd33569be3d98978e9000cdb84ad8d85.camel@gmail.com
Am Dienstag, dem 16.01.2024 um 22:32 +0100 schrieb Vivien Kraus:
Toggle quote (3 lines)
> * gnu/packages/gnome.scm (gnome) [propagated-inputs]: Add gnome-
> connections
> and gnome-remote-desktop.
Are these core GNOME applications? I think we might want to have
another meta-package for these + builder + whatever-else.

Cheers
Maxim Cournoyer wrote 1 years ago
(name . Liliana Marie Prikler)(address . liliana.prikler@gmail.com)
87edebhn8s.fsf@gmail.com
Hi Liliana,

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

Toggle quote (7 lines)
> Am Dienstag, dem 16.01.2024 um 22:32 +0100 schrieb Vivien Kraus:
>> * gnu/packages/gnome.scm (gnome) [propagated-inputs]: Add gnome-
>> connections
>> and gnome-remote-desktop.
> Are these core GNOME applications? I think we might want to have
> another meta-package for these + builder + whatever-else.

For any query about what's core and at what version, you'll want to
check in the GNOME releng repository [0]; there's no tag but the commit
history is clear about the corresponding GNOME release. The release
team also snapshot such file in e.g. [1].

Answering the question, yes they are part of core GNOME applications.


--
Thanks,
Maxim
Liliana Marie Prikler wrote 1 years ago
(name . Maxim Cournoyer)(address . maxim.cournoyer@gmail.com)
2ce92558c93cd765d7b9361bce4aa4f9e9273a79.camel@gmail.com
Am Samstag, dem 20.01.2024 um 13:29 -0500 schrieb Maxim Cournoyer:
Toggle quote (20 lines)
> Hi Liliana,
>
> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
>
> > Am Dienstag, dem 16.01.2024 um 22:32 +0100 schrieb Vivien Kraus:
> > > * gnu/packages/gnome.scm (gnome) [propagated-inputs]: Add gnome-
> > > connections and gnome-remote-desktop.
> > Are these core GNOME applications?  I think we might want to have
> > another meta-package for these + builder + whatever-else.
>
> For any query about what's core and at what version, you'll want to
> check in the GNOME releng repository [0]; there's no tag but the
> commit history is clear about the corresponding GNOME release.  The
> release team also snapshot such file in e.g. [1].
>
> Answering the question, yes they are part of core GNOME applications.
>
> [0] 
> https://gitlab.gnome.org/GNOME/releng/-/blob/dcec695c6ae86a156656935d3e0247cb233e44bd/tools/versions-stable
> [1]  https://ftp2.nluug.nl/windowing/gnome/teams/releng/45.0/versions
I'm not sure, releng is that authoritative. [2] markets devhelp as
"developer extra", and only lists gnome-connections out of the two.
The actual source of truth appears to be encoded in yaml files over at
[3] and is appropriately version-tagged.

Cheers

Maxim Cournoyer wrote 1 years ago
(name . Liliana Marie Prikler)(address . liliana.prikler@gmail.com)
87jzo2abme.fsf@gmail.com
Hi Liliana,

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

Toggle quote (26 lines)
> Am Samstag, dem 20.01.2024 um 13:29 -0500 schrieb Maxim Cournoyer:
>> Hi Liliana,
>>
>> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
>>
>> > Am Dienstag, dem 16.01.2024 um 22:32 +0100 schrieb Vivien Kraus:
>> > > * gnu/packages/gnome.scm (gnome) [propagated-inputs]: Add gnome-
>> > > connections and gnome-remote-desktop.
>> > Are these core GNOME applications?  I think we might want to have
>> > another meta-package for these + builder + whatever-else.
>>
>> For any query about what's core and at what version, you'll want to
>> check in the GNOME releng repository [0]; there's no tag but the
>> commit history is clear about the corresponding GNOME release.  The
>> release team also snapshot such file in e.g. [1].
>>
>> Answering the question, yes they are part of core GNOME applications.
>>
>> [0] 
>> https://gitlab.gnome.org/GNOME/releng/-/blob/dcec695c6ae86a156656935d3e0247cb233e44bd/tools/versions-stable
>> [1]  https://ftp2.nluug.nl/windowing/gnome/teams/releng/45.0/versions
> I'm not sure, releng is that authoritative. [2] markets devhelp as
> "developer extra", and only lists gnome-connections out of the two.
> The actual source of truth appears to be encoded in yaml files over at
> [3] and is appropriately version-tagged.

I'm not sure either, but that's what I was pointed at by GNOME devs such
as ebassi last time I ask in #gnome. I think it's there for a good
reason, perhaps as the bill of materials used by their own GNOME image
(distribution).

--
Thanks,
Maxim
Vivien Kraus wrote 1 years ago
174967df6e6fb29592195bed1e8944fe292d6e1c.camel@planete-kraus.eu
Hello!

Le samedi 20 janvier 2024 à 20:46 +0100, Liliana Marie Prikler a
écrit :
Toggle quote (2 lines)
> [2] markets devhelp as
> "developer extra", and only lists gnome-connections out of the two.
It would be sad to have only gnome-connections and not gnome-remote-
desktop. What remote desktop would you access?

Toggle quote (3 lines)
> The actual source of truth appears to be encoded in yaml files over
> at
> [3] and is appropriately version-tagged.
Can you decipher it? I don’t understand where you would find the
information.

Best regards,

Vivien
Vivien Kraus wrote 1 years ago
[PATCH gnome-team v2] gnu: gnome-desktop: Propagate missing core applications.
(address . 68551@debbugs.gnu.org)
61a9ceb094a57bba073a9b1e673f7e78eca58f14.1705961791.git.vivien@planete-kraus.eu
The categories are from the meta-packages in the

* gnu/packages/gnome.scm (gnome) [propagated-inputs]: Add gnome-connections
and gnome-remote-desktop. Add GNOME-Core-Developer-Tools section with
dconf-editor, devhelp, d-spy, gnome-boxes, gnome-builder, sysprof. Add
GNOME-Core-Mobile section with calls.

Change-Id: I218cf0c3c4d52d9f611275737accb0f723fe94b5
---
Dear guix,

have the core applications in the correct section (and yes,
gnome-remote-desktop is one!). That’s quite a lot of applications, but maybe
it’s OK. What do you think? Regarding i686-linux, gnome-shell depends on gjs
and thus rust, so I’m not sure there’s anything to save.

Best regards,

Vivien

gnu/packages/gnome.scm | 11 +++++++++++
1 file changed, 11 insertions(+)

Toggle diff (40 lines)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 3d89f06d6a..fdc903d48d 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -10145,6 +10145,15 @@ (define-public gnome
(list eog)
'())
,@(list
+ ;; GNOME-Core-Developer-Tools.
+ dconf-editor
+ devhelp
+ d-spy
+ gnome-boxes
+ gnome-builder
+ sysprof
+ ;; GNOME-Core-Mobile.
+ calls
;; GNOME-Core-OS-Services.
accountsservice
network-manager
@@ -10162,6 +10171,7 @@ (define-public gnome
gnome-initial-setup
gnome-keyring
gnome-menus
+ gnome-remote-desktop
gnome-session
gnome-settings-daemon
gnome-shell
@@ -10185,6 +10195,7 @@ (define-public gnome
gnome-calendar
gnome-characters
gnome-clocks
+ gnome-connections
gnome-console
gnome-contacts
gnome-disk-utility

base-commit: 49897f2dde7f469c83c496fad2699d3a05f72701
--
2.41.0
Maxim Cournoyer wrote 1 years ago
(name . Vivien Kraus)(address . vivien@planete-kraus.eu)
87ede323u1.fsf@gmail.com
Hi,

Vivien Kraus <vivien@planete-kraus.eu> writes:

Toggle quote (18 lines)
> The categories are from the meta-packages in the
> https://gitlab.gnome.org/GNOME/gnome-build-meta repository.
>
> * gnu/packages/gnome.scm (gnome) [propagated-inputs]: Add gnome-connections
> and gnome-remote-desktop. Add GNOME-Core-Developer-Tools section with
> dconf-editor, devhelp, d-spy, gnome-boxes, gnome-builder, sysprof. Add
> GNOME-Core-Mobile section with calls.
>
> Change-Id: I218cf0c3c4d52d9f611275737accb0f723fe94b5
> ---
> Dear guix,
>
> I crawled https://gitlab.gnome.org/GNOME/gnome-build-meta and I think now we
> have the core applications in the correct section (and yes,
> gnome-remote-desktop is one!). That’s quite a lot of applications, but maybe
> it’s OK. What do you think? Regarding i686-linux, gnome-shell depends on gjs
> and thus rust, so I’m not sure there’s anything to save.

Thanks for doing so!

Toggle quote (44 lines)
> Best regards,
>
> Vivien
>
> gnu/packages/gnome.scm | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 3d89f06d6a..fdc903d48d 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -10145,6 +10145,15 @@ (define-public gnome
> (list eog)
> '())
> ,@(list
> + ;; GNOME-Core-Developer-Tools.
> + dconf-editor
> + devhelp
> + d-spy
> + gnome-boxes
> + gnome-builder
> + sysprof
> + ;; GNOME-Core-Mobile.
> + calls
> ;; GNOME-Core-OS-Services.
> accountsservice
> network-manager
> @@ -10162,6 +10171,7 @@ (define-public gnome
> gnome-initial-setup
> gnome-keyring
> gnome-menus
> + gnome-remote-desktop
> gnome-session
> gnome-settings-daemon
> gnome-shell
> @@ -10185,6 +10195,7 @@ (define-public gnome
> gnome-calendar
> gnome-characters
> gnome-clocks
> + gnome-connections
> gnome-console
> gnome-contacts
> gnome-disk-utility

I think that's fine for now, and the RFC from Liliana looks great as
well, so the above could be used as the legacy meta-package (I assume
they are part of Liliana's new categorized lists of default GNOME
packages that can be configured).

Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>

--
Thanks,
Maxim
Liliana Marie Prikler wrote 1 years ago
bfe76adaf1b78912f2c5d1552901ae417b8ffe75.camel@gmail.com
Am Freitag, dem 26.01.2024 um 16:16 -0500 schrieb Maxim Cournoyer:
Toggle quote (74 lines)
> Hi,
>
> Vivien Kraus <vivien@planete-kraus.eu> writes:
>
> > The categories are from the meta-packages in the
> > https://gitlab.gnome.org/GNOME/gnome-build-meta repository.
> >
> > * gnu/packages/gnome.scm (gnome) [propagated-inputs]: Add gnome-
> > connections and gnome-remote-desktop. Add GNOME-Core-Developer-
> > Tools section
> > with dconf-editor, devhelp, d-spy, gnome-boxes, gnome-builder,
> > sysprof. Add GNOME-Core-Mobile section with calls.
> >
> > Change-Id: I218cf0c3c4d52d9f611275737accb0f723fe94b5
> > ---
> > Dear guix,
> >
> > I crawled https://gitlab.gnome.org/GNOME/gnome-build-meta and I
> > think now we have the core applications in the correct section (and
> > yes, gnome-remote-desktop is one!).  That’s quite a lot of
> > applications, but maybe it’s OK. What do you think? Regarding i686-
> > linux, gnome-shell depends on gjs and thus rust, so I’m not sure
> > there’s anything to save.
>
> Thanks for doing so!
>
> > Best regards,
> >
> > Vivien
> >
> >  gnu/packages/gnome.scm | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> > index 3d89f06d6a..fdc903d48d 100644
> > --- a/gnu/packages/gnome.scm
> > +++ b/gnu/packages/gnome.scm
> > @@ -10145,6 +10145,15 @@ (define-public gnome
> >               (list eog)
> >               '())
> >         ,@(list
> > +          ;; GNOME-Core-Developer-Tools.
> > +          dconf-editor
> > +          devhelp
> > +          d-spy
> > +          gnome-boxes
> > +          gnome-builder
> > +          sysprof
> > +          ;; GNOME-Core-Mobile.
> > +          calls
> >            ;; GNOME-Core-OS-Services.
> >            accountsservice
> >            network-manager
> > @@ -10162,6 +10171,7 @@ (define-public gnome
> >            gnome-initial-setup
> >            gnome-keyring
> >            gnome-menus
> > +          gnome-remote-desktop
> >            gnome-session
> >            gnome-settings-daemon
> >            gnome-shell
> > @@ -10185,6 +10195,7 @@ (define-public gnome
> >            gnome-calendar
> >            gnome-characters
> >            gnome-clocks
> > +          gnome-connections
> >            gnome-console
> >            gnome-contacts
> >            gnome-disk-utility
>
> I think that's fine for now, and the RFC from Liliana looks great as
> well, so the above could be used as the legacy meta-package (I assume
> they are part of Liliana's new categorized lists of default GNOME
> packages that can be configured).
I skipped the optional bits (developer tools + calls), as they're a
rather mixed bag. We should probably add the other two, however.

Cheers
Vivien Kraus wrote 1 years ago
Re: [PATCH gnome-team v2] gnu: gnome-desk top: Propagate missing core applications.
FC54A207-DD19-4600-84DD-061F959E4C4D@planete-kraus.eu
Hello!

The extra packages that I included in this patch (calls and the developer tools) were there because you hinted to a source that had them listed. I don’t care if you keep them or not.

Vivien
Attachment: file
Vivien Kraus wrote 1 years ago
[PATCH gnome-team] gnu: gnome-desktop: Propagate gnome-remote-desktop and gnome-connections.
(address . 68551-done@debbugs.gnu.org)
3134b4a92f7956e8056d675ebbb0ecb8597c4ffe.camel@planete-kraus.eu
I’m closing this one in favor of https://issues.guix.gnu.org/68716
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 68551@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 68551
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help