[PATCH 0/8] Fix usage of glib-or-gtk-build-system

  • Done
  • quality assurance status badge
Details
3 participants
  • Andreas Enge
  • Nicolas Graves
  • Tomas Volf
Owner
unassigned
Submitted by
Tomas Volf
Severity
normal

Debbugs page

Tomas Volf wrote 1 years ago
(address . guix-patches@gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
cover.1703953716.git.~@wolfsden.cz
Using glib-or-gtk-build-system requires hard-coding the list of modules in
#:modules. Libreoffice and netsurf tried to use
%glib-or-gtk-build-system-modules instead, but that lead to crashes.

This series introduces new %glib-or-gtk-build-system-default-modules that
contains the list that should go into #:modules. Using it in libreoffice and
netsurf fixes the mentioned crashes. Other places were adjusted as well to
use it instead of copying over the list. That would be hard to keep in sync.

Tomas Volf (8):
build: glib-or-gtk: Export %glib-or-gtk-build-system-default-modules.
gnu: netsurf: Actually use glib-or-gtk-build-system.
gnu: libreoffice: Actually use glib-or-gtk-build-system.
gnu: sugar: Dehardcode #:modules.
gnu: sugar-datastore: Dehardcode #:modules.
gnu: sugar-toolkit-gtk3: Dehardcode #:modules.
gnu: nimf: Dehardcode #:modules.
gnu: hime: Dehardcode #:modules.

gnu/packages/language.scm | 12 ++++--------
gnu/packages/libreoffice.scm | 2 +-
gnu/packages/sugar.scm | 15 ++++++---------
gnu/packages/web.scm | 2 +-
guix/build-system/glib-or-gtk.scm | 9 +++++----
5 files changed, 17 insertions(+), 23 deletions(-)


base-commit: f24b14767d362a84e6469682b4fe303b50f4b589
--
2.41.0
Tomas Volf wrote 1 years ago
[PATCH 2/8] gnu: netsurf: Actually use glib-or-gtk-build-system.
(address . 68150@debbugs.gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
e48f4e3a570af8f37f131ca170d67f81a1542243.1703953716.git.~@wolfsden.cz
The #:modules argument was based on %glib-or-gtk-build-system-modules, which,
despite the name, should go into #:imported-modules. When put into #:modules,
it leads to following warning:

WARNING: (guile-user): `%standard-phases' imported from both (guix build glib-or-gtk-build-system) and (guix build gnu-build-system)

Due to the definition of %glib-or-gtk-build-system-modules

`((guix build glib-or-gtk-build-system)
,@%gnu-build-system-modules)

It results in %standard-phases from gnu-build-system being used, effectively
turning glib-or-gtk-build-system with #:modules set to
%glib-or-gtk-build-system-modules into gnu-build-system.

The solution is to use the (now) exported default value of
#:modules (%glib-or-gtk-build-system-default-modules) as a base of the
#:modules.

* gnu/packages/web.scm (netsurf)[arguments]<#:modules>: Use
%glib-or-gtk-build-system-default-modules instead of
%glib-or-gtk-build-system-modules.

Change-Id: Iacc4df7e213dbdae5a783e3aedde7e6e20402025
---
gnu/packages/web.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)
diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index 67f59ca9f9..df476e7ccd 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -5927,7 +5927,7 @@ (define-public netsurf
(ice-9 match)
(srfi srfi-1)
(sxml simple)
- ,@%glib-or-gtk-build-system-modules)
+ ,@%glib-or-gtk-build-system-default-modules)
#:phases
(modify-phases %standard-phases
(delete 'configure)
--
2.41.0
Tomas Volf wrote 1 years ago
[PATCH 1/8] build: glib-or-gtk: Export %glib-or-gtk-build-system-default-modules.
(address . 68150@debbugs.gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
c005e76b76bf4f5775e6a6750bdf2fc583bf3de4.1703953716.git.~@wolfsden.cz
The list of modules used by default was not public, so users of this build
system had to pick between copy&pasting the list, or using
%glib-or-gtk-build-system-modules. The former is sub-optimal, since it is
hard to keep it in sync. The latter is just wrong and leads to basically
fall-backing to gnu-build-system.

The solution is to export the default list giving the users option to use it
directly.

* guix/build-system/glib-or-gtk.scm
(%glib-or-gtk-build-system-default-modules): Renamed from %default-modules.
(define-module): Export it.
(glib-or-gtk-build), (glib-or-gtk-cross-build): Use it.

Change-Id: I331b2a3f0bdc3ce14eb9f2f80605e7873369168d
---
guix/build-system/glib-or-gtk.scm | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)

Toggle diff (43 lines)
diff --git a/guix/build-system/glib-or-gtk.scm b/guix/build-system/glib-or-gtk.scm
index 726d19efad..38a6eeb178 100644
--- a/guix/build-system/glib-or-gtk.scm
+++ b/guix/build-system/glib-or-gtk.scm
@@ -30,7 +30,8 @@ (define-module (guix build-system glib-or-gtk)
#:use-module (guix build-system)
#:use-module (guix build-system gnu)
#:use-module (guix packages)
- #:export (%glib-or-gtk-build-system-modules
+ #:export (%glib-or-gtk-build-system-default-modules
+ %glib-or-gtk-build-system-modules
glib-or-gtk-build
glib-or-gtk-cross-build
glib-or-gtk-build-system)
@@ -64,7 +65,7 @@ (define-module (guix build-system glib-or-gtk)
;;
;; Code:
-(define %default-modules
+(define %glib-or-gtk-build-system-default-modules
;; Build-side modules made available in the build environment.
'((guix build glib-or-gtk-build-system)
(guix build utils)))
@@ -144,7 +145,7 @@ (define* (glib-or-gtk-build name inputs
(glib-or-gtk-wrap-excluded-outputs ''())
(system (%current-system))
(imported-modules %glib-or-gtk-build-system-modules)
- (modules %default-modules)
+ (modules %glib-or-gtk-build-system-default-modules)
allowed-references
disallowed-references)
"Build SOURCE with INPUTS. See GNU-BUILD for more details."
@@ -219,7 +220,7 @@ (define* (glib-or-gtk-cross-build name
(system (%current-system))
(build (nix-system->gnu-triplet system))
(imported-modules %glib-or-gtk-build-system-modules)
- (modules %default-modules)
+ (modules %glib-or-gtk-build-system-default-modules)
allowed-references
disallowed-references)
"Cross-build SOURCE with INPUTS. See GNU-BUILD for more details."
--
2.41.0
Tomas Volf wrote 1 years ago
[PATCH 4/8] gnu: sugar: Dehardcode #:modules.
(address . 68150@debbugs.gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
a8fd8db36ca2c87c22c437a2c0b406d3fff52a62.1703953716.git.~@wolfsden.cz
* gnu/packages/sugar.scm (sugar)[arguments]<#:modules>: Replace the hardcoded
list with %glib-or-gtk-build-system-default-modules.

Change-Id: I5a98d356c3e1a32b71e7949e3425da74081c1e82
---
gnu/packages/sugar.scm | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

Toggle diff (18 lines)
diff --git a/gnu/packages/sugar.scm b/gnu/packages/sugar.scm
index 4a0de1b55a..30f78c5576 100644
--- a/gnu/packages/sugar.scm
+++ b/gnu/packages/sugar.scm
@@ -70,9 +70,8 @@ (define-public sugar
`(,@%glib-or-gtk-build-system-modules
(guix build python-build-system))
#:modules
- '((guix build glib-or-gtk-build-system)
- ((guix build python-build-system) #:prefix python:)
- (guix build utils))
+ `(((guix build python-build-system) #:prefix python:)
+ ,@%glib-or-gtk-build-system-default-modules)
#:phases
#~(modify-phases %standard-phases
(add-after 'unpack 'patch-build-system
--
2.41.0
Tomas Volf wrote 1 years ago
[PATCH 5/8] gnu: sugar-datastore: Dehardcode #:modules.
(address . 68150@debbugs.gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
83443339431be8eba633a862e259eb20b1583895.1703953716.git.~@wolfsden.cz
* gnu/packages/sugar.scm (sugar-datastore)[arguments]<#:modules>: Replace the
hardcoded list with %glib-or-gtk-build-system-default-modules.

Change-Id: I9ceadd163d3f6cd49ed2623b6060b223257e9aed
---
gnu/packages/sugar.scm | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

Toggle diff (18 lines)
diff --git a/gnu/packages/sugar.scm b/gnu/packages/sugar.scm
index 30f78c5576..8a79509de2 100644
--- a/gnu/packages/sugar.scm
+++ b/gnu/packages/sugar.scm
@@ -252,9 +252,8 @@ (define-public sugar-datastore
`(,@%glib-or-gtk-build-system-modules
(guix build python-build-system))
#:modules
- '((guix build glib-or-gtk-build-system)
- ((guix build python-build-system) #:prefix python:)
- (guix build utils))
+ `(((guix build python-build-system) #:prefix python:)
+ ,@%glib-or-gtk-build-system-default-modules)
#:phases
'(modify-phases %standard-phases
(add-after 'unpack 'patch-build-system
--
2.41.0
Tomas Volf wrote 1 years ago
[PATCH 6/8] gnu: sugar-toolkit-gtk3: Dehardcode #:modules.
(address . 68150@debbugs.gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
489ff2a82cc757acebd23ac1e93f9bbf48112ed3.1703953716.git.~@wolfsden.cz
* gnu/packages/sugar.scm (sugar-toolkit-gtk3)[arguments]<#:modules>: Replace
the hardcoded list with %glib-or-gtk-build-system-default-modules.

Change-Id: I6a5e4511d2e696a673f7d5b49f75285ee488223d
---
gnu/packages/sugar.scm | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

Toggle diff (18 lines)
diff --git a/gnu/packages/sugar.scm b/gnu/packages/sugar.scm
index 8a79509de2..6df07d5cc2 100644
--- a/gnu/packages/sugar.scm
+++ b/gnu/packages/sugar.scm
@@ -320,9 +320,8 @@ (define-public sugar-toolkit-gtk3
`(,@%glib-or-gtk-build-system-modules
(guix build python-build-system))
#:modules
- '((guix build glib-or-gtk-build-system)
- ((guix build python-build-system) #:prefix python:)
- (guix build utils))
+ `(((guix build python-build-system) #:prefix python:)
+ ,@%glib-or-gtk-build-system-default-modules)
#:phases
#~(modify-phases %standard-phases
(add-after 'unpack 'patch-build-system
--
2.41.0
Tomas Volf wrote 1 years ago
[PATCH 3/8] gnu: libreoffice: Actually use glib-or-gtk-build-system.
(address . 68150@debbugs.gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
035edc6095b0f8e7c3bee5408d37e0d23d493a6e.1703953716.git.~@wolfsden.cz
The #:modules argument was based on %glib-or-gtk-build-system-modules, which,
despite the name, should go into #:imported-modules. When put into #:modules,
it leads to following warning:

WARNING: (guile-user): `%standard-phases' imported from both (guix build glib-or-gtk-build-system) and (guix build gnu-build-system)

Due to the definition of %glib-or-gtk-build-system-modules

`((guix build glib-or-gtk-build-system)
,@%gnu-build-system-modules)

It results in %standard-phases from gnu-build-system being used, effectively
turning glib-or-gtk-build-system with #:modules set to
%glib-or-gtk-build-system-modules into gnu-build-system.

The solution is to use the (now) exported default value of
#:modules (%glib-or-gtk-build-system-default-modules) as a base of the
#:modules.

* gnu/packages/libreoffice.scm (libreoffice)[arguments]<#:modules>: Use
%glib-or-gtk-build-system-default-modules instead of
%glib-or-gtk-build-system-modules.

Change-Id: I5304d9993af7d5f1187c6276e72a269aa60f5666
---
gnu/packages/libreoffice.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)
diff --git a/gnu/packages/libreoffice.scm b/gnu/packages/libreoffice.scm
index 79b30cecaf..6368dbf5bb 100644
--- a/gnu/packages/libreoffice.scm
+++ b/gnu/packages/libreoffice.scm
@@ -915,7 +915,7 @@ (define-public libreoffice
,@%glib-or-gtk-build-system-modules)
#:modules `(((guix build python-build-system) #:select (python-version))
(ice-9 textual-ports)
- ,@%glib-or-gtk-build-system-modules)
+ ,@%glib-or-gtk-build-system-default-modules)
#:tests? #f ; Building the tests already fails.
#:phases
#~(modify-phases %standard-phases
--
2.41.0
Tomas Volf wrote 1 years ago
[PATCH 8/8] gnu: hime: Dehardcode #:modules.
(address . 68150@debbugs.gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
fde756b510c44ffe19c41d44281cd99f54344132.1703953716.git.~@wolfsden.cz
* gnu/packages/language.scm (hime)[arguments]<#:modules>: Replace the
hardcoded list with %glib-or-gtk-build-system-default-modules.

Change-Id: I5360c0000173b293e9e24290a2e8eaed84e05750
---
gnu/packages/language.scm | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

Toggle diff (19 lines)
diff --git a/gnu/packages/language.scm b/gnu/packages/language.scm
index 30af9e33f5..4e64324af1 100644
--- a/gnu/packages/language.scm
+++ b/gnu/packages/language.scm
@@ -218,10 +218,8 @@ (define-public hime
(guix build qt-build-system)
(guix build qt-utils))
#:modules
- ((guix build glib-or-gtk-build-system)
- ((guix build qt-build-system)
- #:prefix qt:)
- (guix build utils))
+ (((guix build qt-build-system) #:prefix qt:)
+ ,@%glib-or-gtk-build-system-default-modules)
#:configure-flags
(list
;; FIXME
--
2.41.0
Tomas Volf wrote 1 years ago
[PATCH 7/8] gnu: nimf: Dehardcode #:modules.
(address . 68150@debbugs.gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
dfe58c52b4c7be158fbbd5fbe05328e23c405319.1703953716.git.~@wolfsden.cz
* gnu/packages/language.scm (nimf)[arguments]<#:modules>: Replace the
hardcoded list with %glib-or-gtk-build-system-default-modules.

Change-Id: I5eaaac4cdd50b635d24b10c7fa2d365dcf392498
---
gnu/packages/language.scm | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

Toggle diff (19 lines)
diff --git a/gnu/packages/language.scm b/gnu/packages/language.scm
index db78425ec9..30af9e33f5 100644
--- a/gnu/packages/language.scm
+++ b/gnu/packages/language.scm
@@ -99,10 +99,8 @@ (define-public nimf
(guix build cmake-build-system)
(guix build qt-build-system)
(guix build qt-utils))
- #:modules '((guix build glib-or-gtk-build-system)
- ((guix build qt-build-system)
- #:prefix qt:)
- (guix build utils))
+ #:modules `(((guix build qt-build-system) #:prefix qt:)
+ ,@%glib-or-gtk-build-system-default-modules)
#:configure-flags
#~(list "--with-im-config-data"
"--with-imsettings-data"
--
2.41.0
Tomas Volf wrote 5 months ago
[PATCH v2 2/8] gnu: netsurf: Actually use glib-or-gtk-build-system.
(address . 68150@debbugs.gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
c1524d27f8384098ef301c1902e129fa3806f460.1728234031.git.~@wolfsden.cz
The #:modules argument was based on %glib-or-gtk-build-system-modules, which,
despite the name, should go into #:imported-modules. When put into #:modules,
it leads to following warning:

WARNING: (guile-user): `%standard-phases' imported from both (guix build glib-or-gtk-build-system) and (guix build gnu-build-system)

Due to the definition of %glib-or-gtk-build-system-modules

`((guix build glib-or-gtk-build-system)
,@%gnu-build-system-modules)

It results in %standard-phases from gnu-build-system being used, effectively
turning glib-or-gtk-build-system with #:modules set to
%glib-or-gtk-build-system-modules into gnu-build-system.

The solution is to use the (now) exported default value of
#:modules (%glib-or-gtk-build-system-default-modules) as a base of the
#:modules.

* gnu/packages/web.scm (netsurf)[arguments]<#:modules>: Use
%glib-or-gtk-build-system-default-modules instead of
%glib-or-gtk-build-system-modules.

Change-Id: Iacc4df7e213dbdae5a783e3aedde7e6e20402025
---
Rebase on latest master.

gnu/packages/web.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (13 lines)
diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index 552abf83c5..0ed88c11cf 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -6265,7 +6265,7 @@ (define-public netsurf
(ice-9 match)
(srfi srfi-1)
(sxml simple)
- ,@%glib-or-gtk-build-system-modules)
+ ,@%glib-or-gtk-build-system-default-modules)
#:phases
(modify-phases %standard-phases
(delete 'configure)
--
2.46.0
Tomas Volf wrote 5 months ago
[PATCH v2 3/8] gnu: libreoffice: Actually use glib-or-gtk-build-system.
(address . 68150@debbugs.gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
048211ca5d3fca6a7d86973ddf7bfb8dca426649.1728234031.git.~@wolfsden.cz
The #:modules argument was based on %glib-or-gtk-build-system-modules, which,
despite the name, should go into #:imported-modules. When put into #:modules,
it leads to following warning:

WARNING: (guile-user): `%standard-phases' imported from both (guix build glib-or-gtk-build-system) and (guix build gnu-build-system)

Due to the definition of %glib-or-gtk-build-system-modules

`((guix build glib-or-gtk-build-system)
,@%gnu-build-system-modules)

It results in %standard-phases from gnu-build-system being used, effectively
turning glib-or-gtk-build-system with #:modules set to
%glib-or-gtk-build-system-modules into gnu-build-system.

The solution is to use the (now) exported default value of
#:modules (%glib-or-gtk-build-system-default-modules) as a base of the
#:modules.

* gnu/packages/libreoffice.scm (libreoffice)[arguments]<#:modules>: Use
%glib-or-gtk-build-system-default-modules instead of
%glib-or-gtk-build-system-modules.

Change-Id: I5304d9993af7d5f1187c6276e72a269aa60f5666
---
Rebase on latest master.

gnu/packages/libreoffice.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (13 lines)
diff --git a/gnu/packages/libreoffice.scm b/gnu/packages/libreoffice.scm
index ed8dfd432b..2acbddaa3b 100644
--- a/gnu/packages/libreoffice.scm
+++ b/gnu/packages/libreoffice.scm
@@ -908,7 +908,7 @@ (define-public libreoffice
,@%glib-or-gtk-build-system-modules)
#:modules `(((guix build python-build-system) #:select (python-version))
(ice-9 textual-ports)
- ,@%glib-or-gtk-build-system-modules)
+ ,@%glib-or-gtk-build-system-default-modules)
#:tests? #f ; Building the tests already fails.
#:phases
#~(modify-phases %standard-phases
--
2.46.0
Tomas Volf wrote 5 months ago
[PATCH v2 4/8] gnu: sugar: Dehardcode #:modules.
(address . 68150@debbugs.gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
40bc3cdf0208472a340ed15a2c3e5b83cde7437b.1728234031.git.~@wolfsden.cz
* gnu/packages/sugar.scm (sugar)[arguments]<#:modules>: Replace the hardcoded
list with %glib-or-gtk-build-system-default-modules.

Change-Id: I5a98d356c3e1a32b71e7949e3425da74081c1e82
---
Rebase on latest master.

gnu/packages/sugar.scm | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

Toggle diff (16 lines)
diff --git a/gnu/packages/sugar.scm b/gnu/packages/sugar.scm
index 77008bc078..e9cfd1a21a 100644
--- a/gnu/packages/sugar.scm
+++ b/gnu/packages/sugar.scm
@@ -74,9 +74,8 @@ (define-public sugar
`(,@%glib-or-gtk-build-system-modules
(guix build python-build-system))
#:modules
- '((guix build glib-or-gtk-build-system)
- ((guix build python-build-system) #:prefix python:)
- (guix build utils))
+ `(((guix build python-build-system) #:prefix python:)
+ ,@%glib-or-gtk-build-system-default-modules)
#:phases
#~(modify-phases %standard-phases
(add-after 'unpack 'patch-build-system
--
2.46.0
Tomas Volf wrote 5 months ago
[PATCH v2 5/8] gnu: sugar-datastore: Dehardcode #:modules.
(address . 68150@debbugs.gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
2e5a67cccc836e8a49b4cdf086763d558b93f048.1728234031.git.~@wolfsden.cz
* gnu/packages/sugar.scm (sugar-datastore)[arguments]<#:modules>: Replace the
hardcoded list with %glib-or-gtk-build-system-default-modules.

Change-Id: I9ceadd163d3f6cd49ed2623b6060b223257e9aed
---
Rebase on latest master.

gnu/packages/sugar.scm | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

Toggle diff (16 lines)
diff --git a/gnu/packages/sugar.scm b/gnu/packages/sugar.scm
index e9cfd1a21a..1a353f6f3c 100644
--- a/gnu/packages/sugar.scm
+++ b/gnu/packages/sugar.scm
@@ -251,9 +251,8 @@ (define-public sugar-datastore
`(,@%glib-or-gtk-build-system-modules
(guix build python-build-system))
#:modules
- '((guix build glib-or-gtk-build-system)
- ((guix build python-build-system) #:prefix python:)
- (guix build utils))
+ `(((guix build python-build-system) #:prefix python:)
+ ,@%glib-or-gtk-build-system-default-modules)
#:phases
'(modify-phases %standard-phases
(add-after 'unpack 'patch-build-system
--
2.46.0
Tomas Volf wrote 5 months ago
[PATCH v2 1/8] build: glib-or-gtk: Export %glib-or-gtk-build-system-default-modules.
(address . 68150@debbugs.gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
44f290956d9b581e384d4ceb8859dc863190e376.1728234031.git.~@wolfsden.cz
The list of modules used by default was not public, so users of this build
system had to pick between copy&pasting the list, or using
%glib-or-gtk-build-system-modules. The former is sub-optimal, since it is
hard to keep it in sync. The latter is just wrong and leads to basically
fall-backing to gnu-build-system.

The solution is to export the default list giving the users option to use it
directly.

* guix/build-system/glib-or-gtk.scm
(%glib-or-gtk-build-system-default-modules): Renamed from %default-modules.
(define-module): Export it.
(glib-or-gtk-build), (glib-or-gtk-cross-build): Use it.

Change-Id: I331b2a3f0bdc3ce14eb9f2f80605e7873369168d
---
Rebase on latest master.

guix/build-system/glib-or-gtk.scm | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)

Toggle diff (41 lines)
diff --git a/guix/build-system/glib-or-gtk.scm b/guix/build-system/glib-or-gtk.scm
index 5d026ec5ab..6c69a950e8 100644
--- a/guix/build-system/glib-or-gtk.scm
+++ b/guix/build-system/glib-or-gtk.scm
@@ -30,7 +30,8 @@ (define-module (guix build-system glib-or-gtk)
#:use-module (guix build-system)
#:use-module (guix build-system gnu)
#:use-module (guix packages)
- #:export (%glib-or-gtk-build-system-modules
+ #:export (%glib-or-gtk-build-system-default-modules
+ %glib-or-gtk-build-system-modules
glib-or-gtk-build
glib-or-gtk-cross-build
glib-or-gtk-build-system)
@@ -64,7 +65,7 @@ (define-module (guix build-system glib-or-gtk)
;;
;; Code:

-(define %default-modules
+(define %glib-or-gtk-build-system-default-modules
;; Build-side modules made available in the build environment.
'((guix build glib-or-gtk-build-system)
(guix build utils)))
@@ -144,7 +145,7 @@ (define* (glib-or-gtk-build name inputs
(glib-or-gtk-wrap-excluded-outputs ''())
(system (%current-system))
(imported-modules %glib-or-gtk-build-system-modules)
- (modules %default-modules)
+ (modules %glib-or-gtk-build-system-default-modules)
allowed-references
disallowed-references)
"Build SOURCE with INPUTS. See GNU-BUILD for more details."
@@ -219,7 +220,7 @@ (define* (glib-or-gtk-cross-build name
(system (%current-system))
(build (nix-system->gnu-triplet system))
(imported-modules %glib-or-gtk-build-system-modules)
- (modules %default-modules)
+ (modules %glib-or-gtk-build-system-default-modules)
allowed-references
disallowed-references)
"Cross-build SOURCE with INPUTS. See GNU-BUILD for more details."
--
2.46.0
Tomas Volf wrote 5 months ago
[PATCH v2 6/8] gnu: sugar-toolkit-gtk3: Dehardcode #:modules.
(address . 68150@debbugs.gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
f838b575a22cc4038b9f472c3b48dbb2e7061d73.1728234031.git.~@wolfsden.cz
* gnu/packages/sugar.scm (sugar-toolkit-gtk3)[arguments]<#:modules>: Replace
the hardcoded list with %glib-or-gtk-build-system-default-modules.

Change-Id: I6a5e4511d2e696a673f7d5b49f75285ee488223d
---
Rebase on latest master.

gnu/packages/sugar.scm | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

Toggle diff (16 lines)
diff --git a/gnu/packages/sugar.scm b/gnu/packages/sugar.scm
index 1a353f6f3c..10893a1dfd 100644
--- a/gnu/packages/sugar.scm
+++ b/gnu/packages/sugar.scm
@@ -320,9 +320,8 @@ (define-public sugar-toolkit-gtk3
`(,@%glib-or-gtk-build-system-modules
(guix build python-build-system))
#:modules
- '((guix build glib-or-gtk-build-system)
- ((guix build python-build-system) #:prefix python:)
- (guix build utils))
+ `(((guix build python-build-system) #:prefix python:)
+ ,@%glib-or-gtk-build-system-default-modules)
#:phases
#~(modify-phases %standard-phases
(add-after 'unpack 'patch-build-system
--
2.46.0
Tomas Volf wrote 5 months ago
[PATCH v2 8/8] gnu: hime: Dehardcode #:modules.
(address . 68150@debbugs.gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
9199fb3edff0e5ebfd28dfead197e8f8228096f2.1728234031.git.~@wolfsden.cz
* gnu/packages/language.scm (hime)[arguments]<#:modules>: Replace the
hardcoded list with %glib-or-gtk-build-system-default-modules.

Change-Id: I5360c0000173b293e9e24290a2e8eaed84e05750
---
Rebase on latest master.

gnu/packages/language.scm | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

Toggle diff (17 lines)
diff --git a/gnu/packages/language.scm b/gnu/packages/language.scm
index 2d522f6877..fb8d090fa3 100644
--- a/gnu/packages/language.scm
+++ b/gnu/packages/language.scm
@@ -218,10 +218,8 @@ (define-public hime
(guix build qt-build-system)
(guix build qt-utils))
#:modules
- ((guix build glib-or-gtk-build-system)
- ((guix build qt-build-system)
- #:prefix qt:)
- (guix build utils))
+ (((guix build qt-build-system) #:prefix qt:)
+ ,@%glib-or-gtk-build-system-default-modules)
#:configure-flags
(list
;; FIXME
--
2.46.0
Tomas Volf wrote 5 months ago
[PATCH v2 7/8] gnu: nimf: Dehardcode #:modules.
(address . 68150@debbugs.gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
4df57c09796c144f2c8f6103228a5206895d097f.1728234031.git.~@wolfsden.cz
* gnu/packages/language.scm (nimf)[arguments]<#:modules>: Replace the
hardcoded list with %glib-or-gtk-build-system-default-modules.

Change-Id: I5eaaac4cdd50b635d24b10c7fa2d365dcf392498
---
Rebase on latest master.

gnu/packages/language.scm | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

Toggle diff (17 lines)
diff --git a/gnu/packages/language.scm b/gnu/packages/language.scm
index 7a3deb0b43..2d522f6877 100644
--- a/gnu/packages/language.scm
+++ b/gnu/packages/language.scm
@@ -99,10 +99,8 @@ (define-public nimf
(guix build cmake-build-system)
(guix build qt-build-system)
(guix build qt-utils))
- #:modules '((guix build glib-or-gtk-build-system)
- ((guix build qt-build-system)
- #:prefix qt:)
- (guix build utils))
+ #:modules `(((guix build qt-build-system) #:prefix qt:)
+ ,@%glib-or-gtk-build-system-default-modules)
#:configure-flags
#~(list "--with-im-config-data"
"--with-imsettings-data"
--
2.46.0
Nicolas Graves wrote 5 months ago
control message for bug #73439
(address . control@debbugs.gnu.org)
87zfn4ugap.fsf@ngraves.fr
block 73439 by 68150
quit


--
Best regards,
Nicolas Graves
Nicolas Graves wrote 1 months ago
[PATCH v3 0/8] Fix usage of glib-or-gtk-build-system
(address . 68150@debbugs.gnu.org)(name . Nicolas Graves)(address . ngraves@ngraves.fr)
20250124114934.24600-1-ngraves@ngraves.fr
This is a rebased version of the patch series by Tomas Volf.

Using glib-or-gtk-build-system requires hard-coding the list of modules in
#:modules. Libreoffice and netsurf tried to use
%glib-or-gtk-build-system-modules instead, but that lead to crashes.

This series introduces new %glib-or-gtk-build-system-default-modules that
contains the list that should go into #:modules. Using it in libreoffice and
netsurf fixes the mentioned crashes. Other places were adjusted as well to
use it instead of copying over the list. That would be hard to keep in sync.

Tomas Volf (8):
build: glib-or-gtk: Export %glib-or-gtk-build-system-default-modules.
gnu: netsurf: Actually use glib-or-gtk-build-system.
gnu: libreoffice: Actually use glib-or-gtk-build-system.
gnu: sugar: Dehardcode #:modules.
gnu: sugar-datastore: Dehardcode #:modules.
gnu: sugar-toolkit-gtk3: Dehardcode #:modules.
gnu: nimf: Dehardcode #:modules.
gnu: hime: Dehardcode #:modules.

gnu/packages/language.scm | 12 ++++--------
gnu/packages/libreoffice.scm | 2 +-
gnu/packages/sugar.scm | 15 ++++++---------
gnu/packages/web.scm | 2 +-
guix/build-system/glib-or-gtk.scm | 9 +++++----
5 files changed, 17 insertions(+), 23 deletions(-)

--
2.47.1
Nicolas Graves wrote 1 months ago
[PATCH v3 1/8] build: glib-or-gtk: Export %glib-or-gtk-build-system-default-modules.
(address . 68150@debbugs.gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
20250124114934.24600-2-ngraves@ngraves.fr
From: Tomas Volf <~@wolfsden.cz>

The list of modules used by default was not public, so users of this build
system had to pick between copy&pasting the list, or using
%glib-or-gtk-build-system-modules. The former is sub-optimal, since it is
hard to keep it in sync. The latter is just wrong and leads to basically
fall-backing to gnu-build-system.

The solution is to export the default list giving the users option to use it
directly.

* guix/build-system/glib-or-gtk.scm
(%glib-or-gtk-build-system-default-modules): Renamed from %default-modules.
(define-module): Export it.
(glib-or-gtk-build), (glib-or-gtk-cross-build): Use it.

Change-Id: I331b2a3f0bdc3ce14eb9f2f80605e7873369168d
---
guix/build-system/glib-or-gtk.scm | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)

Toggle diff (43 lines)
diff --git a/guix/build-system/glib-or-gtk.scm b/guix/build-system/glib-or-gtk.scm
index 5d026ec5ab..6c69a950e8 100644
--- a/guix/build-system/glib-or-gtk.scm
+++ b/guix/build-system/glib-or-gtk.scm
@@ -30,7 +30,8 @@ (define-module (guix build-system glib-or-gtk)
#:use-module (guix build-system)
#:use-module (guix build-system gnu)
#:use-module (guix packages)
- #:export (%glib-or-gtk-build-system-modules
+ #:export (%glib-or-gtk-build-system-default-modules
+ %glib-or-gtk-build-system-modules
glib-or-gtk-build
glib-or-gtk-cross-build
glib-or-gtk-build-system)
@@ -64,7 +65,7 @@ (define-module (guix build-system glib-or-gtk)
;;
;; Code:
-(define %default-modules
+(define %glib-or-gtk-build-system-default-modules
;; Build-side modules made available in the build environment.
'((guix build glib-or-gtk-build-system)
(guix build utils)))
@@ -144,7 +145,7 @@ (define* (glib-or-gtk-build name inputs
(glib-or-gtk-wrap-excluded-outputs ''())
(system (%current-system))
(imported-modules %glib-or-gtk-build-system-modules)
- (modules %default-modules)
+ (modules %glib-or-gtk-build-system-default-modules)
allowed-references
disallowed-references)
"Build SOURCE with INPUTS. See GNU-BUILD for more details."
@@ -219,7 +220,7 @@ (define* (glib-or-gtk-cross-build name
(system (%current-system))
(build (nix-system->gnu-triplet system))
(imported-modules %glib-or-gtk-build-system-modules)
- (modules %default-modules)
+ (modules %glib-or-gtk-build-system-default-modules)
allowed-references
disallowed-references)
"Cross-build SOURCE with INPUTS. See GNU-BUILD for more details."
--
2.47.1
Nicolas Graves wrote 1 months ago
[PATCH v3 2/8] gnu: netsurf: Actually use glib-or-gtk-build-system.
(address . 68150@debbugs.gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
20250124114934.24600-3-ngraves@ngraves.fr
From: Tomas Volf <~@wolfsden.cz>

The #:modules argument was based on %glib-or-gtk-build-system-modules, which,
despite the name, should go into #:imported-modules. When put into #:modules,
it leads to following warning:

WARNING: (guile-user): `%standard-phases' imported from both (guix build glib-or-gtk-build-system) and (guix build gnu-build-system)

Due to the definition of %glib-or-gtk-build-system-modules

`((guix build glib-or-gtk-build-system)
,@%gnu-build-system-modules)

It results in %standard-phases from gnu-build-system being used, effectively
turning glib-or-gtk-build-system with #:modules set to
%glib-or-gtk-build-system-modules into gnu-build-system.

The solution is to use the (now) exported default value of
#:modules (%glib-or-gtk-build-system-default-modules) as a base of the
#:modules.

* gnu/packages/web.scm (netsurf)[arguments]<#:modules>: Use
%glib-or-gtk-build-system-default-modules instead of
%glib-or-gtk-build-system-modules.

Change-Id: Iacc4df7e213dbdae5a783e3aedde7e6e20402025
---
gnu/packages/web.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)
diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index b781c13b62..58384a193f 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -6344,7 +6344,7 @@ (define-public netsurf
(ice-9 match)
(srfi srfi-1)
(sxml simple)
- ,@%glib-or-gtk-build-system-modules)
+ ,@%glib-or-gtk-build-system-default-modules)
#:phases
(modify-phases %standard-phases
(delete 'configure)
--
2.47.1
Nicolas Graves wrote 1 months ago
[PATCH v3 3/8] gnu: libreoffice: Actually use glib-or-gtk-build-system.
(address . 68150@debbugs.gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
20250124114934.24600-4-ngraves@ngraves.fr
From: Tomas Volf <~@wolfsden.cz>

The #:modules argument was based on %glib-or-gtk-build-system-modules, which,
despite the name, should go into #:imported-modules. When put into #:modules,
it leads to following warning:

WARNING: (guile-user): `%standard-phases' imported from both (guix build glib-or-gtk-build-system) and (guix build gnu-build-system)

Due to the definition of %glib-or-gtk-build-system-modules

`((guix build glib-or-gtk-build-system)
,@%gnu-build-system-modules)

It results in %standard-phases from gnu-build-system being used, effectively
turning glib-or-gtk-build-system with #:modules set to
%glib-or-gtk-build-system-modules into gnu-build-system.

The solution is to use the (now) exported default value of
#:modules (%glib-or-gtk-build-system-default-modules) as a base of the
#:modules.

* gnu/packages/libreoffice.scm (libreoffice)[arguments]<#:modules>: Use
%glib-or-gtk-build-system-default-modules instead of
%glib-or-gtk-build-system-modules.

Change-Id: I5304d9993af7d5f1187c6276e72a269aa60f5666
---
gnu/packages/libreoffice.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)
diff --git a/gnu/packages/libreoffice.scm b/gnu/packages/libreoffice.scm
index 22112ccee7..e61ed11143 100644
--- a/gnu/packages/libreoffice.scm
+++ b/gnu/packages/libreoffice.scm
@@ -916,7 +916,7 @@ (define-public libreoffice
(ice-9 textual-ports)
(srfi srfi-1)
(srfi srfi-26)
- ,@%glib-or-gtk-build-system-modules)
+ ,@%glib-or-gtk-build-system-default-modules)
#:tests? #f ; Building the tests already fails.
#:phases
#~(modify-phases %standard-phases
--
2.47.1
Nicolas Graves wrote 1 months ago
[PATCH v3 4/8] gnu: sugar: Dehardcode #:modules.
(address . 68150@debbugs.gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
20250124114934.24600-5-ngraves@ngraves.fr
From: Tomas Volf <~@wolfsden.cz>

* gnu/packages/sugar.scm (sugar)[arguments]<#:modules>: Replace the hardcoded
list with %glib-or-gtk-build-system-default-modules.

Change-Id: I5a98d356c3e1a32b71e7949e3425da74081c1e82
---
gnu/packages/sugar.scm | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

Toggle diff (18 lines)
diff --git a/gnu/packages/sugar.scm b/gnu/packages/sugar.scm
index 9a82b5fb20..e53d8404e6 100644
--- a/gnu/packages/sugar.scm
+++ b/gnu/packages/sugar.scm
@@ -74,9 +74,8 @@ (define-public sugar
`(,@%glib-or-gtk-build-system-modules
(guix build python-build-system))
#:modules
- '((guix build glib-or-gtk-build-system)
- ((guix build python-build-system) #:prefix python:)
- (guix build utils))
+ `(((guix build python-build-system) #:prefix python:)
+ ,@%glib-or-gtk-build-system-default-modules)
#:phases
#~(modify-phases %standard-phases
(add-after 'unpack 'patch-build-system
--
2.47.1
Nicolas Graves wrote 1 months ago
[PATCH v3 6/8] gnu: sugar-toolkit-gtk3: Dehardcode #:modules.
(address . 68150@debbugs.gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
20250124114934.24600-7-ngraves@ngraves.fr
From: Tomas Volf <~@wolfsden.cz>

* gnu/packages/sugar.scm (sugar-toolkit-gtk3)[arguments]<#:modules>: Replace
the hardcoded list with %glib-or-gtk-build-system-default-modules.

Change-Id: I6a5e4511d2e696a673f7d5b49f75285ee488223d
---
gnu/packages/sugar.scm | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

Toggle diff (18 lines)
diff --git a/gnu/packages/sugar.scm b/gnu/packages/sugar.scm
index c66ca1692a..2bf1377b66 100644
--- a/gnu/packages/sugar.scm
+++ b/gnu/packages/sugar.scm
@@ -320,9 +320,8 @@ (define-public sugar-toolkit-gtk3
`(,@%glib-or-gtk-build-system-modules
(guix build python-build-system))
#:modules
- '((guix build glib-or-gtk-build-system)
- ((guix build python-build-system) #:prefix python:)
- (guix build utils))
+ `(((guix build python-build-system) #:prefix python:)
+ ,@%glib-or-gtk-build-system-default-modules)
#:phases
#~(modify-phases %standard-phases
(add-after 'unpack 'patch-build-system
--
2.47.1
Nicolas Graves wrote 1 months ago
[PATCH v3 7/8] gnu: nimf: Dehardcode #:modules.
(address . 68150@debbugs.gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
20250124114934.24600-8-ngraves@ngraves.fr
From: Tomas Volf <~@wolfsden.cz>

* gnu/packages/language.scm (nimf)[arguments]<#:modules>: Replace the
hardcoded list with %glib-or-gtk-build-system-default-modules.

Change-Id: I5eaaac4cdd50b635d24b10c7fa2d365dcf392498
---
gnu/packages/language.scm | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

Toggle diff (19 lines)
diff --git a/gnu/packages/language.scm b/gnu/packages/language.scm
index 6facc27174..cc76164f41 100644
--- a/gnu/packages/language.scm
+++ b/gnu/packages/language.scm
@@ -108,10 +108,8 @@ (define-public nimf
(guix build cmake-build-system)
(guix build qt-build-system)
(guix build qt-utils))
- #:modules '((guix build glib-or-gtk-build-system)
- ((guix build qt-build-system)
- #:prefix qt:)
- (guix build utils))
+ #:modules `(((guix build qt-build-system) #:prefix qt:)
+ ,@%glib-or-gtk-build-system-default-modules)
#:configure-flags
#~(list "--with-im-config-data"
"--with-imsettings-data"
--
2.47.1
Nicolas Graves wrote 1 months ago
[PATCH v3 8/8] gnu: hime: Dehardcode #:modules.
(address . 68150@debbugs.gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
20250124114934.24600-9-ngraves@ngraves.fr
From: Tomas Volf <~@wolfsden.cz>

* gnu/packages/language.scm (hime)[arguments]<#:modules>: Replace the
hardcoded list with %glib-or-gtk-build-system-default-modules.

Change-Id: I5360c0000173b293e9e24290a2e8eaed84e05750
---
gnu/packages/language.scm | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

Toggle diff (19 lines)
diff --git a/gnu/packages/language.scm b/gnu/packages/language.scm
index cc76164f41..1d45c7e180 100644
--- a/gnu/packages/language.scm
+++ b/gnu/packages/language.scm
@@ -227,10 +227,8 @@ (define-public hime
(guix build qt-build-system)
(guix build qt-utils))
#:modules
- ((guix build glib-or-gtk-build-system)
- ((guix build qt-build-system)
- #:prefix qt:)
- (guix build utils))
+ (((guix build qt-build-system) #:prefix qt:)
+ ,@%glib-or-gtk-build-system-default-modules)
#:configure-flags
(list
;; FIXME
--
2.47.1
Nicolas Graves wrote 1 months ago
[PATCH v3 5/8] gnu: sugar-datastore: Dehardcode #:modules.
(address . 68150@debbugs.gnu.org)(name . Tomas Volf)(address . ~@wolfsden.cz)
20250124114934.24600-6-ngraves@ngraves.fr
From: Tomas Volf <~@wolfsden.cz>

* gnu/packages/sugar.scm (sugar-datastore)[arguments]<#:modules>: Replace the
hardcoded list with %glib-or-gtk-build-system-default-modules.

Change-Id: I9ceadd163d3f6cd49ed2623b6060b223257e9aed
---
gnu/packages/sugar.scm | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

Toggle diff (18 lines)
diff --git a/gnu/packages/sugar.scm b/gnu/packages/sugar.scm
index e53d8404e6..c66ca1692a 100644
--- a/gnu/packages/sugar.scm
+++ b/gnu/packages/sugar.scm
@@ -251,9 +251,8 @@ (define-public sugar-datastore
`(,@%glib-or-gtk-build-system-modules
(guix build python-build-system))
#:modules
- '((guix build glib-or-gtk-build-system)
- ((guix build python-build-system) #:prefix python:)
- (guix build utils))
+ `(((guix build python-build-system) #:prefix python:)
+ ,@%glib-or-gtk-build-system-default-modules)
#:phases
'(modify-phases %standard-phases
(add-after 'unpack 'patch-build-system
--
2.47.1
Nicolas Graves wrote 1 months ago
[PATCH v3 9/8] gnu: libreoffice: Update to 24.8.4.2.
(address . 68150@debbugs.gnu.org)
87y0z0pc19.fsf@ngraves.fr
* gnu/packages/libreoffice.scm (libreoffice): Update to 24.8.4.2.

This patch is to complement #68150, if we're rebuilding libreoffice,
let's update it too.
---
gnu/packages/libreoffice.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (22 lines)
diff --git a/gnu/packages/libreoffice.scm b/gnu/packages/libreoffice.scm
index e61ed11143..4ca0857b01 100644
--- a/gnu/packages/libreoffice.scm
+++ b/gnu/packages/libreoffice.scm
@@ -893,7 +893,7 @@ (define dtoa
(define-public libreoffice
(package
(name "libreoffice")
- (version "24.8.3.2") ;keep in sync with hunspell dictionaries
+ (version "24.8.4.2") ;keep in sync with hunspell dictionaries
(source
(origin
(method url-fetch)
@@ -906,7 +906,7 @@ (define-public libreoffice
"https://downloadarchive.documentfoundation.org/libreoffice/old/"
version "/src/libreoffice-" version ".tar.xz")))
(sha256
- (base32 "1sa7bxxh7v26p77vj1mspynhn2l2b1vnz1mpyczhnmcxcan9nw2x"))))
+ (base32 "05qs12z0xkpqy3yl7378d99y82rswic101aw65k1macslcpdwr0m"))))
(build-system glib-or-gtk-build-system)
(arguments
(list
--
2.47.1



--
Best regards,
Nicolas Graves
Nicolas Graves wrote 1 months ago
QA review for 68150
87v7u3p7th.fsf@ngraves.fr
user guix
usertag 68150 + reviewed-looks-good
thanks

Guix QA review form submission:
Tested, makes
guix shell --pure libreoffice -- libreoffice
work properly (fixes reopened #30642)

Items marked as checked: Lint warnings, Package builds, Commit messages

--
Best regards,
Nicolas Graves
Andreas Enge wrote 2 weeks ago
Close
(address . 68150-done@debbugs.gnu.org)
Z7MpkRdOGicPkgk0@jurong
Thanks for the review, which has allowed me to push the patch series in
a field where I do not feel competent. And thanks for the patch, of
course, I hope it solves the problem in #30642.

Andreas
Closed
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 68150@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 68150
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help