[PATCH] gnu: kubo: Fix build.

Done

Details

3 participants

Ludovic Courtès
Christopher Baines
Artyom V. Poptsov

Owner: unassigned

Submitted by: Artyom V. Poptsov

Severity: normal

Artyom V. Poptsov wrote on 1 Dec 2023 20:08

Recipients:(address . guix-patches@gnu.org)

Message-ID:878r6deo5c.fsf@gmail.com

Hello,

this patch series fixes Kubo build.

Attachment: 0001-gnu-kubo-Fix-build.patch

Attachment: 0002-gnu-kubo-Fix-the-package-style.patch

- avp

-- 
Artyom "avp" Poptsov <poptsov.artyom@gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

Ludovic Courtès wrote on 2 Dec 2023 11:04

Recipients:(name . Artyom V. Poptsov)(address . poptsov.artyom@gmail.com)(address . 67570@debbugs.gnu.org)

Message-ID:87leacj4xj.fsf@gnu.org

Hi,

I spoke too fast…

"Artyom V. Poptsov" <poptsov.artyom@gmail.com> skribis:

Toggle quote (10 lines)> +     (let ((p (package-input-rewriting
> +               `((,go-golang-org-x-sys . ,go-golang-org-x-sys-0.8))
> +               #:deep? #true)))
> +       (cons go-golang-org-x-sys-0.8
> +             (map p
> +                  (list go-github-com-alecthomas-units
> +                        ;; TODO: needs to be updated first
> +                        ;; go-github-com-blang-semver
> +                        go-github-com-cespare-xxhash

It does fix the build, but it’s a bit heavy-handed: every time we

compute the kubo derivation, we go through that graph rewriting, which

is quite expensive.

Can you think of another way this could be fixed? What if we don’t

replace go-golang-org-x-sys everywhere? Or perhaps there’s a trick that

would allow us to build with go-golang-org-x-sys 0.4?

In parallel perhaps we should work on upgrading go-golang-org-x-sys

altogether?

WDYT?

Ludo’.

Ludovic Courtès wrote on 2 Dec 2023 11:05

control message for bug #67570

Recipients:(address . control@debbugs.gnu.org)

Message-ID:87jzpwj4x7.fsf@gnu.org

reopen 67570
tags 67570 - fixed patch
quit

Artyom V. Poptsov wrote on 9 Dec 2023 09:22

Re: [bug#67570] [PATCH] gnu: go-golang-org-x-sys: Update to 0.8.0. (was: [PATCH] gnu: kubo: Fix build.)

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 67570@debbugs.gnu.org)

Message-ID:8734wbbxak.fsf_-_@gmail.com

Hello Ludovic!

Toggle quote (4 lines)

> It does fix the build, but it’s a bit heavy-handed: every time we

> compute the kubo derivation, we go through that graph rewriting, which

> is quite expensive.

Agreed, I just wanted to make a "quick fix" that works.

Toggle quote (7 lines)

> Can you think of another way this could be fixed? What if we don’t

> replace go-golang-org-x-sys everywhere? Or perhaps there’s a trick that

> would allow us to build with go-golang-org-x-sys 0.4?

> In parallel perhaps we should work on upgrading go-golang-org-x-sys

> altogether?

Alright, I tried to update "go-golang-org-x-sys" to 0.8.0, here's the

patch:

Attachment: 0001-gnu-go-golang-org-x-sys-Update-to-0.8.0.patch

It seems that the dependent packages are fine with that.  I haven't
checked everything but I did some cherry-picking across the dependent
packages and build some of them and found no build errors.  Please find
my check-list attached.

Attachment: go-golang-org-x-sys-0.8.0-upgrade-check.org

Thanks,

- avp

Artyom "avp" Poptsov <poptsov.artyom@gmail.com>

Home page: https://memory-heap.org/~avp/

CADR Hackerspace co-founder: https://cadrspace.ru/

GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F

Ludovic Courtès wrote on 10 Dec 2023 22:22

Re: [bug#67570] [PATCH] gnu: go-golang-org-x-sys: Update to 0.8.0.

Recipients:(name . Artyom V. Poptsov)(address . poptsov.artyom@gmail.com)(address . 67570@debbugs.gnu.org)

Message-ID:875y154us6.fsf@gnu.org

Hi,

"Artyom V. Poptsov" <poptsov.artyom@gmail.com> skribis:

Toggle quote (24 lines)>> Can you think of another way this could be fixed?  What if we don’t
>> replace go-golang-org-x-sys everywhere?  Or perhaps there’s a trick that
>> would allow us to build with go-golang-org-x-sys 0.4?
>
>> In parallel perhaps we should work on upgrading go-golang-org-x-sys
>> altogether?
>
> Alright, I tried to update "go-golang-org-x-sys" to 0.8.0, here's the
> patch:
>
> From 6022d28be487d06e9987785db1240355c080f459 Mon Sep 17 00:00:00 2001
> Message-ID: <6022d28be487d06e9987785db1240355c080f459.1702109906.git.poptsov.artyom@gmail.com>
> From: "Artyom V. Poptsov" <poptsov.artyom@gmail.com>
> Date: Sat, 9 Dec 2023 11:09:26 +0300
> Subject: [PATCH] gnu: go-golang-org-x-sys: Update to 0.8.0.
>
> * gnu/packages/golang.scm (go-golang-org-x-sys): Update to 0.8.0.
>   (go-golang-org-x-sys-0.8): Remove.
>   (go-github-com-quic-go-quic-go, go-github-com-quic-go-qtls-go1-20):
>   Use the new version of "go-golang-org-x-sys".
> * gnu/packages/networking.scm (yggdrasil): Use the new version of
>   "go-golang-org-x-sys".
>   [propagated-inputs]: Don't rewrite inputs; add "go-golang-org-x-sys".

This is being built:

https://qa.guix.gnu.org/issue/67570

Let’s keep an eye on it and see how it goes.

Thanks,

Ludo’.

Artyom V. Poptsov wrote on 29 Dec 2023 10:55

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 67570@debbugs.gnu.org)

Message-ID:87tto1z62d.fsf@gmail.com

Hello!

Toggle quote (4 lines)

> This is being built:

> https://qa.guix.gnu.org/issue/67570

So what is the status of this? Last time I checked the link the

information about the build was gone and it's not obvious for me how to

get this info again.

Before I saw that some new packages were failing, I'd like to check if I

can fix them.

Could you provide a new link or the info itself?

Thanks!

- avp

Artyom "avp" Poptsov <poptsov.artyom@gmail.com>

Home page: https://memory-heap.org/~avp/

CADR Hackerspace co-founder: https://cadrspace.ru/

GPG: D0C2 EAC1 3310 822D 98DE B57C E9C5 A2D9 0898 A02F

Ludovic Courtès wrote on 7 Jan 15:48 +0100

Recipients:(name . Artyom V. Poptsov)(address . poptsov.artyom@gmail.com)

Message-ID:87frz9ci8s.fsf@gnu.org

Hi!

"Artyom V. Poptsov" <poptsov.artyom@gmail.com> skribis:

Toggle quote (13 lines)>> This is being built:
>>
>>   https://qa.guix.gnu.org/issue/67570
>
> So what is the status of this?  Last time I checked the link the
> information about the build was gone and it's not obvious for me how to
> get this info again.
>
> Before I saw that some new packages were failing, I'd like to check if I
> can fix them.
>
> Could you provide a new link or the info itself?

Unfortunately I’m not sure why qa.guix is no longer providing any info,

and I don’t know how to get it back. Chris?

Anyhow, I built Kubo with this patch and got substitutes from

bordeaux.guix for all its dependencies; Kubo itself built fine. So I’m

proposing to apply the patch and see from there whether anything needs

fixing. It’s suboptimal, but that’s what we have.

Thanks,

Ludo’.

Closed

Christopher Baines wrote on 7 Jan 16:34 +0100

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)

Message-ID:87cyudqhnq.fsf@cbaines.net

Ludovic Courtès <ludo@gnu.org> writes:

Toggle quote (20 lines)> Hi!
>
> "Artyom V. Poptsov" <poptsov.artyom@gmail.com> skribis:
>
>>> This is being built:
>>>
>>>   https://qa.guix.gnu.org/issue/67570
>>
>> So what is the status of this?  Last time I checked the link the
>> information about the build was gone and it's not obvious for me how to
>> get this info again.
>>
>> Before I saw that some new packages were failing, I'd like to check if I
>> can fix them.
>>
>> Could you provide a new link or the info itself?
>
> Unfortunately I’m not sure why qa.guix is no longer providing any info,
> and I don’t know how to get it back.  Chris?

Looks like these patches were sent long enough ago that they've dropped

out of the fixed number of recent patches that QA looks at [1].

1: https://git.cbaines.net/guix/qa-frontpage/tree/scripts/guix-qa-frontpage.in#n154

You can resend the series to get QA to pay attention again, but current

QA isn't really working anyway due to a number of issues.

Ludovic Courtès wrote on 8 Jan 18:02 +0100

Recipients:(name . Christopher Baines)(address . mail@cbaines.net)

Message-ID:87eder4v2k.fsf@gnu.org

Hi Chris!

Christopher Baines <mail@cbaines.net> skribis:

Toggle quote (3 lines)

> Looks like these patches were sent long enough ago that they've dropped

> out of the fixed number of recent patches that QA looks at [1].

Would it be possible to keep previous build results beyond that number,

only marking them as “archived” or similar? (And then after a longer

period of time, they can be removed altogether.)

It would allow us to get useful info even for old patches.

Thanks,

Ludo’.

Artyom V. Poptsov wrote on 8 Jan 18:13 +0100

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)

Message-ID:87eder4ujs.fsf@gmail.com

Hello,

as far as I remember, one of the packages that was failing is
"go-github-com-charmbracelet-glamour" -- this is not directly related to
"go-golang-org-x-sys" as the package build has started failing before my
patch, but anyways.  Yesterday I sent a patch that should fix
"go-github-com-charmbracelet-glamour" build:
  https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68311

- avp

-- 
Artyom "avp" Poptsov <poptsov.artyom@gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

Closed

Your comment

This issue is archived.

To comment on this conversation send an email to 67570@debbugs.gnu.org

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date