libtorrent-rasterbar tests fail [with patch]

Open

Details

4 participants

Dr. Arne Babenhauserheide
Jakob Kirsch
Ludovic Courtès
Tomas Volf

Owner: unassigned

Submitted by: Dr. Arne Babenhauserheide

Severity: normal

Dr. Arne Babenhauserheide wrote on 30 Nov 2023 21:51

Recipients:(address . guix-patches@gnu.org)

Message-ID:87leafvubv.fsf@web.de

Attached is a patch to disable the failing tests, so I can build

libtorrent-rasterbar locally.

From 1adbe26fefadd282d6d54ce9d03c0b2f1ae2d90b Mon Sep 17 00:00:00 2001

Message-ID: <1adbe26fefadd282d6d54ce9d03c0b2f1ae2d90b.1701376316.git.arne_bab@web.de>

* gnu/packages/bittorrent.scm(libtorrent-rasterbar): disable the failing tests

"test_fast_extension" "test_privacy" "test_resolve_links" "test_lsd"

Change-Id: I7273bfb62e5d648fcfdc41586c1dd231236d965c

---

gnu/packages/bittorrent.scm | 3 ++-

1 file changed, 2 insertions(+), 1 deletion(-)

Toggle diff (18 lines)diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm
index 6f75a92cff..6597c74fd7 100644
--- a/gnu/packages/bittorrent.scm
+++ b/gnu/packages/bittorrent.scm
@@ -442,7 +442,8 @@ (define-public libtorrent-rasterbar
            (lambda* (#:key tests? parallel-tests? #:allow-other-keys)
              (let ((disabled-tests
                     ;; test_upnp requires a non-localhost IPv4 interface.
-                    '("test_upnp")))
+                    '("test_upnp" "test_fast_extension" "test_privacy"
+                      "test_resolve_links" "test_lsd")))
                (when tests?
                  ;; test_ssl relies on bundled TLS certificates with a fixed
                  ;; expiry date.  To ensure succesful builds in the future,

base-commit: 2b782f67266b42bb40015bd23ce2443be2f9b01f
-- 
2.41.0

Best wishes,

Arne

Dr. Arne Babenhauserheide wrote on 30 Nov 2023 23:28

Recipients:(name . Tomas Volf)(address . ~@wolfsden.cz)(address . guix-patches@gnu.org)

Message-ID:87cyvqx4a5.fsf@web.de

Tomas Volf <~@wolfsden.cz> writes:

Toggle quote (9 lines)

> On 2023-11-30 21:51:00 +0100, Dr. Arne Babenhauserheide wrote:

>> Attached is a patch to disable the failing tests, so I can build

>> libtorrent-rasterbar locally.

> I have an actual patch fixing the tests (and updating to newer version) in the

> works, will send it today once I figure out how (there are many steps in the

> manual).

Very cool! Then please do *not* apply my patch!

I’m looking forward to having an updated backend to qBittorrent :-)

Thank you for taking it up — and digging deeper to the actual issue than

I did!

Best wishes,

Arne

Unpolitisch sein

heißt politisch sein,

ohne es zu merken.

draketo.de

Tomas Volf wrote on 30 Nov 2023 23:21

Recipients:(name . Dr. Arne Babenhauserheide)(address . arne_bab@web.de)(address . guix-patches@gnu.org)

Message-ID:ZWkK0ob0P0kGgN-b@ws

On 2023-11-30 21:51:00 +0100, Dr. Arne Babenhauserheide wrote:

Toggle quote (4 lines)

> Attached is a patch to disable the failing tests, so I can build

> libtorrent-rasterbar locally.

I have an actual patch fixing the tests (and updating to newer version) in the

works, will send it today once I figure out how (there are many steps in the

manual).

So not sure if applying this makes sense (I don't want to handle the conflict :)

Toggle quote (41 lines)> From 1adbe26fefadd282d6d54ce9d03c0b2f1ae2d90b Mon Sep 17 00:00:00 2001
> Message-ID: <1adbe26fefadd282d6d54ce9d03c0b2f1ae2d90b.1701376316.git.arne_bab@web.de>
> From: Arne Babenhauserheide <arne_bab@web.de>
> Date: Thu, 30 Nov 2023 20:52:12 +0100
> Subject: [PATCH] libtorrent-rasterbar: disable locally failing tests
>
> * gnu/packages/bittorrent.scm(libtorrent-rasterbar): disable the failing tests
>   "test_fast_extension" "test_privacy" "test_resolve_links" "test_lsd"
>
> Change-Id: I7273bfb62e5d648fcfdc41586c1dd231236d965c
> ---
>  gnu/packages/bittorrent.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm
> index 6f75a92cff..6597c74fd7 100644
> --- a/gnu/packages/bittorrent.scm
> +++ b/gnu/packages/bittorrent.scm
> @@ -442,7 +442,8 @@ (define-public libtorrent-rasterbar
>             (lambda* (#:key tests? parallel-tests? #:allow-other-keys)
>               (let ((disabled-tests
>                      ;; test_upnp requires a non-localhost IPv4 interface.
> -                    '("test_upnp")))
> +                    '("test_upnp" "test_fast_extension" "test_privacy"
> +                      "test_resolve_links" "test_lsd")))
>                 (when tests?
>                   ;; test_ssl relies on bundled TLS certificates with a fixed
>                   ;; expiry date.  To ensure succesful builds in the future,
>
> base-commit: 2b782f67266b42bb40015bd23ce2443be2f9b01f
> --
> 2.41.0
>

>
> Best wishes,
> Arne

--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

Tomas Volf wrote on 1 Dec 2023 13:54

RE: libtorrent-rasterbar tests fail [with patch]

Recipients:(address . 67552@debbugs.gnu.org)

Message-ID:ZWnXhuOHt4DzKZsI@ws

Hi,

I submitted my patch set as https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67557.

For some reason it seems it takes while to get through, not sure what the

problem is, but once it shows up, feel free to test it out.

Tomas

There are only two hard things in Computer Science:

cache invalidation, naming things and off-by-one errors.

Jakob Kirsch wrote on 5 Dec 2023 19:57

libtorrent-rasterbar tests fail [with patch]

Recipients:(address . 67552@debbugs.gnu.org)

Message-ID:0be054f0-2dae-4130-93dd-0d6cd4b89a98@web.de

I hope this will be fixed soon.

"guix system reconfigure" is basically unusable for me right now since 
it just hangs at the check phase of libtorrent-rasterbar.

Attachment: OpenPGP_0x6AD8A2FE6B5CD0DC.asc

Attachment: OpenPGP_signature.asc

Ludovic Courtès wrote on 7 Dec 2023 10:01

Recipients:(address . 67552@debbugs.gnu.org)

Message-ID:87a5qmfkt6.fsf_-_@gnu.org

Hi!

Tomas Volf <~@wolfsden.cz> skribis:

Toggle quote (4 lines)

> I submitted my patch set as https://debbugs.gnu.org/cgi/bugreport.cgi?bug=67557.

> For some reason it seems it takes while to get through, not sure what the

> problem is, but once it shows up, feel free to test it out.

I applied Tomas’ update from https://issues.guix.gnu.org/67557 and

everything built fine on my x86_64 machine, but test fails at ci.guix.

From https://ci.guix.gnu.org/build/2804230/log:

Toggle snippet (19 lines)

100% tests passed, 0 tests failed out of 104

Total Test time (real) = 759.05 sec

Test project /tmp/guix-build-libtorrent-rasterbar-2.0.9.drv-0/build

Start 75: test_ssl

1/1 Test #75: test_ssl .........................***Timeout 600.11 sec

test: /tmp/guix-build-libtorrent-rasterbar-2.0.9.drv-0/build/test/test_ssl

cwd_prefix = "/tmp/guix-build-libtorrent-rasterbar-2.0.9.drv-0/build/test/test_tmp_7352_"

0% tests passed, 1 tests failed out of 1

Total Test time (real) = 600.11 sec

The following tests FAILED:

75 - test_ssl (Timeout)

Errors while running CTest

I don’t think Arne’s patch addresses this, right?

Let me know what you think should be done.

Cheers,

Ludo’.

Tomas Volf wrote on 7 Dec 2023 16:11

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)

Message-ID:ZXHgpp4jvACuJZv0@ws

Hello ^_^

On 2023-12-07 10:01:25 +0100, Ludovic Courtès wrote:

Toggle quote (26 lines)> I applied Tomas’ update from https://issues.guix.gnu.org/67557 and
> everything built fine on my x86_64 machine, but test fails at ci.guix.
> From <https://ci.guix.gnu.org/build/2804230/log>:
>
> --8<---------------cut here---------------start------------->8---
> 100% tests passed, 0 tests failed out of 104
>
> Total Test time (real) = 759.05 sec
> Test project /tmp/guix-build-libtorrent-rasterbar-2.0.9.drv-0/build
>     Start 75: test_ssl
> 1/1 Test #75: test_ssl .........................***Timeout 600.11 sec
> test: /tmp/guix-build-libtorrent-rasterbar-2.0.9.drv-0/build/test/test_ssl
> cwd_prefix = "/tmp/guix-build-libtorrent-rasterbar-2.0.9.drv-0/build/test/test_tmp_7352_"
>
>
> 0% tests passed, 1 tests failed out of 1
>
> Total Test time (real) = 600.11 sec
>
> The following tests FAILED:
> 	 75 - test_ssl (Timeout)
> Errors while running CTest
> --8<---------------cut here---------------end--------------->8---
>
> I don’t think Arne’s patch addresses this, right?

Correct, it does not.

Toggle quote (3 lines)

> Let me know what you think should be done.

Good question.  For the time being I would suggest applying the attached patch
to work around the immediate issue, it would be nice to have the substitute
available in ci as well (for some reason the build succeeded in bordeaux).

    $ guix weather libtorrent-rasterbar
    computing 1 package derivations for x86_64-linux...
    looking for 1 store items on https://ci.guix.gnu.org...
    https://ci.guix.gnu.org?
      0.0% substitutes available (0 out of 1)
      unknown substitute sizes
      0.0 MiB on disk (uncompressed)
      0.233 seconds per request (0.2 seconds in total)
      4.3 requests per second

      0.0% (0 out of 1) of the missing items are queued
      at least 1000 queued builds
          aarch64-linux: 998 (99.8%)
          armhf-linux: 2 (.2%)
      build rate: 15.54 builds per hour
          powerpc64le-linux: 3.67 builds per hour
          x86_64-linux: 6.47 builds per hour
          i686-linux: 3.93 builds per hour
          aarch64-linux: 1.65 builds per hour
    looking for 1 store items on https://bordeaux.guix.gnu.org...
    https://bordeaux.guix.gnu.org?
      100.0% substitutes available (1 out of 1)
      2.4 MiB of nars (compressed)
      12.2 MiB on disk (uncompressed)
      0.233 seconds per request (0.2 seconds in total)
      4.3 requests per second
      (continuous integration information unavailable)

And I will look into getting the test working (starting with just removing the
timeout) and send a separate patch re-enabling it once I have a solution.

Does that sound reasonable?

Have a nice day,
Tomas

--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

From 5e4c31518aba62b2cca7c346bcc56cfa9a4d10d0 Mon Sep 17 00:00:00 2001

Message-ID: <5e4c31518aba62b2cca7c346bcc56cfa9a4d10d0.1701961719.git.~@wolfsden.cz>

It times out in the ci.guix.gnu.org, so this commit disables it. It will be

re-enabled once solution is found.

* gnu/packages/bittorrent.scm

(libtorrent-rasterbar)[arguments]<#:phases>['check]: Disable test_ssl test.

Change-Id: Ib396fd8a1786e14baad72ae892bdd0fd3fe7a180

---

gnu/packages/bittorrent.scm | 16 ++++++++++------

1 file changed, 10 insertions(+), 6 deletions(-)

Toggle diff (31 lines)diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm
index 731c8e1c20..8c032940d4 100644
--- a/gnu/packages/bittorrent.scm
+++ b/gnu/packages/bittorrent.scm
@@ -488,12 +488,16 @@ (define-public libtorrent-rasterbar
                  ;; test_fast_extension, test_privacy and test_resolve_links
                  ;; to hang, even with FAKETIME_ONLY_CMDS.  Not sure why.  So
                  ;; execute only test_ssl under faketime.
-                 (invoke "faketime" "2022-10-24"
-                         "ctest"
-                         "-R" "^test_ssl$"
-                         "-j" jobs
-                         "--timeout" timeout
-                         "--output-on-failure"))))))))
+                 ;;
+                 ;; Note: The test_ssl test times out in the ci.
+                 ;; Temporarily disable it until that is resolved.
+                 ;; (invoke "faketime" "2022-10-24"
+                 ;;         "ctest"
+                 ;;         "-R" "^test_ssl$"
+                 ;;         "-j" jobs
+                 ;;         "--timeout" timeout
+                 ;;         "--output-on-failure")
+                 )))))))
     (inputs (list boost openssl))
     (native-inputs `(("libfaketime" ,libfaketime)
                      ("python-wrapper" ,python-wrapper)

base-commit: 99bf4840cec2e74d1824684dd8bd29511e904ba0
-- 
2.41.0

Ludovic Courtès wrote on 14 Dec 2023 19:14

Recipients:(name . Tomas Volf)(address . ~@wolfsden.cz)

Message-ID:875y10vehj.fsf@gnu.org

Hi,

Tomas Volf <~@wolfsden.cz> skribis:

Toggle quote (2 lines)

> On 2023-12-07 10:01:25 +0100, Ludovic Courtès wrote:

[...]

Toggle quote (2 lines)

>> 1/1 Test #75: test_ssl .........................***Timeout 600.11 sec

[...]

Toggle quote (5 lines)

> And I will look into getting the test working (starting with just removing the

> timeout) and send a separate patch re-enabling it once I have a solution.

> Does that sound reasonable?

It does!

Toggle quote (14 lines)> From 5e4c31518aba62b2cca7c346bcc56cfa9a4d10d0 Mon Sep 17 00:00:00 2001
> Message-ID: <5e4c31518aba62b2cca7c346bcc56cfa9a4d10d0.1701961719.git.~@wolfsden.cz>
> From: Tomas Volf <~@wolfsden.cz>
> Date: Thu, 7 Dec 2023 16:02:15 +0100
> Subject: [PATCH] gnu: libtorrent-rasterbar: Disable test_ssl test.
>
> It times out in the ci.guix.gnu.org, so this commit disables it.  It will be
> re-enabled once solution is found.
>
> * gnu/packages/bittorrent.scm
> (libtorrent-rasterbar)[arguments]<#:phases>['check]: Disable test_ssl test.
>
> Change-Id: Ib396fd8a1786e14baad72ae892bdd0fd3fe7a180

Applied, thanks!

Ludo’.

Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 67552@debbugs.gnu.org

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date