[PATCH 0/4] Update weirdware packages.

  • Done
  • quality assurance status badge
Details
3 participants
  • Liliana Marie Prikler
  • Nicolas Goaziou
  • Sergey Trofimov
Owner
unassigned
Submitted by
Sergey Trofimov
Severity
normal
S
S
Sergey Trofimov wrote on 29 Nov 2023 22:31
(address . guix-patches@gnu.org)(name . Sergey Trofimov)(address . sarg@sarg.org.ru)
cover.1701293236.git.sarg@sarg.org.ru
Hello guix,

I've noticed that recently added weirdware emacs packages use `inputs` to
declare dependencies. I think `propagated-inputs` make more sense here as
these are required in runtime.

Sergey Trofimov (4):
gnu: emacs-dnt: Propagate inputs.
gnu: emacs-debase: Remove unused inputs.
gnu: emacs-discomfort: Propagate inputs.
gnu: emacs-hyperspace: Propagated inputs.

gnu/packages/emacs-xyz.scm | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)


base-commit: bdbb9dc27a590b08651d058f06a42caa26e04abb
--
2.41.0
S
S
Sergey Trofimov wrote on 29 Nov 2023 22:33
[PATCH 1/4] gnu: emacs-dnt: Propagate inputs.
(address . 67537@debbugs.gnu.org)(name . Sergey Trofimov)(address . sarg@sarg.org.ru)
f762e7c6d1396c8e6c7033f473c2c70e8084482b.1701293236.git.sarg@sarg.org.ru
* gnu/packages/emacs-xyz.scm (emacs-dnt):
Use propagated-inputs for runtime dependencies.
---
gnu/packages/emacs-xyz.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 996142dc3e..d50b76d099 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -3310,7 +3310,7 @@ (define-public emacs-dnt
(file-name (git-file-name name version))
(sha256
(base32 "1bls9j1ibw0npjapslbrh6nmlbn3d4ajhjygsqlf6h9qg12sxm3r"))))
- (inputs (list emacs-s))
+ (propagated-inputs (list emacs-s))
(build-system emacs-build-system)
(home-page "https://codeberg.org/emacs-weirdware/dnt")
(synopsis "Strip trackers from URLs")
--
2.41.0
S
S
Sergey Trofimov wrote on 29 Nov 2023 22:33
[PATCH 2/4] gnu: emacs-debase: Remove unused inputs.
(address . 67537@debbugs.gnu.org)(name . Sergey Trofimov)(address . sarg@sarg.org.ru)
f047a8d54da79384e4895f52a0c97dee8cecb60d.1701293236.git.sarg@sarg.org.ru
* gnu/packages/emacs-xyz.scm (emacs-debase):
Remove empty inputs list.
---
gnu/packages/emacs-xyz.scm | 1 -
1 file changed, 1 deletion(-)

Toggle diff (14 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d50b76d099..a832501f55 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -34906,7 +34906,6 @@ (define-public emacs-debase
(sha256
(base32 "112vk1svnc6516vhs47sx5jw6bg8lwrc15l99dxj0sc313lxjy3k"))))
(build-system emacs-build-system)
- (inputs (list))
(home-page "https://codeberg.org/emacs-weirdware/debase")
(synopsis "D-Bus convenience layer for Emacs")
(description
--
2.41.0
S
S
Sergey Trofimov wrote on 29 Nov 2023 22:33
[PATCH 3/4] gnu: emacs-discomfort: Propagate inputs.
(address . 67537@debbugs.gnu.org)(name . Sergey Trofimov)(address . sarg@sarg.org.ru)
54480fb084de19776dfcea1fa3bec995ab5784ed.1701293237.git.sarg@sarg.org.ru
* gnu/packages/emacs-xyz.scm (emacs-discomfort):
Use propagated-inputs for runtime dependencies.
---
gnu/packages/emacs-xyz.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index a832501f55..f72fb180b8 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -34929,7 +34929,7 @@ (define-public emacs-discomfort
(sha256
(base32 "01p4bfiasqxfmp9x1bxdc7763bh712d3vlp2014y8pzrwb1jqdaq"))))
(build-system emacs-build-system)
- (inputs (list emacs-debase))
+ (propagated-inputs (list emacs-debase))
(home-page "https://codeberg.org/emacs-weirdware/discomfort")
(synopsis "User interface to mount & unmount disks in Emacs.")
(description "Discomfort is an interface to mount and unmount disks in Emacs, using UDisks2.")
--
2.41.0
S
S
Sergey Trofimov wrote on 29 Nov 2023 22:33
[PATCH 4/4] gnu: emacs-hyperspace: Propagated inputs.
(address . 67537@debbugs.gnu.org)(name . Sergey Trofimov)(address . sarg@sarg.org.ru)
7a42767bb2ed6460759c7da21e5d2817c6f46126.1701293237.git.sarg@sarg.org.ru
* gnu/packages/emacs-xyz.scm (emacs-hyperspace):
Use propagated inputs for runtime dependencies.
---
gnu/packages/emacs-xyz.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f72fb180b8..c079d740ec 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -36504,7 +36504,7 @@ (define-public emacs-hyperspace
(sha256
(base32 "19h3d12a99i7a92k3iw4zmjmw3dazsgnkc6j4965h033r1s40amx"))))
(build-system emacs-build-system)
- (inputs (list emacs-s))
+ (propagated-inputs (list emacs-s))
(home-page "https://codeberg.org/emacs-weirdware/hyperspace")
(synopsis "Get there from here")
(description
--
2.41.0
L
L
Liliana Marie Prikler wrote on 29 Nov 2023 22:55
Re: [bug#67537] [PATCH 0/4] Update weirdware packages.
bd813759e0d388e39b585020d3c2b82ae047c548.camel@gmail.com
Am Mittwoch, dem 29.11.2023 um 22:31 +0100 schrieb Sergey Trofimov:
Toggle quote (13 lines)
> Hello guix,
>
> I've noticed that recently added weirdware emacs packages use
> `inputs` to
> declare dependencies. I think `propagated-inputs` make more sense
> here as
> these are required in runtime.
>
> Sergey Trofimov (4):
>   gnu: emacs-dnt: Propagate inputs.
>   gnu: emacs-debase: Remove unused inputs.
>   gnu: emacs-discomfort: Propagate inputs.
>   gnu: emacs-hyperspace: Propagated inputs.
Nice catch. LGTM.
N
N
Nicolas Goaziou wrote on 4 Jan 2024 12:38
(name . Liliana Marie Prikler)(address . liliana.prikler@gmail.com)
87edexjpks.fsf@nicolasgoaziou.fr
Hello,

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

Toggle quote (16 lines)
> Am Mittwoch, dem 29.11.2023 um 22:31 +0100 schrieb Sergey Trofimov:
>> Hello guix,
>>
>> I've noticed that recently added weirdware emacs packages use
>> `inputs` to
>> declare dependencies. I think `propagated-inputs` make more sense
>> here as
>> these are required in runtime.
>>
>> Sergey Trofimov (4):
>>   gnu: emacs-dnt: Propagate inputs.
>>   gnu: emacs-debase: Remove unused inputs.
>>   gnu: emacs-discomfort: Propagate inputs.
>>   gnu: emacs-hyperspace: Propagated inputs.
> Nice catch. LGTM.

Applied. Thanks.

Regards,
--
Nicolas Goaziou
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 67537@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 67537
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch