[PATCH gnome-team] gnu: rygel: Update to 0.42.4.

  • Done
  • quality assurance status badge
Details
2 participants
  • Maxim Cournoyer
  • Vivien Kraus
Owner
unassigned
Submitted by
Vivien Kraus
Severity
normal

Debbugs page

Vivien Kraus wrote 1 years ago
(address . guix-patches@gnu.org)
9fc592d15a9081b879fd87d71c4a9ce4e106aa05.1701040174.git.vivien@planete-kraus.eu
* gnu/packages/gnome.scm (rygel): Update to 0.42.4.
[arguments]: Convert to list of G-Expressions.
[propagated-inputs]: Add glib.

Change-Id: I17da7894a9626cd056c7c86ac6747acc0828e1ba
---
gnu/packages/gnome.scm | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)

Toggle diff (43 lines)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index d354327497..d6ee3493b5 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -1676,7 +1676,7 @@ (define-public sushi
(define-public rygel
(package
(name "rygel")
- (version "0.41.2")
+ (version "0.42.4")
(source (origin
(method url-fetch)
(uri (string-append "mirror://gnome/sources/" name "/"
@@ -1684,12 +1684,12 @@ (define-public rygel
name "-" version ".tar.xz"))
(sha256
(base32
- "0wivd60hn115ar3hsrsa595kpxzp8gwq30ksh32qlq8j9dhlq65i"))))
+ "1xq36f0n42yall67ibqzqsdpvljbdanhy0lvkc8ncark5nmdy433"))))
(build-system meson-build-system)
(arguments
;; Disable the tracker plugin.
- '(#:configure-flags
- (list "-Dplugins=external,gst-launch,lms,media-export,
+ (list #:configure-flags
+ #~'("-Dplugins=external,gst-launch,lms,media-export,
mpris,playbin,ruih,tracker3")))
(native-inputs
(list gettext-minimal
@@ -1719,6 +1719,9 @@ (define-public rygel
libxslt
libunistring
tracker))
+ (propagated-inputs
+ ;; The .pc files require.private gmodule-2.0
+ (list glib))
(synopsis "Share audio, video, and pictures with other devices")
(description
"Rygel is a home media solution (@dfn{UPnP AV MediaServer and

base-commit: e21f0cb7b7a87992004193cd56638ad961fe5928
--
2.41.0
Maxim Cournoyer wrote 1 years ago
(name . Vivien Kraus)(address . vivien@planete-kraus.eu)
87leaax2ky.fsf@gmail.com
Hello,

Vivien Kraus <vivien@planete-kraus.eu> writes:

Toggle quote (37 lines)
> * gnu/packages/gnome.scm (rygel): Update to 0.42.4.
> [arguments]: Convert to list of G-Expressions.
> [propagated-inputs]: Add glib.
>
> Change-Id: I17da7894a9626cd056c7c86ac6747acc0828e1ba
> ---
> gnu/packages/gnome.scm | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index d354327497..d6ee3493b5 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -1676,7 +1676,7 @@ (define-public sushi
> (define-public rygel
> (package
> (name "rygel")
> - (version "0.41.2")
> + (version "0.42.4")
> (source (origin
> (method url-fetch)
> (uri (string-append "mirror://gnome/sources/" name "/"
> @@ -1684,12 +1684,12 @@ (define-public rygel
> name "-" version ".tar.xz"))
> (sha256
> (base32
> - "0wivd60hn115ar3hsrsa595kpxzp8gwq30ksh32qlq8j9dhlq65i"))))
> + "1xq36f0n42yall67ibqzqsdpvljbdanhy0lvkc8ncark5nmdy433"))))
> (build-system meson-build-system)
> (arguments
> ;; Disable the tracker plugin.
> - '(#:configure-flags
> - (list "-Dplugins=external,gst-launch,lms,media-export,
> + (list #:configure-flags
> + #~'("-Dplugins=external,gst-launch,lms,media-export,
> mpris,playbin,ruih,tracker3")))

Nitpick: I prefer the #~(list "args" ...) style, which I find more readable.

Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>

--
Thanks,
Maxim
Vivien Kraus wrote 1 years ago
[PATCH gnome-team v2] gnu: rygel: Improve style.
(name . Maxim Cournoyer)(address . maxim.cournoyer@gmail.com)
4e4f8c3f7c5a97ee67d6a458fd064d3140e8d25e.1701710938.git.vivien@planete-kraus.eu
* gnu/packages/gnome.scm (rygel) [#:configure-flags]: Use the 'list' syntax
istead of 'quote'.

Change-Id: I173b5872ebfa82855055145923cd2f1a1b4d68d1
---
Hi,

The patch was already applied, so I make a new commit.

I am sorry for the X-Debbugs-CC error on my side, I understand why it is
useful and I will systematically use it in the future for new submissions.

Best regards,

Vivien

gnu/packages/gnome.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (17 lines)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index c6437ce450..2bb0587d5f 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -1697,7 +1697,7 @@ (define-public rygel
(arguments
;; Disable the tracker plugin.
(list #:configure-flags
- #~'("-Dplugins=external,gst-launch,lms,media-export,
+ #~(list "-Dplugins=external,gst-launch,lms,media-export,
mpris,playbin,ruih,tracker3")))
(native-inputs
(list gettext-minimal

base-commit: 4c323c2f8308bba0e3295f3109d159c7b8f72838
--
2.41.0
Maxim Cournoyer wrote 1 years ago
(name . Vivien Kraus)(address . vivien@planete-kraus.eu)
87plzlpnzo.fsf@gmail.com
Vivien Kraus <vivien@planete-kraus.eu> writes:

Toggle quote (5 lines)
> * gnu/packages/gnome.scm (rygel) [#:configure-flags]: Use the 'list' syntax
> istead of 'quote'.
>
> Change-Id: I173b5872ebfa82855055145923cd2f1a1b4d68d1

Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>

--
Thanks,
Maxim
Vivien Kraus wrote 1 years ago
Closing!
(address . 67466-done@debbugs.gnu.org)
85f773e0fd4fceec89717b045ce46d1a3fe0fc2d.camel@planete-kraus.eu
It has been pushed.
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 67466@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 67466
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help