[PATCH gnome-team 0/2] Add gnome-connections

  • Done
  • quality assurance status badge
Details
3 participants
  • Liliana Marie Prikler
  • Maxim Cournoyer
  • Vivien Kraus
Owner
unassigned
Submitted by
Vivien Kraus
Severity
normal
V
V
Vivien Kraus wrote on 20 Nov 2023 20:28
(address . guix-patches@gnu.org)
cover.1700508505.git.vivien@planete-kraus.eu
Dear guix,

GNOME now has a RDP/VNC viewer, named “Connections”. Here it is.

The set-up page looks like an advertisement for non-free operating systems to
me. I tried to make it a bit more neutral.

I made a similar UI change for the connection menu. I’m not sure it is
needed.

What do you think?

Best regards,

Vivien

Vivien Kraus (2):
gnu: Add gtk-frdp.
gnu: Add gnome-connections.

gnu/packages/gnome.scm | 88 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 88 insertions(+)


base-commit: 1cc3b7e80f60a2a5a6a1400ed0b025efeae7a523
--
2.41.0
V
V
Vivien Kraus wrote on 20 Nov 2023 20:25
[PATCH gnome-team 2/2] gnu: Add gnome-connections.
(address . 67309@debbugs.gnu.org)
5ce27f5a5cd0cf93561e542103426cf39b2b9a1b.1700508505.git.vivien@planete-kraus.eu
* gnu/packages/gnome.scm (gnome-connections): New variable.

Change-Id: I4c026ab3aae07a73fcbc9b4b0612538455fe126a
---
gnu/packages/gnome.scm | 58 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 58 insertions(+)

Toggle diff (68 lines)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 6ace6d2f90..90090b11bc 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -13621,3 +13621,61 @@ (define-public gtk-frdp
This library provides a widget to view @acronym{RDP,Remote Desktop Protocol}
sessions.")
(license license:gpl3+)))
+
+(define-public gnome-connections
+ (package
+ (name "gnome-connections")
+ (version "44.1")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://gnome/sources/" name "/"
+ (version-major version) "/"
+ name "-" version ".tar.xz"))
+ (sha256
+ (base32
+ "0sv238bq0dhi68ksr3bcl4q44i3ishk5i10c2325qz879f92sshk"))
+ (snippet
+ #~(begin
+ (use-modules (guix build utils))
+ (delete-file-recursively "subprojects")))))
+ (build-system meson-build-system)
+ (arguments
+ (list
+ #:glib-or-gtk? #t
+ #:phases
+ #~(modify-phases %standard-phases
+ (add-after 'unpack 'patch-meson
+ (lambda _
+ (substitute* "meson.build"
+ (("gtk_update_icon_cache: true")
+ "gtk_update_icon_cache: false")
+ (("update_desktop_database: true")
+ "update_desktop_database: false"))))
+ (add-after 'unpack 'disable-nonfree-advertisement
+ (lambda _
+ (substitute* "src/ui/assistant.ui"
+ (("\\(standard for connecting to Windows\\)")
+ "")
+ (("\\(standard for connecting to Linux\\)")
+ "(standard for connecting to GNU/Linux)"))
+ (substitute* "src/ui/onboarding-dialog.ui"
+ (("Access Linux, Mac, and Windows")
+ "Access many different")
+ (("multiplatform.svg")
+ "welcome.svg")))))))
+ (inputs
+ (list gtk+ gtk-frdp gtk-vnc libhandy libsecret libxml2))
+ (native-inputs
+ (list gettext-minimal
+ `(,glib "bin")
+ itstool
+ pkg-config
+ vala))
+ (home-page "https://apps.gnome.org/Connections")
+ (synopsis "View and use other desktops")
+ (description "\
+Connections allows the user to connect to different machines or virtual
+machines. It can be used to provide support to users who might need help. It
+can use @acronym{VNC,Virtual Network Computing} and @acronym{RDP,Remote
+Desktop Protocol}.")
+ (license license:gpl3+)))
--
2.41.0
V
V
Vivien Kraus wrote on 20 Nov 2023 20:25
[PATCH gnome-team 1/2] gnu: Add gtk-frdp.
(address . 67309@debbugs.gnu.org)
7d7e1372187643cfd478b9dda7df8ba229fa5863.1700508505.git.vivien@planete-kraus.eu
* gnu/packages/gnome.scm (gtk-frdp): New variable.

Change-Id: I8ce190ca80245eff48af08e005e90e396e498e91
---
gnu/packages/gnome.scm | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)

Toggle diff (40 lines)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index ab485cffb1..6ace6d2f90 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -13591,3 +13591,33 @@ (define-public calls
backends, such as ModemManager for phones and @acronym{SIP, Session Initiation
Protocol} for @acronym{VoIP, Voice over @acronym{IP, Internet Protocol}}.")
(license license:gpl3+)))
+
+(define-public gtk-frdp
+ (package
+ (name "gtk-frdp")
+ ;; The latest published tag is 3.37.1, but it is very old:
+ ;; https://gitlab.gnome.org/GNOME/gtk-frdp/-/issues/39
+ (version "3.37.1")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://gitlab.gnome.org/GNOME/gtk-frdp")
+ (commit "62fc62c5ccb7634f0bc87c57a4673877c24c94ed")))
+ (file-name (git-file-name "gtk-frdp" version))
+ (sha256
+ (base32
+ "0msw7qpsyf9hkyq9ddhvl4g4vk1fnyi7g0bddca9x6p9d0arprqz"))))
+ (build-system meson-build-system)
+ (arguments
+ (list #:glib-or-gtk? #t))
+ (inputs
+ (list freerdp fuse gtk+))
+ (native-inputs
+ (list `(,glib "bin") gobject-introspection pkg-config vala))
+ (home-page "https://gitlab.gnome.org/GNOME/gtk-frdp")
+ (synopsis "RDP viewer widget for Gtk")
+ (description "\
+This library provides a widget to view @acronym{RDP,Remote Desktop Protocol}
+sessions.")
+ (license license:gpl3+)))
--
2.41.0
L
L
Liliana Marie Prikler wrote on 20 Nov 2023 20:55
Re: [PATCH gnome-team 2/2] gnu: Add gnome-connections.
2a8ced71196fa237f6a366029c7a216860748945.camel@gmail.com
Am Montag, dem 20.11.2023 um 20:25 +0100 schrieb Vivien Kraus:
Toggle quote (53 lines)
> * gnu/packages/gnome.scm (gnome-connections): New variable.
>
> Change-Id: I4c026ab3aae07a73fcbc9b4b0612538455fe126a
> ---
>  gnu/packages/gnome.scm | 58
> ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 58 insertions(+)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 6ace6d2f90..90090b11bc 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -13621,3 +13621,61 @@ (define-public gtk-frdp
>  This library provides a widget to view @acronym{RDP,Remote Desktop
> Protocol}
>  sessions.")
>      (license license:gpl3+)))
> +
> +(define-public gnome-connections
> +  (package
> +    (name "gnome-connections")
> +    (version "44.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://gnome/sources/" name "/"
> +                                  (version-major version) "/"
> +                                  name "-" version ".tar.xz"))
> +              (sha256
> +               (base32
> +               
> "0sv238bq0dhi68ksr3bcl4q44i3ishk5i10c2325qz879f92sshk"))
> +              (snippet
> +               #~(begin
> +                   (use-modules (guix build utils))
> +                   (delete-file-recursively "subprojects")))))
> +    (build-system meson-build-system)
> +    (arguments
> +     (list
> +      #:glib-or-gtk? #t
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (add-after 'unpack 'patch-meson
> +            (lambda _
> +              (substitute* "meson.build"
> +                (("gtk_update_icon_cache: true")
> +                 "gtk_update_icon_cache: false")
> +                (("update_desktop_database: true")
> +                 "update_desktop_database: false"))))
> +          (add-after 'unpack 'disable-nonfree-advertisement
> +            (lambda _
> +              (substitute* "src/ui/assistant.ui"
> +                (("\\(standard for connecting to Windows\\)")
> +                 "")
I'm not sure whether deleting this makes sense. We have a similar
information/warning in the disk formatter regarding NTFS :)
Toggle quote (5 lines)
> +                (("\\(standard for connecting to Linux\\)")
> +                 "(standard for connecting to GNU/Linux)"))
> +              (substitute* "src/ui/onboarding-dialog.ui"
> +                (("Access Linux, Mac, and Windows")
> +                 "Access many different")
Use a regexp here.
Toggle quote (2 lines)
> +                (("multiplatform.svg")
> +                 "welcome.svg")))))))
What's the visual diff between the two?
Toggle quote (13 lines)
> +    (inputs
> +     (list gtk+ gtk-frdp gtk-vnc libhandy libsecret libxml2))
> +    (native-inputs
> +     (list gettext-minimal
> +           `(,glib "bin")
> +           itstool
> +           pkg-config
> +           vala))
> +    (home-page "https://apps.gnome.org/Connections")
> +    (synopsis "View and use other desktops")
> +    (description "\
> +Connections allows the user to connect to different machines or
> virtual
If possible, don't use these "smart" non-line-breaks. Just write your
description as is.
Toggle quote (1 lines)
> +machines.
"Machines or virtual machines" reads a little weird imho.
Toggle quote (1 lines)
>   It can be used to provide support to users who might need help.
This sentence is a bit gratutious imho. Deleting it also allows you to
merge the previous and the next with an appropriate connector.
Toggle quote (6 lines)
>   It
> +can use @acronym{VNC,Virtual Network Computing} and
> @acronym{RDP,Remote
> +Desktop Protocol}.")
> +    (license license:gpl3+)))

Cheers
V
V
Vivien Kraus wrote on 20 Nov 2023 20:25
[PATCH gnome-team v2 2/2] gnu: Add gnome-connections.
c36ca506c7e4d1bc90bb518a653d2034df005091.1700598480.git.vivien@planete-kraus.eu
* gnu/packages/gnome.scm (gnome-connections): New variable.

Change-Id: I4c026ab3aae07a73fcbc9b4b0612538455fe126a
---
I kept the support-related sentence in the description because I think it is
important to put this application in the search results for “support” and
“help”. But feel free to kill the last sentence if you don’t think so.

gnu/packages/gnome.scm | 58 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 58 insertions(+)

Toggle diff (68 lines)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 6ace6d2f90..441eab6f4d 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -13621,3 +13621,61 @@ (define-public gtk-frdp
This library provides a widget to view @acronym{RDP,Remote Desktop Protocol}
sessions.")
(license license:gpl3+)))
+
+(define-public gnome-connections
+ (package
+ (name "gnome-connections")
+ (version "44.1")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://gnome/sources/" name "/"
+ (version-major version) "/"
+ name "-" version ".tar.xz"))
+ (sha256
+ (base32
+ "0sv238bq0dhi68ksr3bcl4q44i3ishk5i10c2325qz879f92sshk"))
+ (snippet
+ #~(begin
+ (use-modules (guix build utils))
+ (delete-file-recursively "subprojects")))))
+ (build-system meson-build-system)
+ (arguments
+ (list
+ #:glib-or-gtk? #t
+ #:phases
+ #~(modify-phases %standard-phases
+ (add-after 'unpack 'patch-meson
+ (lambda _
+ (substitute* "meson.build"
+ (("gtk_update_icon_cache: true")
+ "gtk_update_icon_cache: false")
+ (("update_desktop_database: true")
+ "update_desktop_database: false"))))
+ (add-after 'unpack 'disable-nonfree-advertisement
+ (lambda _
+ (substitute* "src/ui/assistant.ui"
+ (("\\(standard for connecting to Linux\\)")
+ "(standard for connecting to GNU/Linux)"))
+ (substitute* "src/ui/onboarding-dialog.ui"
+ (("Access [a-zA-Z ,]* desktops")
+ "Access desktops with different operating systems")
+ ;; Replace the logos of non-free operating systems with the
+ ;; default image: the project metaphor for connecting to a
+ ;; remote desktop.
+ (("multiplatform.svg")
+ "welcome.svg")))))))
+ (inputs
+ (list gtk+ gtk-frdp gtk-vnc libhandy libsecret libxml2))
+ (native-inputs
+ (list gettext-minimal
+ `(,glib "bin")
+ itstool
+ pkg-config
+ vala))
+ (home-page "https://apps.gnome.org/Connections")
+ (synopsis "View and use other desktops")
+ (description "Connections allows the user to connect to different
+real or virtual machines, using @acronym{VNC,Virtual Network Computing}
+or @acronym{RDP,Remote Desktop Protocol}. It can be used to provide support
+for other users who need help.")
+ (license license:gpl3+)))
--
2.41.0
V
V
Vivien Kraus wrote on 20 Nov 2023 20:25
[PATCH gnome-team v2 1/2] gnu: Add gtk-frdp.
14d75a8336919498688aa081fb11251b50898ebc.1700598480.git.vivien@planete-kraus.eu
* gnu/packages/gnome.scm (gtk-frdp): New variable.

Change-Id: I8ce190ca80245eff48af08e005e90e396e498e91
---
gnu/packages/gnome.scm | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)

Toggle diff (42 lines)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index ab485cffb1..6ace6d2f90 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -13591,3 +13591,33 @@ (define-public calls
backends, such as ModemManager for phones and @acronym{SIP, Session Initiation
Protocol} for @acronym{VoIP, Voice over @acronym{IP, Internet Protocol}}.")
(license license:gpl3+)))
+
+(define-public gtk-frdp
+ (package
+ (name "gtk-frdp")
+ ;; The latest published tag is 3.37.1, but it is very old:
+ ;; https://gitlab.gnome.org/GNOME/gtk-frdp/-/issues/39
+ (version "3.37.1")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://gitlab.gnome.org/GNOME/gtk-frdp")
+ (commit "62fc62c5ccb7634f0bc87c57a4673877c24c94ed")))
+ (file-name (git-file-name "gtk-frdp" version))
+ (sha256
+ (base32
+ "0msw7qpsyf9hkyq9ddhvl4g4vk1fnyi7g0bddca9x6p9d0arprqz"))))
+ (build-system meson-build-system)
+ (arguments
+ (list #:glib-or-gtk? #t))
+ (inputs
+ (list freerdp fuse gtk+))
+ (native-inputs
+ (list `(,glib "bin") gobject-introspection pkg-config vala))
+ (home-page "https://gitlab.gnome.org/GNOME/gtk-frdp")
+ (synopsis "RDP viewer widget for Gtk")
+ (description "\
+This library provides a widget to view @acronym{RDP,Remote Desktop Protocol}
+sessions.")
+ (license license:gpl3+)))

base-commit: 1cc3b7e80f60a2a5a6a1400ed0b025efeae7a523
--
2.41.0
L
L
Liliana Marie Prikler wrote on 21 Nov 2023 21:57
Re: [PATCH gnome-team v2 2/2] gnu: Add gnome-connections.
7abc74e8aefac345c05ee5b9f3b58e04fcf2d44a.camel@gmail.com
Am Montag, dem 20.11.2023 um 20:25 +0100 schrieb Vivien Kraus:
Toggle quote (8 lines)
> * gnu/packages/gnome.scm (gnome-connections): New variable.
>
> Change-Id: I4c026ab3aae07a73fcbc9b4b0612538455fe126a
> ---
> I kept the support-related sentence in the description because I
> think it is important to put this application in the search results
> for “support” and “help”.  But feel free to kill the last sentence if
> you don’t think so.
I don't think "support" or "help" are good search terms to look for
when you need remote desktop software and vice versa. Yes, you can
help others through remote desktop software, but you should be very
aware of the implications of doing so. Needless to say, descriptions
are not likely to capture that nuance.

Cheers
V
V
Vivien Kraus wrote on 20 Nov 2023 20:25
[PATCH gnome-team v3] gnu: Add gnome-connections.
0b1ff76e7cff908921d0df29279815191caca68c.1700864372.git.vivien@planete-kraus.eu
* gnu/packages/gnome.scm (gnome-connections): New variable.

Change-Id: I4c026ab3aae07a73fcbc9b4b0612538455fe126a
---
gnu/packages/gnome.scm | 57 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 57 insertions(+)

Toggle diff (69 lines)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 194a443484..a9ff217380 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -13624,3 +13624,60 @@ (define-public calls
backends, such as ModemManager for phones and @acronym{SIP, Session Initiation
Protocol} for @acronym{VoIP, Voice over @acronym{IP, Internet Protocol}}.")
(license license:gpl3+)))
+
+(define-public gnome-connections
+ (package
+ (name "gnome-connections")
+ (version "44.1")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://gnome/sources/" name "/"
+ (version-major version) "/"
+ name "-" version ".tar.xz"))
+ (sha256
+ (base32
+ "0sv238bq0dhi68ksr3bcl4q44i3ishk5i10c2325qz879f92sshk"))
+ (snippet
+ #~(begin
+ (use-modules (guix build utils))
+ (delete-file-recursively "subprojects")))))
+ (build-system meson-build-system)
+ (arguments
+ (list
+ #:glib-or-gtk? #t
+ #:phases
+ #~(modify-phases %standard-phases
+ (add-after 'unpack 'patch-meson
+ (lambda _
+ (substitute* "meson.build"
+ (("gtk_update_icon_cache: true")
+ "gtk_update_icon_cache: false")
+ (("update_desktop_database: true")
+ "update_desktop_database: false"))))
+ (add-after 'unpack 'disable-nonfree-advertisement
+ (lambda _
+ (substitute* "src/ui/assistant.ui"
+ (("\\(standard for connecting to Linux\\)")
+ "(standard for connecting to GNU/Linux)"))
+ (substitute* "src/ui/onboarding-dialog.ui"
+ (("Access [a-zA-Z ,]* desktops")
+ "Access desktops with different operating systems")
+ ;; Replace the logos of non-free operating systems with the
+ ;; default image: the project metaphor for connecting to a
+ ;; remote desktop.
+ (("multiplatform.svg")
+ "welcome.svg")))))))
+ (inputs
+ (list gtk+ gtk-frdp gtk-vnc libhandy libsecret libxml2))
+ (native-inputs
+ (list gettext-minimal
+ `(,glib "bin")
+ itstool
+ pkg-config
+ vala))
+ (home-page "https://apps.gnome.org/Connections")
+ (synopsis "View and use other desktops")
+ (description "Connections allows the user to connect to different
+real or virtual machines, using @acronym{VNC,Virtual Network Computing}
+or @acronym{RDP,Remote Desktop Protocol}.")
+ (license license:gpl3+)))

base-commit: 60db3a6b3f6e4d1bd751d04b7d9ad1e894febf93
--
2.41.0
L
L
Liliana Marie Prikler wrote on 25 Nov 2023 00:09
c81598fbd1712338bb9a2f3c7d553f06a0a0e533.camel@gmail.com
Am Montag, dem 20.11.2023 um 20:25 +0100 schrieb Vivien Kraus:
Toggle quote (64 lines)
> * gnu/packages/gnome.scm (gnome-connections): New variable.
>
> Change-Id: I4c026ab3aae07a73fcbc9b4b0612538455fe126a
> ---
>  gnu/packages/gnome.scm | 57
> ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 57 insertions(+)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 194a443484..a9ff217380 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -13624,3 +13624,60 @@ (define-public calls
>  backends, such as ModemManager for phones and @acronym{SIP, Session
> Initiation
>  Protocol} for @acronym{VoIP, Voice over @acronym{IP, Internet
> Protocol}}.")
>      (license license:gpl3+)))
> +
> +(define-public gnome-connections
> +  (package
> +    (name "gnome-connections")
> +    (version "44.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://gnome/sources/" name "/"
> +                                  (version-major version) "/"
> +                                  name "-" version ".tar.xz"))
> +              (sha256
> +               (base32
> +               
> "0sv238bq0dhi68ksr3bcl4q44i3ishk5i10c2325qz879f92sshk"))
> +              (snippet
> +               #~(begin
> +                   (use-modules (guix build utils))
> +                   (delete-file-recursively "subprojects")))))
> +    (build-system meson-build-system)
> +    (arguments
> +     (list
> +      #:glib-or-gtk? #t
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (add-after 'unpack 'patch-meson
> +            (lambda _
> +              (substitute* "meson.build"
> +                (("gtk_update_icon_cache: true")
> +                 "gtk_update_icon_cache: false")
> +                (("update_desktop_database: true")
> +                 "update_desktop_database: false"))))
> +          (add-after 'unpack 'disable-nonfree-advertisement
> +            (lambda _
> +              (substitute* "src/ui/assistant.ui"
> +                (("\\(standard for connecting to Linux\\)")
> +                 "(standard for connecting to GNU/Linux)"))
> +              (substitute* "src/ui/onboarding-dialog.ui"
> +                (("Access [a-zA-Z ,]* desktops")
> +                 "Access desktops with different operating systems")
> +                ;; Replace the logos of non-free operating systems
> with the
> +                ;; default image: the project metaphor for
> connecting to a
> +                ;; remote desktop.
> +                (("multiplatform.svg")
> +                 "welcome.svg")))))))
Finally had the time to test this, and I'm afraid it breaks
localization. Try skipping the page entirely instead :)
V
V
Vivien Kraus wrote on 20 Nov 2023 20:25
[PATCH gnome-team v4] gnu: Add gnome-connections.
592f6e51802212298461f654a7ec196a3b221b61.1701024576.git.vivien@planete-kraus.eu
* gnu/packages/gnome.scm (gnome-connections): New variable.

Change-Id: I4c026ab3aae07a73fcbc9b4b0612538455fe126a
* gnu/packages/patches/gnome-connections-disable-nonfree-desktop-page.patch:
New file.
* gnu/local.mk (dist_patch_DATA): Register it here.

Change-Id: If88a6e4c4f640a1175a8c98d13986f7520fe77b7
---
gnu/local.mk | 1 +
gnu/packages/gnome.scm | 51 ++++++++++++++++++
...ections-disable-nonfree-desktop-page.patch | 52 +++++++++++++++++++
3 files changed, 104 insertions(+)
create mode 100644 gnu/packages/patches/gnome-connections-disable-nonfree-desktop-page.patch

Toggle diff (123 lines)
diff --git a/gnu/local.mk b/gnu/local.mk
index 5cb9874d9f..6ae7e9b577 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1332,6 +1332,7 @@ dist_patch_DATA = \
%D%/packages/patches/gnome-2048-fix-positional-argument.patch \
%D%/packages/patches/gnome-control-center-firmware-security.patch \
%D%/packages/patches/gnome-control-center-libexecdir.patch \
+ %D%/packages/patches/gnome-connections-disable-nonfree-desktop-page.patch \
%D%/packages/patches/gnome-dictionary-meson-i18n.patch \
%D%/packages/patches/gnome-online-miners-tracker-3.patch \
%D%/packages/patches/gnome-settings-daemon-gc.patch \
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index d354327497..f2ed075172 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -13623,3 +13623,54 @@ (define-public calls
backends, such as ModemManager for phones and @acronym{SIP, Session Initiation
Protocol} for @acronym{VoIP, Voice over @acronym{IP, Internet Protocol}}.")
(license license:gpl3+)))
+
+(define-public gnome-connections
+ (package
+ (name "gnome-connections")
+ (version "44.1")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://gnome/sources/" name "/"
+ (version-major version) "/"
+ name "-" version ".tar.xz"))
+ (sha256
+ (base32
+ "0sv238bq0dhi68ksr3bcl4q44i3ishk5i10c2325qz879f92sshk"))
+ (snippet
+ #~(begin
+ (use-modules (guix build utils))
+ (delete-file-recursively "subprojects")))
+ (patches
+ (search-patches "gnome-connections-disable-nonfree-desktop-page.patch"))))
+ (build-system meson-build-system)
+ (arguments
+ (list
+ #:glib-or-gtk? #t
+ #:phases
+ #~(modify-phases %standard-phases
+ (add-after 'unpack 'patch-meson
+ (lambda _
+ (substitute* "meson.build"
+ (("gtk_update_icon_cache: true")
+ "gtk_update_icon_cache: false")
+ (("update_desktop_database: true")
+ "update_desktop_database: false"))))
+ (add-after 'unpack 'say-gnu/linux
+ (lambda _
+ (substitute* "src/ui/assistant.ui"
+ (("\\(standard for connecting to Linux\\)")
+ "(standard for connecting to GNU/Linux)")))))))
+ (inputs
+ (list gtk+ gtk-frdp gtk-vnc libhandy libsecret libxml2))
+ (native-inputs
+ (list gettext-minimal
+ `(,glib "bin")
+ itstool
+ pkg-config
+ vala))
+ (home-page "https://apps.gnome.org/Connections")
+ (synopsis "View and use other desktops")
+ (description "Connections allows the user to connect to different
+real or virtual machines, using @acronym{VNC,Virtual Network Computing}
+or @acronym{RDP,Remote Desktop Protocol}.")
+ (license license:gpl3+)))
diff --git a/gnu/packages/patches/gnome-connections-disable-nonfree-desktop-page.patch b/gnu/packages/patches/gnome-connections-disable-nonfree-desktop-page.patch
new file mode 100644
index 0000000000..10ff421864
--- /dev/null
+++ b/gnu/packages/patches/gnome-connections-disable-nonfree-desktop-page.patch
@@ -0,0 +1,52 @@
+From d6841278e27ee560c080867ec128add9e1faab8c Mon Sep 17 00:00:00 2001
+Message-ID: <d6841278e27ee560c080867ec128add9e1faab8c.1701024334.git.vivien@planete-kraus.eu>
+From: Vivien Kraus <vivien@planete-kraus.eu>
+Date: Sun, 26 Nov 2023 19:23:43 +0100
+Subject: [PATCH] =?UTF-8?q?Onboarding:=20Remove=20the=20=E2=80=9CDifferent?=
+ =?UTF-8?q?=20operating=20systems=E2=80=9D=20page.?=
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+This page may be used to push users to use non-free software on a
+remote computer.
+---
+Discussion: https://gitlab.gnome.org/GNOME/connections/-/issues/144
+
+ src/ui/onboarding-dialog.ui | 8 --------
+ src/ui/onboarding/multiplatform.svg | 1 -
+ 2 files changed, 9 deletions(-)
+ delete mode 100644 src/ui/onboarding/multiplatform.svg
+
+diff --git a/src/ui/onboarding-dialog.ui b/src/ui/onboarding-dialog.ui
+index 3ab8a1d..80d6a64 100644
+--- a/src/ui/onboarding-dialog.ui
++++ b/src/ui/onboarding-dialog.ui
+@@ -53,14 +53,6 @@
+ </object>
+ </child>
+
+- <child>
+- <object class="ConnectionsOnboardingDialogPage">
+- <property name="title" translatable="yes">Connect to different operating systems</property>
+- <property name="description" translatable="yes">Access Linux, Mac, and Windows desktops using Connections.</property>
+- <property name="image">/org/gnome/Connections/ui/onboarding/multiplatform.svg</property>
+- </object>
+- </child>
+-
+ <child>
+ <object class="ConnectionsOnboardingDialogPage">
+ <property name="title" translatable="yes">Enable remote desktop before connecting</property>
+diff --git a/src/ui/onboarding/multiplatform.svg b/src/ui/onboarding/multiplatform.svg
+deleted file mode 100644
+index 5b3e6a1..0000000
+--- a/src/ui/onboarding/multiplatform.svg
++++ /dev/null
+@@ -1 +0,0 @@
+-<svg height="600" width="800" xmlns:xlink="http://www.w3.org/1999/xlink" xmlns="http://www.w3.org/2000/svg"><defs><linearGradient id="c"><stop style="stop-color:#8ff0a4;stop-opacity:1" offset="0"/><stop style="stop-color:#99c1f1;stop-opacity:1" offset="1"/></linearGradient><linearGradient id="b"><stop style="stop-color:#c5dbf7;stop-opacity:1" offset="0"/><stop style="stop-color:#1b6fd4;stop-opacity:1" offset=".08"/><stop style="stop-color:#175fb6;stop-opacity:1" offset=".798"/><stop style="stop-color:#438de7;stop-opacity:1" offset=".932"/><stop style="stop-color:#175caf;stop-opacity:1" offset="1"/></linearGradient><linearGradient xlink:href="#a" id="d" x1="-46.029" y1="119.025" x2="139.157" y2="119.025" gradientUnits="userSpaceOnUse"/><linearGradient id="a"><stop style="stop-color:#4a86cf;stop-opacity:1" offset="0"/><stop style="stop-color:#33d17a;stop-opacity:1" offset=".144"/><stop style="stop-color:#f6d32d;stop-opacity:1" offset=".322"/><stop style="stop-color:#ff7800;stop-opacity:1" offset=".499"/><stop style="stop-color:#e01b24;stop-opacity:1" offset=".681"/><stop style="stop-color:#9141ac;stop-opacity:1" offset=".853"/><stop style="stop-color:#613583;stop-opacity:1" offset="1"/></linearGradient><linearGradient xlink:href="#b" id="f" x1="526.469" y1="262.426" x2="731.547" y2="262.426" gradientUnits="userSpaceOnUse"/><linearGradient xlink:href="#b" id="g" gradientUnits="userSpaceOnUse" x1="73.23" y1="262.426" x2="263.805" y2="262.426"/><linearGradient xlink:href="#c" id="e" x1="403.101" y1="232.449" x2="341.082" y2="463.905" gradientUnits="userSpaceOnUse"/><clipPath clipPathUnits="userSpaceOnUse" id="h"><rect style="fill:#e01b24;stroke-width:6;stop-color:#000" width="192.919" height="192.919" x="70.218" y="71.496" rx="23.687" ry="23.687"/></clipPath></defs><g transform="translate(-1536.865 -208.68) scale(3.8216)" style="display:inline"><rect style="opacity:1;vector-effect:none;fill:#000;fill-opacity:1;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;marker-start:none;marker-mid:none;marker-end:none;paint-order:normal" width="95.25" height="58.208" x="47.625" y="84.667" rx="2.884" ry="2.884"/><rect ry="2.884" rx="2.884" y="145.256" x="47.625" height="58.208" width="95.25" style="opacity:1;vector-effect:none;fill:#000;fill-opacity:.102362;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;marker-start:none;marker-mid:none;marker-end:none;paint-order:normal"/><rect style="opacity:1;vector-effect:none;fill:#deddda;fill-opacity:1;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;marker-start:none;marker-mid:none;marker-end:none;paint-order:normal" width="95.25" height="58.208" x="47.625" y="144.198" rx="2.884" ry="2.884"/><rect ry="2.884" rx="2.884" y="142.875" x="47.625" height="58.208" width="95.25" style="opacity:1;vector-effect:none;fill:#f6f5f4;fill-opacity:1;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;marker-start:none;marker-mid:none;marker-end:none;paint-order:normal"/><rect style="opacity:1;vector-effect:none;fill:#c0bfbc;fill-opacity:1;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;marker-start:none;marker-mid:none;marker-end:none;paint-order:normal" width="84.667" height="29.104" x="52.917" y="148.167" rx="1.958" ry="1.958"/><rect ry="1.958" rx="1.958" y="148.696" x="52.917" height="29.104" width="84.667" style="opacity:1;vector-effect:none;fill:#deddda;fill-opacity:1;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;marker-start:none;marker-mid:none;marker-end:none;paint-order:normal"/><rect ry=".826" rx=".826" y="137.583" x="63.5" height="7.408" width="63.5" style="opacity:1;vector-effect:none;fill:#000;fill-opacity:1;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;marker-start:none;marker-mid:none;marker-end:none;paint-order:normal"/><rect ry="2.884" rx="2.884" y="179.917" x="82.021" height="15.875" width="26.458" style="opacity:1;vector-effect:none;fill:#deddda;fill-opacity:1;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;marker-start:none;marker-mid:none;marker-end:none;paint-order:normal"/><rect style="opacity:1;vector-effect:none;fill:#241f31;fill-opacity:1;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;marker-start:none;marker-mid:none;marker-end:none;paint-order:normal" width="46.302" height="5.292" x="74.083" y="170.656" rx="1.013" ry="1.013"/><rect ry="1.013" rx="1.013" y="170.656" x="121.708" height="5.292" width="6.615" style="opacity:1;vector-effect:none;fill:#241f31;fill-opacity:1;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;marker-start:none;marker-mid:none;marker-end:none;paint-order:normal"/><rect style="opacity:1;vector-effect:none;fill:#241f31;fill-opacity:1;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;marker-start:none;marker-mid:none;marker-end:none;paint-order:normal" width="6.615" height="5.292" x="129.646" y="170.656" rx="1.013" ry="1.013"/><rect ry="1.013" rx="1.013" y="164.042" x="125.677" height="5.292" width="5.292" style="opacity:1;vector-effect:none;fill:#241f31;fill-opacity:1;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;marker-start:none;marker-mid:none;marker-end:none;paint-order:normal"/><rect style="opacity:1;vector-effect:none;fill:#241f31;fill-opacity:1;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;marker-start:none;marker-mid:none;marker-end:none;paint-order:normal" width="6.615" height="5.292" x="117.74" y="164.042" rx="1.013" ry="1.013"/><rect ry="1.013" rx="1.013" y="164.042" x="109.802" height="5.292" width="6.615" style="opacity:1;vector-effect:none;fill:#241f31;fill-opacity:1;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;marker-start:none;marker-mid:none;marker-end:none;paint-order:normal"/><rect style="opacity:1;vector-effect:none;fill:#241f31;fill-opacity:1;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;marker-start:none;marker-mid:none;marker-end:none;paint-order:normal" width="6.615" height="5.292" x="101.865" y="164.042" rx="1.013" ry="1.013"/><rect ry="1.013" rx="1.013" y="164.042" x="93.927" height="5.292" width="6.615" style="opacity:1;vector-effect:none;fill:#241f31;fill-opacity:1;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;marker-start:none;marker-mid:none;marker-end:none;paint-order:normal"/><rect style="opacity:1;vector-effect:none;fill:#241f31;fill-opacity:1;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;marker-start:none;marker-mid:none;marker-end:none;paint-order:normal" width="6.615" height="5.292" x="85.99" y="164.042" rx="1.013" ry="1.013"/><rect ry="1.013" rx="1.013" y="164.042" x="78.052" height="5.292" width="6.615" style="opacity:1;vector-effect:none;fill:#241f31;fill-opacity:1;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;marker-start:none;marker-mid:none;marker-end:none;paint-order:normal"/><rect style="opacity:1;vector-effect:none;fill:#241f31;fill-opacity:1;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;marker-start:none;marker-mid:none;marker-end:none;paint-order:normal" width="6.615" height="5.292" x="70.115" y="164.042" rx="1.013" ry="1.013"/><rect ry="1.013" rx="1.013" y="164.042" x="62.177" height="5.292" width="6.615" style="opacity:1;vector-effect:none;fill:#241f31;fill-opacity:1;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;marker-start:none;marker-mid:none;marker-end:none;paint-order:normal"/><rect style="opacity:1;vector-effect:none;fill:#241f31;fill-opacity:1;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;marker-start:none;marker-mid:none;marker-end:none;paint-order:normal" width="6.615" height="5.292" x="121.708" y="157.427" rx="1.013" ry="1.013"/><rect ry="1.013" rx="1.013" y="157.427" x="113.771" height="5.292" width="6.615" style="opacity:1;vector-effect:none;fill:#241f31;fill-opacity:1;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;marker-start:none;marker-mid:none;marker-end:none;paint-order:normal"/><rect style="opacity:1;vector-effect:none;fill:#241f31;fill-opacity:1;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;marker-start:none;marker-mid:none;marker-end:none;paint-order:normal" width="6.615" height="5.292" x="105.833" y="157.427" rx="1.013" ry="1.013"/><rect ry="1.013" rx="1.013" y="157.427" x="97.896" height="5.292" width="6.615" style="opacity:1;vector-effect:none;fill:#241f31;fill-opacity:1;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;marker-start:none;marker-mid:none;marker-end:none;paint-order:normal"/><rect style="opacity:1;vector-effect:none;fill:#241f31;fill-opacity:1;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;marker-start:none;marker-mid:none;marker-end:none;paint-order:normal" width="6.615" height="5.292" x="89.958" y="157.427" rx="1.013" ry="1.013"/><rect ry="1.013" rx="1.013" y="157.427" x="82.021" height="5.292" width="6.615" style="opacity:1;vector-effect:none;fill:#241f31;fill-opacity:1;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;marker-start:none;marker-mid:none;marker-end:none;paint-order:normal"/><rect style="opacity:1;vector-effect:none;fill:#241f31;fill-opacity:1;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;marker-start:none;marker-mid:none;marker-end:none;paint-order:normal" width="6.615" height="5.292" x="74.083" y="157.427" rx="1.013" ry="1.013"/><rect ry="1.013" rx="1.013" y="157.427" x="66.146" height="5.292" width="6.615" style="opacity:1;vector-effect:none;fill:#241f31;fill-opacity:1;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;marker-start:none;marker-mid:none;marker-end:none;paint-order:normal"/><rect style="opacity:1;vector-effect:none;fill:#241f31;fill-opacity:1;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;marker-start:none;marker-mid:none;marker-end:none;paint-order:normal" width="10.583" height="5.292" x="54.24" y="157.427" rx="1.013" ry="1.013"/><rect ry="1.013" rx="1.013" y="150.813" x="125.677" height="5.292" width="10.583" style="opacity:1;vector-effect:none;fill:#241f31;fill-opacity:1;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;marker-start:none;marker-mid:none;marker-end:none;paint-order:normal"/><rect style="opacity:1;vector-effect:none;fill:#241f31;fill-opacity:1;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;marker-start:none;marker-mid:none;marker-end:none;paint-order:normal" width="6.615" height="5.292" x="117.74" y="150.813" rx="1.013" ry="1.013"/><rect ry="1.013" rx="1.013" y="150.813" x="109.802" height="5.292" width="6.615" style="opacity:1;vector-effect:none;fill:#241f31;fill-opacity:1;stroke:none;stroke-width:1.5875;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;
This message was truncated. Download the full message here.
L
L
Liliana Marie Prikler wrote on 26 Nov 2023 21:17
c3c31cad5aeb9ac4c1abd86b1885106a02bbe28e.camel@gmail.com
Am Montag, dem 20.11.2023 um 20:25 +0100 schrieb Vivien Kraus:
Toggle quote (84 lines)
> * gnu/packages/gnome.scm (gnome-connections): New variable.
>
> Change-Id: I4c026ab3aae07a73fcbc9b4b0612538455fe126a
> * gnu/packages/patches/gnome-connections-disable-nonfree-desktop-
> page.patch:
> New file.
> * gnu/local.mk (dist_patch_DATA): Register it here.
>
> Change-Id: If88a6e4c4f640a1175a8c98d13986f7520fe77b7
> ---
>  gnu/local.mk                                  |  1 +
>  gnu/packages/gnome.scm                        | 51
> ++++++++++++++++++
>  ...ections-disable-nonfree-desktop-page.patch | 52
> +++++++++++++++++++
>  3 files changed, 104 insertions(+)
>  create mode 100644 gnu/packages/patches/gnome-connections-disable-
> nonfree-desktop-page.patch
>
> diff --git a/gnu/local.mk b/gnu/local.mk
> index 5cb9874d9f..6ae7e9b577 100644
> --- a/gnu/local.mk
> +++ b/gnu/local.mk
> @@ -1332,6 +1332,7 @@ dist_patch_DATA
> =                                         \
>    %D%/packages/patches/gnome-2048-fix-positional-
> argument.patch        \
>    %D%/packages/patches/gnome-control-center-firmware-
> security.patch    \
>    %D%/packages/patches/gnome-control-center-libexecdir.patch   \
> +  %D%/packages/patches/gnome-connections-disable-nonfree-desktop-
> page.patch \
>    %D%/packages/patches/gnome-dictionary-meson-i18n.patch       \
>    %D%/packages/patches/gnome-online-miners-tracker-3.patch     \
>    %D%/packages/patches/gnome-settings-daemon-gc.patch          \
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index d354327497..f2ed075172 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -13623,3 +13623,54 @@ (define-public calls
>  backends, such as ModemManager for phones and @acronym{SIP, Session
> Initiation
>  Protocol} for @acronym{VoIP, Voice over @acronym{IP, Internet
> Protocol}}.")
>      (license license:gpl3+)))
> +
> +(define-public gnome-connections
> +  (package
> +    (name "gnome-connections")
> +    (version "44.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://gnome/sources/" name "/"
> +                                  (version-major version) "/"
> +                                  name "-" version ".tar.xz"))
> +              (sha256
> +               (base32
> +               
> "0sv238bq0dhi68ksr3bcl4q44i3ishk5i10c2325qz879f92sshk"))
> +              (snippet
> +               #~(begin
> +                   (use-modules (guix build utils))
> +                   (delete-file-recursively "subprojects")))
> +              (patches
> +               (search-patches "gnome-connections-disable-nonfree-
> desktop-page.patch"))))
> +    (build-system meson-build-system)
> +    (arguments
> +     (list
> +      #:glib-or-gtk? #t
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (add-after 'unpack 'patch-meson
> +            (lambda _
> +              (substitute* "meson.build"
> +                (("gtk_update_icon_cache: true")
> +                 "gtk_update_icon_cache: false")
> +                (("update_desktop_database: true")
> +                 "update_desktop_database: false"))))
> +          (add-after 'unpack 'say-gnu/linux
> +            (lambda _
> +              (substitute* "src/ui/assistant.ui"
> +                (("\\(standard for connecting to Linux\\)")
> +                 "(standard for connecting to GNU/Linux)")))))))
Unless you also replace these in the .po files, this change is actively
harmful. In fact, I'd argue that even then it's probably not the best
idea to do this.
Toggle quote (41 lines)
> +    (inputs
> +     (list gtk+ gtk-frdp gtk-vnc libhandy libsecret libxml2))
> +    (native-inputs
> +     (list gettext-minimal
> +           `(,glib "bin")
> +           itstool
> +           pkg-config
> +           vala))
> +    (home-page "https://apps.gnome.org/Connections")
> +    (synopsis "View and use other desktops")
> +    (description "Connections allows the user to connect to
> different
> +real or virtual machines, using @acronym{VNC,Virtual Network
> Computing}
> +or @acronym{RDP,Remote Desktop Protocol}.")
> +    (license license:gpl3+)))
> diff --git a/gnu/packages/patches/gnome-connections-disable-nonfree-
> desktop-page.patch b/gnu/packages/patches/gnome-connections-disable-
> nonfree-desktop-page.patch
> new file mode 100644
> index 0000000000..10ff421864
> --- /dev/null
> +++ b/gnu/packages/patches/gnome-connections-disable-nonfree-desktop-
> page.patch
> @@ -0,0 +1,52 @@
> +From d6841278e27ee560c080867ec128add9e1faab8c Mon Sep 17 00:00:00
> 2001
> +Message-ID:
> <d6841278e27ee560c080867ec128add9e1faab8c.1701024334.git.vivien@plane
> te-kraus.eu>
> +From: Vivien Kraus <vivien@planete-kraus.eu>
> +Date: Sun, 26 Nov 2023 19:23:43 +0100
> +Subject: [PATCH] =?UTF-
> 8?q?Onboarding:=20Remove=20the=20=E2=80=9CDifferent?=
> + =?UTF-8?q?=20operating=20systems=E2=80=9D=20page.?=
> +MIME-Version: 1.0
> +Content-Type: text/plain; charset=UTF-8
> +Content-Transfer-Encoding: 8bit
> +
> +This page may be used to push users to use non-free software on a
> +remote computer.
I think the claim here is "This page may push users to connect to
remote machines running non-free software", or more concretely, "this
program suggests to connect to Windows and/or Mac PCs", taking the
onboarding self-ad at face value. Under such a literal reading, I'd
personally remove the onboarding dialogue itself ("don't tell me what
to do"), but that aside, I fear that simply dropping the page won't
work for upstream (they still have a feature to advertise). Why not
emphasize the multi-protocol thing instead? That way, it at least
stays OS-agnostic, which is probably better for everyone :)
V
V
Vivien Kraus wrote on 20 Nov 2023 20:25
[PATCH gnome-team v5] gnu: Add gnome-connections.
d56c2e6017d914354abebb60742de153cf19ab89.1701036061.git.vivien@planete-kraus.eu
* gnu/packages/gnome.scm (gnome-connections): New variable.

Change-Id: If88a6e4c4f640a1175a8c98d13986f7520fe77b7
---
gnu/packages/gnome.scm | 49 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 49 insertions(+)

Toggle diff (61 lines)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index d354327497..72121a0517 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -13623,3 +13623,52 @@ (define-public calls
backends, such as ModemManager for phones and @acronym{SIP, Session Initiation
Protocol} for @acronym{VoIP, Voice over @acronym{IP, Internet Protocol}}.")
(license license:gpl3+)))
+
+(define-public gnome-connections
+ (package
+ (name "gnome-connections")
+ (version "44.1")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://gnome/sources/" name "/"
+ (version-major version) "/"
+ name "-" version ".tar.xz"))
+ (sha256
+ (base32
+ "0sv238bq0dhi68ksr3bcl4q44i3ishk5i10c2325qz879f92sshk"))
+ (snippet
+ #~(begin
+ (use-modules (guix build utils))
+ (delete-file-recursively "subprojects")))))
+ (build-system meson-build-system)
+ (arguments
+ (list
+ #:glib-or-gtk? #t
+ #:phases
+ #~(modify-phases %standard-phases
+ (add-after 'unpack 'patch-meson
+ (lambda _
+ (substitute* "meson.build"
+ (("gtk_update_icon_cache: true")
+ "gtk_update_icon_cache: false")
+ (("update_desktop_database: true")
+ "update_desktop_database: false"))))
+ (add-after 'unpack 'disable-onboarding-dialog
+ (lambda _
+ (substitute* "src/application.vala"
+ (("\\(new OnboardingDialog \\(main_window\\)\\).present \\(\\);")
+ "// Skip the onboarding dialog")))))))
+ (inputs
+ (list gtk+ gtk-frdp gtk-vnc libhandy libsecret libxml2))
+ (native-inputs
+ (list gettext-minimal
+ `(,glib "bin")
+ itstool
+ pkg-config
+ vala))
+ (home-page "https://apps.gnome.org/Connections")
+ (synopsis "View and use other desktops")
+ (description "Connections allows the user to connect to different
+real or virtual machines, using @acronym{VNC,Virtual Network Computing}
+or @acronym{RDP,Remote Desktop Protocol}.")
+ (license license:gpl3+)))

base-commit: e21f0cb7b7a87992004193cd56638ad961fe5928
--
2.41.0
M
M
Maxim Cournoyer wrote on 4 Dec 2023 00:52
(name . Vivien Kraus)(address . vivien@planete-kraus.eu)
87wmtux2ro.fsf@gmail.com
Hi,

Vivien Kraus <vivien@planete-kraus.eu> writes:

Toggle quote (2 lines)
> * gnu/packages/gnome.scm (gnome-connections): New variable.

[...]

Toggle quote (5 lines)
> + (description "Connections allows the user to connect to different
> +real or virtual machines, using @acronym{VNC,Virtual Network Computing}
> +or @acronym{RDP,Remote Desktop Protocol}.")
> + (license license:gpl3+)))

Nitpick: You can add a space following the colon to separate arguments
of @acronym, for better readability.

Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>

--
Thanks,
Maxim
V
V
Vivien Kraus wrote on 4 Dec 2023 18:22
[PATCH gnome-team v6 2/2] gnu: gnome-connections: Improve wording.
(name . Maxim Cournoyer)(address . maxim.cournoyer@gmail.com)
a75f7c80f2eaca7cbdba86718e480d2ff69de332.1701710667.git.vivien@planete-kraus.eu
* gnu/packages/gnome.scm (gnome-connections) [description]: Add space after
comma in @acronym.

Change-Id: Ib6c9e39057786e7bd135874238a9b7629e316200
---
See 1/2.

gnu/packages/gnome.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (15 lines)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 185726dd5f..9943b10c2c 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -13817,6 +13817,6 @@ (define-public gnome-connections
(home-page "https://apps.gnome.org/Connections")
(synopsis "View and use other desktops")
(description "Connections allows the user to connect to different
-real or virtual machines, using @acronym{VNC,Virtual Network Computing}
-or @acronym{RDP,Remote Desktop Protocol}.")
+real or virtual machines, using @acronym{VNC, Virtual Network Computing}
+or @acronym{RDP, Remote Desktop Protocol}.")
(license license:gpl3+)))
--
2.41.0
V
V
Vivien Kraus wrote on 4 Dec 2023 18:22
[PATCH gnome-team v6 1/2] gnu: gtk-frdp: Improve wording.
(name . Maxim Cournoyer)(address . maxim.cournoyer@gmail.com)
0f3d2784e6765538780f1b2447de944e10236106.1701710667.git.vivien@planete-kraus.eu
* gnu/packages/gnome.scm (gtk-frdp) [description]: Add space after comma in
@acronym.

Change-Id: Ic3bc9b317ff54636fad0d073de1af2ffdabcd8f2
---
Hi, the patch has already been merged (by accident?), so I added a new commit.

Best regards,

Vivien

gnu/packages/gnome.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (17 lines)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index c6437ce450..185726dd5f 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -13769,7 +13769,7 @@ (define-public gtk-frdp
(home-page "https://gitlab.gnome.org/GNOME/gtk-frdp")
(synopsis "RDP viewer widget for Gtk")
(description "This library provides a widget to view
-@acronym{RDP,Remote Desktop Protocol} sessions.")
+@acronym{RDP, Remote Desktop Protocol} sessions.")
(license license:gpl3+)))
(define-public gnome-connections

base-commit: 4c323c2f8308bba0e3295f3109d159c7b8f72838
--
2.41.0
M
M
Maxim Cournoyer wrote on 5 Dec 2023 00:05
(name . Vivien Kraus)(address . vivien@planete-kraus.eu)
87lea9pnzd.fsf@gmail.com
Vivien Kraus <vivien@planete-kraus.eu> writes:

Toggle quote (5 lines)
> * gnu/packages/gnome.scm (gtk-frdp) [description]: Add space after comma in
> @acronym.
>
> Change-Id: Ic3bc9b317ff54636fad0d073de1af2ffdabcd8f2

Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>

--
Thanks,
Maxim
M
M
Maxim Cournoyer wrote on 5 Dec 2023 00:06
Re: [PATCH gnome-team v6 2/2] gnu: gnome-connections: Improve wording.
(name . Vivien Kraus)(address . vivien@planete-kraus.eu)
87h6kxpnyx.fsf@gmail.com
Vivien Kraus <vivien@planete-kraus.eu> writes:

Toggle quote (5 lines)
> * gnu/packages/gnome.scm (gnome-connections) [description]: Add space after
> comma in @acronym.
>
> Change-Id: Ib6c9e39057786e7bd135874238a9b7629e316200

Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>

--
Thanks,
Maxim
L
L
Liliana Marie Prikler wrote on 20 Dec 2023 00:01
Re: [PATCH gnome-team v6 1/2] gnu: gtk-frdp: Improve wording.
09c9f33dee5fa2d4a73779cfb77935e08c6cf7ee.camel@gmail.com
Am Montag, dem 04.12.2023 um 18:05 -0500 schrieb Maxim Cournoyer:
Toggle quote (9 lines)
> Vivien Kraus <vivien@planete-kraus.eu> writes:
>
> > * gnu/packages/gnome.scm (gtk-frdp) [description]: Add space after
> > comma in
> > @acronym.
> >
> > Change-Id: Ic3bc9b317ff54636fad0d073de1af2ffdabcd8f2
>
> Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>
Done at last.
Closed
?