builtin:git-download capability detection not working for the bordeaux build farm

Done

Details

3 participants

Ludovic Courtès
Christopher Baines
Simon Tournier

Owner: unassigned

Submitted by: Christopher Baines

Severity: important

Debbugs page

Christopher Baines wrote 1 years ago

Recipients:(address . bug-guix@gnu.org)

Message-ID:87pm08f41q.fsf@cbaines.net

The bordeaux build farm depends on computing the derivations on one

machine, then potentially building them on a different machine.

Some of the build machines don't have a new enough guix-daemon that

understands builtin:git-download, so derivations that use this are

sometimes failing (e.g. [1])

1: https://bordeaux.guix.gnu.org/build/10cc5622-6b1f-4f28-ad9a-41cf796d7a15

One potential approach to address this is somehow have the data service

indicate that it wants compatible derivations when computing them,

rather than to have guix do feature detection against the guix-daemon

that is being used at the point the derivations are being computed.

Simon Tournier wrote 1 years ago

Recipients:

Message-ID:86zfz8219i.fsf@gmail.com

Hi Chris,

On Fri, 17 Nov 2023 at 21:39, Christopher Baines <mail@cbaines.net> wrote:

Toggle quote (7 lines)

> The bordeaux build farm depends on computing the derivations on one

> machine, then potentially building them on a different machine.

> Some of the build machines don't have a new enough guix-daemon that

> understands builtin:git-download, so derivations that use this are

> sometimes failing (e.g. [1])

Do you mean that the drv file is generated using a new daemon then this

drv file is “offloaded” to another machine using an older daemon and

thus fails to build it?

Toggle quote (5 lines)

> One potential approach to address this is somehow have the data service

> indicate that it wants compatible derivations when computing them,

> rather than to have guix do feature detection against the guix-daemon

> that is being used at the point the derivations are being computed.

Other solutions are: downgrade the daemon of one of the machine or

update the daemon of other machines, no?

Why would the latter not be possible?

Cheers

simon

Christopher Baines wrote 1 years ago

Recipients:(name . Simon Tournier)(address . zimon.toutoune@gmail.com)(address . 67250@debbugs.gnu.org)

Message-ID:87cyw4g1hd.fsf@cbaines.net

Simon Tournier <zimon.toutoune@gmail.com> writes:

Toggle quote (15 lines)> Hi Chris,
>
> On Fri, 17 Nov 2023 at 21:39, Christopher Baines <mail@cbaines.net> wrote:
>
>> The bordeaux build farm depends on computing the derivations on one
>> machine, then potentially building them on a different machine.
>>
>> Some of the build machines don't have a new enough guix-daemon that
>> understands builtin:git-download, so derivations that use this are
>> sometimes failing (e.g. [1])
>
> Do you mean that the drv file is generated using a new daemon then this
> drv file is “offloaded” to another machine using an older daemon and
> thus fails to build it?

Roughly, yep.

Toggle quote (10 lines)>> One potential approach to address this is somehow have the data service
>> indicate that it wants compatible derivations when computing them,
>> rather than to have guix do feature detection against the guix-daemon
>> that is being used at the point the derivations are being computed.
>
> Other solutions are: downgrade the daemon of one of the machine or
> update the daemon of other machines, no?
>
> Why would the latter not be possible?

It's possible, just difficult. Because with the current guix-daemon, the
build coordinator can only build things that can be GC'd, some machines
deliberately run older daemons to allow building newer things without
hitting this issue.

Ludovic Courtès wrote 1 years ago

Recipients:(name . Christopher Baines)(address . mail@cbaines.net)(address . 67250@debbugs.gnu.org)

Message-ID:87bkbmm6o1.fsf@gnu.org

Hi,

Christopher Baines <mail@cbaines.net> skribis:

Toggle quote (14 lines)> The bordeaux build farm depends on computing the derivations on one
> machine, then potentially building them on a different machine.
>
> Some of the build machines don't have a new enough guix-daemon that
> understands builtin:git-download, so derivations that use this are
> sometimes failing (e.g. [1])
>
> 1: https://bordeaux.guix.gnu.org/build/10cc5622-6b1f-4f28-ad9a-41cf796d7a15
>
> One potential approach to address this is somehow have the data service
> indicate that it wants compatible derivations when computing them,
> rather than to have guix do feature detection against the guix-daemon
> that is being used at the point the derivations are being computed.

Would it work for you if we added a keyword argument to

‘open-connection’ in (guix store) that would let you select which

builtins to use?

As in:

(open-connection

#:assume-available-builtin-builders '("download"))

Ludo’.

Ludovic Courtès wrote 1 years ago

control message for bug #67250

Recipients:(address . control@debbugs.gnu.org)

Message-ID:87a5r6m6np.fsf@gnu.org

severity 67250 important

quit

Simon Tournier wrote 1 years ago

Re: bug#67250: builtin:git-download capability detection not working for the bordeaux build farm

Recipients:(address . 67250@debbugs.gnu.org)

Message-ID:87msuy9dem.fsf@gmail.com

Hi,

On Wed, 22 Nov 2023 at 11:19, Ludovic Courtès <ludo@gnu.org> wrote:

Toggle quote (5 lines)

> As in:

> (open-connection

> #:assume-available-builtin-builders '("download"))

Instead, why not check in ’git-fetch’? Currently, the test is done

against the local daemon, right?

Toggle snippet (17 lines)(define* (git-fetch ref hash-algo hash
                    #:optional name
                    #:key (system (%current-system))
                    guile git)
  "Return a fixed-output derivation that fetches REF, a <git-reference>
object.  The output is expected to have recursive hash HASH of type
HASH-ALGO (a symbol).  Use NAME as the file name, or a generic name if #f."
  (mlet %store-monad ((builtins (built-in-builders*)))
    (if (member "git-download" builtins)
        (git-fetch/built-in ref hash-algo hash name
                            #:system system)
        (git-fetch/in-band ref hash-algo hash name
                           #:system system
                           #:guile guile
                           #:git git))))

For example, why not a test as:

(if (and SOMETHING

(member "git-download" builtins))

And this SOMETHING could be a global variable, as

%assume-builtin-builder, set to true by default and turn to false with

an environment variable, as GUIX_ASSUME_BUILTIN.

Cheers,

simon

Christopher Baines wrote 1 years ago

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 67250@debbugs.gnu.org)

Message-ID:87y1ehlsup.fsf@cbaines.net

Ludovic Courtès <ludo@gnu.org> writes:

Toggle quote (27 lines)> Hi,
>
> Christopher Baines <mail@cbaines.net> skribis:
>
>> The bordeaux build farm depends on computing the derivations on one
>> machine, then potentially building them on a different machine.
>>
>> Some of the build machines don't have a new enough guix-daemon that
>> understands builtin:git-download, so derivations that use this are
>> sometimes failing (e.g. [1])
>>
>> 1: https://bordeaux.guix.gnu.org/build/10cc5622-6b1f-4f28-ad9a-41cf796d7a15
>>
>> One potential approach to address this is somehow have the data service
>> indicate that it wants compatible derivations when computing them,
>> rather than to have guix do feature detection against the guix-daemon
>> that is being used at the point the derivations are being computed.
>
> Would it work for you if we added a keyword argument to
> ‘open-connection’ in (guix store) that would let you select which
> builtins to use?
>
> As in:
>
>   (open-connection
>     #:assume-available-builtin-builders '("download"))

Yep, that would at least allow freezing the available builtins going

forward and separating it from the running daemon.

Christopher Baines wrote 10 months ago

Recipients:(address . 67250@debbugs.gnu.org)

Message-ID:87pltjb6fk.fsf@cbaines.net

Christopher Baines <mail@cbaines.net> writes:

Toggle quote (32 lines)> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Hi,
>>
>> Christopher Baines <mail@cbaines.net> skribis:
>>
>>> The bordeaux build farm depends on computing the derivations on one
>>> machine, then potentially building them on a different machine.
>>>
>>> Some of the build machines don't have a new enough guix-daemon that
>>> understands builtin:git-download, so derivations that use this are
>>> sometimes failing (e.g. [1])
>>>
>>> 1: https://bordeaux.guix.gnu.org/build/10cc5622-6b1f-4f28-ad9a-41cf796d7a15
>>>
>>> One potential approach to address this is somehow have the data service
>>> indicate that it wants compatible derivations when computing them,
>>> rather than to have guix do feature detection against the guix-daemon
>>> that is being used at the point the derivations are being computed.
>>
>> Would it work for you if we added a keyword argument to
>> ‘open-connection’ in (guix store) that would let you select which
>> builtins to use?
>>
>> As in:
>>
>>   (open-connection
>>     #:assume-available-builtin-builders '("download"))
>
> Yep, that would at least allow freezing the available builtins going
> forward and separating it from the running daemon.

I've now sent some patches which add this option to #71038.

Christopher Baines wrote 10 months ago

Recipients:(name . Simon Tournier)(address . zimon.toutoune@gmail.com)(address . 67250@debbugs.gnu.org)

Message-ID:87jzjrb60a.fsf@cbaines.net

Simon Tournier <zimon.toutoune@gmail.com> writes:

Toggle quote (37 lines)> On Wed, 22 Nov 2023 at 11:19, Ludovic Courtès <ludo@gnu.org> wrote:
>
>> As in:
>>
>>   (open-connection
>>     #:assume-available-builtin-builders '("download"))
>
> Instead, why not check in ’git-fetch’?  Currently, the test is done
> against the local daemon, right?
>
> --8<---------------cut here---------------start------------->8---
> (define* (git-fetch ref hash-algo hash
>                     #:optional name
>                     #:key (system (%current-system))
>                     guile git)
>   "Return a fixed-output derivation that fetches REF, a <git-reference>
> object.  The output is expected to have recursive hash HASH of type
> HASH-ALGO (a symbol).  Use NAME as the file name, or a generic name if #f."
>   (mlet %store-monad ((builtins (built-in-builders*)))
>     (if (member "git-download" builtins)
>         (git-fetch/built-in ref hash-algo hash name
>                             #:system system)
>         (git-fetch/in-band ref hash-algo hash name
>                            #:system system
>                            #:guile guile
>                            #:git git))))
> --8<---------------cut here---------------end--------------->8---
>
> For example, why not a test as:
>
>     (if (and SOMETHING
>              (member "git-download" builtins))
>
> And this SOMETHING could be a global variable, as
> %assume-builtin-builder, set to true by default and turn to false with
> an environment variable, as GUIX_ASSUME_BUILTIN.

I can think of a couple of reasons not to do this via an environment
variable.

Having the logic in git-fetch via an environment variable would mean
that if other builtins are added, the code generating derivations using
them would also have to check the environment variable. Specifying the
builtin's that are available on a store connection would work
automatically in the case of new builtins being added..

There's also trade-offs in control when using environment variables, or
deciding when to take the value from an environment variable and switch
to passing the value around through arguments or other means. Consider
the case where you have a single process which has multiple store
connections open and it wants to specify different available builtin's
on particular store connections. This would become quite difficult when
using an environment variable, but work easily when specifying the
builtins available on the store connection.

Ludovic Courtès wrote 6 months ago

Recipients:(name . Christopher Baines)(address . mail@cbaines.net)(address . 67250-done@debbugs.gnu.org)

Message-ID:874j6sy058.fsf@gnu.org

Christopher Baines <mail@cbaines.net> skribis:

Toggle quote (2 lines)

> I've now sent some patches which add this option to #71038.

These were committed as f002371767df04238e3fc6dfacb6930f5529144b.

Closing,

Ludo’.

Closed

Your comment

This issue is archived.

To comment on this conversation send an email to 67250@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 67250

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags

mumi command -t +confirmed -t +easy

Or, remove the moreinfo tag and set the help tag

mumi command -t -moreinfo -t +help

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date