Request for merging "mesa-updates" branch

  • Done
  • quality assurance status badge
Details
5 participants
  • Efraim Flashner
  • dan
  • John Kehayias
  • Kaelyn
  • Christopher Baines
Owner
unassigned
Submitted by
John Kehayias
Severity
normal
J
J
John Kehayias wrote on 6 Nov 2023 05:45
(name . guix-patches@gnu.org)(address . guix-patches@gnu.org)
87a5rr32x8.fsf@protonmail.com
Hello,

This is to start the process for merging the "mesa-updates" branch. A set of commits was just pushed there and the CI already has a build job for this branch. It is only 12 commits currently, but will be a lot of builds due mostly to the ungrafting of libx11 (and certain package updates beyond mesa itself, like pixman, libdrm, etc.). So, mostly waiting for things to build and hoping no major breakages. The ungrafts and version updates shouldn't be huge changes but you never know.

Please feel free to report any issues here and I'll update as well as things go.

Thanks!
John
D
(address . 66964@debbugs.gnu.org)
875y2b6nvs.fsf@dan.games
Hi John,

I noticed one of my commit #65153 is on the mesa-update branch, it
would be helpful if you could take a look at #65155, an update
trying to export XDG_DATA_DIRS for mesa. Since no one replied
there, I'm not sure if this change is appropriate and if it fits
in this update.

--
dan
K
K
Kaelyn wrote on 12 Nov 2023 21:01
Re: mesa-updates: call for patches
(name . John Kehayias)(address . john.kehayias@protonmail.com)
m-1_kiiKXWXP4nJVxxUfx4CaLLLo-pNr7J3C4dKk0erStH8DfkrwqyQ3s1ou2ibM1cul7813G5q5znMvotRhWsVHSgkTVJqrSRO3jSgyM5w=@protonmail.com
Hi,

I've just submitted a pair of patches for the mesa-updates branch: https://issues.guix.gnu.org/67136 updating xorgproto and xorg-server-xwayland. The xorgproto is a high-impact update (guix refresh reports rebuilding 8710 packages would ensure 22871 dependent packages are rebuilt), but required to update to the latest xwayland as xwayland requires a newer version of presentproto than in the current guix xorgproto package. The updating and ungrafting of mesa and a number of X.org related libraries seemed like a good time (and place) to update xorgproto as well.

Cheers,
Kaelyn
J
J
John Kehayias wrote on 14 Nov 2023 21:05
Re: bug#66964: Request for merging "mesa-updates" branch
(name . dan)(address . i@dan.games)(address . 66964@debbugs.gnu.org)
8734x8umli.fsf_-_@protonmail.com
Hi dan,

On Thu, Nov 09, 2023 at 09:43 PM, dan wrote:

Toggle quote (7 lines)
> Hi John,
>
> I noticed one of my commit #65153 is on the mesa-update branch, it
> would be helpful if you could take a look at #65155, an update trying
> to export XDG_DATA_DIRS for mesa. Since no one replied there, I'm not
> sure if this change is appropriate and if it fits in this update.

Apologies I did not see this message as I think you only sent it to the
bug number (which does not get sent to anyone else as far as I know). I
had meant to respond to #65155 but I think I forgot. I did have a note
on the thread on guix-devel about this briefly:

Toggle quote (4 lines)
> I don't think this is a correct change as written (search-path should
> be in vulkan-loader if I'm understanding what is supposed to happen
> here). Anyway, will follow up on that issue and left it out for now.

I'll follow up on that bug number directly to discuss.

Sorry for the miscommunication!

John
J
J
John Kehayias wrote on 14 Nov 2023 21:11
(name . Kaelyn)(address . kaelyn.alexi@protonmail.com)
87y1f0t7s9.fsf_-_@protonmail.com
Hi Kaelyn,

On Sun, Nov 12, 2023 at 08:01 PM, Kaelyn wrote:

Toggle quote (15 lines)
> Hi,
>
> I've just submitted a pair of patches for the mesa-updates branch:
> <https://issues.guix.gnu.org/67136> updating xorgproto and
> xorg-server-xwayland. The xorgproto is a high-impact update (guix
> refresh reports rebuilding 8710 packages would ensure 22871 dependent
> packages are rebuilt), but required to update to the latest xwayland
> as xwayland requires a newer version of presentproto than in the
> current guix xorgproto package. The updating and ungrafting of mesa
> and a number of X.org related libraries seemed like a good time (and
> place) to update xorgproto as well.
>
> Cheers,
> Kaelyn

Thanks for the patches. I think mesa-updates in this current iteration
is set on builds (ended up being a lot more due to the ungrafting but
seems done on our main architectures for several days now). I had to
make some other changes to fix some larger breakages but at this point I
think it will just be taking us back in the build queue too much.

So I think it would make more sense on the next big rebuild, either
core-updates (talk about doing that with more ungrafts right now) or
I'll do mesa-updates again when the next release of mesa hits. Or maybe
it makes sense to just do another branch for xwayland?

Open to ideas! I'll send a separate message soon on the status of
mesa-updates and see what people think, but my thought was to merge this
to master in the next day or so if there are no objections.

Thanks!
John
K
K
Kaelyn wrote on 14 Nov 2023 21:36
(name . John Kehayias)(address . john.kehayias@protonmail.com)
7k1WKdjeNkQdy2Sn-n5KIRtaueKF5rV_eePjWm6w9cp5wSdgaTiv-siJxwNeX12FUywY_ezumz-LeYDMKR_bBbdFn2YrD-e3-IvyvneN15E=@protonmail.com
Hi John,

On Tuesday, November 14th, 2023 at 12:11 PM, John Kehayias <john.kehayias@protonmail.com> wrote:

Toggle quote (39 lines)
>
> Hi Kaelyn,
>
> On Sun, Nov 12, 2023 at 08:01 PM, Kaelyn wrote:
>
> > Hi,
> >
> > I've just submitted a pair of patches for the mesa-updates branch:
> > https://issues.guix.gnu.org/67136 updating xorgproto and
> > xorg-server-xwayland. The xorgproto is a high-impact update (guix
> > refresh reports rebuilding 8710 packages would ensure 22871 dependent
> > packages are rebuilt), but required to update to the latest xwayland
> > as xwayland requires a newer version of presentproto than in the
> > current guix xorgproto package. The updating and ungrafting of mesa
> > and a number of X.org related libraries seemed like a good time (and
> > place) to update xorgproto as well.
> >
> > Cheers,
> > Kaelyn
>
>
> Thanks for the patches. I think mesa-updates in this current iteration
> is set on builds (ended up being a lot more due to the ungrafting but
> seems done on our main architectures for several days now). I had to
> make some other changes to fix some larger breakages but at this point I
> think it will just be taking us back in the build queue too much.
>
> So I think it would make more sense on the next big rebuild, either
> core-updates (talk about doing that with more ungrafts right now) or
> I'll do mesa-updates again when the next release of mesa hits. Or maybe
> it makes sense to just do another branch for xwayland?
>
> Open to ideas! I'll send a separate message soon on the status of
> mesa-updates and see what people think, but my thought was to merge this
> to master in the next day or so if there are no objections.
>
> Thanks!
> John

No worries! I realize I was a little late to the party for the mesa-updates branch (had some ongoing technical issues), so if core-updates is still early enough in the process I think it would be good to push the changes to that branch. The current xwayland is pretty old, and the updated version has quite a few CVEs fixed in comparison (just https://www.phoronix.com/news/X.Org-Halloween-Bugs-2023and https://www.phoronix.com/news/X.Org-Server-Holiday-2022 list 8 CVEs fixed between xwayland 21.1.3 and 23.2.2).

Cheers,
Kaelyn
J
J
John Kehayias wrote on 15 Nov 2023 06:39
Re: mesa-updates: call for patches
(address . guix-devel@gnu.org)
87v8a3tw0s.fsf@protonmail.com
Hi everyone,

Update below:

On Sun, Nov 05, 2023 at 11:47 PM, John Kehayias wrote:
[snippy snip snip]
Toggle quote (12 lines)
>>
>> Happy to! Substitutes will eventually become available, but there's
>> quite a few builds to be done. This takes care of some ungrafts and
>> updates with I hope minimal disruption. I'll be keeping an eye out and
>> using locally as well. Please test and report, thanks everyone!
>>
>> John
>
> An issue was created to track merging the mesa-updates branch here:
> <https://issues.guix.gnu.org/66964>. Please use that bug number as
> needed (and cc me or use wide-reply in emacs debbugs).

At this point I feel we are just about ready to go, unless there are
objections?

Substitute coverage, according to
i686 (about 95% and 83%, respectively) while, as usual, other
architectures are behind. The next best is aarch64 at 54% on bordeaux,
and then falling to 24% for armhf, with others we build in the teens.
I think this is to be expected? In any event builds continue very
slowly and in the past I think this is about where we merge.

I should note: please check for any breakages. I didn't expect too
much, but did get more than I thought. It seems the ungrafting version
changes caused some things to fail. Also, the libx11 ungraft mean
python and rust were rebuilt, with the many packages that entails.

I fixed big ones I saw, like QT (unrelated: it was libxkbcommon
upgrade), but other leaf packages I saw had tests failing for reasons
I didn't see. For instance, php fails tests. The current ones are due
to the curl update, but updating php and removing an obsolete patch
had a different test fail. It would be great if someone more familiar
will take a look. With few dependents I figure this can just be done
on master after the merge.

So, shall I merge this to master in the next couple of days? I've been
merging master into mesa-updates smoothly so far. Please do check and
feel free to object if this needs more time.

Thanks everyone,
John


PS: I forgot to email the various patches/issues that are done on
mesa-updates, as listed in a previous message. I will do that too.
E
E
Efraim Flashner wrote on 15 Nov 2023 07:28
Re: bug#66964: Request for merging "mesa-updates" branch
(name . John Kehayias)(address . john.kehayias@protonmail.com)
ZVRlKCMfEJNxwkiZ@3900XT
On Tue, Nov 14, 2023 at 08:11:08PM +0000, John Kehayias wrote:
Toggle quote (34 lines)
> Hi Kaelyn,
>
> On Sun, Nov 12, 2023 at 08:01 PM, Kaelyn wrote:
>
> > Hi,
> >
> > I've just submitted a pair of patches for the mesa-updates branch:
> > <https://issues.guix.gnu.org/67136> updating xorgproto and
> > xorg-server-xwayland. The xorgproto is a high-impact update (guix
> > refresh reports rebuilding 8710 packages would ensure 22871 dependent
> > packages are rebuilt), but required to update to the latest xwayland
> > as xwayland requires a newer version of presentproto than in the
> > current guix xorgproto package. The updating and ungrafting of mesa
> > and a number of X.org related libraries seemed like a good time (and
> > place) to update xorgproto as well.
> >
> > Cheers,
> > Kaelyn
>
> Thanks for the patches. I think mesa-updates in this current iteration
> is set on builds (ended up being a lot more due to the ungrafting but
> seems done on our main architectures for several days now). I had to
> make some other changes to fix some larger breakages but at this point I
> think it will just be taking us back in the build queue too much.
>
> So I think it would make more sense on the next big rebuild, either
> core-updates (talk about doing that with more ungrafts right now) or
> I'll do mesa-updates again when the next release of mesa hits. Or maybe
> it makes sense to just do another branch for xwayland?
>
> Open to ideas! I'll send a separate message soon on the status of
> mesa-updates and see what people think, but my thought was to merge this
> to master in the next day or so if there are no objections.

If the mesa branch is ready to merge so soon then I think we should just
get that merged and then I'll rebase the rust-team branch on top of new
master. The rust-team branch is also ready to merge, but we're way
behind on aarch64 substitutes. Either way the substitute servers will
be rebuilding all of rust so I think it'd be better to merge in
mesa-updates and then do rust.

--
Efraim Flashner <efraim@flashner.co.il> ????? ?????
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmVUZSgACgkQQarn3Mo9
g1FwDhAAvMsauLw0ubrocKOpbzZzzNlR4TGC6qiOmjc7CXyKuwQhmX9D4LTL6h0c
8Yq7fvxrrYdWejSCfSwSqkaq3C5UqbedsMP81eM8O3Pft2Y9mQUO9vnDRqp+/mRy
9iBqJxWaDz502e4Sif6IIz2qD53Eq3D8PGCDkB68t6L3QwmDVRDghVjO3hsMUt+x
r6Z3NGqpWKaTgJ03c57dZMdN1lgAmUhPINfbVVePByUh4/zo6ymFRYi9xhej8wXt
v7hsEGGmiJD5WZulC7Q0GTTK5Wy3qveNFoce+0JA/p7rKa3HCFyXlGXka0drUtfD
BO0o8RmScD5vHQwFT1tx4FHB7HHh/GbrH1YVHghQ6iCLQp5cr8PdsQ1K1QUrcfx7
4VMU+xxD4QPDsy7fpTI9aXQRSQ5DcOPXmv2tukBJiBTvCxNyl/FXjScNNWc2751U
+JxYb5tkSq/9nzr/0a63LDyIrgDOrOMspZ1VNJwq/BC3meL0iMOcy6H11H8bCyDH
G4rNiQzYVYgEkzWB10Jfv9NJP7+MtEchIDqeU8XitCKJ7Uhs7k4TJd+QTcLr1r5z
EiDgqdmKMfJbo2lX1fGcaWr1zAEglcoFA4QaYTA2TApzug9xpkdG7kAtQNZ7qc6z
HqbfgXEMVOyT43sKHGPGHxK+7vD4nA9ny+FSQ0sr2p1kxUGl05o=
=HIRp
-----END PGP SIGNATURE-----


C
C
Christopher Baines wrote on 18 Nov 2023 12:07
Re: mesa-updates: call for patches
(name . John Kehayias)(address . john.kehayias@protonmail.com)
87leavfglk.fsf@cbaines.net
John Kehayias <john.kehayias@protonmail.com> writes:

Toggle quote (29 lines)
> Hi everyone,
>
> Update below:
>
> On Sun, Nov 05, 2023 at 11:47 PM, John Kehayias wrote:
> [snippy snip snip]
>>>
>>> Happy to! Substitutes will eventually become available, but there's
>>> quite a few builds to be done. This takes care of some ungrafts and
>>> updates with I hope minimal disruption. I'll be keeping an eye out and
>>> using locally as well. Please test and report, thanks everyone!
>>>
>>> John
>>
>> An issue was created to track merging the mesa-updates branch here:
>> <https://issues.guix.gnu.org/66964>. Please use that bug number as
>> needed (and cc me or use wide-reply in emacs debbugs).
>
> At this point I feel we are just about ready to go, unless there are
> objections?
>
> Substitute coverage, according to
> <https://qa.guix.gnu.org/branch/mesa-updates> is good on x86_64 and
> i686 (about 95% and 83%, respectively) while, as usual, other
> architectures are behind. The next best is aarch64 at 54% on bordeaux,
> and then falling to 24% for armhf, with others we build in the teens.
> I think this is to be expected? In any event builds continue very
> slowly and in the past I think this is about where we merge.

I think some changes have been pushed since this email, since the
aarch64 substitute availability has dropped from 54% to 25%.

Toggle quote (4 lines)
> So, shall I merge this to master in the next couple of days? I've been
> merging master into mesa-updates smoothly so far. Please do check and
> feel free to object if this needs more time.

I guess this has been held up by the changes on the 15th, but still, I
think we need to wait for substitute availability to improve more prior
to merging, unless there's a specific and significant reason why we
don't want to wait.

Targets are arbitrary, but guix weather defines ? as 80%+, so I think
that's what we should aim for at least for x86_64-linux, i686-linux,
aarch64-linux and armhf-linux. This isn't just about substitute
availability though as this is key for discovering what things fail to
build.

Obviously delays in merging aren't ideal, but we should tackle the
problems around this, maybe by deciding that testing and providing
substitutes for ARM isn't a priority and thus isn't something we should
wait for, or look at getting more ARM hardware to speed up the process
(we also have a lack of x86_64 hardware on the bordeaux build farm).
-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmVYnzdfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9Xcz5A/9Ey4YiLv3pk1jl0cuxZG1ebPVCTHesyyP
9Zc98+2ToTm3TAT00OfI4yEe5NDhUYNcOrEa0L8rRBre8+pkxQREoC+d3jTXNYbp
o8OWUUBZ+LrE/o6eD21xQRezNaJvMDcad2tu0SbYTIjX4AT76mg/zHBXuVylF2jD
uw1YAEPen3ND6r2B9aGpnMlZAPJ+gA7e2E7JzqGhYq9Fgdeyn3QVorngjvXfSkKG
Fvb1ssjWIyzsi3yLl19nWJSghs7Q3NiJ42X3iaJcjSUSTdvpOvTcCRbvnvTIltFE
o/0C8hb1qC/VBWrpN/Hq7UXPsdE7wRGr3Oo5rz+1tCplZeXjeteZm4poQnBXw/Bd
Yaj7pAG6fdAMPkkzHnQVY9azMDXE5ZfWeGmkoz7V3ozJCTj7gEvhMxyxO8jhWXDs
MoJNfiXMZ2TszxiKtkvPdQivcecWPZGJK7tdkAGKg7gc1BUk+mg/D7WJXNbs25oD
bFnrk/QnUTpYdPsrGhzkuZiHIGvYpidn2/awBBeEUfuv0Qe1Gsm6h24bmnEa9WkV
dMkinQUSfIDdJPEazh8g5Nk7uzB/irin2TfM1bf6XgJ8nvVwybH5ex/B5ZMQWpZd
f+9tE/AueU9/MOOsFbbGnBnTUCh4T4p2/Mqv/x/jYJ6EQ5GBxubnV2zIGt7ge6x6
4srt9R20N1A=
=G/Ul
-----END PGP SIGNATURE-----

J
J
John Kehayias wrote on 20 Nov 2023 06:41
(name . Christopher Baines)(address . mail@cbaines.net)
8734x1t213.fsf@protonmail.com
Hi,

On Sat, Nov 18, 2023 at 11:07 AM, Christopher Baines wrote:

Toggle quote (25 lines)
>
> John Kehayias <john.kehayias@protonmail.com> writes:
>
>> Hi everyone,
>>
>> Update below:
>>
>> On Sun, Nov 05, 2023 at 11:47 PM, John Kehayias wrote:
>> [snippy snip snip]
>>
>> At this point I feel we are just about ready to go, unless there are
>> objections?
>>
>> Substitute coverage, according to
>> <https://qa.guix.gnu.org/branch/mesa-updates> is good on x86_64 and
>> i686 (about 95% and 83%, respectively) while, as usual, other
>> architectures are behind. The next best is aarch64 at 54% on bordeaux,
>> and then falling to 24% for armhf, with others we build in the teens.
>> I think this is to be expected? In any event builds continue very
>> slowly and in the past I think this is about where we merge.
>
> I think some changes have been pushed since this email, since the
> aarch64 substitute availability has dropped from 54% to 25%.
>

Yes, Efraim chimed in to help on some other architectures and some big
rebuilds were/are happening for those. I see them slowly ticking up
but it will still need some time.

Toggle quote (10 lines)
>> So, shall I merge this to master in the next couple of days? I've been
>> merging master into mesa-updates smoothly so far. Please do check and
>> feel free to object if this needs more time.
>
> I guess this has been held up by the changes on the 15th, but still, I
> think we need to wait for substitute availability to improve more prior
> to merging, unless there's a specific and significant reason why we
> don't want to wait.
>

Yes, agreed. I'm not as clear on how well we do typically on non-x86
but getting a sense of it now, which is why I wanted to ask.

Toggle quote (7 lines)
> Targets are arbitrary, but guix weather defines ? as 80%+, so I think
> that's what we should aim for at least for x86_64-linux, i686-linux,
> aarch64-linux and armhf-linux. This isn't just about substitute
> availability though as this is key for discovering what things fail to
> build.
>

I think this is something we could better clarify and quantify as many
of us probably only pay attention to x86_64, where for others we can
be strapped for both hardware and people. So I didn't want to wait for
some substitutes that would never come but also don't want to
inconvenience people on other architectures, especially if builds
there take much much longer in the first place.

Perhaps we can look at some historical data on what we've hit in
substitute coverage and try to at least keep up with that if not set
some goals for better coverage? While we might also expect further
difficulties as some get left behind by upstream (as we've had to work
around rust on i686 so far, I believe).

All that is to say, yes, let's make sure we have good substitute
coverage and are clear on what architectures we want to make sure
users get substitutes for.

Toggle quote (7 lines)
> Obviously delays in merging aren't ideal, but we should tackle the
> problems around this, maybe by deciding that testing and providing
> substitutes for ARM isn't a priority and thus isn't something we should
> wait for, or look at getting more ARM hardware to speed up the process
> (we also have a lack of x86_64 hardware on the bordeaux build farm).
>

Agreed. We should have some clear Guix-wide standards and goals. I'm
sure we can get some hardware from Guix-ers and/or funding too,
especially if people know exactly what it will go towards improving.

Thanks for chiming in here and all your work on this front!

In the meantime, I'll go back to refreshing the CI and QA pages every
so often to make sure we keep getting closer...
J
J
John Kehayias wrote on 28 Nov 2023 06:29
Re: bug#66964: Request for merging "mesa-updates" branch
871qcaa1jc.fsf@protonmail.com
Guix-ers,

On Wed, Nov 15, 2023 at 08:28 AM, Efraim Flashner wrote:

Toggle quote (42 lines)
> On Tue, Nov 14, 2023 at 08:11:08PM +0000, John Kehayias wrote:
>> Hi Kaelyn,
>>
>> On Sun, Nov 12, 2023 at 08:01 PM, Kaelyn wrote:
>>
>> > Hi,
>> >
>> > I've just submitted a pair of patches for the mesa-updates branch:
>> > <https://issues.guix.gnu.org/67136> updating xorgproto and
>> > xorg-server-xwayland. The xorgproto is a high-impact update (guix
>> > refresh reports rebuilding 8710 packages would ensure 22871 dependent
>> > packages are rebuilt), but required to update to the latest xwayland
>> > as xwayland requires a newer version of presentproto than in the
>> > current guix xorgproto package. The updating and ungrafting of mesa
>> > and a number of X.org related libraries seemed like a good time (and
>> > place) to update xorgproto as well.
>> >
>> > Cheers,
>> > Kaelyn
>>
>> Thanks for the patches. I think mesa-updates in this current iteration
>> is set on builds (ended up being a lot more due to the ungrafting but
>> seems done on our main architectures for several days now). I had to
>> make some other changes to fix some larger breakages but at this point I
>> think it will just be taking us back in the build queue too much.
>>
>> So I think it would make more sense on the next big rebuild, either
>> core-updates (talk about doing that with more ungrafts right now) or
>> I'll do mesa-updates again when the next release of mesa hits. Or maybe
>> it makes sense to just do another branch for xwayland?
>>
>> Open to ideas! I'll send a separate message soon on the status of
>> mesa-updates and see what people think, but my thought was to merge this
>> to master in the next day or so if there are no objections.
>
> If the mesa branch is ready to merge so soon then I think we should just
> get that merged and then I'll rebase the rust-team branch on top of new
> master. The rust-team branch is also ready to merge, but we're way
> behind on aarch64 substitutes. Either way the substitute servers will
> be rebuilding all of rust so I think it'd be better to merge in
> mesa-updates and then do rust.

Merged as 79765b40fd9b4921b531284c589ace8a2c89a6ea woop!

We got good coverage on x86_64, i686, powerpc64le, aarch64 (all
-linux) especially from Bordeaux. Unfortunately armhf got stuck even
with prodding and waiting, but hopefully it will recover. There may be
some slight catching up across the board with recent issues on Berlin,
but prior to things getting wonky it was looking good (of course all
that happened right when I wanted to merge the other day).

Thanks to Efraim for some fixes and especially getting non-x86 in
better shape.

Feel free anyone to ping me on patches/bugs due to this merge. And
please enjoy updated mesa, fixes to gtk4 applications, some less
grafts, and more.

John

PS: I'll return to mesa-updates soon with next major mesa update and
pending related patches, or in core-updates if that is getting close.
Closed
K
K
Kaelyn wrote on 9 Dec 2023 20:28
(name . Kaelyn)(address . kaelyn.alexi@protonmail.com)
BHpzRQHJypx3wH0EYnyZTz4bhzimiXCUrKYiusTC8NG_aIUCg24L9CchkJgWusBFVwE1h83k6lpqSEMVJdXW_NqyMxxB1yP6SLcIZLpPsA8=@protonmail.com
Hi,

On Tuesday, November 14th, 2023 at 12:36 PM, Kaelyn <kaelyn.alexi@protonmail.com> wrote:

Toggle quote (45 lines)
>
> Hi John,
>
> On Tuesday, November 14th, 2023 at 12:11 PM, John Kehayias john.kehayias@protonmail.com wrote:
>
> > Hi Kaelyn,
> >
> > On Sun, Nov 12, 2023 at 08:01 PM, Kaelyn wrote:
> >
> > > Hi,
> > >
> > > I've just submitted a pair of patches for the mesa-updates branch:
> > > https://issues.guix.gnu.org/67136 updating xorgproto and
> > > xorg-server-xwayland. The xorgproto is a high-impact update (guix
> > > refresh reports rebuilding 8710 packages would ensure 22871 dependent
> > > packages are rebuilt), but required to update to the latest xwayland
> > > as xwayland requires a newer version of presentproto than in the
> > > current guix xorgproto package. The updating and ungrafting of mesa
> > > and a number of X.org related libraries seemed like a good time (and
> > > place) to update xorgproto as well.
> > >
> > > Cheers,
> > > Kaelyn
> >
> > Thanks for the patches. I think mesa-updates in this current iteration
> > is set on builds (ended up being a lot more due to the ungrafting but
> > seems done on our main architectures for several days now). I had to
> > make some other changes to fix some larger breakages but at this point I
> > think it will just be taking us back in the build queue too much.
> >
> > So I think it would make more sense on the next big rebuild, either
> > core-updates (talk about doing that with more ungrafts right now) or
> > I'll do mesa-updates again when the next release of mesa hits. Or maybe
> > it makes sense to just do another branch for xwayland?
> >
> > Open to ideas! I'll send a separate message soon on the status of
> > mesa-updates and see what people think, but my thought was to merge this
> > to master in the next day or so if there are no objections.
> >
> > Thanks!
> > John
>
>
> No worries! I realize I was a little late to the party for the mesa-updates branch (had some ongoing technical issues), so if core-updates is still early enough in the process I think it would be good to push the changes to that branch. The current xwayland is pretty old, and the updated version has quite a few CVEs fixed in comparison (just https://www.phoronix.com/news/X.Org-Halloween-Bugs-2023 and https://www.phoronix.com/news/X.Org-Server-Holiday-2022 list 8 CVEs fixed between xwayland 21.1.3 and 23.2.2).

I forgot to sent an email when I did this, but a few weeks ago I updated the xorgproto/xwayland update ticket (#66964) to refer to core-updates instead of mesa-updates and sent in a v2 of the patches rebased against core-updates.

Cheers,
Kaelyn
?
Your comment

This issue is archived.

To comment on this conversation send an email to 66964@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 66964
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch