[PATCH] gnu: lvm2: Remove systemd rule.

  • Open
  • quality assurance status badge
Details
5 participants
  • Josselin Poiret
  • Ludovic Courtès
  • Adrien 'neox' Bourmault
  • Yann Dupont
  • Simon Tournier
Owner
unassigned
Submitted by
Simon Tournier
Severity
normal
S
S
Simon Tournier wrote on 17 Oct 2023 10:57
(address . guix-patches@gnu.org)(name . Yann Dupont)(address . Yann.Dupont@univ-nantes.fr)
716e42d582706ad11107e1b48bdd252966bd4133.1697532777.git.zimon.toutoune@gmail.com
From: Yann Dupont <Yann.Dupont@univ-nantes.fr>

Reported by Adrien 'neox' Bourmault <neox@gnu.org>.

* gnu/packages/patches/lvm2-no-systemd.patch: New file.
* gnu/packages/linux.scm (lvm2)[source]: Apply patch.
* gnu/local.mk: Register new patch.
---
gnu/local.mk | 1 +
gnu/packages/linux.scm | 1 +
gnu/packages/patches/lvm2-no-systemd.patch | 22 ++++++++++++++++++++++
3 files changed, 24 insertions(+)
create mode 100644 gnu/packages/patches/lvm2-no-systemd.patch

Hi,

Here is the patch from Yann sent in patch 65177 [1]. I have just reformatted
it and preprare it for merging if it is correct. I know nothing about udev.


Cheers,
simon


Toggle diff (56 lines)
diff --git a/gnu/local.mk b/gnu/local.mk
index daacd786a7..3d74c3e228 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1625,6 +1625,7 @@ dist_patch_DATA = \
%D%/packages/patches/mcrypt-CVE-2012-4527.patch \
%D%/packages/patches/libmemcached-build-with-gcc7.patch \
%D%/packages/patches/libmhash-hmac-fix-uaf.patch \
+ %D%/packages/patches/lvm2-no-systemd.patch \
%D%/packages/patches/maturin-no-cross-compile.patch \
%D%/packages/patches/mecab-variable-param.patch \
%D%/packages/patches/memtest86+-build-reproducibly.patch \
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 6bb6d62182..6882244e92 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -4527,6 +4527,7 @@ (define-public lvm2
(sha256
(base32
"0z6w6bknhwh1n3qfkb5ij6x57q3wjf28lq3l8kh7rkhsplinjnjc"))
+ (patches (search-patches "lvm2-no-systemd.patch"))
(modules '((guix build utils)))
(snippet
'(begin
diff --git a/gnu/packages/patches/lvm2-no-systemd.patch b/gnu/packages/patches/lvm2-no-systemd.patch
new file mode 100644
index 0000000000..46b4dcffbb
--- /dev/null
+++ b/gnu/packages/patches/lvm2-no-systemd.patch
@@ -0,0 +1,22 @@
+Fixes <https://issues.guix.gnu.org/65177>.
+
+Since lvm2 2.03.14, the included udev rules use systemd-run to run vgchange
+and activate the volume group. lvm2 was updated recently from 2.03.11 to
+2.03.21, then 2.03.22, and probably started exhibiting this behavior then. It
+removes the indirection through systemd-run and directly run vgchange.
+
+diff --git a/udev/69-dm-lvm.rules.in b/udev/69-dm-lvm.rules.in
+index ff15681..f9e5b70 100644
+--- a/udev/69-dm-lvm.rules.in
++++ b/udev/69-dm-lvm.rules.in
+@@ -75,8 +75,8 @@ LABEL="lvm_scan"
+ # TODO: adjust the output of vgchange -aay so that
+ # it's better suited to appearing in the journal.
+
+-IMPORT{program}="(LVM_EXEC)/lvm pvscan --cache --listvg --checkcomplete --vgonline --autoactivation event --udevoutput --journal=output $env{DEVNAME}"
+-ENV{LVM_VG_NAME_COMPLETE}=="?*", RUN+="(SYSTEMDRUN) --no-block --property DefaultDependencies=no --unit lvm-activate-$env{LVM_VG_NAME_COMPLETE} (LVM_EXEC)/lvm vgchange -aay --autoactivation event $env{LVM_VG_NAME_COMPLETE}"
++IMPORT{program}="(LVM_EXEC)/lvm pvscan --cache --listvg
++ENV{LVM_VG_NAME_COMPLETE}=="?*", RUN+="(SYSTEMDRUN) --no-block lvm-activate-$env{LVM_VG_NAME_COMPLETE} (LVM_EXEC)/lvm vgchange -aay
+ GOTO="lvm_end"
+
+ LABEL="lvm_end"

base-commit: b437896e87a51cc610388d4c462893652dd773e6
--
2.38.1
L
L
Ludovic Courtès wrote on 23 Oct 2023 23:52
(name . Simon Tournier)(address . zimon.toutoune@gmail.com)
87bkcpdn22.fsf@gnu.org
Hi!

Simon Tournier <zimon.toutoune@gmail.com> skribis:

Toggle quote (9 lines)
> From: Yann Dupont <Yann.Dupont@univ-nantes.fr>
>
> Fixes <https://issues.guix.gnu.org/65177>.
> Reported by Adrien 'neox' Bourmault <neox@gnu.org>.
>
> * gnu/packages/patches/lvm2-no-systemd.patch: New file.
> * gnu/packages/linux.scm (lvm2)[source]: Apply patch.
> * gnu/local.mk: Register new patch.

One minor nit:

Toggle quote (9 lines)
> +++ b/gnu/packages/patches/lvm2-no-systemd.patch
> @@ -0,0 +1,22 @@
> +Fixes <https://issues.guix.gnu.org/65177>.
> +
> +Since lvm2 2.03.14, the included udev rules use systemd-run to run vgchange
> +and activate the volume group. lvm2 was updated recently from 2.03.11 to
> +2.03.21, then 2.03.22, and probably started exhibiting this behavior then. It
> +removes the indirection through systemd-run and directly run vgchange.

I propose to change this paragraph so that it is self-contained, like:

Run ‘vgchange’ directly instead of attempting to run it via
‘systemd-run’ as the udev rules included in lvm2 >= 2.03.14 do.

LGTM with a change along these lines!

Ludo’.
S
S
Simon Tournier wrote on 24 Oct 2023 18:47
[PATCH v2] gnu: lvm2: Remove systemd rule.
(address . 66586@debbugs.gnu.org)(name . Yann Dupont)(address . Yann.Dupont@univ-nantes.fr)
9102296a5c1faade8528ec115eee7ebb17ce9a5f.1698165907.git.zimon.toutoune@gmail.com
From: Yann Dupont <Yann.Dupont@univ-nantes.fr>

Reported by Adrien 'neox' Bourmault <neox@gnu.org>.

* gnu/packages/patches/lvm2-no-systemd.patch: New file.
* gnu/packages/linux.scm (lvm2)[source]: Apply patch.
* gnu/local.mk: Register new patch.
---
gnu/local.mk | 1 +
gnu/packages/linux.scm | 1 +
gnu/packages/patches/lvm2-no-systemd.patch | 20 ++++++++++++++++++++
3 files changed, 22 insertions(+)
create mode 100644 gnu/packages/patches/lvm2-no-systemd.patch

Toggle diff (54 lines)
diff --git a/gnu/local.mk b/gnu/local.mk
index 43145caf80..4c8800b274 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1627,6 +1627,7 @@ dist_patch_DATA = \
%D%/packages/patches/mcrypt-CVE-2012-4527.patch \
%D%/packages/patches/libmemcached-build-with-gcc7.patch \
%D%/packages/patches/libmhash-hmac-fix-uaf.patch \
+ %D%/packages/patches/lvm2-no-systemd.patch \
%D%/packages/patches/maturin-no-cross-compile.patch \
%D%/packages/patches/mecab-variable-param.patch \
%D%/packages/patches/memtest86+-build-reproducibly.patch \
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index f02577d2d5..c618651553 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -4494,6 +4494,7 @@ (define-public lvm2
(sha256
(base32
"0z6w6bknhwh1n3qfkb5ij6x57q3wjf28lq3l8kh7rkhsplinjnjc"))
+ (patches (search-patches "lvm2-no-systemd.patch"))
(modules '((guix build utils)))
(snippet
'(begin
diff --git a/gnu/packages/patches/lvm2-no-systemd.patch b/gnu/packages/patches/lvm2-no-systemd.patch
new file mode 100644
index 0000000000..440559b96d
--- /dev/null
+++ b/gnu/packages/patches/lvm2-no-systemd.patch
@@ -0,0 +1,20 @@
+Fixes <https://issues.guix.gnu.org/65177>.
+
+Run 'vgchange' directly instead of attempting to run it via 'systemd-run' as
+the udev rules included in lvm2 >= 2.03.14 do.
+
+diff --git a/udev/69-dm-lvm.rules.in b/udev/69-dm-lvm.rules.in
+index ff15681..f9e5b70 100644
+--- a/udev/69-dm-lvm.rules.in
++++ b/udev/69-dm-lvm.rules.in
+@@ -75,8 +75,8 @@ LABEL="lvm_scan"
+ # TODO: adjust the output of vgchange -aay so that
+ # it's better suited to appearing in the journal.
+
+-IMPORT{program}="(LVM_EXEC)/lvm pvscan --cache --listvg --checkcomplete --vgonline --autoactivation event --udevoutput --journal=output $env{DEVNAME}"
+-ENV{LVM_VG_NAME_COMPLETE}=="?*", RUN+="(SYSTEMDRUN) --no-block --property DefaultDependencies=no --unit lvm-activate-$env{LVM_VG_NAME_COMPLETE} (LVM_EXEC)/lvm vgchange -aay --autoactivation event $env{LVM_VG_NAME_COMPLETE}"
++IMPORT{program}="(LVM_EXEC)/lvm pvscan --cache --listvg
++ENV{LVM_VG_NAME_COMPLETE}=="?*", RUN+="(SYSTEMDRUN) --no-block lvm-activate-$env{LVM_VG_NAME_COMPLETE} (LVM_EXEC)/lvm vgchange -aay
+ GOTO="lvm_end"
+
+ LABEL="lvm_end"

base-commit: f3714b3d5f51aced4b31447c42d5e89c75e3079f
--
2.38.1
S
S
Simon Tournier wrote on 24 Oct 2023 18:48
Re: [bug#66586] [PATCH] gnu: lvm2: Remove systemd rule.
(name . Ludovic Courtès)(address . ludo@gnu.org)
87jzrchsqd.fsf@gmail.com
Hi Ludo,

On Mon, 23 Oct 2023 at 23:52, Ludovic Courtès <ludo@gnu.org> wrote:

Toggle quote (5 lines)
> I propose to change this paragraph so that it is self-contained, like:
>
> Run ‘vgchange’ directly instead of attempting to run it via
> ‘systemd-run’ as the udev rules included in lvm2 >= 2.03.14 do.

I copy/pasted these lines in v2.

Cheers,
simon
L
L
Ludovic Courtès wrote on 30 Oct 2023 00:22
Re: [bug#66586] [PATCH v2] gnu: lvm2: Remove systemd rule.
(name . Simon Tournier)(address . zimon.toutoune@gmail.com)
87bkch6ml8.fsf@gnu.org
Simon Tournier <zimon.toutoune@gmail.com> skribis:

Toggle quote (9 lines)
> From: Yann Dupont <Yann.Dupont@univ-nantes.fr>
>
> Fixes <https://issues.guix.gnu.org/65177>.
> Reported by Adrien 'neox' Bourmault <neox@gnu.org>.
>
> * gnu/packages/patches/lvm2-no-systemd.patch: New file.
> * gnu/packages/linux.scm (lvm2)[source]: Apply patch.
> * gnu/local.mk: Register new patch.

LGTM, thanks!
S
S
Simon Tournier wrote on 31 Oct 2023 09:58
(name . Ludovic Courtès)(address . ludo@gnu.org)
87wmv3yxqw.fsf@gmail.com
Hi,

On lun., 30 oct. 2023 at 00:22, Ludovic Courtès <ludo@gnu.org> wrote:
Toggle quote (13 lines)
> Simon Tournier <zimon.toutoune@gmail.com> skribis:
>
>> From: Yann Dupont <Yann.Dupont@univ-nantes.fr>
>>
>> Fixes <https://issues.guix.gnu.org/65177>.
>> Reported by Adrien 'neox' Bourmault <neox@gnu.org>.
>>
>> * gnu/packages/patches/lvm2-no-systemd.patch: New file.
>> * gnu/packages/linux.scm (lvm2)[source]: Apply patch.
>> * gnu/local.mk: Register new patch.
>
> LGTM, thanks!

Pushed as c0895371c5759c7d9edb330774e90f192cc4cf2c.

Cheers,
simon
Closed
J
J
Josselin Poiret wrote on 31 Oct 2023 21:07
Re: bug#66586: [PATCH v2] gnu: lvm2: Remove systemd rule.
87ttq6pnca.fsf@jpoiret.xyz
Hi everyone,

The given .patch file is malformed: there are no closing double quotes
for each of the strings. Additionally, I don't believe that the
reference to systemd has been truly removed with this, as it's
referenced in the second line of the patch.

I get errors immediately in my dmesg when booting with this patch. Has
this been tested? I believe this will affect users relying on LVM
volumes.

Best,
--
Josselin Poiret
-----BEGIN PGP SIGNATURE-----

iQHEBAEBCgAuFiEEOSSM2EHGPMM23K8vUF5AuRYXGooFAmVBXpUQHGRldkBqcG9p
cmV0Lnh5egAKCRBQXkC5FhcaimzGC/9/LA6r8GzLydPwxGED9C6RpaH9uB3j63sg
L9Ws6vc+drOJELyzHlN3+lLecrR0YPhHsZHIpzxH4QvMu9R2M38a79OrWzt+8qvy
E0Z9uOzBmyAYaf63C8ZW5gNZV8SvP6UylyKqJKyvYYmiLNpUorw0D+SOEvgcTUS1
E/iR6RHx/vUyHCzmvkRAz5XI73LoOws7BVxwA470GdwXA9cU2uxBXEUjbJntccXN
pFETWOg0A6wKTT1+zNw5AfvCDszEbhuJtahVf+bKbm1NjAbz9/OcVgeyrxqHopMj
E9wv0AepOUjrSkZcTuKk+kr79DpDVsJk83zW7EQrGZUQ5HgsiRMt5eCEAfVoD6jm
jMx8rI+Yses8GMmPEfZoETxDyk6eb17NBeevAd72JsU0vLtrqkfBfDs1YCN6Y1LJ
yKwKu2zI6P6nN39v6hTW0aDDYgAEEFxmNpsoAnPvygPkBFcW/2iheXlMnm0dydZC
eE8cV+UYzM7CLXbmxqlz35psNzNe50s=
=gPr7
-----END PGP SIGNATURE-----

Closed
S
S
Simon Tournier wrote on 31 Oct 2023 22:28
Re: [bug#66586] [PATCH v2] gnu: lvm2: Remove systemd rule.
86zfzy5vn9.fsf@gmail.com
Hi,

On Tue, 31 Oct 2023 at 21:07, Josselin Poiret via Guix-patches via <guix-patches@gnu.org> wrote:

Toggle quote (2 lines)
> I get errors immediately in my dmesg when booting with this patch.

Reverted 3991d9e4d9867ec499283bfc71b34d7bfebe49b3. Oops, sorry for the
annoyance. I screwed up!

Could you propose a fix for https://issues.guix.gnu.org/65177?

Cheers,
simon
S
S
Simon Tournier wrote on 31 Oct 2023 22:11
control message for bug #66586
(address . control@debbugs.gnu.org)
86a5ry7b0e.fsf@gmail.com
reopen 66586
tags 66586 - fixed patch
quit
S
S
Simon Tournier wrote on 31 Oct 2023 23:11
[PATCH v3] gnu: lvm2: Remove systemd rule.
(address . 66586@debbugs.gnu.org)
bb0f31205d14de6a84a205c5cd466deefbf74e7a.1698790161.git.zimon.toutoune@gmail.com
Follow-up of 3991d9e4d9867ec499283bfc71b34d7bfebe49b3.

* gnu/packages/patches/lvm2-no-systemd.patch: New file.
* gnu/packages/linux.scm (lvm2)[source]: Apply patch.
* gnu/local.mk: Register new patch.

Change-Id: I916fb5f6ae786d22af69f0a7d81c0c28da3c96ea
---
gnu/local.mk | 1 +
gnu/packages/linux.scm | 1 +
gnu/packages/patches/lvm2-no-systemd.patch | 19 +++++++++++++++++++
3 files changed, 21 insertions(+)
create mode 100644 gnu/packages/patches/lvm2-no-systemd.patch

Toggle diff (53 lines)
diff --git a/gnu/local.mk b/gnu/local.mk
index 8d817379a7..27e57302ae 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1629,6 +1629,7 @@ dist_patch_DATA = \
%D%/packages/patches/mcrypt-CVE-2012-4527.patch \
%D%/packages/patches/libmemcached-build-with-gcc7.patch \
%D%/packages/patches/libmhash-hmac-fix-uaf.patch \
+ %D%/packages/patches/lvm2-no-systemd.patch \
%D%/packages/patches/maturin-no-cross-compile.patch \
%D%/packages/patches/mecab-variable-param.patch \
%D%/packages/patches/memtest86+-build-reproducibly.patch \
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 7a9f357681..6abdb23958 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -4494,6 +4494,7 @@ (define-public lvm2
(sha256
(base32
"0z6w6bknhwh1n3qfkb5ij6x57q3wjf28lq3l8kh7rkhsplinjnjc"))
+ (patches (search-patches "lvm2-no-systemd.patch"))
(modules '((guix build utils)))
(snippet
'(begin
diff --git a/gnu/packages/patches/lvm2-no-systemd.patch b/gnu/packages/patches/lvm2-no-systemd.patch
new file mode 100644
index 0000000000..f786cd9705
--- /dev/null
+++ b/gnu/packages/patches/lvm2-no-systemd.patch
@@ -0,0 +1,19 @@
+Fixes <https://issues.guix.gnu.org/65177>.
+
+Run 'vgchange' directly instead of attempting to run it via 'systemd-run' as
+the udev rules included in lvm2 >= 2.03.14 do.
+
+diff --git a/udev/69-dm-lvm.rules.in b/udev/69-dm-lvm.rules.in
+index ff15681..d3cc125 100644
+--- a/udev/69-dm-lvm.rules.in
++++ b/udev/69-dm-lvm.rules.in
+@@ -75,8 +75,7 @@ LABEL="lvm_scan"
+ # TODO: adjust the output of vgchange -aay so that
+ # it's better suited to appearing in the journal.
+
+-IMPORT{program}="(LVM_EXEC)/lvm pvscan --cache --listvg --checkcomplete --vgonline --autoactivation event --udevoutput --journal=output $env{DEVNAME}"
+-ENV{LVM_VG_NAME_COMPLETE}=="?*", RUN+="(SYSTEMDRUN) --no-block --property DefaultDependencies=no --unit lvm-activate-$env{LVM_VG_NAME_COMPLETE} (LVM_EXEC)/lvm vgchange -aay --autoactivation event $env{LVM_VG_NAME_COMPLETE}"
++ENV{LVM_VG_NAME_COMPLETE}=="?*", RUN+="(LVM_EXEC)/lvm vgchange -aay --autoactivation event $env{LVM_VG_NAME_COMPLETE}"
+ GOTO="lvm_end"
+
+ LABEL="lvm_end"

base-commit: 3991d9e4d9867ec499283bfc71b34d7bfebe49b3
--
2.41.0
Y
Y
Yann Dupont wrote on 5 Mar 16:51 +0100
[PATCH] gnu: lvm2: Remove systemd rule.
(address . 66586@debbugs.gnu.org)
9efe6049-3b9f-6961-a781-6a034fc35e09@univ-nantes.fr
Hi, this bug is still open, and, as far as I can tell, generating a VM
using lvm2 is still currently broken.

Is there still a problem preventing this path from being integrated?
A
A
Adrien 'neox' Bourmault wrote on 2 Apr 19:26 +0200
(address . 66586@debbugs.gnu.org)
9e5aa31de2c1789535b90e5f427a6a7ccfc9e8c7.camel@gnu.org
Hi there, I just tested it but it did not work while not showing the error I
reported earlier. I just obtain "Device ... not found or access denied".

However, it might be linked to 70051 too, so I'll try to test with that too (or
wait it's merged).
Y
Y
Yann Dupont wrote on 10 Apr 15:19 +0200
(no subject)
(address . 66586@debbugs.gnu.org)
b9fa1d83-04c6-077a-095b-5a913b968097@univ-nantes.fr
Hi there,

I'd looked at the patch Simon reformatted and it seemed fine, but I just
tested *this* thread's patch, and it doesn't seem to work.

I suspect there's an extra "-" in the 1st line of the 3rd patch (it
wasn't in my original patch https://issues.guix.gnu.org/65177#3)

the « - » in the line '-IMPORT{program}="(LVM_EXEC)/lvm pvscan --cache
--listvg --checkcomplete --vgonline --autoactivation event --udevoutput
--journal=output $env{DEVNAME}' is too much in the patch.

I've just tested the generation of a VM generated with the patch
amputated from the excess line and it's ok.

Unless someone does it before me, I'll try again to post the correct
version.
Attachment: file
Y
Y
Yann Dupont wrote 7 days ago
[PATCH] gnu: lvm2: Remove systemd rule.
(address . 66586@debbugs.gnu.org)
06ddf9e4-2cc9-e424-362f-8bedf6166b7d@univ-nantes.fr
I hope this time patch won't be garbled… (trying to attach patch)
Toggle diff (48 lines)
diff --git a/gnu/local.mk b/gnu/local.mk
index 2e0c6a5d3c..d9d11b31b9 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1694,6 +1694,7 @@ dist_patch_DATA = \
%D%/packages/patches/mcrypt-CVE-2012-4527.patch \
%D%/packages/patches/libmemcached-build-with-gcc7.patch \
%D%/packages/patches/libmhash-hmac-fix-uaf.patch \
+ %D%/packages/patches/lvm2-no-systemd.patch \
%D%/packages/patches/maturin-no-cross-compile.patch \
%D%/packages/patches/mecab-variable-param.patch \
%D%/packages/patches/memtest86+-build-reproducibly.patch \
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 9c819838bd..549de85ea4 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -4613,6 +4613,7 @@ (define-public lvm2
(sha256
(base32
"0z6w6bknhwh1n3qfkb5ij6x57q3wjf28lq3l8kh7rkhsplinjnjc"))
+ (patches (search-patches "lvm2-no-systemd.patch"))
(modules '((guix build utils)))
(snippet
'(begin
diff --git a/gnu/packages/patches/lvm2-no-systemd.patch b/gnu/packages/patches/lvm2-no-systemd.patch
new file mode 100644
index 0000000000..f43e568bb1
--- /dev/null
+++ b/gnu/packages/patches/lvm2-no-systemd.patch
@@ -0,0 +1,18 @@
+Fixes <https://issues.guix.gnu.org/65177>.
+
+Run 'vgchange' directly instead of attempting to run it via 'systemd-run' as
+the udev rules included in lvm2 >= 2.03.14 do.
+
+diff --git a/udev/69-dm-lvm.rules.in b/udev/69-dm-lvm.rules.in
+index ff1568145..8879a2ef9 100644
+--- a/udev/69-dm-lvm.rules.in
++++ b/udev/69-dm-lvm.rules.in
+@@ -76,7 +76,7 @@ LABEL="lvm_scan"
+ # it's better suited to appearing in the journal.
+
+ IMPORT{program}="(LVM_EXEC)/lvm pvscan --cache --listvg --checkcomplete --vgonline --autoactivation event --udevoutput --journal=output $env{DEVNAME}"
+-ENV{LVM_VG_NAME_COMPLETE}=="?*", RUN+="(SYSTEMDRUN) --no-block --property DefaultDependencies=no --unit lvm-activate-$env{LVM_VG_NAME_COMPLETE} (LVM_EXEC)/lvm vgchange -aay --autoactivation event $env{LVM_VG_NAME_COMPLETE}"
++ENV{LVM_VG_NAME_COMPLETE}=="?*", RUN+="(LVM_EXEC)/lvm vgchange -aay --autoactivation event $env{LVM_VG_NAME_COMPLETE}"
+ GOTO="lvm_end"
+
+ LABEL="lvm_end"
?