[PATCH]: Update emacs-slime and sbcl-slime-swank to 2.28-0.1e4b741

  • Done
  • quality assurance status badge
Details
3 participants
  • André A. Gomes
  • Guillaume Le Vaillant
  • Christopher Baines
Owner
unassigned
Submitted by
André A. Gomes
Severity
normal
A
A
André A. Gomes wrote on 21 Sep 2023 22:51
(address . guix-patches@gnu.org)
87fs375jy2.fsf@gmail.com
Hi Guix,

Please find the patch attached. Thanks!

--
André A. Gomes
"You cannot even find the ruins..."
From 2a5b2b845c0a9446d22803bf90d46741b78cee5b Mon Sep 17 00:00:00 2001
From: "Andre A. Gomes" <andremegafone@gmail.com>
Date: Thu, 21 Sep 2023 23:46:55 +0300
Subject: [PATCH 1/2] gnu: emacs-slime: Update to 2.28-0.1e4b741.

* gnu/packages/emacs-xyz.scm (emacs-slime): Update to 2.28-0.1e4b741.
---
gnu/packages/emacs-xyz.scm | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)

Toggle diff (41 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index c4de0e1d1f..3640f3aca6 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -9814,18 +9814,21 @@ (define-public emacs-tagedit
(license license:gpl3+)))
(define-public emacs-slime
- (package
+ ;; Update together with sbcl-slime-swank.
+ (let ((commit "1e4b7417a1ade842ba4938f66445af68a93176b9")
+ (revision "0"))
+ (package
(name "emacs-slime")
- (version "2.28")
+ (version (git-version "2.28" revision commit))
(source
(origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/slime/slime")
- (commit (string-append "v" version))))
+ (commit commit)))
(file-name (git-file-name name version))
(sha256
- (base32 "1acmm4w1mv1qzpnkgc4wyiilbx8l0dk16sx8wv815ri5ks289rll"))))
+ (base32 "17fs4wjplcxwbgsqzawwnw45xw6rdyyqk3f7dqck7pfazpzziizp"))))
(build-system emacs-build-system)
(arguments
(list
@@ -9875,7 +9878,7 @@ (define-public emacs-slime
While lisp-mode supports editing Lisp source files, @command{slime-mode}
adds support for interacting with a running Common Lisp process
for compilation, debugging, documentation lookup, and so on.")
- (license (list license:gpl2+ license:public-domain))))
+ (license (list license:gpl2+ license:public-domain)))))
(define-public emacs-popup
(package
--
2.41.0
Attachment: 0002-gnu-sbcl-slime-swank-Update-to-2.28-0.1e4b741.patch
C
C
Christopher Baines wrote on 25 Sep 2023 12:01
(name . André A. Gomes)(address . andremegafone@gmail.com)
87il7y7efi.fsf@cbaines.net
André A. Gomes <andremegafone@gmail.com> writes:

Toggle quote (4 lines)
> Hi Guix,
>
> Please find the patch attached. Thanks!

It seems like you've attached two patches? It's useful to just send one
patch per email, as lots of tooling expects that.

Looking at the first patch though, packaging anything but the latest
release shouldn't be the norm [1].


You need to put the reasoning for updating these packages to these
specific commits in to some comments. Depending on that justification as
well, we need to decide whether to ship these versions in addition to
the latest releases, or as you're doing currently to replace the latest
releases with these snapshots.

What approach to take depends on the justification, e.g. if the latest
release is unusable or using it could be problematic, then replacing it
with a snapshot seems better, otherwise, we should create package
variants (e.g. emacs-slime-next) for these snapshots.

Does that make sense?

Thanks,

Chris
-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmURXDFfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XfyxRAAsFWsRjXtZr3KWvyohw/zs3hVDVlCn9r4
A/eX/oiymFf38UuejXjbVkp+G1vQUMe6rDcJMXcHLQPzIgetuMiPJOHVqqdUHrei
MpZRlmpYvfOMWXT+y5O/sjFWkbwdNNeJlK2FHXfLapg5/GTxfdr8CxD4GNKbuzoa
UVfD5z2DrCi8WuuxYytqBVSmQL0oZK6AGjkbwyhpRsofKrzfHGopsLkApqB2Vrme
tfygeForRGjr5t/EBUCrRtFAVz2aSTSWs5eT+U4iWFShBf7o9/MnBD53Ao1oOYAb
zJg73VUB8m5rk1b1VeHXrHAw8ZlV2KqRv9WR18sZ/OXMIhD+9wrxCs4pWnkfCeNx
TixpkowQoDusAjXg3ZTasxr868zMuLN9UzCQB/lLSCo6BL62f6SJgs4IpPg4Fjm0
IIu+vb8QQz2dQ/1SwxrdmImPORv5/X1SCk+etAXov+Kp75aOOtuuIraJBVxLYl/r
/H0N9dnRXbX4CMDpZkp969CX/jOFQugx/c/FEkW5Yz0ESq6AJ6WsmGk+zenbQ9JN
ypkS8+x2+8/cuyHxIlbb3atmGFrL1C+WpwQuBXuDTOc54iyMoF1jZLbvlXkEys46
bTa+FeqI/c+HO3HZpUDz66NJOLPKsp6Qs7AkuqawXuJamlLA9OVEd9NNgWkrRv/p
T7oV+mbuOck=
=sMzx
-----END PGP SIGNATURE-----

A
A
André A. Gomes wrote on 26 Sep 2023 11:16
(name . Christopher Baines)(address . mail@cbaines.net)
87pm25l2ga.fsf@gmail.com
Christopher Baines <mail@cbaines.net> writes:

Toggle quote (3 lines)
> It seems like you've attached two patches? It's useful to just send one
> patch per email, as lots of tooling expects that.

I'm more used to sending patches as email attachments, instead of using
git-send-email. If Guix requires the latter then I'll adjust, but I've
been sending plenty of patches following the former approach.

Toggle quote (16 lines)
> Looking at the first patch though, packaging anything but the latest
> release shouldn't be the norm [1].
>
> 1: https://guix.gnu.org/manual/en/guix.html#index-version-number_002c-for-VCS-snapshots
>
> You need to put the reasoning for updating these packages to these
> specific commits in to some comments. Depending on that justification as
> well, we need to decide whether to ship these versions in addition to
> the latest releases, or as you're doing currently to replace the latest
> releases with these snapshots.
>
> What approach to take depends on the justification, e.g. if the latest
> release is unusable or using it could be problematic, then replacing it
> with a snapshot seems better, otherwise, we should create package
> variants (e.g. emacs-slime-next) for these snapshots.

It makes no sense to have emacs-slime-next and cl-slime-swank-next.
I've bumped it because significant changes have been introduced since
the last tagged released.

In the meantime, I've kindly request a tagged release upstream. Whether
I'll get a reply soon remains to be seen.


With all respect to your work, Christopher Baines, I'd kindly suggest a
review by the Common Lisp team - Guillaume Le Vaillant, who has been
reviewing most of my patches lately.

Thanks!


--
André A. Gomes
"You cannot even find the ruins..."
A
A
André A. Gomes wrote on 28 Sep 2023 12:19
(name . Christopher Baines)(address . mail@cbaines.net)
875y3uob1g.fsf@gmail.com
André A. Gomes <andremegafone@gmail.com> writes:

Toggle quote (9 lines)
> It makes no sense to have emacs-slime-next and cl-slime-swank-next.
> I've bumped it because significant changes have been introduced since
> the last tagged released.
>
> In the meantime, I've kindly request a tagged release upstream. Whether
> I'll get a reply soon remains to be seen.
>
> https://github.com/slime/slime/issues/792

Still no reply to my request to tag a new release. These projects are
run by volunteers and releases are rare.

Recently Ludovic merged a similar patch in spirit (relative to SLY,

I'd kindly ask to take another look at the patch. I'm adding Ludo and
Guillaume in CC. Thanks!

As a sidenote, I'm considering requesting commit access to Guix to help
the team that handles Common Lisp and WebKitGTK. I am part of the Nyxt


--
André A. Gomes
"You cannot even find the ruins..."
C
C
Christopher Baines wrote on 11 Oct 2023 12:24
tag 66143 moreinfo
(address . control@debbugs.gnu.org)
87sf6hmp7f.fsf@cbaines.net
tags 66143 + moreinfo
quit
A
A
André A. Gomes wrote on 20 Oct 2023 21:46
Re: [bug#66143] [PATCH]: Update emacs-slime and sbcl-slime-swank to 2.28-0.1e4b741
(name . Christopher Baines)(address . mail@cbaines.net)
87jzrhaxg7.fsf@gmail.com
André A. Gomes <andremegafone@gmail.com> writes:

Toggle quote (11 lines)
> André A. Gomes <andremegafone@gmail.com> writes:
>
>> It makes no sense to have emacs-slime-next and cl-slime-swank-next.
>> I've bumped it because significant changes have been introduced since
>> the last tagged released.
>>
>> In the meantime, I've kindly request a tagged release upstream. Whether
>> I'll get a reply soon remains to be seen.
>>
>> https://github.com/slime/slime/issues/792

The author ignored my kind request release.

I still think that it is not necessary to maintain both emacs-slime-next
and emacs-slime, but please help me to get this patch through. Thanks.


--
André A. Gomes
"You cannot even find the ruins..."
G
G
Guillaume Le Vaillant wrote on 22 Oct 2023 13:51
(name . André A. Gomes)(address . andremegafone@gmail.com)
877cne7tml.fsf@kitej
Hi.
Concerning patch 2 for sbcl-slime-swank, the first 'substitute*' form
of the 'set-fasl-directory' phase looks obsolete because of changes in
"swank.asd".
If the fasl files are now put in the right place even without it, and if
slime and swank still work fine, could you send an updated patch?
Thanks.
-----BEGIN PGP SIGNATURE-----

iIUEAREKAC0WIQTLxZxm7Ce5cXlAaz5r6CCK3yH+PwUCZTUPQg8cZ2x2QHBvc3Rl
by5uZXQACgkQa+ggit8h/j8ESAD9E4i5cl92cWIHTTC44GuHArLe2cPNj2b8N/PH
QT1xbDoA/iKavdOO/M1mfI9FtY7MzC0t5/lrH+BAqcJ19+shd4G5
=9v39
-----END PGP SIGNATURE-----

A
A
André A. Gomes wrote on 24 Oct 2023 09:31
(name . Guillaume Le Vaillant)(address . glv@posteo.net)
87v8awa32o.fsf@gmail.com
Guillaume Le Vaillant <glv@posteo.net> writes:

Toggle quote (8 lines)
> Hi.
> Concerning patch 2 for sbcl-slime-swank, the first 'substitute*' form
> of the 'set-fasl-directory' phase looks obsolete because of changes in
> "swank.asd".
> If the fasl files are now put in the right place even without it, and if
> slime and swank still work fine, could you send an updated patch?
> Thanks.

Hi Guillaume,

Thanks for pointing that out. Please find the updated patches attached.


--
André A. Gomes
"You cannot even find the ruins..."
From 7a9559602c62c90d9d4ff01233bce2c33b2d34d3 Mon Sep 17 00:00:00 2001
From: "Andre A. Gomes" <andremegafone@gmail.com>
Date: Tue, 24 Oct 2023 10:28:01 +0300
Subject: [PATCH 1/2] gnu: emacs-slime: Update to 2.28-0.0cc2e73.

* gnu/packages/emacs-xyz.scm (emacs-slime): Update to 2.28-0.0cc2e73.
---
gnu/packages/emacs-xyz.scm | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)

Toggle diff (41 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 7112a65181..ed31b0fd19 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -9895,18 +9895,21 @@ (define-public emacs-tagedit
(license license:gpl3+)))
(define-public emacs-slime
- (package
+ ;; Update together with sbcl-slime-swank.
+ (let ((commit "0cc2e736112a0bc2a048ef6efd11dd67e3fbf7ad")
+ (revision "0"))
+ (package
(name "emacs-slime")
- (version "2.28")
+ (version (git-version "2.28" revision commit))
(source
(origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/slime/slime")
- (commit (string-append "v" version))))
+ (commit commit)))
(file-name (git-file-name name version))
(sha256
- (base32 "1acmm4w1mv1qzpnkgc4wyiilbx8l0dk16sx8wv815ri5ks289rll"))))
+ (base32 "0iq9r4007rrnabj290y79i926x2m4j20j6b0x701pkywz926sn02"))))
(build-system emacs-build-system)
(arguments
(list
@@ -9956,7 +9959,7 @@ (define-public emacs-slime
While lisp-mode supports editing Lisp source files, @command{slime-mode}
adds support for interacting with a running Common Lisp process
for compilation, debugging, documentation lookup, and so on.")
- (license (list license:gpl2+ license:public-domain))))
+ (license (list license:gpl2+ license:public-domain)))))
(define-public emacs-popup
(package
--
2.41.0
Attachment: 0002-gnu-sbcl-slime-swank-Update-to-2.28-0.0cc2e73.patch
G
G
Guillaume Le Vaillant wrote on 24 Oct 2023 14:40
(name . André A. Gomes)(address . andremegafone@gmail.com)
87a5s8kxa5.fsf@kitej
Patches applied as d62a613bcff726dfc835313064228e7bc3b7cda6 and
following, with a completed commit message for the second patch.
Thanks.
-----BEGIN PGP SIGNATURE-----

iIUEAREKAC0WIQTLxZxm7Ce5cXlAaz5r6CCK3yH+PwUCZTe7gg8cZ2x2QHBvc3Rl
by5uZXQACgkQa+ggit8h/j+VxQD/ZSSVGNyWH3bj1O9/SMjsVMRJ8Cxb9aXcPJla
qnj96vwBAIrmAcOhWDZ9y+K7xHc0l7Z2kYoF9cc7yXO4VitqqmND
=hWqr
-----END PGP SIGNATURE-----

Closed
C
C
Christopher Baines wrote on 24 Oct 2023 15:08
(name . Guillaume Le Vaillant)(address . glv@posteo.net)(address . 66143-done@debbugs.gnu.org)
87r0lk2mc4.fsf@cbaines.net
Guillaume Le Vaillant <glv@posteo.net> writes:

Toggle quote (3 lines)
> Patches applied as d62a613bcff726dfc835313064228e7bc3b7cda6 and
> following, with a completed commit message for the second patch.

I did raise an objection earlier in the thread to these changes being
merged. Not discussing (or even acknowledging issues raised) is
unhelpful.

Given what I've now read from upstream [1], I think it can be justified
in this case, but this is independent from the above. I think we still
should record reasons for deviating from the norm in comments (and
commit messages if useful).

-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmU3w2tfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XdhhxAAmVFpAQ40xy8Un0jilP9vHAVPB+S7SVg/
GhpX9UGAPlmB1gK02MFqc02S6ZLJt1cEl5muNaabpATVtCagpuJItFaf+E1/SH5S
qm3+1P/LVLlNUErzatZ8rtgbor8aCbPZaqPPfHea+MGu/Wkl7T2w4StGOfhOY4d3
dXYi2DxQ+TNs7axCnuYBqoBMy2jIWjIDBWtk3k9fgOHGwjk7XvtSSQKcc/Da3mlj
NEgNAIdbUDF8KWswD2yCxRr/coxte10DlyyczCxdy5o/keJixBtgWEVJ7YDvf26u
+fbinw2cdfQJ3/BcfltvKQuPaAKCD9FX/TfWODo+rQob9lz3Mdun7raSY/T8Dvpg
hAcYc54enGFD549gfaCr90Uh/nuQkYTfK/iQNSuK5atOoSHhMA/lMus7iX58nCzE
dsBN7YgsXOeje54RBdldtEKuAYsonxOg88G7i8bC3x7+/5szmRsOxQWOog3WbFOR
WaRre0ovGGUwCkZJrjV0Pmx49deYhn1ku2GLNCe9PUwysCz+TgPtMgM2XzbzipD5
N4Ws0zzA+cHDj2PkIWNeb/mXZegqt2iDL+2TmamFwXhEyjAv7NvD4JkE5X5ekdal
0DAQtuHnhUKd8/ugL6nh2t6CSZ9uFH9OlynaTe85YmuBQnByk554kEnQ2RD8tw1G
j00xg7IUPVM=
=1141
-----END PGP SIGNATURE-----

Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 66143@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 66143
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch