[PATCH] gnu: python-hicmatrix: Fix "'build': uncaught exception".

  • Done
  • quality assurance status badge
Details
2 participants
  • Mădălin Ionel Patrașcu
  • Ricardo Wurmus
Owner
unassigned
Submitted by
Mădălin Ionel Patrașcu
Severity
normal

Debbugs page

Mădălin Ionel Patrașcu wrote 1 years ago
(address . guix-patches@gnu.org)
20230913133942.9140-1-madalinionel.patrascu@mdc-berlin.de
* gnu/packages/bioinformatics.scm (python-hicmatrix): Add new phase
'fix-references that remove the * character from the name of the
requirements.
---
gnu/packages/bioinformatics.scm | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

Toggle diff (21 lines)
diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index e24d70e569..06ff34e877 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -16228,7 +16228,11 @@ (define-public python-hicmatrix
(arguments
(list
#:phases
- '(modify-phases %standard-phases
+ #~(modify-phases %standard-phases
+ (add-after 'unpack 'fix-references
+ (lambda _
+ (substitute* "setup.py"
+ ((".\\*\"") ".0\""))))
(replace 'check
(lambda* (#:key tests? #:allow-other-keys)
(when tests?

base-commit: 9996896dc252a02ba3b17473a685ce8957237546
--
2.41.0
Ricardo Wurmus wrote 1 years ago
(name . Mădălin Ionel Patrașcu)(address . madalinionel.patrascu@mdc-berlin.de)(address . 65916-done@debbugs.gnu.org)
87pm2l258a.fsf@elephly.net
Hi, thanks for the patch.

Toggle quote (22 lines)
> * gnu/packages/bioinformatics.scm (python-hicmatrix): Add new phase
> 'fix-references that remove the * character from the name of the
> requirements.
> ---
> gnu/packages/bioinformatics.scm | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
> index e24d70e569..06ff34e877 100644
> --- a/gnu/packages/bioinformatics.scm
> +++ b/gnu/packages/bioinformatics.scm
> @@ -16228,7 +16228,11 @@ (define-public python-hicmatrix
> (arguments
> (list
> #:phases
> - '(modify-phases %standard-phases
> + #~(modify-phases %standard-phases
> + (add-after 'unpack 'fix-references
> + (lambda _
> + (substitute* "setup.py"
> + ((".\\*\"") ".0\""))))

I simplified this to remove the “.0”, renamed the phase because it isn’t
about fixing references, and removed the gexp.

--
Ricardo
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 65916@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 65916
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help