[PATCH]: Update sbcl to 2.3.8

  • Done
  • quality assurance status badge
Details
3 participants
  • André A. Gomes
  • Guillaume Le Vaillant
  • Christopher Baines
Owner
unassigned
Submitted by
André A. Gomes
Severity
normal
A
A
André A. Gomes wrote on 29 Aug 2023 15:49
(address . guix-patches@gnu.org)
87bkeqj6w0.fsf@gmail.com
Hi Guix,

Please find the patch attached. Thanks.


--
André A. Gomes
"You cannot even find the ruins..."
From 001395fa5fd21654cadb20e4f9daaa30e000396d Mon Sep 17 00:00:00 2001
From: "Andre A. Gomes" <andremegafone@gmail.com>
Date: Tue, 29 Aug 2023 16:48:10 +0300
Subject: [PATCH] gnu: sbcl: Update to 2.3.8.

* gnu/packages/lisp.scm (sbcl): Update to 2.3.8.
---
gnu/packages/lisp.scm | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

Toggle diff (26 lines)
diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
index 6f425a6e4a..db9c644144 100644
--- a/gnu/packages/lisp.scm
+++ b/gnu/packages/lisp.scm
@@ -433,17 +433,15 @@ (define-public clisp
(define-public sbcl
(package
(name "sbcl")
- (version "2.3.5")
+ (version "2.3.8")
(source
(origin
(method url-fetch)
(uri (string-append "mirror://sourceforge/sbcl/sbcl/" version "/sbcl-"
version "-source.tar.bz2"))
(sha256
- (base32 "11ji5n65l31249r0v7hm0wc0yk2ila0y746nj36xn1cxrwh0gjc9"))
+ (base32 "0a8dranh15gsbq51ssnvccl91mzqmgs5xsmwisz5hvlimjr725a2"))
(modules '((guix build utils)))
- ;; backport from upstream.
- (patches (search-patches "sbcl-riscv-Make-contribs-build-again.patch"))
(snippet
'(begin
;; Don't force ARMv5.
--
2.41.0
G
G
Guillaume Le Vaillant wrote on 4 Sep 2023 15:32
(name . André A. Gomes)(address . andremegafone@gmail.com)(address . 65592@debbugs.gnu.org)
87il8qhxas.fsf@kitej
I applied a modified version of your patch (to remove the obsolete patch
from the sources) on the lisp-team branch.
When the CI machines have rebuilt the dependents, we'll merge the
lisp-team branch into the master branch.
-----BEGIN PGP SIGNATURE-----

iIUEAREKAC0WIQTLxZxm7Ce5cXlAaz5r6CCK3yH+PwUCZPXeKw8cZ2x2QHBvc3Rl
by5uZXQACgkQa+ggit8h/j+8PQD9EE6Zfzg52TbTEhbNcu2ug5n80dVZjsuqKlmG
WgBTdq0A+QG2vBBUIkRbde8TRsB/0tktHRtctAx/LGC00OqeWYxN
=+SPp
-----END PGP SIGNATURE-----

G
G
Guillaume Le Vaillant wrote on 23 Sep 2023 11:16
(name . André A. Gomes)(address . andremegafone@gmail.com)(address . 65592-done@debbugs.gnu.org)
87ttrldz46.fsf@kitej
SBCL 2.3.8 didn't build on riscv64, so instead version 2.3.7 is used for
now. It has been merged in master at
4f35ff1275e05be31f5d41464ccf147e9dbfd016.
Let's close this issue and open a new one for a future update of SBCL
(maybe 2.3.9 will fix the build failure).
-----BEGIN PGP SIGNATURE-----

iIUEAREKAC0WIQTLxZxm7Ce5cXlAaz5r6CCK3yH+PwUCZQ6t+Q8cZ2x2QHBvc3Rl
by5uZXQACgkQa+ggit8h/j/X4gEAmtlyI7IQEj6pCMwbCE4X4XiG+C6hA51nYfXw
si/FDZ4A/jMnqtEaR3vjnQM5x9M1F2mIjeYmL+kju95fr9Xry2sy
=jadz
-----END PGP SIGNATURE-----

Closed
A
A
André A. Gomes wrote on 26 Sep 2023 11:17
(name . Guillaume Le Vaillant)(address . glv@posteo.net)(address . 65592-done@debbugs.gnu.org)
87lectl2dc.fsf@gmail.com
Guillaume Le Vaillant <glv@posteo.net> writes:

Toggle quote (6 lines)
> SBCL 2.3.8 didn't build on riscv64, so instead version 2.3.7 is used for
> now. It has been merged in master at
> 4f35ff1275e05be31f5d41464ccf147e9dbfd016.
> Let's close this issue and open a new one for a future update of SBCL
> (maybe 2.3.9 will fix the build failure).

Hi Guillaume,

Just for future reference, is there a way for me to check whether a SBCL
builds on all platforms when sending a patch? Thanks.


--
André A. Gomes
"You cannot even find the ruins..."
Closed
G
G
Guillaume Le Vaillant wrote on 27 Sep 2023 11:03
(name . André A. Gomes)(address . andremegafone@gmail.com)(address . 65592-done@debbugs.gnu.org)
874jjgt16d.fsf@kitej
André A. Gomes <andremegafone@gmail.com> skribis:

Toggle quote (13 lines)
> Guillaume Le Vaillant <glv@posteo.net> writes:
>
>> SBCL 2.3.8 didn't build on riscv64, so instead version 2.3.7 is used for
>> now. It has been merged in master at
>> 4f35ff1275e05be31f5d41464ccf147e9dbfd016.
>> Let's close this issue and open a new one for a future update of SBCL
>> (maybe 2.3.9 will fix the build failure).
>
> Hi Guillaume,
>
> Just for future reference, is there a way for me to check whether a SBCL
> builds on all platforms when sending a patch? Thanks.

For x86_64, i686, aarch64, armhf and powerpc64le, you can check on

However so far the CI doesn't have builds for riscv64, because it
doesn't have riscv64 hardware. Efraim Flashner <efraim@flashner.co.il>
has a riscv64 board with Guix on it, and he is the one who tried
building SBCL 2.3.8 and saw the failure.

If you are using a Guix system, you could also add the
qemu-binfmt-service-type to your system definition, which gives the
possibility to build packages for some other architectures with:

guix build -s riscv64-linux PACKAGE-NAME

Unfortunately, qemu-binfmt has difficulties running SBCL on foreign
architectures, and building SBCL for aarch64 or riscv64 on a x86_64
machine fails with an error about a missing tty or something like that.
However, trying the build with qemu-binfmt can still be useful, because
if compilation fails before getting to the tty error, it usually
indicates that the package has an issue on this architecture.
-----BEGIN PGP SIGNATURE-----

iIUEAREKAC0WIQTLxZxm7Ce5cXlAaz5r6CCK3yH+PwUCZRP1yg8cZ2x2QHBvc3Rl
by5uZXQACgkQa+ggit8h/j/fDgD+MEDR2E/TwgOPXgBfREoO/xMbJbX7KJxiP5Wt
Jj3u99oA/3/r53aZjGjZa+isM7fIPFWNMIjyl7ylrOPORcF8I2Fp
=IVed
-----END PGP SIGNATURE-----

Closed
C
C
Christopher Baines wrote on 27 Sep 2023 12:44
(name . Guillaume Le Vaillant)(address . glv@posteo.net)
874jjfevwi.fsf@cbaines.net
Guillaume Le Vaillant <glv@posteo.net> writes:

Toggle quote (18 lines)
> André A. Gomes <andremegafone@gmail.com> skribis:
>
>> Guillaume Le Vaillant <glv@posteo.net> writes:
>>
>>> SBCL 2.3.8 didn't build on riscv64, so instead version 2.3.7 is used for
>>> now. It has been merged in master at
>>> 4f35ff1275e05be31f5d41464ccf147e9dbfd016.
>>> Let's close this issue and open a new one for a future update of SBCL
>>> (maybe 2.3.9 will fix the build failure).
>>
>> Hi Guillaume,
>>
>> Just for future reference, is there a way for me to check whether a SBCL
>> builds on all platforms when sending a patch? Thanks.
>
> For x86_64, i686, aarch64, armhf and powerpc64le, you can check on
> <https://qa.guix.gnu.org/issue/ISSUE-NUMBER>.

Note that we're lacking sufficient powerpc64 hardware to do QA for that
architecture.

Toggle quote (5 lines)
> However so far the CI doesn't have builds for riscv64, because it
> doesn't have riscv64 hardware. Efraim Flashner <efraim@flashner.co.il>
> has a riscv64 board with Guix on it, and he is the one who tried
> building SBCL 2.3.8 and saw the failure.

We do however have RiscV hardware connected to the bordeaux build farm,
I've got a machine and there's also a second connected. We probably need
at least one more machine to enable the system for QA though.
-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmUUB/1fFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9Xc00A/9HbYrPfjzG+mcaPA51wfj2zrCfoYVtLS2
HooK/gUEiOOAoQI+HNGldwNE+R6lhfg/CsDbaQsaVcv6NBFe8Suv2MRNDTQ0n+Mh
iJuld7B/h+b2y+r8IOE7X1bxZICLdEGJERpgG5gTYgI8RLvExri0D2njow9rHwCm
n6uj1SVmlnuSWJFtuYFsdXU33bhQ8bWWuoqy8p71Nz8eOH1uOVFJtG4y9PuNizML
hZO3BNjOIyTbFrW+IKkTWr+6Wd71XkEipFfHI/YP4fwb9SZAuT5jcnzS4vlo/rW0
iaf1pH/xydO9tPheUI5o044p5rxOifO8r60JVQVnfX6cQQecCNmBsUhNUtyomDB1
8aTxdbRJrG3W8ge4FYTUwVoAWBP7KYrBw2OTsgplnUdL8v1DdeFUvBQDT2Uztc1B
cnl4KEdjtfLWjCLp/MqH+lNJa5uAdsYMkmMeCmycwLphXMHVDlKX9hl8ot02N0SK
wxVISn6KFziXooKITsrCWRAedwoiWoGWx9n/PGIJMmcAiJEmwsb4E7GU56S8/oSS
8aaiQizjnUJiYBjuKHPGjVdInnfS8o9EgkhS03AaAcK97b9W1q2PI722wQW6o8Vq
fko1+7FDeyZClVKPLLsvbQEMlCqsv/W8jnDEtaUDglA+/VuIs0GuMjjA7tu7eJcp
bQLXqGsuMaA=
=fdu1
-----END PGP SIGNATURE-----

?
Your comment

This issue is archived.

To comment on this conversation send an email to 65592@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 65592
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch