[PATCH] gnu: smartdns: Update to 43.

  • Done
  • quality assurance status badge
Details
2 participants
  • Hilton Chain
  • Christopher Baines
Owner
unassigned
Submitted by
Hilton Chain
Severity
normal
H
H
Hilton Chain wrote on 12 Aug 2023 15:27
(address . guix-patches@gnu.org)(name . Hilton Chain)(address . hako@ultrarare.space)
928218e0956afa751b1dbf87ece58328d478cd96.1691846836.git.hako@ultrarare.space
* gnu/packages/dns.scm (smartdns): Update to 43.
[arguments]<#:tests?>: Enable tests.
<#:test-target>: Set to "test".
<#:make-flags>: Set "VER".
<#:phases>: Add phase 'skip-unavailable-tests, 'prepare-test-dir,
'enter-test-dir, 'leave-test-dir.
[native-inputs]: Add googletest, isc-bind:utils.
---
gnu/packages/dns.scm | 35 ++++++++++++++++++++++++++++++-----
1 file changed, 30 insertions(+), 5 deletions(-)

Toggle diff (65 lines)
diff --git a/gnu/packages/dns.scm b/gnu/packages/dns.scm
index fdd10a6611..0fd8050286 100644
--- a/gnu/packages/dns.scm
+++ b/gnu/packages/dns.scm
@@ -1340,7 +1340,7 @@ (define-public openresolv
(define-public smartdns
(package
(name "smartdns")
- (version "42")
+ (version "43")
(source (origin
(method git-fetch)
(uri (git-reference
@@ -1352,18 +1352,43 @@ (define-public smartdns
((".*SYSTEMDSYSTEMUNITDIR.*") "")))
(sha256
(base32
- "17j0h5l7gig6rzk8b9180jwrx5khpnrylacjxvnnpgsi2725k8lq"))))
+ "0s789l6i4yirmarg80mknc1pp65rz01ky9f7gidgclkfcwzz41l3"))))
(build-system gnu-build-system)
(arguments
- (list #:tests? #f ;no tests
+ (list #:test-target "test"
#:make-flags
#~(list (string-append "CC=" #$(cc-for-target))
(string-append "DESTDIR=" #$output)
- "PREFIX=''")
+ "PREFIX=''"
+ (string-append "VER=" #$version))
#:phases
#~(modify-phases %standard-phases
- (delete 'configure))))
+ (delete 'configure)
+ (add-after 'unpack 'skip-unavailable-tests
+ (lambda _
+ (with-directory-excursion "test/cases"
+ ;; Tests try to open /etc/resolv.conf
+ (substitute* "test-bind.cc"
+ ;; Bind.tls
+ (("smartdns::Server server_wrap;" all)
+ (string-append "GTEST_SKIP();" all)))
+ ;; Tests use ICMP ping.
+ (substitute* (find-files ".")
+ ((".*PING_TYPE_ICMP.*" all)
+ (string-append "GTEST_SKIP();" all)))
+ (delete-file "test-speed-check.cc"))))
+ ;; Compiled .o files in build phase can't be used for tests.
+ (add-after 'skip-unavailable-tests 'prepare-test-dir
+ (lambda _
+ (copy-recursively "." "../test")))
+ (add-before 'check 'enter-test-dir
+ (lambda _
+ (chdir "../test/test")))
+ (add-after 'check 'leave-test-dir
+ (lambda _
+ (chdir "../../source"))))))
(inputs (list openssl))
+ (native-inputs (list googletest `(,isc-bind "utils")))
(home-page "https://github.com/pymumu/smartdns")
(synopsis "Local DNS server")
(description

base-commit: 19a7a824c35eae56ce56e2a460042fb7e2129234
--
2.41.0
C
C
Christopher Baines wrote on 29 Aug 2023 14:59
(name . Hilton Chain)(address . hako@ultrarare.space)
87v8cygg21.fsf@cbaines.net
Hilton Chain via Guix-patches via <guix-patches@gnu.org> writes:

Toggle quote (11 lines)
> * gnu/packages/dns.scm (smartdns): Update to 43.
> [arguments]<#:tests?>: Enable tests.
> <#:test-target>: Set to "test".
> <#:make-flags>: Set "VER".
> <#:phases>: Add phase 'skip-unavailable-tests, 'prepare-test-dir,
> 'enter-test-dir, 'leave-test-dir.
> [native-inputs]: Add googletest, isc-bind:utils.
> ---
> gnu/packages/dns.scm | 35 ++++++++++++++++++++++++++++++-----
> 1 file changed, 30 insertions(+), 5 deletions(-)

Looks good to me, I've pushed this to master as
5a20470800f3d73cc29b5d45e5e0b3f3e28c1c14.
-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmTt67ZfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XcCJw/+NhpKtSuRKZZG8dvtVQy4L2nhK5x18Tr8
mdfUMxSK5rVdPYylha8mXqFbxysIw9vnDo90FeNah6aRPZo5BXAgmS4aNfA2mYhP
GzIPvfEwk3mfxR8DllLuwPvQCA86MJfViXF+nY4eHlMcG7ehkzbtkexN7D/H6bNd
q1B597Kxaj+nnM1kAxdWrtRr574QbRnWORnvdHwwIojC3zLccl1oCN0VfgkMNOkU
KW8nGuilYBS6zfFmudxVYEF2WU6D1FFaLw+AKwYR6z0JFR6ljtoF6XlRUmEILZlS
gackJgb8uPrAlI3AeKBrQC1xJfjFn5XnQgfHxDUEzef6OQFk4J2uYoNaARcOTtoN
LHWWi7iE5Z415T3tz/MSS1iVxQ/S4zrjE9VMD+4cj3NRv92e2dbBiEZLiSPL73lE
nv5d3W++u/5Q8JyHqGiK87szVpeU7KQvspq1JT5hWrdV0Zyv+st50DuaZ5tw2znK
zsI18dN/BQAPmZ5e3uBXY2VXgmM9sK5PR7Kp4Kb/sCsmyXUub6V3yqwMGROj9dvX
i5+HHtwIDnYOICRbUe3byDkQ3wm1ESHdVM44cRol6NeA6Zqeq9tiCjy6qoz9YgKY
eDxtkKijdO1OM3Qo1ICkYhjrszc1DNcL+uEwIbYvSeV5H0btenvKAoSamtP8leSh
/Hgzhl8mWmY=
=N69r
-----END PGP SIGNATURE-----

?
Your comment

This issue is archived.

To comment on this conversation send an email to 65247@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 65247
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch