Fix python-daemon, Trezor support

dear Maintainers,

the ultimate intention of this series of patches is to fix Trezor support.

the reason i'm sending seemingly unrelated patches under one issue is that some of them are dependent on each other. please apply in order.

--

• attila lendvai

• PGP: 963F 5D5F 45C7 DFCD 0A39

--

“A political situation is the manifestation of a parallel psychological problem in millions of individuals. This problem is largely unconscious (which makes it a particularly dangerous one!)”

— Carl Jung (1875–1961), Letters, vol.1 pg. 535

---

gnu/packages/python-xyz.scm | 10 ++++++----

1 file changed, 6 insertions(+), 4 deletions(-)

tests (3 altogether).

---

gnu/packages/python-xyz.scm | 18 +++++++++---------

1 file changed, 9 insertions(+), 9 deletions(-)

---

gnu/packages/python-xyz.scm | 25 +++++++++++++++++++++++++

1 file changed, 25 insertions(+)

---

gnu/packages/finance.scm | 25 +++++++++++++++----------

1 file changed, 15 insertions(+), 10 deletions(-)

---

gnu/packages/finance.scm | 12 ++++++++----

1 file changed, 8 insertions(+), 4 deletions(-)

Fix it by adding missing native-inputs, so that the tests finish (and thus the

build succeeds).

Also clarify the versioning of the package in a comment, so that later updates

will not pick the wrong version number.

0.12.0 (!). Move the git tag from v0.14.4 to v0.14.6.

---

gnu/packages/finance.scm | 27 +++++++++++++++++++--------

1 file changed, 19 insertions(+), 8 deletions(-)

as the compiler. Mention in a comment that the minimal requirement is 1.18.

---

gnu/packages/finance.scm | 8 +++++---

1 file changed, 5 insertions(+), 3 deletions(-)

---

one small addition (that disrupts the 7/7 numbering).

gnu/packages/finance.scm | 8 ++++----

1 file changed, 4 insertions(+), 4 deletions(-)

Am Donnerstag, dem 03.08.2023 um 12:53 +0000 schrieb Attila Lendvai:

QA says "investigate", but the failing builds appear to have been

blocked before, so we can possibly see this as green. However [notes

to individual commits follow in separate mails]

Am Donnerstag, dem 03.08.2023 um 15:11 +0200 schrieb Attila Lendvai:

The ChangeLog is missing.

Perhaps write

"gnu: python-daemon: Build from git sources.

[uri, sha256]: Adjust accordingly."

Cheers

Am Donnerstag, dem 03.08.2023 um 15:11 +0200 schrieb Attila Lendvai:

Even if it's boring, actually follow the update template.

For the disabled tests, write

[arguments]<adjust-tests>: Drop workaround for hasattr.

Also disable “test_exception_types” and “test_exception_instance”.

Cheers

Am Donnerstag, dem 03.08.2023 um 15:11 +0200 schrieb Attila Lendvai:

Again, write out the ChangeLog.

IIUC the sanity check shouldn't run on scripts, but rather public

modules. You might want to check that there isn't some unmet

dependency or write a comment that more truthfully reflects the cause

of failure, e.g. "This module requires an active Trezor blafoo to be

loaded."

Cheers

Am Donnerstag, dem 03.08.2023 um 15:11 +0200 schrieb Attila Lendvai:

??

???????????

First things first, if it's one source for two packages, why don't we

simply inherit that package (or at least its source) instead of doing

things this roundabout way?

Second, I'd do this as a multi-stage thing. First, "upgrade" trezor-

agent to 0.14.6, then "downgrade" it without changing the source. This

way, folks who use the builtin downgrade prevention will have a commit

to point to get a newer version from.

Cheers

note: some of your mail displays as kanji characters for me.

i asked for clarification in https://github.com/romanz/trezor-agent/issues/369and updated the commit accordingly.

in the new commit there's no downgrade.

--

• attila lendvai

• PGP: 963F 5D5F 45C7 DFCD 0A39

--

“The thing worse than rebellion is the thing that causes rebellion.”

— Frederick Douglass (1818–1895), a former slave.

[uri, sha256]: Adjust accordingly.

---

gnu/packages/python-xyz.scm | 10 ++++++----

1 file changed, 6 insertions(+), 4 deletions(-)

---

gnu/packages/python-xyz.scm | 25 +++++++++++++++++++++++++

1 file changed, 25 insertions(+)

workaround for hasattr. Also disable “test_exception_types” and

“test_exception_instance”.

---

gnu/packages/python-xyz.scm | 18 +++++++++---------

1 file changed, 9 insertions(+), 9 deletions(-)

---

gnu/packages/finance.scm | 25 +++++++++++++++----------

1 file changed, 15 insertions(+), 10 deletions(-)

---

gnu/packages/finance.scm | 12 ++++++++----

1 file changed, 8 insertions(+), 4 deletions(-)

Clarify the versioning of the package in a comment, so that later updates will

not pick the wrong version number.

python-trezor-agent which effectively updates it from 0.14.4 to 0.14.7. Copy

the origin also from python-trezor-agent to effectively sync the source and

the version of the two packages; something that upstream will also do in

future releases.

[native-inputs]: Add missing python-bech32 and python-simple-rlp so that the

test suite runs clean and the build finishes.

---

gnu/packages/finance.scm | 31 ++++++++++++++++++-------------

1 file changed, 18 insertions(+), 13 deletions(-)

as the compiler. Mention in a comment that the minimal requirement is 1.18.

---

gnu/packages/finance.scm | 8 +++++---

1 file changed, 5 insertions(+), 3 deletions(-)

---

gnu/packages/finance.scm | 8 ++++----

1 file changed, 4 insertions(+), 4 deletions(-)

workaround for hasattr. Also disable “test_exception_types” and

“test_exception_instance”.

---

gnu/packages/python-xyz.scm | 18 +++++++++---------

1 file changed, 9 insertions(+), 9 deletions(-)

[uri, sha256]: Adjust accordingly.

---

all raised issues should be addressed in this v3 (modulo anything i

forgot or overlooked).

gnu/packages/python-xyz.scm | 10 ++++++----

1 file changed, 6 insertions(+), 4 deletions(-)

---

gnu/packages/python-xyz.scm | 25 +++++++++++++++++++++++++

1 file changed, 25 insertions(+)

---

gnu/packages/finance.scm | 12 ++++++++----

1 file changed, 8 insertions(+), 4 deletions(-)

Clarify the versioning of the package in a comment, so that later updates will

not pick the wrong version number.

python-trezor-agent which effectively updates it from 0.14.4 to 0.14.7. Copy

the origin also from python-trezor-agent to effectively sync the source and

the version of the two packages; something that upstream will also do in

future releases.

[native-inputs]: Add missing python-bech32 and python-simple-rlp so that the

test suite runs clean and the build finishes.

---

gnu/packages/finance.scm | 37 +++++++++++++++++++++----------------

1 file changed, 21 insertions(+), 16 deletions(-)

as the compiler. Mention in a comment that the minimal requirement is 1.18.

---

gnu/packages/finance.scm | 8 +++++---

1 file changed, 5 insertions(+), 3 deletions(-)

---

gnu/packages/finance.scm | 19 +++++++++----------

1 file changed, 9 insertions(+), 10 deletions(-)

---

gnu/packages/finance.scm | 8 ++++----

1 file changed, 4 insertions(+), 4 deletions(-)

[uri, sha256]: Adjust accordingly.

---

v4: edited some of the commit messages

gnu/packages/python-xyz.scm | 10 ++++++----

1 file changed, 6 insertions(+), 4 deletions(-)

---

gnu/packages/python-xyz.scm | 25 +++++++++++++++++++++++++

1 file changed, 25 insertions(+)

python-click-7 kludge, add python-construct-classes instead of

python-construct.

[native-inputs]: Adjust for the tests to run cleanly.

---

gnu/packages/finance.scm | 19 +++++++++----------

1 file changed, 9 insertions(+), 10 deletions(-)

python-bech32 and python-cryptography.

---

gnu/packages/finance.scm | 12 ++++++++----

1 file changed, 8 insertions(+), 4 deletions(-)

as the compiler.

---

gnu/packages/finance.scm | 8 +++++---

1 file changed, 5 insertions(+), 3 deletions(-)

Clarify the versioning of the package in a comment, so that later updates will

not pick the wrong version number.

python-trezor-agent which effectively updates it from 0.14.4 to 0.14.7. Copy

the origin also from python-trezor-agent to effectively sync the source and

the version of the two packages; something that upstream will also do in

future releases.

[native-inputs]: Add missing python-bech32 and python-simple-rlp so that the

test suite runs clean and the build finishes.

---

gnu/packages/finance.scm | 37 +++++++++++++++++++++----------------

1 file changed, 21 insertions(+), 16 deletions(-)

---

gnu/packages/finance.scm | 8 ++++----

1 file changed, 4 insertions(+), 4 deletions(-)

workaround for hasattr. Also disable “test_exception_types” and

“test_exception_instance”.

---

gnu/packages/python-xyz.scm | 18 +++++++++---------

1 file changed, 9 insertions(+), 9 deletions(-)

---

annoyingly enough, python-daemon has been fixed by someone else in master,

even though it's been failing to build for *months*, and i've sent a fix

also months ago. now, not only mbakke had to do the same changes again

(he hasn't seen my patch, looking at you debbugs...), i also had to

rebase my work once again.

nothing demotivates me more than a sense of futility...

so, once again, please find v5 below.

gnu/packages/python-xyz.scm | 25 +++++++++++++++++++++++++

1 file changed, 25 insertions(+)

python-bech32 and python-cryptography.

---

gnu/packages/finance.scm | 12 ++++++++----

1 file changed, 8 insertions(+), 4 deletions(-)

python-click-7 kludge, add python-construct-classes instead of

python-construct.

[native-inputs]: Adjust for the tests to run cleanly.

---

gnu/packages/finance.scm | 19 +++++++++----------

1 file changed, 9 insertions(+), 10 deletions(-)

as the compiler.

---

gnu/packages/finance.scm | 8 +++++---

1 file changed, 5 insertions(+), 3 deletions(-)

Clarify the versioning of the package in a comment, so that later updates will

not pick the wrong version number.

python-trezor-agent which effectively updates it from 0.14.4 to 0.14.7. Copy

the origin also from python-trezor-agent to effectively sync the source and

the version of the two packages; something that upstream will also do in

future releases.

[native-inputs]: Add missing python-bech32 and python-simple-rlp so that the

test suite runs clean and the build finishes.

---

gnu/packages/finance.scm | 37 +++++++++++++++++++++----------------

1 file changed, 21 insertions(+), 16 deletions(-)

---

gnu/packages/finance.scm | 8 ++++----

1 file changed, 4 insertions(+), 4 deletions(-)

Patches applied as 8036852533b26ce48e82272042ee3ac2a9974ec5 and

following with a few minor modifications (added copyright lines,

modified some commit messages).

Thanks.