[PATCH] gnu: Add gp-saml-gui

  • Done
  • quality assurance status badge
Details
3 participants
  • Ludovic Courtès
  • Bruno Victal
  • Unstable Horse
Owner
unassigned
Submitted by
Unstable Horse
Severity
normal
U
U
Unstable Horse wrote on 3 Jul 2023 17:59
(address . guix-patches@gnu.org)
0e38627cdd71b9abfd1219cc06a6fd5c28551d41.camel@unstable.horse
* gnu/packages/vpn.scm (gp-saml-gui): New variable.
---
gnu/packages/vpn.scm | 41 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 41 insertions(+)

Toggle diff (68 lines)
diff --git a/gnu/packages/vpn.scm b/gnu/packages/vpn.scm
index af070526ec..41e8f0996f 100644
--- a/gnu/packages/vpn.scm
+++ b/gnu/packages/vpn.scm
@@ -67,6 +67,7 @@ (define-module (gnu packages vpn)
#:use-module (gnu packages gettext)
#:use-module (gnu packages gnome)
#:use-module (gnu packages gl)
+ #:use-module (gnu packages glib)
#:use-module (gnu packages gnupg)
#:use-module (gnu packages golang)
#:use-module (gnu packages guile)
@@ -86,6 +87,7 @@ (define-module (gnu packages vpn)
#:use-module (gnu packages qt)
#:use-module (gnu packages samba)
#:use-module (gnu packages tls)
+ #:use-module (gnu packages webkit)
#:use-module (gnu packages xml))
(define-public bitmask
@@ -279,6 +281,45 @@ (define-public bitmask
(home-page "https://bitmask.net/")
(license license:gpl3+)))
+(define-public gp-saml-gui
+ ;; No release.
+ (let ((commit "258f47cdc4a8ed57a1eef16667f6cad0d1cb49b1")
+ (revision "1"))
+ (package
+ (name "gp-saml-gui")
+ (version (git-version "0.0.0" revision commit))
+ (home-page "https://github.com/dlenski/gp-saml-gui")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url home-page)
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0qj2mmi6lfkq5c4v6fbzgriajqc27k9kb1i9k2r776pn5pq14pc3"))))
+ (build-system python-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-after 'install 'wrap-program
+ (lambda* (#:key outputs #:allow-other-keys)
+ (wrap-program
+ (string-append (assoc-ref outputs "out") "/bin/gp-saml-gui")
+ `("GUIX_PYTHONPATH" ":" prefix
+ (,(getenv "GUIX_PYTHONPATH")))
+ `("GI_TYPELIB_PATH" ":" prefix
+ (,(getenv "GI_TYPELIB_PATH")))))))))
+ (inputs
+ (list python-pygobject python-urllib3 python-requests webkitgtk-with-libsoup2))
+ (propagated-inputs
+ (list openconnect))
+ (synopsis "Interactively authenticate to GlobalProtect VPNs that require SAML")
+ (description "This is a helper script to allow you to interactively login
+to a GlobalProtect VPN that uses SAML authentication, so that you can
+subsequently connect with OpenConnect.")
+ (license license:gpl3+))))
+
(define-public gvpe
(package
(name "gvpe")
--
2.40.1
U
U
Unstable Horse wrote on 4 Jul 2023 12:58
[PATCH v1] gnu: Add gp-saml-gui
(address . 64443@debbugs.gnu.org)
8d71ec46a7d06cecf6a5d8afb2585277980b3a73.camel@unstable.horse
* gnu/packages/vpn.scm (gp-saml-gui): New variable.
---
 gnu/packages/vpn.scm | 45 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

Toggle diff (74 lines)
diff --git a/gnu/packages/vpn.scm b/gnu/packages/vpn.scm
index af070526ec..ee1082bc68 100644
--- a/gnu/packages/vpn.scm
+++ b/gnu/packages/vpn.scm
@@ -67,6 +67,7 @@ (define-module (gnu packages vpn)
   #:use-module (gnu packages gettext)
   #:use-module (gnu packages gnome)
   #:use-module (gnu packages gl)
+  #:use-module (gnu packages glib)
   #:use-module (gnu packages gnupg)
   #:use-module (gnu packages golang)
   #:use-module (gnu packages guile)
@@ -86,6 +87,7 @@ (define-module (gnu packages vpn)
   #:use-module (gnu packages qt)
   #:use-module (gnu packages samba)
   #:use-module (gnu packages tls)
+  #:use-module (gnu packages webkit)
   #:use-module (gnu packages xml))
 
 (define-public bitmask
@@ -279,6 +281,49 @@ (define-public bitmask
     (home-page "https://bitmask.net/")
     (license license:gpl3+)))
 
+(define-public gp-saml-gui
+  ;; No release.
+  (let ((commit "258f47cdc4a8ed57a1eef16667f6cad0d1cb49b1")
+        (revision "1"))
+    (package
+      (name "gp-saml-gui")
+      (version (git-version "0.0.0" revision commit))
+      (home-page "https://github.com/dlenski/gp-saml-gui")
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url home-page)
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "0qj2mmi6lfkq5c4v6fbzgriajqc27k9kb1i9k2r776pn5pq14pc3"))))
+      (build-system python-build-system)
+      (arguments
+       `(#:phases
+         (modify-phases %standard-phases
+           (add-after 'install 'wrap-program
+             (lambda* (#:key outputs #:allow-other-keys)
+               (wrap-program
+                   (string-append (assoc-ref outputs "out") "/bin/gp-saml-gui")
+                 `("GUIX_PYTHONPATH" ":" prefix
+                   (,(getenv "GUIX_PYTHONPATH")))
+                 `("GI_TYPELIB_PATH" ":" prefix
+                   (,(getenv "GI_TYPELIB_PATH")))))))))
+      (inputs
+       (list bash-minimal
+             python-pygobject
+             python-urllib3
+             python-requests
+             webkitgtk-with-libsoup2))
+      (propagated-inputs
+       (list openconnect))
+      (synopsis "Interactively authenticate to GlobalProtect VPNs that require SAML")
+      (description "This is a helper script to allow you to interactively login
+to a GlobalProtect VPN that uses SAML authentication, so that you can
+subsequently connect with OpenConnect.")
+      (license license:gpl3+))))
+
 (define-public gvpe
   (package
     (name "gvpe")

base-commit: 94ac93042f09b4ba68b7b64ed1feeebd3dab1ea4
--
2.40.1
B
B
Bruno Victal wrote on 5 Jul 2023 16:22
(name . Unstable Horse)(address . stable.master@unstable.horse)(address . 64443@debbugs.gnu.org)
48a62d97-d0a1-6ec6-9d92-f0c9941880c8@makinata.eu
Hi,

On 2023-07-04 11:58, Unstable Horse wrote:
Toggle quote (12 lines)
> +      (arguments
> +       `(#:phases
> +         (modify-phases %standard-phases
> +           (add-after 'install 'wrap-program
> +             (lambda* (#:key outputs #:allow-other-keys)
> +               (wrap-program
> +                   (string-append (assoc-ref outputs "out") "/bin/gp-saml-gui")
> +                 `("GUIX_PYTHONPATH" ":" prefix
> +                   (,(getenv "GUIX_PYTHONPATH")))
> +                 `("GI_TYPELIB_PATH" ":" prefix
> +                   (,(getenv "GI_TYPELIB_PATH")))))))))

I'd use G-Expressions and write this part as:

Toggle snippet (11 lines)
(list
#:phases
#~(modify-phases %standard-phases
(add-after 'install 'wrap-program
(lambda _
(let ((prog (string-append #$output "/bin/gp-saml-gui")))
(wrap-program prog
`("GUIX_PYTHONPATH" = (,(getenv "GUIX_PYTHONPATH")))
`("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH")))))))))

Another thing, your email client mangled this patch since I had to do
some sed magic to remove the Unicode non-breaking spaces.
Please use 'git send-email' as it doesn't exhibit this behavior.


--
Furthermore, I consider that nonfree software must be eradicated.

Cheers,
Bruno.
U
U
Unstable Horse wrote on 5 Jul 2023 17:49
(name . Bruno Victal)(address . mirai@makinata.eu)(address . 64443@debbugs.gnu.org)
5edc0a52d99cccbe569f1f974e9e5fb406e558dc.camel@unstable.horse
On Wed, 2023-07-05 at 15:22 +0100, Bruno Victal wrote:

Toggle quote (15 lines)
> I'd use G-Expressions and write this part as:
>
> --8<---------------cut here---------------start------------->8---
> (list
> #:phases
> #~(modify-phases %standard-phases
> (add-after 'install 'wrap-program
> (lambda _
> (let ((prog (string-append #$output "/bin/gp-saml-gui")))
> (wrap-program prog
> `("GUIX_PYTHONPATH" = (,(getenv "GUIX_PYTHONPATH")))
> `("GI_TYPELIB_PATH" = (,(getenv
> "GI_TYPELIB_PATH")))))))))
> --8<---------------cut here---------------end--------------->8---

Ooh, I haven't wrapped my head around those yet. I'll test this in a
minute.

Toggle quote (4 lines)
> Another thing, your email client mangled this patch since I had to do
> some sed magic to remove the Unicode non-breaking spaces.
> Please use 'git send-email' as it doesn't exhibit this behavior.

Thanks! That was Evolution... I'll keep that in mind.
U
U
Unstable Horse wrote on 5 Jul 2023 18:50
[PATCH v2] gnu: Add gp-saml-gui
(address . 64443@debbugs.gnu.org)(name . Unstable Horse)(address . stable.master@unstable.horse)
5061c686c9579e5c0468a27fdb2f1ec93d9e0042.1688575796.git.stable.master@unstable.horse
* gnu/packages/vpn.scm (gp-saml-gui): New variable.
---
gnu/packages/vpn.scm | 44 ++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)

Toggle diff (73 lines)
diff --git a/gnu/packages/vpn.scm b/gnu/packages/vpn.scm
index af070526ec..972f9b0329 100644
--- a/gnu/packages/vpn.scm
+++ b/gnu/packages/vpn.scm
@@ -67,6 +67,7 @@ (define-module (gnu packages vpn)
#:use-module (gnu packages gettext)
#:use-module (gnu packages gnome)
#:use-module (gnu packages gl)
+ #:use-module (gnu packages glib)
#:use-module (gnu packages gnupg)
#:use-module (gnu packages golang)
#:use-module (gnu packages guile)
@@ -86,6 +87,7 @@ (define-module (gnu packages vpn)
#:use-module (gnu packages qt)
#:use-module (gnu packages samba)
#:use-module (gnu packages tls)
+ #:use-module (gnu packages webkit)
#:use-module (gnu packages xml))
(define-public bitmask
@@ -279,6 +281,48 @@ (define-public bitmask
(home-page "https://bitmask.net/")
(license license:gpl3+)))
+(define-public gp-saml-gui
+ ;; No release.
+ (let ((commit "258f47cdc4a8ed57a1eef16667f6cad0d1cb49b1")
+ (revision "1"))
+ (package
+ (name "gp-saml-gui")
+ (version (git-version "0.0.0" revision commit))
+ (home-page "https://github.com/dlenski/gp-saml-gui")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url home-page)
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0qj2mmi6lfkq5c4v6fbzgriajqc27k9kb1i9k2r776pn5pq14pc3"))))
+ (build-system python-build-system)
+ (arguments
+ (list
+ #:phases
+ #~(modify-phases %standard-phases
+ (add-after 'install 'wrap-program
+ (lambda _
+ (let ((prog (string-append #$output "/bin/gp-saml-gui")))
+ (wrap-program prog
+ `("GUIX_PYTHONPATH" = (,(getenv "GUIX_PYTHONPATH")))
+ `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH"))))))))))
+ (inputs
+ (list bash-minimal
+ python-pygobject
+ python-urllib3
+ python-requests
+ webkitgtk-with-libsoup2))
+ (propagated-inputs
+ (list openconnect))
+ (synopsis "Interactively authenticate to GlobalProtect VPNs that require SAML")
+ (description "This is a helper script to allow you to interactively login
+to a GlobalProtect VPN that uses SAML authentication, so that you can
+subsequently connect with OpenConnect.")
+ (license license:gpl3+))))
+
(define-public gvpe
(package
(name "gvpe")

base-commit: 94ac93042f09b4ba68b7b64ed1feeebd3dab1ea4
--
2.40.1
L
L
Ludovic Courtès wrote on 8 Aug 2023 16:47
Re: bug#64443: [PATCH] gnu: Add gp-saml-gui
(name . Unstable Horse)(address . stable.master@unstable.horse)(address . 64443-done@debbugs.gnu.org)
87pm3xr3p7.fsf_-_@gnu.org
Hello,

Unstable Horse <stable.master@unstable.horse> skribis:

Toggle quote (2 lines)
> * gnu/packages/vpn.scm (gp-saml-gui): New variable.

Applied, thanks!

Ludo’.
Closed
?