Request for merging "mesa-updates" branch

  • Done
  • quality assurance status badge
Details
3 participants
  • ???
  • John Kehayias
  • Christopher Baines
Owner
unassigned
Submitted by
John Kehayias
Severity
normal
J
J
John Kehayias wrote on 30 Jun 2023 17:53
(address . bug-guix@gnu.org)
87o7kx6j62.fsf@protonmail.com
Hello all,

This is a request to merge the recently created "mesa-updates" branch. Currently there are just 2 patches on there, fixing/updating mesa only. The main thing to see is how substitute building goes in case anything breaks, but I'm hoping there isn't anything caused by this update.

I believe the "ruby-team" and "tex-team-next" [1] are ahead in the queue, not sure the timing of where those are. In addition/alternatively, would it make sense to have this branch as a separate build job on Cuirass directly as the "kernel-updates" branch? This would need a build roughly every month or so when mesa puts out a new update, we check for breakages, and then merge to master with substitutes available already.

I wasn't sure if this needs formal blockers in debbugs for the other branch merge requests, let me know!

Thanks,
John


C
C
Christopher Baines wrote on 1 Jul 2023 12:35
(no subject)
(address . control@debbugs.gnu.org)
87v8f3q5pl.fsf@cbaines.net
reassign 64369 guix-patches
thanks
C
C
Christopher Baines wrote on 1 Jul 2023 12:36
Re: bug#64369: Request for merging "mesa-updates" branch
(name . John Kehayias)(address . john.kehayias@protonmail.com)(address . 64369@debbugs.gnu.org)
87r0prq50s.fsf@cbaines.net
John Kehayias via Bug reports for GNU Guix <bug-guix@gnu.org> writes:

Toggle quote (14 lines)
> This is a request to merge the recently created "mesa-updates"
> branch. Currently there are just 2 patches on there, fixing/updating
> mesa only. The main thing to see is how substitute building goes in
> case anything breaks, but I'm hoping there isn't anything caused by
> this update.
>
> I believe the "ruby-team" and "tex-team-next" [1] are ahead in the
> queue, not sure the timing of where those are. In
> addition/alternatively, would it make sense to have this branch as a
> separate build job on Cuirass directly as the "kernel-updates" branch?
> This would need a build roughly every month or so when mesa puts out a
> new update, we check for breakages, and then merge to master with
> substitutes available already.

I think ruby-team should be merged in the next few days. There's quite a
few changes in tex-team-next so that might take a little longer.

QA should start building the branch automatically when ruby-team is
merged, and I've created a specification on ci.guix.gnu.org for
mesa-updates now.

Toggle quote (3 lines)
> I wasn't sure if this needs formal blockers in debbugs for the other
> branch merge requests, let me know!

I've gone ahead and reassigned this issue to guix-patches, rather than
the guix package. It's a very minor distinction, but I think
guix-patches is the right place for this issue.

As for the blocking things, I don't think that's necessary at the
moment.

Thanks,

Chris
-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmSgBRNfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9Xdp8hAAmfiapyqzFaoPaYRnpY5OfdLKt4C+X8o8
X7U9kIrT5dDMx+QYbIIiRhjZOl26JuBtJHIgYJBXTB2mTA6cctrsqY1lX75RVYbb
HzZiFc3FOXFbz4Sg3E3FhRPD5M/1jWC/V79DCyFvCE3u7VCk3+54ByxqveumWJY1
ejubk3oB4mi1YOXNUeq+UeT/BUipBDdvLlr80T3z4m1FBIDa3/pTEb5l287YZ879
ofUSikArQ3K5zV9RuAlrIc389H4Xk2509gqIWjsCwg36T8JGXnNoEHtjhynTULv7
im4uUWcGmxjVsIu/isKiikvRLhzGET3fHASo6SSmnh3x3t0DbdSdtkWmMImU75vu
1XkrMaZr+pDfRRMbxdev5mBGOqfp0C6BAaPT3GMUd6713spKJa7fXdZA1A0YQeQf
ADHpmEfsWlSICI8yxwI6YbMu9C6yldSCLhQ4192OqHvGqcpP1puDsbjtanxvnB8V
eaJYgRJHwiZDMz7KGmXocVmWoztBRNG2jibzFLeTqE4faWBF31XxBWEAhMYm9zKJ
xtvM/4w8g1MhcnSqKPqr4tHFstbhEd2jPlmF5EBbfH865WhsH7eupfzIy1fo0p7d
PO5fnaZq8rjuQ0bjie3wQ1p+ms23GJToWEIllkOgjTfDRPgybcF9/xEhDTyM8lGw
9fAXFQZ6OfI=
=HTUF
-----END PGP SIGNATURE-----

J
J
John Kehayias wrote on 5 Jul 2023 22:04
(name . Christopher Baines)(address . mail@cbaines.net)(address . 64369@debbugs.gnu.org)
87ilayktw4.fsf@protonmail.com
Hi Chris,

On Sat, Jul 01, 2023 at 11:36 AM, Christopher Baines wrote:
Toggle quote (25 lines)
>
> John Kehayias via Bug reports for GNU Guix <bug-guix@gnu.org> writes:
>
>> This is a request to merge the recently created "mesa-updates"
>> branch. Currently there are just 2 patches on there, fixing/updating
>> mesa only. The main thing to see is how substitute building goes in
>> case anything breaks, but I'm hoping there isn't anything caused by
>> this update.
>>
>> I believe the "ruby-team" and "tex-team-next" [1] are ahead in the
>> queue, not sure the timing of where those are. In
>> addition/alternatively, would it make sense to have this branch as a
>> separate build job on Cuirass directly as the "kernel-updates" branch?
>> This would need a build roughly every month or so when mesa puts out a
>> new update, we check for breakages, and then merge to master with
>> substitutes available already.
>
> I think ruby-team should be merged in the next few days. There's quite a
> few changes in tex-team-next so that might take a little longer.
>
> QA should start building the branch automatically when ruby-team is
> merged, and I've created a specification on ci.guix.gnu.org for
> mesa-updates now.
>

Thanks! I've seen it build and looks like good coverage on x86_64 and
i686 at least in raw weather number, though I'm not sure on the QA
branch comparison page it is showing me the correct info. For example,
this shows nothing as broken or still working:

Or is that because Bordeaux hasn't built the branch?

So I'm not sure if anything much broke, but at least a good number of
substitutes are built for x86_64/i686.

Toggle quote (11 lines)
>> I wasn't sure if this needs formal blockers in debbugs for the other
>> branch merge requests, let me know!
>
> I've gone ahead and reassigned this issue to guix-patches, rather than
> the guix package. It's a very minor distinction, but I think
> guix-patches is the right place for this issue.
>
> As for the blocking things, I don't think that's necessary at the
> moment.
>

Sounds good, thanks!

John
?
Re: bug#64738: [PATCH] gnu: Make Mesa use zstd compression for shader cache instead of zlib.
(name . Sigve Sudland)(address . sigve_sudland@hotmail.com)
87o7k6onmw.fsf_-_@envs.net
Toggle quote (6 lines)
>
> gnu: mesa: Enable zstd compression for shader cache.
>
> * gnu/packages/gl.scm (mesa)[inputs]: Add zstd:lib.
> [arguments]: Add '-Dzstd=enabled' to configure-flags.

Pushed to the mesa-updates branch, merging progress tracked in

Thanks.
J
J
John Kehayias wrote on 20 Jul 2023 17:54
Re: bug#64369: Request for merging "mesa-updates" branch
(name . ???)(address . iyzsong@envs.net)
87ilaezigl.fsf_-_@protonmail.com
Hi,

On Thu, Jul 20, 2023 at 06:58 PM, ??? wrote:

Toggle quote (11 lines)
>>
>> gnu: mesa: Enable zstd compression for shader cache.
>>
>> * gnu/packages/gl.scm (mesa)[inputs]: Add zstd:lib.
>> [arguments]: Add '-Dzstd=enabled' to configure-flags.
>
> Pushed to the mesa-updates branch, merging progress tracked in
> https://issues.guix.gnu.org/64369.
>
> Thanks.

I just saw this as the message only went to the bug number. I would not
have merged this yet without checking about build status after the big
texlive updates. I was hoping to avoid a full rebuild so we could merge
to master with substitutes already, after checking post-texlive and the
graft of mesa on master.

However, doesn't seem like Cuirass has picked up this change and hasn't
built yet. Any idea why?

My plan right now was going to be to merge master into mesa-updates, see
what the build status looks like, and then decide from there. If there
were not too many rebuilds (say less than 1000) from the updates on
master, we should be able to go ahead soon. And then start on the next
round of patches/updates for mesa-updates.

On the other hand, if there were lots of rebuilds there are other
patches waiting that should be used also (libdrm, libva if I remember)
as well as ungrafting the change on master. So, preventing waiting and
doing another big rebuild with the changes that have been waiting since
the first build of this branch.

What do people think? My thought right now was to revert this change
(since it rebuilds all of mesa dependents), merge master in, and check
the status. But I'm confused why Cuirass wasn't building..

John
C
C
Christopher Baines wrote on 20 Jul 2023 18:03
(name . John Kehayias)(address . john.kehayias@protonmail.com)
871qh2y2yk.fsf@cbaines.net
John Kehayias <john.kehayias@protonmail.com> writes:

Toggle quote (24 lines)
> Hi,
>
> On Thu, Jul 20, 2023 at 06:58 PM, ??? wrote:
>
>>>
>>> gnu: mesa: Enable zstd compression for shader cache.
>>>
>>> * gnu/packages/gl.scm (mesa)[inputs]: Add zstd:lib.
>>> [arguments]: Add '-Dzstd=enabled' to configure-flags.
>>
>> Pushed to the mesa-updates branch, merging progress tracked in
>> https://issues.guix.gnu.org/64369.
>>
>> Thanks.
>
> I just saw this as the message only went to the bug number. I would not
> have merged this yet without checking about build status after the big
> texlive updates. I was hoping to avoid a full rebuild so we could merge
> to master with substitutes already, after checking post-texlive and the
> graft of mesa on master.
>
> However, doesn't seem like Cuirass has picked up this change and hasn't
> built yet. Any idea why?

Cuirass at ci.guix.gnu.org seems to be having problems noticing new
revisions. At least it's about a day behind for master branch revisions.

Toggle quote (16 lines)
> My plan right now was going to be to merge master into mesa-updates, see
> what the build status looks like, and then decide from there. If there
> were not too many rebuilds (say less than 1000) from the updates on
> master, we should be able to go ahead soon. And then start on the next
> round of patches/updates for mesa-updates.
>
> On the other hand, if there were lots of rebuilds there are other
> patches waiting that should be used also (libdrm, libva if I remember)
> as well as ungrafting the change on master. So, preventing waiting and
> doing another big rebuild with the changes that have been waiting since
> the first build of this branch.
>
> What do people think? My thought right now was to revert this change
> (since it rebuilds all of mesa dependents), merge master in, and check
> the status. But I'm confused why Cuirass wasn't building.

The mesa package wasn't affected by tex-team-next, so unless there are
other inputs to most/all off the packages to which mesa is an input,
there shouldn't be many rebuilds. I'd still rebase or merge master in to
the branch and see what QA says though.

Whether you want to revert this latest commit and try and merge sooner,
or wait for things to be built and merge later is up to you though.
-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmS5XYNfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XfAZxAAo8hQO8CS1TF6C7cHaa/CLeQM9eB7wRYU
rqBQYCI7gSGL/O1xoAzGUOSzz762zZjAKg7zFNAsuX8S5HMovYN0C7OtOqXXj45M
44ZxuGr8ZdRUM6BDQVdEFC3nXg3DJlCuaeVu6m/ZdEq9U3ROB3Z7uTh6fLO3kVK0
CzJDccEa121GGL7AscgCeJ9rrJog78/nvX19Wxlt++HzLZpL/OiW2+kw0BaJsB8Z
LBmthf33haQHswtwHGTO8cwsF6hXV8kyEzKZKR4HvH/FnHrBsUD0gGOlyrAiVzbV
5A0CqX/zECos+oXwq9yyOeECFmTp23Jv6rIZtbCetql9hzTv4Kr6nUVYA1hzxkV9
TAF/V7F4kVApACTngdUs31Qs282rlP2/P/2sOmKBhSo/VFepK/pKre+i0uXivPQE
jb+wsoJW/ofSURvxVZK5I7O837lanSFftZxQv3F1qr+VIulCw//zt4/bCeq+8ufw
4ty/sej4ElN7AirV2eh3z5ygDIBURA6ieJKRXQLaH8UtmxTM7wu6Dd3oZPjI99BQ
9zttu7ceXDn7i3VQg8evBGLYnSzWUd27PHZn97EmQoB+AdSkZQh0T0/bBw6Yd3pU
4QuHN1Ex+/+pIClNSLXwAm/YCXw0pNzT08Pavo8NABJMl73Da3y1SuaDcJLNLKax
Jgx3wLfpKQw=
=DJIm
-----END PGP SIGNATURE-----

J
J
John Kehayias wrote on 20 Jul 2023 18:23
(name . Christopher Baines)(address . mail@cbaines.net)
87h6pyzh4s.fsf@protonmail.com
Hi Chris,

On Thu, Jul 20, 2023 at 05:03 PM, Christopher Baines wrote:

Toggle quote (9 lines)
>
> John Kehayias <john.kehayias@protonmail.com> writes:
>> However, doesn't seem like Cuirass has picked up this change and hasn't
>> built yet. Any idea why?
>
> Cuirass at ci.guix.gnu.org seems to be having problems noticing new
> revisions. At least it's about a day behind for master branch revisions.
>

Okay, thanks for the info. So either way will let things build through
the weekend probably.

Toggle quote (22 lines)
>> My plan right now was going to be to merge master into mesa-updates, see
>> what the build status looks like, and then decide from there. If there
>> were not too many rebuilds (say less than 1000) from the updates on
>> master, we should be able to go ahead soon. And then start on the next
>> round of patches/updates for mesa-updates.
>>
>> On the other hand, if there were lots of rebuilds there are other
>> patches waiting that should be used also (libdrm, libva if I remember)
>> as well as ungrafting the change on master. So, preventing waiting and
>> doing another big rebuild with the changes that have been waiting since
>> the first build of this branch.
>>
>> What do people think? My thought right now was to revert this change
>> (since it rebuilds all of mesa dependents), merge master in, and check
>> the status. But I'm confused why Cuirass wasn't building.
>
> The mesa package wasn't affected by tex-team-next, so unless there are
> other inputs to most/all off the packages to which mesa is an input,
> there shouldn't be many rebuilds. I'd still rebase or merge master in to
> the branch and see what QA says though.
>

Right, wasn't sure what the number of rebuilds the texlive updates
caused beyond tex-related stuff, so I didn't want to assume.

Are we able to rebase and then force push on savannah? I thought not,
or is that just for the master branch? If I can force push (I suppose
I could just try later), I would leave off 64738 (zstd in mesa) and
rebase on master. Otherwise I guess revert and merge master to
mesa-updates.

Toggle quote (4 lines)
> Whether you want to revert this latest commit and try and merge sooner,
> or wait for things to be built and merge later is up to you though.
>

Then either way see what rebuilding looks like. If there isn't much
I'd opt for going sooner while we have substitutes already and then
gather these other patches for the next merge. Likely waiting for a
new mesa update which is probably due very soon. But if things will be
rebuilding a lot anyway, I might as well get all these other related
changes in to just build once.

Thanks Chris, I'll see what to do and keep an eye on the builds.

John
C
C
Christopher Baines wrote on 20 Jul 2023 19:04
(name . John Kehayias)(address . john.kehayias@protonmail.com)(address . 64369@debbugs.gnu.org)
87wmyuwm1q.fsf@cbaines.net
John Kehayias <john.kehayias@protonmail.com> writes:

Toggle quote (6 lines)
> Are we able to rebase and then force push on savannah? I thought not,
> or is that just for the master branch? If I can force push (I suppose
> I could just try later), I would leave off 64738 (zstd in mesa) and
> rebase on master. Otherwise I guess revert and merge master to
> mesa-updates.

Not directly, but you can delete the branch and then just push as if it
is a new branch to effectively force push.
-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmS5aWFfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XdJjQ/9Eln5Qqe7ENO9lHPyOTcq0VZB0eY6H7Le
fnbHDr7NKgky/zoGo+r3pUNJvbfd9Tn5JlQqVcc/OkntxI/ZaQgLPmOZCEn0t7WB
LgYcIqPwlyoVzhskmtFGCNPD3jp+qlKfPaTAQ8oeZmhuOoKc9uuMOHv3b5RKnY0i
ZZ6Y73sojBXBmS+oliYRcsncZdtdKz4fIhNsEAfxXc0vimETi33TqhuV2tVV5sxC
wGgzkW8Mp+kVYrc12Fyya6cHd1B96SIXntHyAK3xpfnEyvavie6Lsed4NpZb0ox4
HLa4Pdl6DCOEOH15BZkh4oXjGnlX6u3AXhnvFoW/snlYSgUnxgH7LWDnKkheBuBI
EzgQRWkZLvvneR32Bwvk9DNW6OjUhKkvFV4qOM4wJeOiDL0GyuaGq5eqXzosDnty
V3z2tMd6keVQaUXTOjV9TCzdEakijjn6+hf6ENQTAsUJCUkwXeyhI1unKZhDBzhM
hcX5zKDZRJoJ9iI/SK6/K70xELXuO/cimfhzNdRLpY7kx0enciFbS91+wD6sKnmg
mGEAhj+Dn8507/Ik6pmWQnDHosfzwoIfOaIhBpPSZ6AnulZ3Q6ru88KWty5Jiepx
Iq3naiYeTqeC3/PUZ+p0jxVU1DqbRmpeQHbQVDCFumSe+j2xh2k3xmQ2Mwa+U3vO
jAKZ07Dt82k=
=soF7
-----END PGP SIGNATURE-----

J
J
John Kehayias wrote on 20 Jul 2023 21:24
(name . Christopher Baines)(address . mail@cbaines.net)(address . 64369@debbugs.gnu.org)
87fs5iz8s2.fsf@protonmail.com
On Thu, Jul 20, 2023 at 06:04 PM, Christopher Baines wrote:

Toggle quote (13 lines)
>
> John Kehayias <john.kehayias@protonmail.com> writes:
>
>> Are we able to rebase and then force push on savannah? I thought not,
>> or is that just for the master branch? If I can force push (I suppose
>> I could just try later), I would leave off 64738 (zstd in mesa) and
>> rebase on master. Otherwise I guess revert and merge master to
>> mesa-updates.
>
> Not directly, but you can delete the branch and then just push as if it
> is a new branch to effectively force push.
>

Gotcha. That's what I did to rebase on master as of now. Let's see
what happens with the build and go from there.

Thanks!
J
J
John Kehayias wrote on 24 Jul 2023 17:14
(name . John Kehayias)(address . john.kehayias@protonmail.com)
87bkg1z6ih.fsf@protonmail.com
On Thu, Jul 20, 2023 at 03:23 PM, John Kehayias wrote:

Toggle quote (20 lines)
> On Thu, Jul 20, 2023 at 06:04 PM, Christopher Baines wrote:
>
>>
>> John Kehayias <john.kehayias@protonmail.com> writes:
>>
>>> Are we able to rebase and then force push on savannah? I thought not,
>>> or is that just for the master branch? If I can force push (I suppose
>>> I could just try later), I would leave off 64738 (zstd in mesa) and
>>> rebase on master. Otherwise I guess revert and merge master to
>>> mesa-updates.
>>
>> Not directly, but you can delete the branch and then just push as if it
>> is a new branch to effectively force push.
>>
>
> Gotcha. That's what I did to rebase on master as of now. Let's see
> what happens with the build and go from there.
>
> Thanks!

I'm not sure what is going on with the CI and QA.
https://ci.guix.gnu.org/ hasn't shown any new evaluations in several
days (the workers were stuck at some point too, but nckx gave it a
poke and now I don't see any builds left). But when I check with guix
weather I do get substitutes. Any ideas what the actual status is?

Thanks,
John
J
J
John Kehayias wrote on 28 Jul 2023 17:29
(address . 64369@debbugs.gnu.org)(name . Christopher Baines)(address . mail@cbaines.net)
87cz0chx5k.fsf_-_@protonmail.com
Hello,

On Mon, Jul 24, 2023 at 03:14 PM, John Kehayias wrote:

Toggle quote (7 lines)
> I'm not sure what is going on with the CI and QA.
> <https://ci.guix.gnu.org/> hasn't shown any new evaluations in several
> days (the workers were stuck at some point too, but nckx gave it a
> poke and now I don't see any builds left). But when I check with guix
> weather I do get substitutes. Any ideas what the actual status is?
>

Things got unstuck recently at ci.guix.gnu.org was churning away. I saw
some failed builds due to what looks like some build farm download
fine locally. I think this is what blocked a bunch of KDE-related
packages as well. A bunch of java packages also failed but the ones I
tried also built locally (some had long build logs but I didn't see the
cause).

So I think x86 is okay, while e.g. aarch64 is slowly chipping away.

If that's okay then I'll cherry pick the commits to master today or
tomorrow.

Thanks for your help Chris!
J
J
John Kehayias wrote on 31 Jul 2023 17:24
(address . 64369-done@debbugs.gnu.org)(name . Christopher Baines)(address . mail@cbaines.net)
871qgohznx.fsf_-_@protonmail.com
On Fri, Jul 28, 2023 at 03:29 PM, John Kehayias wrote:

Toggle quote (26 lines)
> Hello,
>
> On Mon, Jul 24, 2023 at 03:14 PM, John Kehayias wrote:
>
>> I'm not sure what is going on with the CI and QA.
>> <https://ci.guix.gnu.org/> hasn't shown any new evaluations in several
>> days (the workers were stuck at some point too, but nckx gave it a
>> poke and now I don't see any builds left). But when I check with guix
>> weather I do get substitutes. Any ideas what the actual status is?
>>
>
> Things got unstuck recently at ci.guix.gnu.org was churning away. I saw
> some failed builds due to what looks like some build farm download
> issue, e.g. <https://ci.guix.gnu.org/build/1671444/details> which build
> fine locally. I think this is what blocked a bunch of KDE-related
> packages as well. A bunch of java packages also failed but the ones I
> tried also built locally (some had long build logs but I didn't see the
> cause).
>
> So I think x86 is okay, while e.g. aarch64 is slowly chipping away.
>
> If that's okay then I'll cherry pick the commits to master today or
> tomorrow.
>
> Thanks for your help Chris!

Pushed to master with 4f0ce65b74a3d28bf6ecbe4c15052dd0de22b284 the final
commit from that branch.

Thanks!

(I'll delete the remote branch for now, until needed again.)
Closed
?