[PATCH] gnu: emacs-piem: Update to 0.5.0.

Done

Details

3 participants

Andrew Tropin
jlicht
Liliana Marie Prikler

Owner: unassigned

Submitted by: jlicht

Severity: normal

jlicht wrote on 18 Jun 2023 21:38

Recipients:(address . guix-patches@gnu.org)(name . Jelle Licht)(address . jlicht@fsfe.org)

Message-ID:97c1eb6e58e07feaef29a1b10eeabb09f870bee1.1687117071.git.jlicht@fsfe.org

* gnu/packages/emacs-xyz.scm (emacs-piem): Update to 0.5.0.

[propagated-inputs]: Add emacs-debbugs.

---

gnu/packages/emacs-xyz.scm | 7 ++++---

1 file changed, 4 insertions(+), 3 deletions(-)

Toggle diff (36 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f46af73aec..08ec87b94c 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -8337,7 +8337,7 @@ (define-public emacs-debbugs
 (define-public emacs-piem
   (package
     (name "emacs-piem")
-    (version "0.4.0")
+    (version "0.5.0")
     (source
      (origin
        (method git-fetch)
@@ -8346,7 +8346,7 @@ (define-public emacs-piem
              (commit (string-append "v" version))))
        (file-name (string-append name "-" version "-checkout"))
        (sha256
-        (base32 "0wr6n6wvznngjdp4c0pmdr4xz05dark0kxi5svzhzxsg3rdaql3z"))))
+        (base32 "0smdb1iph2q1xvxix5c93llckcxh7kmhg6pxgyrm88j736m4l16q"))))
     (build-system emacs-build-system)
     (arguments
      (list #:phases
@@ -8359,7 +8359,8 @@ (define-public emacs-piem
     (inputs
      (list b4))
     (propagated-inputs
-     (list emacs-elfeed
+     (list emacs-debbugs
+           emacs-elfeed
            emacs-notmuch))
     (home-page "https://docs.kyleam.com/piem")
     (synopsis "Glue for working with public-inbox archives")

base-commit: 726f2a944730a1edbdbebfe57fb9e7e0ba47d83e
-- 
2.40.1

Andrew Tropin wrote on 19 Jun 2023 15:44

Recipients:

Message-ID:87fs6ntvle.fsf@trop.in

On 2023-06-18 21:38, jlicht@fsfe.org wrote:

Toggle quote (44 lines)> From: Jelle Licht <jlicht@fsfe.org>
>
> * gnu/packages/emacs-xyz.scm (emacs-piem): Update to 0.5.0.
> [propagated-inputs]: Add emacs-debbugs.
> ---
>
>  gnu/packages/emacs-xyz.scm | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index f46af73aec..08ec87b94c 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -8337,7 +8337,7 @@ (define-public emacs-debbugs
>  (define-public emacs-piem
>    (package
>      (name "emacs-piem")
> -    (version "0.4.0")
> +    (version "0.5.0")
>      (source
>       (origin
>         (method git-fetch)
> @@ -8346,7 +8346,7 @@ (define-public emacs-piem
>               (commit (string-append "v" version))))
>         (file-name (string-append name "-" version "-checkout"))
>         (sha256
> -        (base32 "0wr6n6wvznngjdp4c0pmdr4xz05dark0kxi5svzhzxsg3rdaql3z"))))
> +        (base32 "0smdb1iph2q1xvxix5c93llckcxh7kmhg6pxgyrm88j736m4l16q"))))
>      (build-system emacs-build-system)
>      (arguments
>       (list #:phases
> @@ -8359,7 +8359,8 @@ (define-public emacs-piem
>      (inputs
>       (list b4))
>      (propagated-inputs
> -     (list emacs-elfeed
> +     (list emacs-debbugs
> +           emacs-elfeed
>             emacs-notmuch))
>      (home-page "https://docs.kyleam.com/piem")
>      (synopsis "Glue for working with public-inbox archives")
>
> base-commit: 726f2a944730a1edbdbebfe57fb9e7e0ba47d83e

Hi Jelle!

Thank you very much for the patch.

IMHO, optional dependencies should not be propagated. On user side

installing additional packages is easier than transforming existing

package and removing unneeded propagated deps. Personally, I would

remove all the propagated inputs from piem and let the user install what

he needs for his particular use case.

Liliana, Jelle WDYT?

Best regards,

Andrew Tropin

Jelle Licht wrote on 19 Jun 2023 17:39

Recipients:(name . Liliana Marie Prikler)(address . liliana.prikler@gmail.com)

Message-ID:871qi7xxyz.fsf@fsfe.org

Hi Andrew + peanut gallery,

Andrew Tropin <andrew@trop.in> writes:

Toggle quote (56 lines)> On 2023-06-18 21:38, jlicht@fsfe.org wrote:
>
>> From: Jelle Licht <jlicht@fsfe.org>
>>
>> * gnu/packages/emacs-xyz.scm (emacs-piem): Update to 0.5.0.
>> [propagated-inputs]: Add emacs-debbugs.
>> ---
>>
>>  gnu/packages/emacs-xyz.scm | 7 ++++---
>>  1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
>> index f46af73aec..08ec87b94c 100644
>> --- a/gnu/packages/emacs-xyz.scm
>> +++ b/gnu/packages/emacs-xyz.scm
>> @@ -8337,7 +8337,7 @@ (define-public emacs-debbugs
>>  (define-public emacs-piem
>>    (package
>>      (name "emacs-piem")
>> -    (version "0.4.0")
>> +    (version "0.5.0")
>>      (source
>>       (origin
>>         (method git-fetch)
>> @@ -8346,7 +8346,7 @@ (define-public emacs-piem
>>               (commit (string-append "v" version))))
>>         (file-name (string-append name "-" version "-checkout"))
>>         (sha256
>> -        (base32 "0wr6n6wvznngjdp4c0pmdr4xz05dark0kxi5svzhzxsg3rdaql3z"))))
>> +        (base32 "0smdb1iph2q1xvxix5c93llckcxh7kmhg6pxgyrm88j736m4l16q"))))
>>      (build-system emacs-build-system)
>>      (arguments
>>       (list #:phases
>> @@ -8359,7 +8359,8 @@ (define-public emacs-piem
>>      (inputs
>>       (list b4))
>>      (propagated-inputs
>> -     (list emacs-elfeed
>> +     (list emacs-debbugs
>> +           emacs-elfeed
>>             emacs-notmuch))
>>      (home-page "https://docs.kyleam.com/piem")
>>      (synopsis "Glue for working with public-inbox archives")
>>
>> base-commit: 726f2a944730a1edbdbebfe57fb9e7e0ba47d83e
>
> Hi Jelle!
>
> Thank you very much for the patch.
>
> IMHO, optional dependencies should not be propagated.  On user side
> installing additional packages is easier than transforming existing
> package and removing unneeded propagated deps.  Personally, I would
> remove all the propagated inputs from piem and let the user install what
> he needs for his particular use case.

I'm of two minds, both for this particular patch, and the policy in
general. I understand the point you are making, and see the elegance of
offering a clean set of composable parts for users (and downstream) to
compose.

OTOH, it makes getting full-featured (and compiled) packages a chore,
where users or downstream has to pick up the slack. Put another
way; someone somewhere has to make a package variant if you want to
cover all use cases.

It is my understanding the guideline is (/was?) to have packages be
full-featured, and offer a '-minimal' version in cases where it makes
sense (e.g. bootstrapping, less-than-sane dependency graphs). If this
guideline has since changed, or (in this case) the Emacs teams decides
otherwise, that is something I'm obviously fine with. Some practical
tips on how to make byte compilation happen would still be appreciated
in that case :-).

All the best,
- Jelle

Andrew Tropin wrote on 19 Jun 2023 18:32

Recipients:(name . Liliana Marie Prikler)(address . liliana.prikler@gmail.com)

Message-ID:87bkhbtnt1.fsf@trop.in

On 2023-06-19 17:39, Jelle Licht wrote:

Toggle quote (78 lines)> Hi Andrew + peanut gallery,
>
> Andrew Tropin <andrew@trop.in> writes:
>
>> On 2023-06-18 21:38, jlicht@fsfe.org wrote:
>>
>>> From: Jelle Licht <jlicht@fsfe.org>
>>>
>>> * gnu/packages/emacs-xyz.scm (emacs-piem): Update to 0.5.0.
>>> [propagated-inputs]: Add emacs-debbugs.
>>> ---
>>>
>>>  gnu/packages/emacs-xyz.scm | 7 ++++---
>>>  1 file changed, 4 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
>>> index f46af73aec..08ec87b94c 100644
>>> --- a/gnu/packages/emacs-xyz.scm
>>> +++ b/gnu/packages/emacs-xyz.scm
>>> @@ -8337,7 +8337,7 @@ (define-public emacs-debbugs
>>>  (define-public emacs-piem
>>>    (package
>>>      (name "emacs-piem")
>>> -    (version "0.4.0")
>>> +    (version "0.5.0")
>>>      (source
>>>       (origin
>>>         (method git-fetch)
>>> @@ -8346,7 +8346,7 @@ (define-public emacs-piem
>>>               (commit (string-append "v" version))))
>>>         (file-name (string-append name "-" version "-checkout"))
>>>         (sha256
>>> -        (base32 "0wr6n6wvznngjdp4c0pmdr4xz05dark0kxi5svzhzxsg3rdaql3z"))))
>>> +        (base32 "0smdb1iph2q1xvxix5c93llckcxh7kmhg6pxgyrm88j736m4l16q"))))
>>>      (build-system emacs-build-system)
>>>      (arguments
>>>       (list #:phases
>>> @@ -8359,7 +8359,8 @@ (define-public emacs-piem
>>>      (inputs
>>>       (list b4))
>>>      (propagated-inputs
>>> -     (list emacs-elfeed
>>> +     (list emacs-debbugs
>>> +           emacs-elfeed
>>>             emacs-notmuch))
>>>      (home-page "https://docs.kyleam.com/piem")
>>>      (synopsis "Glue for working with public-inbox archives")
>>>
>>> base-commit: 726f2a944730a1edbdbebfe57fb9e7e0ba47d83e
>>
>> Hi Jelle!
>>
>> Thank you very much for the patch.
>>
>> IMHO, optional dependencies should not be propagated.  On user side
>> installing additional packages is easier than transforming existing
>> package and removing unneeded propagated deps.  Personally, I would
>> remove all the propagated inputs from piem and let the user install what
>> he needs for his particular use case.
>
> I'm of two minds, both for this particular patch, and the policy in
> general. I understand the point you are making, and see the elegance of
> offering a clean set of composable parts for users (and downstream) to
> compose.
>
> OTOH, it makes getting full-featured (and compiled) packages a chore,
> where users or downstream has to pick up the slack. Put another
> way; someone somewhere has to make a package variant if you want to
> cover all use cases.
>
> It is my understanding the guideline is (/was?) to have packages be
> full-featured, and offer a '-minimal' version in cases where it makes
> sense (e.g. bootstrapping, less-than-sane dependency graphs). If this
> guideline has since changed, or (in this case) the Emacs teams decides
> otherwise, that is something I'm obviously fine with. Some practical
> tips on how to make byte compilation happen would still be appreciated
> in that case :-).

I think we can do byte/native compilation without propagating deps, so
it's almost ready to consume, but doesn't pollute the profile.

-- 
Best regards,
Andrew Tropin

Liliana Marie Prikler wrote on 19 Jun 2023 20:24

Recipients:

Message-ID:7d98c2ad14fa1e9c9964097e7c9b49387caaef1d.camel@gmail.com

Am Montag, dem 19.06.2023 um 17:44 +0400 schrieb Andrew Tropin:

Toggle quote (11 lines)> Hi Jelle!
> 
> Thank you very much for the patch.
> 
> IMHO, optional dependencies should not be propagated.� On user side
> installing additional packages is easier than transforming existing
> package and removing unneeded propagated deps.� Personally, I would
> remove all the propagated inputs from piem and let the user install
> what he needs for his particular use case.
> 
> Liliana, Jelle WDYT?

s/he needs/they need/

Other than that, I don't really have an opinion, but at the very least

we don't *have* to propagate debbugs, given that users who want to use

that probably already have it. As for why I don't really have an

opinion: I don't know how central the existing propagations are towards

the working of emacs-piem.

That being said, we could always make those inputs regular (which might

be helpful for byte/native-compilation).

Cheers

jlicht wrote on 19 Jun 2023 21:35

[PATCH v2 1/2] gnu: emacs-piem: Do not propagate any inputs.

Recipients:(address . 64155@debbugs.gnu.org)

Message-ID:374d72df7d5150bcd55de15d6b299531c5ec86c6.1687203327.git.jlicht@fsfe.org

* gnu/packages/emacs-xyz.scm (emacs-piem) [propagated-inputs]: Remove, moving

emacs-elfeed and emacs-notmuch to...

[inputs]: ...here.

---

(no changes since v1)

gnu/packages/emacs-xyz.scm | 5 ++---

1 file changed, 2 insertions(+), 3 deletions(-)

Toggle diff (20 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f46af73aec..416656f243 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -8357,9 +8357,8 @@ (define-public emacs-piem
                      ("piem-b4-b4-executable"
                       (search-input-file inputs "/bin/b4"))))))))
     (inputs
-     (list b4))
-    (propagated-inputs
-     (list emacs-elfeed
+     (list b4
+           emacs-elfeed
            emacs-notmuch))
     (home-page "https://docs.kyleam.com/piem")
     (synopsis "Glue for working with public-inbox archives")

base-commit: d884fc9e2efecfba09af4694f5a13ad7fc6f704f
-- 
2.40.1

jlicht wrote on 19 Jun 2023 21:35

[PATCH v2 2/2] gnu: emacs-piem: Update to 0.5.0.

Recipients:(address . 64155@debbugs.gnu.org)

Message-ID:026fd94420a1ba7007dd8aa8f2acea6e18953c31.1687203327.git.jlicht@fsfe.org

* gnu/packages/emacs-xyz.scm (emacs-piem): Update to 0.5.0.

[inputs]: Add emacs-debbugs.

---

(no changes since v1)

gnu/packages/emacs-xyz.scm | 5 +++--

1 file changed, 3 insertions(+), 2 deletions(-)

Toggle diff (32 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 416656f243..08d53be8a9 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -8337,7 +8337,7 @@ (define-public emacs-debbugs
 (define-public emacs-piem
   (package
     (name "emacs-piem")
-    (version "0.4.0")
+    (version "0.5.0")
     (source
      (origin
        (method git-fetch)
@@ -8346,7 +8346,7 @@ (define-public emacs-piem
              (commit (string-append "v" version))))
        (file-name (string-append name "-" version "-checkout"))
        (sha256
-        (base32 "0wr6n6wvznngjdp4c0pmdr4xz05dark0kxi5svzhzxsg3rdaql3z"))))
+        (base32 "0smdb1iph2q1xvxix5c93llckcxh7kmhg6pxgyrm88j736m4l16q"))))
     (build-system emacs-build-system)
     (arguments
      (list #:phases
@@ -8358,6 +8358,7 @@ (define-public emacs-piem
                       (search-input-file inputs "/bin/b4"))))))))
     (inputs
      (list b4
+           emacs-debbugs
            emacs-elfeed
            emacs-notmuch))
     (home-page "https://docs.kyleam.com/piem")
-- 
2.40.1

Andrew Tropin wrote on 20 Jun 2023 05:23

Recipients:

Message-ID:87ilbi4y15.fsf@trop.in

On 2023-06-19 21:35, jlicht@fsfe.org wrote:

Toggle quote (43 lines)> From: Jelle Licht <jlicht@fsfe.org>
>
> * gnu/packages/emacs-xyz.scm (emacs-piem): Update to 0.5.0.
> [inputs]: Add emacs-debbugs.
>
> ---
>
> (no changes since v1)
>
>  gnu/packages/emacs-xyz.scm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 416656f243..08d53be8a9 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -8337,7 +8337,7 @@ (define-public emacs-debbugs
>  (define-public emacs-piem
>    (package
>      (name "emacs-piem")
> -    (version "0.4.0")
> +    (version "0.5.0")
>      (source
>       (origin
>         (method git-fetch)
> @@ -8346,7 +8346,7 @@ (define-public emacs-piem
>               (commit (string-append "v" version))))
>         (file-name (string-append name "-" version "-checkout"))
>         (sha256
> -        (base32 "0wr6n6wvznngjdp4c0pmdr4xz05dark0kxi5svzhzxsg3rdaql3z"))))
> +        (base32 "0smdb1iph2q1xvxix5c93llckcxh7kmhg6pxgyrm88j736m4l16q"))))
>      (build-system emacs-build-system)
>      (arguments
>       (list #:phases
> @@ -8358,6 +8358,7 @@ (define-public emacs-piem
>                        (search-input-file inputs "/bin/b4"))))))))
>      (inputs
>       (list b4
> +           emacs-debbugs
>             emacs-elfeed
>             emacs-notmuch))
>      (home-page "https://docs.kyleam.com/piem")

It looks good to me!

Best regards,

Andrew Tropin

Jelle Licht wrote on 20 Jun 2023 21:10

Recipients:(name . Liliana Marie Prikler)(address . liliana.prikler@gmail.com)

Message-ID:87wmzyj6fl.fsf@fsfe.org

Andrew Tropin <andrew@trop.in> writes:

Toggle quote (2 lines)

> It looks good to me!

Pushed to master, thanks for the reviews!

- Jelle

Closed

Your comment

This issue is archived.

To comment on this conversation send an email to 64155@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 64155

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date