Unable to build proot-static locally

Done

Details

3 participants

André A. Gomes
André A. Gomes
Josselin Poiret

Owner: unassigned

Submitted by: André A. Gomes

Severity: normal

Merged with

63284

André A. Gomes wrote on 9 May 2023 20:05

Recipients:(address . bug-guix@gnu.org)

Message-ID:878rdxcrd0.fsf@gmail.com

Hello Guix,

I'm unable to build proot-static locally. The build job seems to idle

for many hours and never succeeds.

Notice that this critical, since guix pack relies on this package.

Toggle snippet (6 lines)

guix a759cbf

repository URL: https://git.savannah.gnu.org/git/guix.git

branch: master

commit: a759cbffafbf67b3a03c80b5bdbe3f3478affc50

Thank you!

André A. Gomes

"You cannot even find the ruins..."

André A. Gomes wrote on 9 May 2023 20:36

(no subject)

Recipients:(address . 63394@debbugs.gnu.org)

Message-ID:874jolcpx0.fsf@gmail.com

Hi Guix,

I was able to build it with the patch attached.

As you can see I've disabled the tests. When they run, it seems that

they idle. See the output below.

Toggle snippet (136 lines)starting phase `check'
make: Entering directory '/tmp/guix-build-proot-static-5.3.1.drv-0/source/test'
which: no valgrind in (/gnu/store/6vxk0i5j9w8mik4l6gx3cbw33f9x4l24-which-2.21/bin:/gnu/store/b77adgjdr4agkxmkr59bxqs3biir1cw0-util-linux-2.37.4/bin:/gnu/store/b77adgjdr4agkxmkr59bxqs3biir1cw0-util-linux-2.37.4/sbin:/gnu/store/yr39rh6wihd1wv6gzf7w4w687dwzf3vb-coreutils-9.1/bin:/gnu/store/jz5dwdxq4di29cd0rjjzkw356dhkzjil-pkg-config-0.29.2/bin:/gnu/store/y9ps2ad7m63h28c08bl6nqjrhbf0nlql-python-docutils-0.19/bin:/gnu/store/sxx22f98vfbavcqmdksm6as8fvskpxiw-tar-1.34/bin:/gnu/store/x24bm49ag5dvki72mjdz195bfb89nrnb-gzip-1.12/bin:/gnu/store/j8wlfmlmfvpbza6is9wv9xsd8psrxn00-bzip2-1.0.8/bin:/gnu/store/gr0sy0m1mv36qv54idm6cn10l3mngshq-file-5.44/bin:/gnu/store/zmcf5kpqiighkbh7wslf91qdjwj06yr1-diffutils-3.8/bin:/gnu/store/210yfax18r2g2inxrml9435ikhfcca6m-patch-2.7.6/bin:/gnu/store/c8jyph2lxw0m9na34fg8h70n4nnnz7is-findutils-4.9.0/bin:/gnu/store/hc05d76f1j3iz3v2bs5jz4fpljl1r4dj-gawk-5.2.1/bin:/gnu/store/xxcfsimvxz7z4dj593gnqbkzc6picwzq-sed-4.8/bin:/gnu/store/yrv5f70mn83a876b78i5s79dd2hsh0zf-grep-3.8/bin:/gnu/store/6k1yys9wqrfn4y41ic1win8gpnimncwj-xz-5.2.8/bin:/gnu/store/a5i8avx826brw5grn3n4qv40g514505c-coreutils-9.1/bin:/gnu/store/wj7casda7rb55rvqjnpm0bm7a2zm6618-make-4.3/bin:/gnu/store/rib9g2ig1xf3kclyl076w28parmncg4k-bash-minimal-5.1.16/bin:/gnu/store/na1dpbbcxjaa3n8wkwrfpch476f90hlf-ld-wrapper-0/bin:/gnu/store/zh4x65snfis7svs6906gj1z8i7dx2j3m-binutils-2.38/bin:/gnu/store/5lqhcv91ijy82p92ac6g5xw48l0lwwz4-gcc-11.3.0/bin:/gnu/store/gsjczqir1wbz8p770zndrpw4rnppmxi3-glibc-2.35/bin:/gnu/store/gsjczqir1wbz8p770zndrpw4rnppmxi3-glibc-2.35/sbin:/bin)
gcc     test-sysexit.c   -o test-sysexit
  CHECK	test-16573e73 ok
  CHECK	test-1ffc8309 ok
  CHECK	test-16573e73 ok
  CHECK	test-5bed7141 FAILED
  CHECK	test-5bed7143 ok
  CHECK	test-5bed7143 ok
  CHECK	test-82ba4ba1 ok
  CHECK	test-9c07fad8 ok
  CHECK	test-82ba4ba1 ok
  CHECK	test-bdc90417 ok
  CHECK	test-c5a7a0f0 ok
  CHECK	test-fa205b56 skipped
  CHECK	test-c5a7a0f0 ok
  CHECK	test-fdf487a0 ok
  CHECK	test-iiiiiiii ok
  CHECK	test-sysexit ok
  CHECK	test-0830d8a8 skipped
  CHECK	test-00000000 ok
  CHECK	test-0238c7f1 ok
  CHECK	test-1cd9d8f9 ok
  CHECK	test-1743dd3d ok
  CHECK	test-1ffc8309 ok
  CHECK	test-230f47ch skipped
  CHECK	test-2db65cd2 skipped
  CHECK	test-03969e70 ok
  CHECK	test-071599da ok
  CHECK	test-0228fbe7 ok
  CHECK	test-22222222 ok
  CHECK	test-3dec4597 ok
  CHECK	test-305ae31d ok
  CHECK	test-092c5e26 ok
  CHECK	test-3624be91 ok
  CHECK	test-311b7a95 ok
  CHECK	test-517e1d6b ok
  CHECK	test-55fd1da5 ok
  CHECK	test-5996858d skipped
  CHECK	test-55b731d3 ok
  CHECK	test-53355a5b ok
  CHECK	test-67972fbe skipped
  CHECK	test-691786c8 skipped
  CHECK	test-1fedd9a3 ok
  CHECK	test-6d1e2650 ok
  CHECK	test-5bed7142 ok
  CHECK	test-6fb08ce1 ok
  CHECK	test-82ba4ba1 skipped
  CHECK	test-7601199b ok
  CHECK	test-5467b986 ok
  CHECK	test-8a83376a skipped
  CHECK	test-517e1d6a ok
  CHECK	test-9f5eeb72 skipped
  CHECK	test-6b5a254a ok
  CHECK	test-b161bc0a ok
  CHECK	test-2401b850 ok
  CHECK	test-b94dd86a ok
  CHECK	test-713b6910 ok
  CHECK	test-a4d7ed70 ok
  CHECK	test-c15999f9 ok
  CHECK	test-c68d18dc skipped
  CHECK	test-b6df3cbe ok
  CHECK	test-654decce ok
  CHECK	test-careexit skipped
  CHECK	test-carehwcp skipped
  CHECK	test-careauth skipped
  CHECK	test-carequot skipped
  CHECK	test-c6b77b77 ok
  CHECK	test-aaaaaaaa ok
  CHECK	test-8e5fa256 ok
  CHECK	test-chroot01 ok
  CHECK	test-bbbbbbbb ok
  CHECK	test-cccccccc ok
  CHECK	test-d1da0d8d ok
  CHECK	test-d1be631a ok
  CHECK	test-99999999 ok
  CHECK	test-d2175fc3 ok
  CHECK	test-df4de4db skipped
  CHECK	test-cea75343 ok
  CHECK	test-d92b57ca ok
  CHECK	test-docker skipped
  CHECK	test-de756935 ok
  CHECK	test-e87ca6ca skipped
  CHECK	test-commmmmm ok
  CHECK	test-eddeba0e ok
  CHECK	test-f7089d4f skipped
  CHECK	test-e99993c8 ok
  CHECK	test-fbca9cc2 skipped
  CHECK	test-getres32 skipped
  CHECK	test-dddddddd ok
  CHECK	test-e940896f ok
  CHECK	test-ffffffff ok
  CHECK	test-cb1143ab ok
  CHECK	test-hhhhhhhh skipped
  CHECK	test-killexit ok
  CHECK	test-gggggggg ok
  CHECK	test-proocare skipped
  CHECK	test-dfb0c3b6 ok
  CHECK	test-mmmmmmmm ok
  CHECK	test-pppppppp ok
  CHECK	test-getresid ok
  CHECK	test-rrrrrrrr ok
  CHECK	test-python01 ok
  CHECK	test-1c68c218 ok
  CHECK	test-305ae31d ok
  CHECK	test-ptrace-exec-trap ok
  CHECK	test-33333334 ok
  CHECK	test-44444444 ok
  CHECK	test-wwwwwwww ok
  CHECK	test-51943658 ok
  CHECK	test-tempdire ok
  CHECK	test-66666666 ok
  CHECK	test-79cf6614 ok
  CHECK	test-88888888 ok
  CHECK	test-a8e69d6f ok
  CHECK	test-af062114 ok
  CHECK	test-c10e2073 ok
  CHECK	test-bug-138 ok
  CHECK	test-d2175fc4 ok
  CHECK	test-nnnnnnnn ok
  CHECK	test-ptrace00 ok
  CHECK	test-ptrace01 ok
  CHECK	test-yyyyyyyy ok
  CHECK	test-ssssssss ok
  CHECK	test-xxxxxxxx ok
  CHECK	test-oooooooo ok
  CHECK	test-e87b34ae ok
  CHECK	test-11111111 ok
  CHECK	test-33333333 ok
  CHECK	test-kkkkkkkk ok
  CHECK	test-cdd39012 ok
  CHECK	test-gdb-ptrace ok

-- 
André A. Gomes
"You cannot even find the ruins..."

From b1046b937fd4b15ff7a78cc725c300694271e5ed Mon Sep 17 00:00:00 2001

* gnu/packages/linux.scm (proot): Update to 5.3.1.

---

gnu/packages/linux.scm | 11 +++--------

1 file changed, 3 insertions(+), 8 deletions(-)

Toggle diff (37 lines)diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index ea64e9d241..acb8cd66e1 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -8143,7 +8143,7 @@ (define-public ulogd
 (define-public proot
   (package
     (name "proot")
-    (version "5.3.0")
+    (version "5.3.1")
     (source
      (origin
        (method git-fetch)
@@ -8152,19 +8152,14 @@ (define-public proot
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "1r1ga3xbwq5kx4i8ihj1p6nmgaa14lfkwxzpsbdcmfh1jimpbmzk"))))
+        (base32 "18455hni05nn3jyy8qfk1xwx0rd6s1qn9np1b61hkfb36b0gbpdq"))))
     (build-system gnu-build-system)
     ;; Many architectures are not supported (see:
     ;; https://github.com/proot-me/proot/blob/master/src/arch.h#L51).
     (supported-systems '("x86_64-linux" "i686-linux"
                          "armhf-linux" "aarch64-linux" "i586-gnu"))
     (arguments
-     ;; Disable the test suite on armhf-linux, as there are too many
-     ;; failures to keep track of (see for example:
-     ;; https://github.com/proot-me/proot/issues/286).
-     `(#:tests? ,(not (or (%current-target-system)
-                          (string-prefix? "armhf"
-                                          (or (%current-system)))))
+     `(#:tests? #f
        #:make-flags '("-C" "src")
        #:phases (modify-phases %standard-phases
                   (add-after 'unpack 'patch-sources
-- 
2.39.2

Josselin Poiret wrote on 9 May 2023 20:43

Recipients:

Message-ID:87r0rp4a7f.fsf@jpoiret.xyz

merge 63394 63284

thankyou

Hi André,

André A. Gomes <andremegafone@gmail.com> writes:

Toggle quote (7 lines)

> Hi Guix,

> I was able to build it with the patch attached.

> As you can see I've disabled the tests. When they run, it seems that

> they idle. See the output below.

See [1] for more information. One of the tests failing is actually

indicative of a regression in proot I think, so this is why we haven't

gotten around to fixing it yet.

[1] https://issues.guix.gnu.org/63284

Best,

Josselin Poiret

André A. Gomes wrote on 29 May 2023 15:04

guix pack and proot

Recipients:(address . 63394@debbugs.gnu.org)

Message-ID:87ttvvi8zo.fsf@atlas.engineer

Hi Guix,

I acknowledge the answers provided, but I'd like to emphasize that guix

pack won't run if proot is broken. This is a critical issue and a

temporary solution is simple enough: disable the tests for the current

proot version packaged.

Please check the patch attached.

André A. Gomes

Atlas Engineer - https://atlas.engineer/

From 1c9ece50575f568c824be2274b7b4d874827f0bb Mon Sep 17 00:00:00 2001

---

gnu/packages/linux.scm | 9 +++------

1 file changed, 3 insertions(+), 6 deletions(-)

Toggle diff (22 lines)diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 1be505d949..01f809d980 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -8212,12 +8212,9 @@ (define-public proot
     (supported-systems '("x86_64-linux" "i686-linux"
                          "armhf-linux" "aarch64-linux" "i586-gnu"))
     (arguments
-     ;; Disable the test suite on armhf-linux, as there are too many
-     ;; failures to keep track of (see for example:
-     ;; https://github.com/proot-me/proot/issues/286).
-     `(#:tests? ,(not (or (%current-target-system)
-                          (string-prefix? "armhf"
-                                          (or (%current-system)))))
+     ;; Temporarily disable the tests until https://issues.guix.gnu.org/63284
+     ;; is solved.
+     `(#:tests? #f
        #:make-flags '("-C" "src")
        #:phases (modify-phases %standard-phases
                   (add-after 'unpack 'patch-sources
-- 
2.39.2

Josselin Poiret wrote on 31 May 2023 19:20

Recipients:

Message-ID:87h6rsquyj.fsf@jpoiret.xyz

Hi André,

André A. Gomes <andre@atlas.engineer> writes:

Toggle quote (7 lines)

> Hi Guix,

> I acknowledge the answers provided, but I'd like to emphasize that guix

> pack won't run if proot is broken. This is a critical issue and a

> temporary solution is simple enough: disable the tests for the current

> proot version packaged.

As I mentioned above, disabling the tests is not a solution here, since
one of the tests failing is *actually* indicative of a regression in
PRoot, and we should not ignore it.  Specifically, it seems the
interaction between pthreads and current working directory sandboxing
isn't working IIRC.  I haven't heard back from upstream, I might have a
look at some point but I have no familiarity whatsoever with its
codebase (and I guess it's using some nasty tricks that will take some
time to understand).

Best,
-- 
Josselin Poiret

Josselin Poiret wrote on 4 Jun 2023 11:39

Re: [bug#63843] [PATCH] gnu: proot: Skip failing test.

Recipients:

Message-ID:87edmrefcm.fsf@jpoiret.xyz

merge 63843 63394

close 63394

thankyou

Hi Ontje,

<Ontje.Luensdorf@dlr.de> writes:

Toggle quote (6 lines)

> Hi,

> this disables a failing proot test to fix guix pack -RR. The issue has

> already been reported upstream (see comment).

This is fixed by b741218e919bfd386772322c1dcb286446bc4c90.  Note that
disabling the tests here was a bad idea, as the upstream issue
indicated: this was a regression.

Best,
-- 
Josselin Poiret

Your comment

This issue is archived.

To comment on this conversation send an email to 63394@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 63394

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date