quodlibet fails to build after python 3.10 update

  • Done
  • quality assurance status badge
Details
4 participants
  • Alice BRENON
  • Efraim Flashner
  • Remco van 't Veer
  • Zack Weinberg
Owner
unassigned
Submitted by
Zack Weinberg
Severity
normal
Z
Z
Zack Weinberg wrote on 1 May 2023 15:48
(address . bug-guix@gnu.org)
4d65908d-97c3-4f57-bc51-da8f58e43f1c@app.fastmail.com
After the core-updates merge (specifically after the bump to python 3.10, I would guess) quodlibet's testsuite has one failing test and therefore the package fails to build:

=================================== FAILURES ===================================
_______________________ TCoverManager.test_invalid_glob ________________________
tests/test_util_cover.py:111: in test_invalid_glob
os.path.abspath(self._find_cover(self.song).name), f)
E AttributeError: 'NoneType' object has no attribute 'name'
=========================== short test summary info ============================
FAILED tests/test_util_cover.py::TCoverManager::test_invalid_glob - Attribute...
===== 1 failed, 3257 passed, 53 skipped, 139 warnings in 90.85s (0:01:30) ======

Full build log is attached.

$ guix describe
Generation 19 May 01 2023 08:59:02 (current)
guix 0c6a7e1
branch: master
commit: 0c6a7e1045cbd06336ef3699734a803a2e4038e5
Attachment: file
A
A
Alice BRENON wrote on 5 May 2023 15:31
(address . 63205@debbugs.gnu.org)
20230505153142.27a1263f@ens-lyon.fr
This problem seems to have been reported and fixed upstream:


Since no newer release has been out, I guess we can backport the commit itself.
I've tried with the attached patch. The operon tests still fail due to some
weird utime magic, a problem also known and discussed at:


So I guess we could backport that as well. Does anyone have a better fix ?
Attachment: 0001-gnu-quodlibet-Fix-glob-failure-in-quodlibet-tests.patch
A
A
Alice BRENON wrote on 5 May 2023 15:58
(address . 63205@debbugs.gnu.org)
20230505155831.67b54875@ens-lyon.fr
The second patch needs an edit because part of it doesn't apply to the
actual source (4.5.0 doesn't contain 427793aa88fb57 which applied the
@flaky markers to the test). But quodlibet builds again on my machine
with this second patch.

Le Fri, 5 May 2023 15:31:42 +0200,
Alice BRENON <alice.brenon@ens-lyon.fr> a écrit :

Toggle quote (13 lines)
> This problem seems to have been reported and fixed upstream:
>
> https://github.com/quodlibet/quodlibet/commit/5f55431a28509fd4f4f7b40dc246f3d34fa8549e
>
> Since no newer release has been out, I guess we can backport the
> commit itself. I've tried with the attached patch. The operon tests
> still fail due to some weird utime magic, a problem also known and
> discussed at:
>
> https://github.com/quodlibet/quodlibet/pull/4053/commits/06a32b319f065550efe0d2a9ff10ca6bdc32b893
>
> So I guess we could backport that as well. Does anyone have a better
> fix ?
Attachment: 0001-gnu-quodlibet-Fix-failures-in-tests.patch
R
R
Remco van 't Veer wrote on 12 Jun 2023 10:47
quodlibet fails to build after python 3.10 update
(address . guix-devel@gnu.org)
87mt15m5hr.fsf@remworks.net
Hi,

Forgotten patch:


The supplied patch by Alice works and looks good to me. Can somebody
please have a look and consider committing it?

Thanks!

Cheers,
Remco
E
E
Efraim Flashner wrote on 13 Jun 2023 08:48
(name . Remco van 't Veer)(address . remco@remworks.net)
ZIgRI75R01yhCJmB@3900XT
Looks good to me. Patch pushed!

On Mon, Jun 12, 2023 at 10:47:44AM +0200, Remco van 't Veer wrote:
Toggle quote (17 lines)
> Hi,
>
> Forgotten patch:
>
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63205#11
>
> The supplied patch by Alice works and looks good to me. Can somebody
> please have a look and consider committing it?
>
> Thanks!
>
> Cheers,
> Remco
>
>
>

--
Efraim Flashner <efraim@flashner.co.il> ????? ?????
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmSIESMACgkQQarn3Mo9
g1GUvhAAnZSVc2c4t1M5XWzr18A8QmyXj0d9KKljTUo5InF1yCUk2m49TmFBKatN
SYi30tETCgssGpQG+OfFO2RLEA8aaYhmc9I/0stojCHG3dOMAuJ15x5L4gVb3r6/
/YABB2JzxXOQS7BPudgnKPYhwnst/6aVvMevw7IqoScGqb8Q6IuP//tanzWCwZQ8
+ZMOOyDmO0KQp5GysRUIJRF1OFqxVh5gSx7YehALygJkH0a78he/SY4963WxQe77
BFOqNGjE6c2MG9d+vf/j9J9/UsnABLoXEhaXtQIZahccM5zptsQBC9iFMYmJzL++
daalYIjcwssAJpGC7Hmv7V5y/Pj44H79ujinaeGW9s6AJpEU97XLJqYx9Rc/1D+g
wvf+ROO7PmGzdd40covblyfCs06LIlfgfT/rRtm237zbVPwNFGFxhC9zAcWTE9Fy
GiK4Z5g7YHhVuikJfiDzIuozdZ7pCd8WhIm+DYO2voNcEZEsh4/h5nKTpSmDLqv/
m2rqMC74ZAnfKhSld4SC7OZyyS0AZBJi3/nAGmunmcTTZpOO4e1iSG7jwwXw3hJH
/rQGkqORRO7aAzfsVe2Qo7xUhRXLaZCXmR6cOl6g1Rhpqskn1BH+17IkgXADZH5V
BXsG2I74atEIag6J7qTdGvRoyjXdKh5dM3URtmhu9jlP9kB1Li4=
=webx
-----END PGP SIGNATURE-----


Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 63205@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 63205
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch