slim fails to build

  • Done
  • quality assurance status badge
Details
2 participants
  • Julian Flake
  • Ludovic Courtès
Owner
unassigned
Submitted by
Julian Flake
Severity
normal
J
J
Julian Flake wrote on 28 Apr 2023 21:23
(address . bug-guix@gnu.org)
87pm7najrf.fsf@uni-koblenz.de
compilation error is:

/tmp/guix-build-slim-1.3.6.drv-0/slim-1.3.6/panel.cpp: In
constructor ‘Panel::Panel(Display*, int, Window, Cfg*, const
string&, Panel::PanelType)’:
/tmp/guix-build-slim-1.3.6.drv-0/slim-1.3.6/panel.cpp:51:27:
error: ordered comparison of pointer with integer zero (‘GC’ {aka
‘_XGC*’} and ‘int’)
51 | if (WinGC < 0) {
| ~~~~~~^~~
make[2]: *** [CMakeFiles/libslim.dir/build.make:121:
CMakeFiles/libslim.dir/panel.cpp.o] Error 1
L
L
Ludovic Courtès wrote on 30 Apr 2023 23:16
Re: bug#63159: [PATCH 1/2] gnu: slim: Fix build failure with GCC-11
(name . Brian Cully)(address . bjc@spork.org)
875y9doytq.fsf@gnu.org
Hi,

Brian Cully <bjc@spork.org> skribis:

Toggle quote (9 lines)
> GCC-11 sniffed out a long-standing bug where a pointer was being tested for a
> negative value, which is impossible. Instead, check for NULL, which is how the
> error result is actually returned.
>
> See https://github.com/iwamatsu/slim/issues/14 for details.
>
> * gnu/packages/display-managers.scm (slim) [fix-0-pointer-comparison]: new
> phase

[...]

Toggle quote (4 lines)
> Moved to github, according to https://www.berlios.de/software/slim/.
>
> * gnu/packages/display-managers.scm (slim) [home-page]: update URL.

Applied, thanks!

Ludo’.
Closed
?