[PATCH 0/9] Add Easyeffects

I realized there was already a patch for this package here but its a bit

out of date: https://issues.guix.gnu.org/57218

I did not use package-with-c-toolchain method because it seemed to

create some weird module dependency cycle with commencement

that broke compilation, so I just added gcc-11 to inputs.

I had to update a few dependencies to get this working, and we cannot

have the latest version until GTK>=4.10 is in guix. Additionally, serd

has a test suite now but there was an error with test_quiet.py "not

existing" even though it does, so I was left stumped and disabled tests

to avoid going insane.

Also this ends up causing a webkitgtk rebuild. Hope that isn't an issue.

---

gnu/packages/audio.scm | 12 ++++++------

1 file changed, 6 insertions(+), 6 deletions(-)

[build-system]: Use meson.

[arguments]: Enable tests.

---

gnu/packages/audio.scm | 11 ++++-------

1 file changed, 4 insertions(+), 7 deletions(-)

[build-system]: Use meson.

[arguments]: Remove.ldflag hack not needed with meson.

---

gnu/packages/rdf.scm | 23 ++++++++---------------

1 file changed, 8 insertions(+), 15 deletions(-)

[build-system]: Use meson.

[arguments]: Remove.ldflag hack not needed with meson.

---

gnu/packages/rdf.scm | 21 +++++----------------

1 file changed, 5 insertions(+), 16 deletions(-)

[build-system]: Use meson.

---

gnu/packages/audio.scm | 10 +++++-----

1 file changed, 5 insertions(+), 5 deletions(-)

[origin]: Use current upstream repository location.

[arguments]: Use libsamplerate over builtin resampler.

Use guix fftw over bundled version.

[inputs]: Add lv2 plugin support. Add fftw.

[native-search-paths]: Add lv2 nad ladspa search paths.

---

gnu/packages/audio.scm | 46 ++++++++++++++++++++++++------------------

1 file changed, 26 insertions(+), 20 deletions(-)

[build-system]: Use meson.

[arguments]: Remove unnecessary flags

---

gnu/packages/audio.scm | 15 +++++----------

1 file changed, 5 insertions(+), 10 deletions(-)

[build-system]: Use meson.

[arguments]: Remove.ldflag hack not needed with meson.

---

gnu/packages/audio.scm | 13 ++++---------

1 file changed, 4 insertions(+), 9 deletions(-)

---

gnu/packages/audio.scm | 98 ++++++++++++++++++++++++++++++++++++++++++

1 file changed, 98 insertions(+)

Thank you so much for this patch series. It looks good to me. The

biggest problem is the large number of rebuilds, but we can use

ci.guix.gnu.org to build everything with this patch series applied.

I’ll create a new branch “wip-easyeffects-62771” and apply your

(rebased) patches, and then have ci.guix.gnu.org build it for x86_64.

If there are any new failures we should address them first. Once there

are no new failures on x86_64 I’ll update the jobset to build for all

architectures.

Do you think you could keep an eye on the progress at ci.guix.gnu.org?

Minor issues that I’ll take care of before applying the patches:

“[native-search-paths]: Add lv2 nad ladspa search paths.”

--

Ricardo

On Wed, Jan 10, 2024, at 8:40 PM, Ricardo Wurmus wrote:

You're welcome :]

I'm currently transferring at Singapore airport, heading to China. I think I will be busy and not prioritising guix at the moment. For now I'll assist on my my mobile phone by making a TODO list below:

It should be possible to remove the inclusion of gcc-11 as an input now that it is the default.

Update serd to 0.32.0

Update sord to 0.16.16

Update sratom to 0.6.16

Update rubber to 3.3.0

Update lilv to 0.24.22

Update lilv homepage to have .html on the end.

Fix typo in commit: native-search-paths]: Add lv2 nad ladspa search paths

Ricardo Wurmus <rekado@elephly.net> writes:

I’ve rebased the patch set on top of master and took the opportunity to

enable the test suites in lilv, sratom, and serd.

The branch is being built here:

--

Ricardo

"Brendan Tildesley" <mail@brendan.scot> writes:

I’ve done all this and pushed to the wip-easyeffects-62771 branch.

Safe travels!

--

Ricardo

Ricardo Wurmus <rekado@elephly.net> writes:

I just merged it into the master branch.

--

Ricardo