[PATCH 0/2] gnu: geary: Add missing dependency, use g-expressions.

Hello,

It turns out Geary needs `evolution-data-server' to launch. These patches 1. add that as an input; and 2. migrate it to g-expressions.

Thanks,

Juli

Empty Message

Empty Message

Hi Juliana,

"J. Sims" <jtsims@protonmail.com> skribis:

The patches LGTM.

However, in the meantime, the ‘core-updates’ branch was merged and now

‘geary’ fails to build (both before and after applying your patches).

Could you take a look and send a second version?

Thank you and apologies for the delay!

Ludo’.

Hello,

This set of patches will fix Geary's build as well as apply the same changes

mentioned previously. For whatever reason, I had deleted the original

branch I made, so this is a clean patchset.

Let me know if I need to make any changes :)

Thanks,

Juli

[arguments]: Disable failing test.

[native-inputs]: Use older version of vala.

---

gnu/packages/gnome.scm | 7 ++++++-

1 file changed, 6 insertions(+), 1 deletion(-)

---

gnu/packages/gnome.scm | 1 +

1 file changed, 1 insertion(+)

---

gnu/packages/gnome.scm | 69 +++++++++++++++++++++---------------------

1 file changed, 34 insertions(+), 35 deletions(-)

Woops, had a leftover bit of code in there from trying to figure out how to fix

the package build... This version removes that.

[arguments]: Disable failing test.

[native-inputs]: Use older version of vala.

---

gnu/packages/gnome.scm | 6 +++++-

1 file changed, 5 insertions(+), 1 deletion(-)

---

gnu/packages/gnome.scm | 1 +

1 file changed, 1 insertion(+)

---

gnu/packages/gnome.scm | 69 +++++++++++++++++++++---------------------

1 file changed, 34 insertions(+), 35 deletions(-)

Hi Juliana,

Am Sonntag, dem 07.05.2023 um 15:21 -0400 schrieb Juliana Sims:

Possibly stupid question: Don't you need evolution-data-server to build

geary? If so, this patch would need to be squashed on top of the

preceding one.

Cheers

Hi,

Le 7 mai 2023 15:44:22 GMT-04:00, Liliana Marie Prikler <liliana.prikler@gmail.com> a écrit :

No such thing :)

Interestingly, evolution-data-server seems to be a runtime-only dependency. I discovered this when I first installed Geary and found it would not launch - I only figured out the issue because a Debian developer friend had apparently run into the error message it threw and knew the cause. As far as I can tell, not even the Geary git repository itself makes any mention of this - perhaps because it's considered a core part of GNOME? I couldn't say. Regardless, the package does in fact build fine without evolution-data-server.

- Juli

Hi there,

Just wanted to ping this patch thread so it doesn't get forgotten for

too long.

Thanks,

Juli

Hi Juliana,

Am Montag, dem 15.05.2023 um 09:55 -0400 schrieb Juliana Sims:

I still don't understand what exactly we gain or lose from adding

evolution-data-server as an input. Have you looked into that?

Cheers

Hello,

When I submitted the initial patch series, Geary was failing to launch

despite building successfully and being run under a GNOME environment.

Adding evolution-data-server to the profile solved the issue, and given

the lack of indication in the error message that that would resolve the

problem, I thought it would be helpful to add as an input.

However. In attempting to reproduce this problem just now by running a

version of Geary without evolution-data-server as an input or in the

profile, it appears this problem... No longer exists? Which is a bit

bizarre... Regardless, I'm happy to remove evolution-data-server as an

input.

While I'm here, I've noticed there are some inputs in both

native-inputs and inputs; namely, glib, gsettings-desktop-schemas, and

gmime. Do you happen to know if these are likely to actually be

required in both sets of inputs? Removing glib and

gsettings-desktop-schemas from inputs seems not to cause issues - the

program builds and launches fine - but this may simply be because I'm

on GNOME; because these are dependencies of dependencies and thus

exposed in the environment of the package; or it may be that this would

cause issues in specific functionality that isn't tested in the tests

that are run and isn't invoked except in specific situations. I'm not

experienced enough with GNOME applications to know; I mostly just

wanted to be able to read and write my email and my preferred

application for doing so had stopped working XD If you happen to know

if they can be safely removed from one or the other set of inputs, I

would like to minimize the set of inputs; if you don't happen to know,

I'll just leave it alone.

Thanks for asking more about evolution-data-server. I don't know why it

was required before, but it's good to know it's not now; I'll go ahead

and remove the commit adding it from my local branch and send up a new

patch set when you get back to me.

- Juli

Am Montag, dem 15.05.2023 um 21:36 -0400 schrieb Juliana Sims:

It is true that Geary, like Evolution, needs a running Evolution Data

Server to function correctly. However, this dependency is most often

met by adding evolution-data-server to the operating-system packages,

as not doing so causes other evolution-data-server-related issues IIRC.

It makes a difference for cross-builds, so you would have to check

those. In my personal experience, glib:bin and gobject-introspection

often come up as native inputs in the GNOME world, whereas glib sans

bin, gsettings-desktop-schemas and gmime are mostly regular inputs.

Cheers

Hi,

Le mar, mai 16 2023 at 06:19:13 +0200, Liliana Marie Prikler

<liliana.prikler@gmail.com> a écrit :

It's probably beyond the scope of this current patch set, but is this

something that should be communicated to users somehow? I would never

have figured out about evolution-data-server if my friend hadn't

recognized the error message. (There are similar situations where other

packages require some non-dependency package to work/use all

functionality, so the solution to this would ideally be bigger than

just Geary and thus out of scope.)

Apparently librsvg is in the dependency graph for Geary, which is a

Rust library, meaning cross builds are not currently an option. So in

addition to removing the commit adding evolution-data-server as an

input, I've added another commit removing the redundant native-input

packages; feel free to simply drop the patch if the patch set looks

good otherwise and this is deemed a frivolous or unnecessary change. I

know dropping these native-inputs doesn't cause any issues because I'm

sending this email using the very Geary package I am about to submit

patches for :D

Anyway, patches incoming!

Thanks,

Juli

[arguments]: Disable failing test.

[native-inputs]: Use older version of vala.

---

gnu/packages/gnome.scm | 6 +++++-

1 file changed, 5 insertions(+), 1 deletion(-)

---

gnu/packages/gnome.scm | 69 +++++++++++++++++++++---------------------

1 file changed, 34 insertions(+), 35 deletions(-)

native-inputs.

---

gnu/packages/gnome.scm | 3 ---

1 file changed, 3 deletions(-)

Am Dienstag, dem 16.05.2023 um 01:10 -0400 schrieb Juliana Sims:

The bigger picture here are services: combinations of packages and

configuration to ensure that "everything" functions as intended.

LGTM, just running some checks and afterwards scheduling for push on

Sunday.

Cheers

G-Expressions.

---

gnu/packages/gnome.scm | 69 +++++++++++++++++++++---------------------

1 file changed, 34 insertions(+), 35 deletions(-)

and gsettings-desktop-schemas.

---

gnu/packages/gnome.scm | 3 ---

1 file changed, 3 deletions(-)

[arguments]<#:phases>: Drop ‘disable-failing-tests’ and ‘generate-vapis’.

Rename ‘disable-postinstall-script’ to ‘skip-gtk-update-icon-cache’ and adjust

accordingly.

[inputs]: Replace folks-with-libsoup2 with folks.

Replace gnome-online-accounts-3.44 with gnome-online-accounts.

Replace webkitgtk-with-libsoup2 with webkitgtk.

[native-inputs]: Replace vala-0.52 with vala.

Add gnutls.

---

Hi Juliana,

1..3/4 have my rewordings for the commit messages, but more importantly,

it turns out that geary can be refreshed to a newer version with fewer

issues to fix :)

Please confirm that this Geary also works for you.

Cheers

gnu/packages/gnome.scm | 40 +++++++++++++---------------------------

1 file changed, 13 insertions(+), 27 deletions(-)

[native-inputs]: Use vala-0.52 instead of vala.

---

gnu/packages/gnome.scm | 6 +++++-

1 file changed, 5 insertions(+), 1 deletion(-)

Hello,

I can confirm that this Geary also works for me! For some reason it was

failing to build when I tried to update it before, so I'm glad you

thought to try this now :D

Thanks so much,

Juli

Am Mittwoch, dem 17.05.2023 um 08:49 -0400 schrieb Juliana Sims:

Thanks, should now be updated for everyone.

Cheers