[PATCH] make more packages tunable

  • Open
  • quality assurance status badge
Details
4 participants
  • Dr. Arne Babenhauserheide
  • Liliana Marie Prikler
  • Ludovic Courtès
  • Simon Tournier
Owner
unassigned
Submitted by
Dr. Arne Babenhauserheide
Severity
normal
D
D
Dr. Arne Babenhauserheide wrote on 22 Mar 2023 22:17
(address . bug-guix@gnu.org)
87h6uc8oxl.fsf@web.de
The attached patch adds the (tunable? . #t) properties to additional
programs for which Clear Linux has an advantage over Ubuntu with the
same scheduler settings in a zen4 benchmark article

This is not guaranteed to help, but the article indicates possible
gains for these packages of 5-10%.
Best wishes,
Arne
--
Unpolitisch sein
heißt politisch sein,
ohne es zu merken.
draketo.de
-----BEGIN PGP SIGNATURE-----

iQJEBAEBCAAuFiEE801qEjXQSQPNItXAE++NRSQDw+sFAmQbcMYQHGFybmVfYmFi
QHdlYi5kZQAKCRAT741FJAPD64sHD/4++u2rH0K6P63ZptxXoLMzAmxkoE0/maG8
5QrDkbBAyUZvvlAzvKzSq5jRguaPSOshGGlStz4hWJAavjNe3cFzzQBwPzt4DFTW
Hg4oRCIVU1BKHEZ2vJf0y0hppGN4IzhtjaXjJCmRdPhV4avfZe5vp3X47ya3CGgd
Ot6smSU7P3QnniZHk2U0mm5QWwevIbkVMOwyAvUb3yyo0U+Ll6b7FZcO55TfziDD
oOdqTu16oFWeDW/i6arlhFC8q0jWZv4e7JA4/mtmvi/s8AZhSL4PC/Wy/KT8uo9y
VUTZtjhnbO8l3q5uCdQib2jk4awGL6CG9eUaLZTwI3nqi0Ko81Ag6HpznTcoyIXD
To++wLZaWU3WsiDsE7m70KlOx3OB8GH0xTIUIy9JgfMQojlC0k+lZc5yqGQS39jO
pam+ArsgjLMHZEPGHU/bkDG0YuyQs22vvEXKNxUYaI6u3JMDrjf62mJEoQvbtENF
zw/d4hsd7mU5OIiPK9dhW/K7xwGou9KmLPR6lBN4rjHM15xWnZnV6Jpv4pAKaNF/
BBChjj24PLzAOXsTQ26I3g756f65bJnyAcYWm1vgMWMScoQG4YFx2xwPNT9mO7rz
dmbCd4/CNt0dcBWiEj0gkvvu0zbF8TMNQgwjXALyLLzDSF6samxd+ZvV/9lttXzu
gq0VFysBvojEBAEBCAAuFiEE3Si95tmHXKvOSosd3M8NswvBBUgFAmQbcMYQHGFy
bmVfYmFiQHdlYi5kZQAKCRDczw2zC8EFSKysBACR7U+d/WL8EcnqDts1lfl3tPcT
7F40cdJ3T58Y7SVEJFHtKma7EnLNGMmVmyKC/ohksaS4OoFD1+6YWp7pFIG7PJ5b
QbhIwI+DE/4nqS4NT4jr1OdOBqrxJci+3nTJPwqrqBJaWlDnw7cNjCEe1I79c4v5
NM3vnR81dy0g+coDjw==
=FZ1x
-----END PGP SIGNATURE-----

L
L
Liliana Marie Prikler wrote on 23 Mar 2023 06:20
(address . control@debbugs.gnu.org)
47fc54749cd8cdfdfc9ac305745f7e9fbe7d5507.camel@gmail.com
reassign 62394 guix-patches
thanks

Toggle quote (1 lines)
> * gnu/packages/compression.scm (zlib): add (tunable? . #t) property
Should probably be ... (zlib)[properties]: Add tunable?.
Likewise for the other packages.

Toggle quote (4 lines)
> + (properties '((tunable? . #t))) ;; advantages of Clear Linux
> over Ubuntu seen + perf:
> https://www.phoronix.com/review/zen4-clear-linux/2
> (arguments
Don't exceed the line limit even in a comment.
Properties are supposed to be the *last* field of a package.

Cheers
D
D
Dr. Arne Babenhauserheide wrote on 23 Mar 2023 07:26
(name . Liliana Marie Prikler)(address . liliana.prikler@gmail.com)
87v8is6kuj.fsf@web.de
Thank you for your review!

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

Toggle quote (7 lines)
> reassign 62394 guix-patches
> thanks
>
>> * gnu/packages/compression.scm (zlib): add (tunable? . #t) property
> Should probably be ... (zlib)[properties]: Add tunable?.
> Likewise for the other packages.

Thank you — fixed.

Toggle quote (7 lines)
>> + (properties '((tunable? . #t))) ;; advantages of Clear Linux
>> over Ubuntu seen + perf:
>> https://www.phoronix.com/review/zen4-clear-linux/2
>> (arguments
> Don't exceed the line limit even in a comment.
> Properties are supposed to be the *last* field of a package.

Thank you — I moved the properties to the last field and moved the
explanation and description into the commit message.

A new patch is attached.
Best wishes,
Arne
--
Unpolitisch sein
heißt politisch sein,
ohne es zu merken.
draketo.de
-----BEGIN PGP SIGNATURE-----

iQJEBAEBCAAuFiEE801qEjXQSQPNItXAE++NRSQDw+sFAmQb8fUQHGFybmVfYmFi
QHdlYi5kZQAKCRAT741FJAPD68s9EADC65tyqhHR3Ys55mvmvcQA8tGXVIUdM7YS
1ZJLV5QYalFqbTW7aS3luRJPlWPi8gbuOglJEyU26wRoYcipbTvmnr5NaoHUZ45r
saE2b0OuJfJSWMtShDuX/sTXWl8Sg3iJqcdGBSXxdAO8ANDOExFyEW+j1onaASu5
sNlsILfq/u2BZWYmRSS8EwaogS8BDLWRAztiOBeFGRrPAro1hNr/ebCqx21uJzMd
DLj10nBLpDH1rW97KhMwDmlpTsy0uz6+PfwS4cOjtt721GVNcIOUXVFrCHat5HMU
2Zsr6Hh/eoUS+3OxO0Rb/Q2pRGnXONpHX29ikHDdaEPaKGGgSICHPCrbCHPBq6VI
QDZq04bt/mNY/I2mBFSUS7lm69uGEXhD5lGRPoWtk9dBjHR9RWN/Hmg9tRosK9lF
4uemkveiikvEAF8SYGQ0fuXt9mcXTMHtM6F6VWIJYSo7JUXtA9d/Vp7hUMgTawnB
h9nIOvbKk80qMeskoqw0ex86lVPouBoThV/ZsCJ76AYDrwru/H4ohAIJ385acmwR
HOqYlS6fCelG9fssMkVSxNTj+kMNU+UheOd1YrOWso06LA/lmnzN6X938qaOqR7B
X/dTBPD5XYoS+uE/m8lIhuwmIcRfgtJPWo4+skC55GE/lHAzftSH/9kDsHnTb69U
7Kn0xqUHi4jEBAEBCAAuFiEE3Si95tmHXKvOSosd3M8NswvBBUgFAmQb8fgQHGFy
bmVfYmFiQHdlYi5kZQAKCRDczw2zC8EFSE+5A/9S+W49ueLufSoLTG9wYeHksi+n
3/O5RKZusYYTbLVzZJ5QWEO/q9lFW0BWLmbEEqOPxdqa4ogBhrRtHbucpt1+3G6S
Z95cbQr5N4YdETCLJs3bAxCmvpYrNoGOypu/HVIS6DS2OOJtS9TATun+lEcavXtD
1q40ijCDvipoqsXrkw==
=XnXu
-----END PGP SIGNATURE-----

L
L
Ludovic Courtès wrote on 1 Apr 2023 10:19
Re: bug#62394: [PATCH] make more packages tunable
(name . Dr. Arne Babenhauserheide)(address . arne_bab@web.de)
874jq0ggkq.fsf_-_@gnu.org
Hi,

"Dr. Arne Babenhauserheide" <arne_bab@web.de> skribis:

Toggle quote (14 lines)
> From 4e498d911ee7948bb82bbdb3c58552c67bbc3832 Mon Sep 17 00:00:00 2001
> From: Arne Babenhauserheide <arne_bab@web.de>
> Date: Wed, 22 Mar 2023 12:57:15 +0100
> Subject: [PATCH] gnu: make more packages tunable
>
> * gnu/packages/compression.scm (zlib)[properties]: add tunable?.
> * gnu/packages/geo.scm (gdal)[properties]: add tunable?.
> * gnu/packages/java.scm (openjdk19, openjdk14)[properties]: add tunable?.
> * gnu/packages/maths.scm (hdf5-1.8, netcdf)[properties]: add tunable?.
> * gnu/packages/protobuf.scm (protobuf)[properties]: add tunable?.
>
> advantages of Clear Linux over Ubuntu seen + perf:
> https://www.phoronix.com/review/zen4-clear-linux/2

I’m reluctant to marking things like Chromium or OpenJDK as tunable
because they take ages to build: it’s more work for ci.guix (which
builds a few tuned variants of each tunable package), and possibly leads
to local recompilations for users when substitutes for their
micro-architecture are unavailable.

It’s also not immediately obvious to me why these two packages as well
as zlib would benefit from micro-architecture-specific optimizations.

Thoughts?

Ludo’.
L
L
Ludovic Courtès wrote on 8 Apr 2023 23:37
control message for bug #62394
(address . control@debbugs.gnu.org)
87r0su9htt.fsf@gnu.org
tags 62394 + moreinfo
quit
S
S
Simon Tournier wrote on 5 May 2023 16:11
Re: bug#62394: [PATCH] make more packages tunable
(name . Ludovic Courtès)(address . ludo@gnu.org)
87a5yi7tqw.fsf_-_@gmail.com
Hi,

On sam., 01 avril 2023 at 10:19, Ludovic Courtès <ludo@gnu.org> wrote:

Toggle quote (9 lines)
> I’m reluctant to marking things like Chromium or OpenJDK as tunable
> because they take ages to build: it’s more work for ci.guix (which
> builds a few tuned variants of each tunable package), and possibly leads
> to local recompilations for users when substitutes for their
> micro-architecture are unavailable.
>
> It’s also not immediately obvious to me why these two packages as well
> as zlib would benefit from micro-architecture-specific optimizations.

What is the status of this patch?

Well, I also have mixed feelings about the tuning of these packages.


Cheers,
simon
?