Exception when showing version-control packages

  • Done
  • quality assurance status badge
Details
2 participants
  • Greg Hogan
  • Josselin Poiret
Owner
unassigned
Submitted by
Greg Hogan
Severity
normal
G
G
Greg Hogan wrote on 21 Mar 2023 15:25
(address . bug-guix@gnu.org)
CA+3U0Zk53qJkPzGM+wfFpX0e5MsPmMzd0CgVkHiTbF3jrzDbrg@mail.gmail.com
I have not installed the guix package so I believe that I am running
an unmodified Guix. Testing on my manifest, only packages from
version-control.scm (cvs, diffstat, git, subversion, ...) are
generating the exception.

Toggle snippet (8 lines)
$ guix describe
Generation 38 Mar 21 2023 13:38:52 (current)
guix 38b64d4
repository URL: https://git.savannah.gnu.org/git/guix.git
branch: master
commit: 38b64d47ed3dfaeb63b859e7a8834e477ffed3a1

Toggle snippet (17 lines)
$ guix show hello
name: hello
version: 2.12.1
outputs:
+ out: everything
systems: x86_64-linux i686-linux
dependencies:
location: gnu/packages/base.scm:87:2
homepage: https://www.gnu.org/software/hello/
license: GPL 3+
synopsis: Hello, GNU world: An example GNU package
description: GNU Hello prints the message "Hello, world!" and then
exits. It serves as an example of standard GNU coding practices. As
such, it supports command-line arguments, multiple
+ languages, and so on.

Toggle snippet (34 lines)
$ guix show git
Backtrace:
In ice-9/boot-9.scm:
3424:24 19 (_)
222:29 18 (map1 _)
222:29 17 (map1 _)
222:29 16 (map1 _)
222:29 15 (map1 _)
222:29 14 (map1 _)
222:29 13 (map1 _)
222:29 12 (map1 _)
222:29 11 (map1 _)
222:17 10 (map1 (((gnu packages python-xyz)) ((gnu packages #)) …))
3327:17 9 (resolve-interface (gnu packages python-xyz) #:select _ …)
In ice-9/threads.scm:
390:8 8 (_ _)
In ice-9/boot-9.scm:
3253:13 7 (_)
In ice-9/threads.scm:
390:8 6 (_ _)
In ice-9/boot-9.scm:
3544:20 5 (_)
2836:4 4 (save-module-excursion _)
3564:26 3 (_)
In unknown file:
2 (primitive-load-path "gnu/packages/python-xyz" #<proced…>)
In gnu/packages/python-xyz.scm:
24360:42 1 (_)
In ice-9/boot-9.scm:
1685:16 0 (raise-exception _ #:continuable? _)

ice-9/boot-9.scm:1685:16: In procedure raise-exception:
error: pre-commit: unbound variable
J
J
Josselin Poiret wrote on 21 Mar 2023 20:00
87pm92q69i.fsf@jpoiret.xyz
Hi Greg,

Greg Hogan <code@greghogan.com> writes:

Toggle quote (3 lines)
> ice-9/boot-9.scm:1685:16: In procedure raise-exception:
> error: pre-commit: unbound variable

This is caused by yet another import cycle: pre-commit is defined in
version-control.scm, which uses python-xyz, which defines
python-jupytext and which has pre-commit among its native-inputs, which
is thus not yet defined (if you tried loading version-control.scm
first).

I think the fix would be to move pre-commit to python-xyz? These import
cycles are getting a bit out of hand, especially since we never catch
them during development... Can we also turn unbound variable warnings
into errors, so that `guix pull` could catch them earlier?

Best,
--
Josselin Poiret
-----BEGIN PGP SIGNATURE-----

iQHEBAEBCAAuFiEEOSSM2EHGPMM23K8vUF5AuRYXGooFAmQZ/skQHGRldkBqcG9p
cmV0Lnh5egAKCRBQXkC5Fhcais86DACFlbfvNFm2/RN4Q67HIjXBXSb6A4HLxMe/
WLR5Akfi0MMmmh6sclmWT6z7YVr7IKo1UoVGbp6k1atZtIg5zZZJx0HO/E9a+Gqd
10S8iSgUbl2s0POKxpzFHwaUCivCOVgob3VLoB3lqMuaBC4gbBd59MjBjiXaqzBK
B8IvfFMp5JVI3eXzB7zorCuIj896sGovIdBgw3jZ7lR3jrqb3Jw1xB571FsBtBay
e0h2agxM+KKonZ8QuxFH5gUPpmX8zP2Ebo35eVr2u2xQ0oSmOtIA5y+X/3TtEnBA
UBxNvb3tBi478wtOO5WI6BdoKQIcdpt3p+FraLwNDQKh82aP1xDY284riQoZv7nr
Tcr3w4NIk4FZh54c7AwGNdW1HuHq8PrjUweqp/yBMML9RR6Uvb+o+XgTYduCpeia
YteRCPJSzShDp8OvZ8ZzgmwQCXmZC8mhRt4fEd5gFrPaVkKoP+U6GSS84/vZtKM8
80QlAondGjWzF06O4NBExVnhPXq8Ick=
=orVK
-----END PGP SIGNATURE-----

J
J
Josselin Poiret wrote on 23 Mar 2023 15:35
87lejn1qof.fsf@jpoiret.xyz
Hi Greg,

Greg Hogan <code@greghogan.com> writes:
Toggle quote (3 lines)
> ice-9/boot-9.scm:1685:16: In procedure raise-exception:
> error: pre-commit: unbound variable

This should be fixed now by Maxim with
5174820753be045ba4fc7cc93da33f4e0b730bc3.

Closing, feel free to re-open if it is not the case.

Best,
--
Josselin Poiret
-----BEGIN PGP SIGNATURE-----

iQHEBAEBCAAuFiEEOSSM2EHGPMM23K8vUF5AuRYXGooFAmQcY7AQHGRldkBqcG9p
cmV0Lnh5egAKCRBQXkC5FhcaivVoC/4jWZ9/MCEiVYU912E1uGCGNx8nxJbfn2RR
BCbaikM6ldCxmyJYAf7fJeI5mbt4BtTl+Rv4i+RLaiiUNgZgqUnmHQrah6TR4nGZ
ITPmAiaWxSWBa5rBFrgdsFLVMXWVgZ/piVF8FHMtSe/FWiacAjbGljAWuo3IvoDz
/6voiLGhe+nNf5jZN9RjsdbJzCTkmKcdJztVMQPLDl3wJBTUPcyW8JbAF0Y75iCH
2htRit4PVMrk7CbN3bVslsmw+6EjmEIov6q1CrTauk0k/q1H+hZFowJpioh1TssV
Gx0Wh4HBheB/fH8/WBqXwrq8uOxoVekqhJt8FYspFlJoFMH9K40GVLqNulj/FjnF
j/hZp8WD1/BAXamKRAK0UnaXaZr+j1SbfTxvQdBSEI06Svv78OvR0pj7qWN3ceZH
um8u4HXXZejF3E+Ohwba/QW8e7gtjN7wy0ochoz9SiA7ZMIfsXWp0MfW8rQxUP8Y
CI/vsU+QXn/626EWIU3dskekwp6qNeo=
=3rfq
-----END PGP SIGNATURE-----

?