[PATCH] gnu: Add cyanrip.

  • Open
  • quality assurance status badge
Details
2 participants
  • Liliana Marie Prikler
  • simon
Owner
unassigned
Submitted by
simon
Severity
normal
S
S
simon wrote on 11 Mar 2023 23:30
(address . guix-patches@gnu.org)(name . Simon Streit)(address . simon@netpanic.org)
f5976557a40b431949c1813593b390aa35431b2e.1678573776.git.simon@netpanic.org
From: Simon Streit <simon@netpanic.org>

* gnu/packages/audio.scm (cyanrip): New variable.
---
gnu/packages/audio.scm | 30 +++++++++++++++++++++++++++++-
1 file changed, 29 insertions(+), 1 deletion(-)

Toggle diff (61 lines)
diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 6f3fa2a580..966a0b96f9 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -38,7 +38,7 @@
;;; Copyright © 2021 Aleksandr Vityazev <avityazev@posteo.org>
;;; Copyright © 2022 Arjan Adriaanse <arjan@adriaan.se>
;;; Copyright © 2022 Juliana Sims <jtsims@protonmail.com>
-;;; Copyright © 2022 Simon Streit <simon@netpanic.org>
+;;; Copyright © 2022, 2023 Simon Streit <simon@netpanic.org>
;;; Copyright © 2022 Andy Tai <atai@atai.org>
;;; Copyright © 2023 Sergiu Ivanov <sivanov@colimite.fr>
;;; Copyright © 2023 David Thompson <dthompson2@worcester.edu>
@@ -68,6 +68,7 @@ (define-module (gnu packages audio)
#:use-module (gnu packages bison)
#:use-module (gnu packages build-tools)
#:use-module (gnu packages boost)
+ #:use-module (gnu packages cdrom)
#:use-module (gnu packages check)
#:use-module (gnu packages compression)
#:use-module (gnu packages curl)
@@ -124,6 +125,7 @@ (define-module (gnu packages audio)
#:use-module (gnu packages linux)
#:use-module (gnu packages tls)
#:use-module (gnu packages valgrind)
+ #:use-module (gnu packages version-control)
#:use-module (gnu packages video)
#:use-module (gnu packages vim) ;xxd
#:use-module (gnu packages web)
@@ -6316,3 +6318,29 @@ (define-public cubeb
(description "Cubeb is Mozilla's cross-platform audio library.")
(home-page "https://github.com/mozilla/cubeb")
(license license:isc))))
+
+(define-public cyanrip
+ (package
+ (name "cyanrip")
+ (version "0.9.0")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/cyanreg/cyanrip")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1pf381qmqr3p3xk26w8v4gfv5cyi5siljs4gv485spsq6icynzw0"))))
+ (build-system meson-build-system)
+ (native-inputs
+ (list pkg-config))
+ (propagated-inputs
+ (list curl ffmpeg libcdio-paranoia libmusicbrainz libxml2 neon))
+ (synopsis "Fully featured CD ripping program")
+ (description "Console CD ripper with automatic tagging through integration
+with MusicBrainz , error detection, log generation, many formats, HDCD
+decoding, covert art automatic download.")
+ (home-page "https://github.com/cyanreg/cyanrip")
+ (license license:lgpl2.1+)))
--
2.39.1
L
L
Liliana Marie Prikler wrote on 13 Mar 2023 21:42
6a0ba9b42f98d0cf7efc7f16ae21ac05088e80b8.camel@gmail.com
Am Samstag, dem 11.03.2023 um 23:30 +0100 schrieb simon@netpanic.org:
Toggle quote (62 lines)
> From: Simon Streit <simon@netpanic.org>
>
> * gnu/packages/audio.scm (cyanrip): New variable.
> ---
>  gnu/packages/audio.scm | 30 +++++++++++++++++++++++++++++-
>  1 file changed, 29 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> index 6f3fa2a580..966a0b96f9 100644
> --- a/gnu/packages/audio.scm
> +++ b/gnu/packages/audio.scm
> @@ -38,7 +38,7 @@
>  ;;; Copyright © 2021 Aleksandr Vityazev <avityazev@posteo.org>
>  ;;; Copyright © 2022 Arjan Adriaanse <arjan@adriaan.se>
>  ;;; Copyright © 2022 Juliana Sims <jtsims@protonmail.com>
> -;;; Copyright © 2022 Simon Streit <simon@netpanic.org>
> +;;; Copyright © 2022, 2023 Simon Streit <simon@netpanic.org>
>  ;;; Copyright © 2022 Andy Tai <atai@atai.org>
>  ;;; Copyright © 2023 Sergiu Ivanov <sivanov@colimite.fr>
>  ;;; Copyright © 2023 David Thompson <dthompson2@worcester.edu>
> @@ -68,6 +68,7 @@ (define-module (gnu packages audio)
>    #:use-module (gnu packages bison)
>    #:use-module (gnu packages build-tools)
>    #:use-module (gnu packages boost)
> +  #:use-module (gnu packages cdrom)
>    #:use-module (gnu packages check)
>    #:use-module (gnu packages compression)
>    #:use-module (gnu packages curl)
> @@ -124,6 +125,7 @@ (define-module (gnu packages audio)
>    #:use-module (gnu packages linux)
>    #:use-module (gnu packages tls)
>    #:use-module (gnu packages valgrind)
> +  #:use-module (gnu packages version-control)
>    #:use-module (gnu packages video)
>    #:use-module (gnu packages vim) ;xxd
>    #:use-module (gnu packages web)
> @@ -6316,3 +6318,29 @@ (define-public cubeb
>        (description "Cubeb is Mozilla's cross-platform audio
> library.")
>        (home-page "https://github.com/mozilla/cubeb")
>        (license license:isc))))
> +
> +(define-public cyanrip
> +  (package
> +    (name "cyanrip")
> +    (version "0.9.0")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/cyanreg/cyanrip")
> +             (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> +         "1pf381qmqr3p3xk26w8v4gfv5cyi5siljs4gv485spsq6icynzw0"))))
> +    (build-system meson-build-system)
> +    (native-inputs
> +     (list pkg-config))
> +    (propagated-inputs
> +     (list curl ffmpeg libcdio-paranoia libmusicbrainz libxml2
> neon))
Propagated inputs are not that great, prefer normal ones. Also don't
let the lines get too long.
Toggle quote (1 lines)
> +    (synopsis "Fully featured CD ripping program")
Avoid marketing buzzwords; perhaps use "Console CD ripper" instead?
Toggle quote (5 lines)
> +    (description "Console CD ripper with automatic tagging through
> integration
> +with MusicBrainz , error detection, log generation, many formats,
> HDCD
> +decoding, covert art automatic download.")
Please use complete sentences for the description.

Cheers
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 62132@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 62132
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch