[PATCH] guix: Strip #:use-module lists.

  • Done
  • quality assurance status badge
Details
4 participants
  • Ludovic Courtès
  • Christopher Baines
  • Maxim Cournoyer
  • Simon Tournier
Owner
unassigned
Submitted by
Ludovic Courtès
Severity
normal
L
L
Ludovic Courtès wrote on 9 Mar 2023 00:26
(address . guix-patches@gnu.org)(name . Ludovic Courtès)(address . ludo@gnu.org)
20230308232624.4348-1-ludo@gnu.org
This was obtained by setting up this environment:

guix shell -D guix --with-input=guile@3.0.9=guile-next \
--with-commit=guile-next=e2ed33ef0445c867fe56c247054aa67e834861f2
-- make -j5

then adding 'unused-module' to (@@ (guix build compiler) %warnings),
building, and checking all the "unused module" warnings and removing
those that were definitely unused.
---
guix/android-repo-download.scm | 3 ---
guix/base32.scm | 1 -
guix/build-system/android-ndk.scm | 2 --
guix/build-system/ant.scm | 2 --
guix/build-system/asdf.scm | 2 --
guix/build-system/chicken.scm | 1 -
guix/build-system/clojure.scm | 2 --
guix/build-system/cmake.scm | 2 --
guix/build-system/copy.scm | 1 -
guix/build-system/dub.scm | 2 --
guix/build-system/dune.scm | 2 --
guix/build-system/emacs.scm | 2 --
guix/build-system/font.scm | 1 -
guix/build-system/glib-or-gtk.scm | 2 --
guix/build-system/gnu.scm | 1 -
guix/build-system/guile.scm | 1 -
guix/build-system/haskell.scm | 1 -
guix/build-system/julia.scm | 2 --
guix/build-system/maven.scm | 1 -
guix/build-system/meson.scm | 1 -
guix/build-system/minify.scm | 2 --
guix/build-system/node.scm | 1 -
guix/build-system/ocaml.scm | 1 -
guix/build-system/perl.scm | 2 --
guix/build-system/pyproject.scm | 4 ----
guix/build-system/python.scm | 3 ---
guix/build-system/qt.scm | 1 -
guix/build-system/r.scm | 1 -
guix/build-system/rakudo.scm | 1 -
guix/build-system/rebar.scm | 2 --
guix/build-system/renpy.scm | 3 ---
guix/build-system/ruby.scm | 2 --
guix/build-system/scons.scm | 1 -
guix/build-system/texlive.scm | 1 -
guix/build-system/trivial.scm | 2 --
guix/build-system/waf.scm | 3 ---
guix/build/android-ndk-build-system.scm | 5 -----
guix/build/asdf-build-system.scm | 4 ----
guix/build/chicken-build-system.scm | 1 -
guix/build/clojure-utils.scm | 1 -
guix/build/download-nar.scm | 1 -
guix/build/elm-build-system.scm | 1 -
guix/build/guile-build-system.scm | 1 +
guix/build/linux-module-build-system.scm | 4 ----
guix/build/lisp-utils.scm | 2 --
guix/build/make-bootstrap.scm | 3 ---
guix/build/svn.scm | 1 -
guix/build/waf-build-system.scm | 4 ----
guix/channels.scm | 4 ----
guix/derivations.scm | 2 --
guix/discovery.scm | 1 -
guix/ftp-client.scm | 2 --
guix/git-authenticate.scm | 1 -
guix/git.scm | 2 --
guix/gnu-maintenance.scm | 3 ---
guix/graph.scm | 1 -
guix/hg-download.scm | 1 -
guix/import/cabal.scm | 1 -
guix/import/cpan.scm | 2 +-
guix/import/cran.scm | 4 ----
guix/import/crate.scm | 3 ---
guix/import/egg.scm | 4 ----
guix/import/elm.scm | 11 -----------
guix/import/elpa.scm | 5 +----
guix/import/gem.scm | 1 -
guix/import/git.scm | 5 +----
guix/import/github.scm | 2 --
guix/import/gnome.scm | 2 --
guix/import/gnu.scm | 3 ---
guix/import/go.scm | 8 --------
guix/import/hexpm.scm | 9 ---------
guix/import/kde.scm | 1 -
guix/import/minetest.scm | 7 -------
guix/import/opam.scm | 7 +------
guix/import/print.scm | 3 +--
guix/import/pypi.scm | 3 ---
guix/import/test.scm | 2 --
guix/import/texlive.scm | 3 ---
guix/import/utils.scm | 1 -
guix/ipfs.scm | 5 -----
guix/lint.scm | 1 -
guix/pki.scm | 1 -
guix/records.scm | 1 -
guix/remote.scm | 2 --
guix/scripts.scm | 1 -
guix/scripts/archive.scm | 1 -
guix/scripts/build.scm | 3 ---
guix/scripts/challenge.scm | 1 -
guix/scripts/deploy.scm | 1 -
guix/scripts/discover.scm | 1 -
guix/scripts/download.scm | 3 ---
guix/scripts/edit.scm | 3 ++-
guix/scripts/graph.scm | 1 -
guix/scripts/hash.scm | 4 ----
guix/scripts/home.scm | 2 --
guix/scripts/import.scm | 3 ---
guix/scripts/offload.scm | 1 -
guix/scripts/pack.scm | 2 --
guix/scripts/package.scm | 5 -----
guix/scripts/publish.scm | 4 ----
guix/scripts/pull.scm | 2 --
guix/scripts/refresh.scm | 3 ---
guix/scripts/repl.scm | 2 --
guix/scripts/search.scm | 1 -
guix/scripts/show.scm | 1 -
guix/scripts/style.scm | 2 --
guix/scripts/substitute.scm | 4 ----
guix/scripts/system.scm | 7 -------
guix/scripts/time-machine.scm | 1 -
guix/self.scm | 1 -
guix/serialization.scm | 1 -
guix/status.scm | 1 -
guix/store.scm | 2 --
guix/store/database.scm | 2 --
guix/store/deduplication.scm | 2 --
guix/substitutes.scm | 9 ---------
guix/tests/gnupg.scm | 1 -
guix/tests/http.scm | 1 -
guix/upstream.scm | 1 -
guix/utils.scm | 3 ---
120 files changed, 8 insertions(+), 279 deletions(-)

Toggle diff (351 lines)
diff --git a/guix/android-repo-download.scm b/guix/android-repo-download.scm
index 1c3502e673..e224cdd295 100644
--- a/guix/android-repo-download.scm
+++ b/guix/android-repo-download.scm
@@ -29,10 +29,7 @@ (define-module (guix android-repo-download)
#:use-module (guix modules)
#:autoload (guix build-system gnu) (standard-packages)
#:use-module (ice-9 match)
- #:use-module (ice-9 vlist)
#:use-module (srfi srfi-1)
- #:use-module (srfi srfi-34)
- #:use-module (srfi srfi-35)
#:export (android-repo-reference
android-repo-reference?
android-repo-reference-manifest-url
diff --git a/guix/base32.scm b/guix/base32.scm
index 8f097d4e77..dd18a796f2 100644
--- a/guix/base32.scm
+++ b/guix/base32.scm
@@ -17,7 +17,6 @@
;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
(define-module (guix base32)
- #:use-module (srfi srfi-1)
#:use-module (srfi srfi-34)
#:use-module (srfi srfi-35)
#:use-module (srfi srfi-60)
diff --git a/guix/build-system/android-ndk.scm b/guix/build-system/android-ndk.scm
index 211fd11311..047f884b19 100644
--- a/guix/build-system/android-ndk.scm
+++ b/guix/build-system/android-ndk.scm
@@ -26,8 +26,6 @@ (define-module (guix build-system android-ndk)
#:use-module (guix packages)
#:use-module (guix build-system)
#:use-module (guix build-system gnu)
- #:use-module (ice-9 match)
- #:use-module (srfi srfi-26)
#:export (android-ndk-build-system))
(define %android-ndk-build-system-modules
diff --git a/guix/build-system/ant.scm b/guix/build-system/ant.scm
index 08a4c996f9..cfb033f6a5 100644
--- a/guix/build-system/ant.scm
+++ b/guix/build-system/ant.scm
@@ -26,8 +26,6 @@ (define-module (guix build-system ant)
#:use-module (guix search-paths)
#:use-module (guix build-system)
#:use-module (guix build-system gnu)
- #:use-module (ice-9 match)
- #:use-module (srfi srfi-26)
#:export (%ant-build-system-modules
ant-build
ant-build-system))
diff --git a/guix/build-system/asdf.scm b/guix/build-system/asdf.scm
index 74a3e47da1..2b17cee37b 100644
--- a/guix/build-system/asdf.scm
+++ b/guix/build-system/asdf.scm
@@ -33,9 +33,7 @@ (define-module (guix build-system asdf)
#:use-module (guix build-system)
#:use-module (guix build-system gnu)
#:use-module (ice-9 match)
- #:use-module (ice-9 regex)
#:use-module (srfi srfi-1)
- #:use-module (srfi srfi-26)
#:use-module (gnu packages)
#:export (%asdf-build-system-modules
%asdf-build-modules
diff --git a/guix/build-system/chicken.scm b/guix/build-system/chicken.scm
index 07666d1321..9f518e66e6 100644
--- a/guix/build-system/chicken.scm
+++ b/guix/build-system/chicken.scm
@@ -27,7 +27,6 @@ (define-module (guix build-system chicken)
#:use-module (guix build-system)
#:use-module (guix build-system gnu)
#:use-module (guix packages)
- #:use-module (ice-9 match)
#:export (%chicken-build-system-modules
chicken-build
chicken-build-system
diff --git a/guix/build-system/clojure.scm b/guix/build-system/clojure.scm
index 2a0713d297..fb897356bc 100644
--- a/guix/build-system/clojure.scm
+++ b/guix/build-system/clojure.scm
@@ -33,8 +33,6 @@ (define-module (guix build-system clojure)
#:select
((search-path-specification->sexp . search-path-spec->sexp)))
#:use-module (guix utils)
-
- #:use-module (ice-9 match)
#:export (%clojure-build-system-modules
clojure-build
clojure-build-system))
diff --git a/guix/build-system/cmake.scm b/guix/build-system/cmake.scm
index 0aabc95b90..09e3ac85db 100644
--- a/guix/build-system/cmake.scm
+++ b/guix/build-system/cmake.scm
@@ -24,12 +24,10 @@ (define-module (guix build-system cmake)
#:use-module (guix gexp)
#:use-module (guix utils)
#:use-module (guix monads)
- #:use-module (guix derivations)
#:use-module (guix search-paths)
#:use-module (guix build-system)
#:use-module (guix build-system gnu)
#:use-module (guix packages)
- #:use-module (ice-9 match)
#:export (%cmake-build-system-modules
cmake-build
cmake-build-system))
diff --git a/guix/build-system/copy.scm b/guix/build-system/copy.scm
index 6efc2b2766..4091eb7847 100644
--- a/guix/build-system/copy.scm
+++ b/guix/build-system/copy.scm
@@ -28,7 +28,6 @@ (define-module (guix build-system copy)
#:use-module (guix build-system)
#:use-module (guix build-system gnu)
#:use-module (guix packages)
- #:use-module (ice-9 match)
#:use-module (srfi srfi-1)
#:export (%copy-build-system-modules
default-glibc
diff --git a/guix/build-system/dub.scm b/guix/build-system/dub.scm
index 8aa93d5b0f..b4011cdb83 100644
--- a/guix/build-system/dub.scm
+++ b/guix/build-system/dub.scm
@@ -29,8 +29,6 @@ (define-module (guix build-system dub)
#:use-module (guix packages)
#:use-module (guix build-system)
#:use-module (guix build-system gnu)
- #:use-module (ice-9 match)
- #:use-module (srfi srfi-26)
#:export (dub-build-system))
(define (default-ldc)
diff --git a/guix/build-system/dune.scm b/guix/build-system/dune.scm
index 3f81d21441..afe5b24f22 100644
--- a/guix/build-system/dune.scm
+++ b/guix/build-system/dune.scm
@@ -25,10 +25,8 @@ (define-module (guix build-system dune)
#:use-module (guix gexp)
#:use-module (guix search-paths)
#:use-module (guix build-system)
- #:use-module ((guix build-system gnu) #:prefix gnu:)
#:use-module ((guix build-system ocaml) #:prefix ocaml:)
#:use-module (guix packages)
- #:use-module (ice-9 match)
#:use-module (srfi srfi-1)
#:export (%dune-build-system-modules
dune-build
diff --git a/guix/build-system/emacs.scm b/guix/build-system/emacs.scm
index 3df68789ff..ebf97a5344 100644
--- a/guix/build-system/emacs.scm
+++ b/guix/build-system/emacs.scm
@@ -28,8 +28,6 @@ (define-module (guix build-system emacs)
#:use-module (guix search-paths)
#:use-module (guix build-system)
#:use-module (guix build-system gnu)
- #:use-module (ice-9 match)
- #:use-module (srfi srfi-26)
#:export (%emacs-build-system-modules
emacs-build
emacs-build-system)
diff --git a/guix/build-system/font.scm b/guix/build-system/font.scm
index a99f76c66b..aac130da4e 100644
--- a/guix/build-system/font.scm
+++ b/guix/build-system/font.scm
@@ -22,7 +22,6 @@ (define-module (guix build-system font)
#:use-module (guix monads)
#:use-module (guix utils)
#:use-module (guix packages)
- #:use-module (guix derivations)
#:use-module (guix search-paths)
#:use-module (guix build-system)
#:use-module (guix build-system gnu)
diff --git a/guix/build-system/glib-or-gtk.scm b/guix/build-system/glib-or-gtk.scm
index aa9703829b..e956354687 100644
--- a/guix/build-system/glib-or-gtk.scm
+++ b/guix/build-system/glib-or-gtk.scm
@@ -24,14 +24,12 @@ (define-module (guix build-system glib-or-gtk)
#:use-module (guix utils)
#:use-module (guix gexp)
#:use-module (guix monads)
- #:use-module (guix derivations)
#:use-module (guix search-paths)
#:use-module ((guix build glib-or-gtk-build-system)
#:select (%gdk-pixbuf-loaders-cache-file))
#:use-module (guix build-system)
#:use-module (guix build-system gnu)
#:use-module (guix packages)
- #:use-module (ice-9 match)
#:export (%glib-or-gtk-build-system-modules
glib-or-gtk-build
glib-or-gtk-cross-build
diff --git a/guix/build-system/gnu.scm b/guix/build-system/gnu.scm
index e62ee18367..c363c3910f 100644
--- a/guix/build-system/gnu.scm
+++ b/guix/build-system/gnu.scm
@@ -22,7 +22,6 @@ (define-module (guix build-system gnu)
#:use-module (guix memoization)
#:use-module (guix gexp)
#:use-module (guix monads)
- #:use-module (guix derivations)
#:use-module (guix search-paths)
#:use-module (guix build-system)
#:use-module (guix packages)
diff --git a/guix/build-system/guile.scm b/guix/build-system/guile.scm
index 7e2e33c13e..1bd292e267 100644
--- a/guix/build-system/guile.scm
+++ b/guix/build-system/guile.scm
@@ -25,7 +25,6 @@ (define-module (guix build-system guile)
#:use-module (guix search-paths)
#:use-module (guix build-system)
#:use-module (guix build-system gnu)
- #:use-module (ice-9 match)
#:use-module (srfi srfi-26)
#:export (%guile-build-system-modules
guile-build-system))
diff --git a/guix/build-system/haskell.scm b/guix/build-system/haskell.scm
index a37b3a938c..b8858421c2 100644
--- a/guix/build-system/haskell.scm
+++ b/guix/build-system/haskell.scm
@@ -32,7 +32,6 @@ (define-module (guix build-system haskell)
#:use-module (guix build-system gnu)
#:use-module (ice-9 match)
#:use-module (srfi srfi-1)
- #:use-module (srfi srfi-26)
#:export (hackage-uri
%haskell-build-system-modules
diff --git a/guix/build-system/julia.scm b/guix/build-system/julia.scm
index 66e7711bcd..b5521e38e4 100644
--- a/guix/build-system/julia.scm
+++ b/guix/build-system/julia.scm
@@ -29,8 +29,6 @@ (define-module (guix build-system julia)
#:use-module (guix search-paths)
#:use-module (guix build-system)
#:use-module (guix build-system gnu)
- #:use-module (ice-9 match)
- #:use-module (srfi srfi-26)
#:export (%julia-build-system-modules
julia-build
julia-build-system))
diff --git a/guix/build-system/maven.scm b/guix/build-system/maven.scm
index 0af5922692..3daff07323 100644
--- a/guix/build-system/maven.scm
+++ b/guix/build-system/maven.scm
@@ -26,7 +26,6 @@ (define-module (guix build-system maven)
#:use-module (guix build-system)
#:use-module (guix build-system gnu)
#:use-module (guix packages)
- #:use-module (ice-9 match)
#:use-module (srfi srfi-1)
#:export (%maven-build-system-modules
default-maven
diff --git a/guix/build-system/meson.scm b/guix/build-system/meson.scm
index 7d413a991d..d7d807f5b6 100644
--- a/guix/build-system/meson.scm
+++ b/guix/build-system/meson.scm
@@ -30,7 +30,6 @@ (define-module (guix build-system meson)
#:use-module (guix build-system gnu)
#:use-module (guix build-system glib-or-gtk)
#:use-module (guix packages)
- #:use-module (ice-9 match)
#:export (%meson-build-system-modules
meson-build-system
make-cross-file))
diff --git a/guix/build-system/minify.scm b/guix/build-system/minify.scm
index 7d4745ab32..787235deeb 100644
--- a/guix/build-system/minify.scm
+++ b/guix/build-system/minify.scm
@@ -26,8 +26,6 @@ (define-module (guix build-system minify)
#:use-module (guix search-paths)
#:use-module (guix build-system)
#:use-module (guix build-system gnu)
- #:use-module (ice-9 match)
- #:use-module (srfi srfi-26)
#:export (%minify-build-system-modules
minify-build
minify-build-system))
diff --git a/guix/build-system/node.scm b/guix/build-system/node.scm
index 24bd677bfc..3f73390809 100644
--- a/guix/build-system/node.scm
+++ b/guix/build-system/node.scm
@@ -29,7 +29,6 @@ (define-module (guix build-system node)
#:use-module (guix search-paths)
#:use-module (guix build-system)
#:use-module (guix build-system gnu)
- #:use-module (ice-9 match)
#:export (%node-build-system-modules
node-build
node-build-system))
diff --git a/guix/build-system/ocaml.scm b/guix/build-system/ocaml.scm
index 921c1f8629..27d5183640 100644
--- a/guix/build-system/ocaml.scm
+++ b/guix/build-system/ocaml.scm
@@ -25,7 +25,6 @@ (define-module (guix build-system ocaml)
#:use-module (guix build-system)
#:use-module (guix build-system gnu)
#:use-module (guix packages)
- #:use-module (ice-9 match)
#:use-module (srfi srfi-1)
#:export (%ocaml-build-system-modules
package-with-ocaml4.07
diff --git a/guix/build-system/perl.scm b/guix/build-system/perl.scm
index 43ec2fdcb6..7c6deb34bf 100644
--- a/guix/build-system/perl.scm
+++ b/guix/build-system/perl.scm
@@ -22,12 +22,10 @@ (define-module (guix build-system perl)
#:use-module (guix utils)
#:use-module (guix gexp)
#:use-module (guix monads)
- #:use-module (guix derivations)
#:use-module (guix search-paths)
#:use-module (guix build-system)
#:use-module (guix build-system gnu)
#:use-module (guix packages)
- #:use-module (ice-9 match)
#:export (%perl-build-system-modules
perl-build
perl-cross-build
diff --git a/guix/build-system/pyproject.scm b/guix/build-system/pyproject.scm
index 8f3b562ca3..44d6650ba9 100644
--- a/guix/build-system/pyproject.scm
+++ b/guix/build-system/pyproject.scm
@@ -22,18 +22,14 @@ (define-module (guix build-system pyproject)
#:use-module (guix gexp)
#:use-module (guix store)
#:use-module (guix utils)
- #:use-module (guix memoization)
#:use-module (guix gexp)
#:use-module (guix monads)
#:use-module (guix packages)
- #:use-module (guix derivations)
#:use-module (guix search-paths)
#:use-module (guix build-system)
#:use-module (guix build-system gnu)
#:use-module (guix build-system python)
- #:use-module (ice-9 match)
#:use-module (srfi srfi-1)
- #:use-module (srfi srfi-26)
#:export (%pyproject-build-system-modules
default-python
pyproject-build
diff --git a/guix/build-system/python.scm b/guix/build-system/python.scm
index c8f04b2298..cca009fb28 100644
--- a/guix/build-system/python.scm
+++ b/guix/build-system/python.scm
@@ -24,7 +24,6 @@ (define-module (guix build-system python)
#:use-module (guix gexp)
#:use-module (guix store)
#:us
This message was truncated. Download the full message here.
C
C
Christopher Baines wrote on 9 Mar 2023 08:54
(name . Ludovic Courtès)(address . ludo@gnu.org)
87356eqrwq.fsf@cbaines.net
Ludovic Courtès <ludo@gnu.org> writes:

Toggle quote (10 lines)
> This was obtained by setting up this environment:
>
> guix shell -D guix --with-input=guile@3.0.9=guile-next \
> --with-commit=guile-next=e2ed33ef0445c867fe56c247054aa67e834861f2
> -- make -j5
>
> then adding 'unused-module' to (@@ (guix build compiler) %warnings),
> building, and checking all the "unused module" warnings and removing
> those that were definitely unused.

This looks great :)

It does change some guix/build/ modules though, so I think that is the
reason it affects ~3227 packages. Maybe this could be split so that
anything affecting packages goes to core-updates, and the rest of the
changes go to master?

Thanks,

Chris
-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmQJkTVfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XcbnxAAtc52etlivbaXmsEWSvw16Lx5bFPraDN7
ybxDFtbf4k7zO4C4nWvrhPVrJQ5OgYu2PJdHKvS+N8Dh9brlObpbllE65KzveWi+
C6fy+w6lLyU/cuu2oTPGe5EjcdO718fzCo0rFcyArMNxPGdIUAUzkvWaiAvRLSGX
apaQ0bvTp56AXR7H//z9CFYCTaQ5t5HsOC0/Yzfq2qpgIAsuH4dwaCZ+euPh0Bsm
qE99/ul88+0rqAbc6ZQSAT79U5PSDQQFiilfLpFIpw7Qr+DpO984kP2wpjB20BXn
aPBKikkl3HoWRJUbcV1gXvD5h0PaRmJ+4ddnG3iZrcq04Gf86/1KHekADlSJjlaQ
UP4qSISb7JP94ejjrYz134oDWsUFMTZYKJSmzDUU1a1fuk+BXEvq2Eto98thEMOG
QZ72QWXoRvSgCiGZ6Zdm7jY7vgJ1rvvcU/go44mJI0TWs7b8ep6JpYZsUFg+XHGH
I1q/NeIac76/yR6XQHrcUzZUva6I5C9HbBNjR6iOoPaSh9pLXrIJqq4j+cebBUGR
9sivGK1cHFSms5EHDCE1r74mUrmViib6f2h+76lY0Nof1q8hVVTHZ3+LyqS6rT2E
aGCjhBzQ+2OuAHS4vlgGW6Ccn78BvjrolveBSwMt/MZVZ07tnaGkgdTKCO/Qm5OA
f17W59tzFp8=
=+uVL
-----END PGP SIGNATURE-----

S
S
Simon Tournier wrote on 9 Mar 2023 11:25
(name . Ludovic Courtès)(address . ludo@gnu.org)
86bkl2nrvy.fsf@gmail.com
Hi Ludo,

Oh, awesome!


On Thu, 09 Mar 2023 at 00:26, Ludovic Courtès <ludo@gnu.org> wrote:
Toggle quote (10 lines)
> This was obtained by setting up this environment:
>
> guix shell -D guix --with-input=guile@3.0.9=guile-next \
> --with-commit=guile-next=e2ed33ef0445c867fe56c247054aa67e834861f2
> -- make -j5
>
> then adding 'unused-module' to (@@ (guix build compiler) %warnings),
> building, and checking all the "unused module" warnings and removing
> those that were definitely unused.

Out of curiosity, well, I have not understood how you proceeded. :-)
Could you explain a bit more what you meant by:

then adding 'unused-module' to (@@ (guix build compiler) %warnings),

Adding where? Do you mean this ’unused-module’ is now part of the
guile-next? Well, Guile e2ed33ef0445c867fe56c247054aa67e834861f2 is
also about removing unused modules in Guile itself.

Last minor comment, is it expected that there is nothing under
’gnu/packages’?


Cheers,
simon
L
L
Ludovic Courtès wrote on 10 Mar 2023 10:40
(name . Simon Tournier)(address . zimon.toutoune@gmail.com)(address . 62062@debbugs.gnu.org)
87sfed7xlx.fsf@gnu.org
Hi Simon,

Simon Tournier <zimon.toutoune@gmail.com> skribis:

Toggle quote (18 lines)
> On Thu, 09 Mar 2023 at 00:26, Ludovic Courtès <ludo@gnu.org> wrote:
>> This was obtained by setting up this environment:
>>
>> guix shell -D guix --with-input=guile@3.0.9=guile-next \
>> --with-commit=guile-next=e2ed33ef0445c867fe56c247054aa67e834861f2
>> -- make -j5
>>
>> then adding 'unused-module' to (@@ (guix build compiler) %warnings),
>> building, and checking all the "unused module" warnings and removing
>> those that were definitely unused.
>
> Out of curiosity, well, I have not understood how you proceeded. :-)
> Could you explain a bit more what you meant by:
>
> then adding 'unused-module' to (@@ (guix build compiler) %warnings),
>
> Adding where?

To the ‘%warnings’ variable in (guix build compile).

Toggle quote (2 lines)
> Do you mean this ’unused-module’ is now part of the guile-next?

It’s in Guile ‘main’ yes.

Toggle quote (3 lines)
> Well, Guile e2ed33ef0445c867fe56c247054aa67e834861f2 is also about
> removing unused modules in Guile itself.

Right; see the preceding commit. :-)

Toggle quote (3 lines)
> Last minor comment, is it expected that there is nothing under
> ’gnu/packages’?

This is left as an exercise to the reader. :-)

That is, one can do the same with gnu/packages/*.scm. It can be quite
tedious though due to “false positives” (not exactly false positives,
but cases where the compiler cannot tell for sure whether a module
really is unused).

Ludo’.
S
S
Simon Tournier wrote on 10 Mar 2023 12:37
(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 62062@debbugs.gnu.org)
87fsacomzu.fsf@gmail.com
Hi,

On ven., 10 mars 2023 at 10:40, Ludovic Courtès <ludo@gnu.org> wrote:

[...]

Thanks for explaining.

Toggle quote (5 lines)
> That is, one can do the same with gnu/packages/*.scm. It can be quite
> tedious though due to “false positives” (not exactly false positives,
> but cases where the compiler cannot tell for sure whether a module
> really is unused).

Ah, ok indeed it is a good exercise for the reader. :-)

Cheers,
simon
L
L
Ludovic Courtès wrote on 13 Mar 2023 15:19
Re: bug#62062: [PATCH] guix: Strip #:use-module lists.
(name . Christopher Baines)(address . mail@cbaines.net)(address . 62062@debbugs.gnu.org)
87edps20pd.fsf_-_@gnu.org
Hi Chris,

Christopher Baines <mail@cbaines.net> skribis:

Toggle quote (19 lines)
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> This was obtained by setting up this environment:
>>
>> guix shell -D guix --with-input=guile@3.0.9=guile-next \
>> --with-commit=guile-next=e2ed33ef0445c867fe56c247054aa67e834861f2
>> -- make -j5
>>
>> then adding 'unused-module' to (@@ (guix build compiler) %warnings),
>> building, and checking all the "unused module" warnings and removing
>> those that were definitely unused.
>
> This looks great :)
>
> It does change some guix/build/ modules though, so I think that is the
> reason it affects ~3227 packages. Maybe this could be split so that
> anything affecting packages goes to core-updates, and the rest of the
> changes go to master?

Sorry for being disorganized: I just saw this after pushing the patch.

Consequently, I reverted some of the guix/build changes in
0bb0eeddf647e5d56afd4517b12919a36acac6ee.

I’ll leave the rest for ‘core-updates’.

I should have checked data.qa.guix to see the number of rebuilds, right?

Thanks!

Ludo’.
M
M
Maxim Cournoyer wrote on 25 Jul 2023 19:10
(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 62062-done@debbugs.gnu.org)
87pm4f29za.fsf@gmail.com
Hi,

Ludovic Courtès <ludo@gnu.org> writes:

Toggle quote (7 lines)
> This was obtained by setting up this environment:
>
> guix shell -D guix --with-input=guile@3.0.9=guile-next \
> --with-commit=guile-next=e2ed33ef0445c867fe56c247054aa67e834861f2
> -- make -j5
>

Seems this was pushed as ae587c2ef041413bc709a555261db752068ea360.

Closing.

--
Thanks,
Maxim
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 62062@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 62062
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch