emacs-lsp-treemacs unused leftover icons in sources

  • Done
  • quality assurance status badge
Details
2 participants
  • Jelle Licht
  • Liliana Marie Prikler
Owner
unassigned
Submitted by
Jelle Licht
Severity
normal

Debbugs page

Jelle Licht wrote 2 years ago
(address . bug-guix@gnu.org)
87v8k55a34.fsf@fsfe.org
Commit e0d2ec418bb on master removed icons that are unclearly licensed
from the sources of emacs-lsp-treemacs. Quoted here:

Toggle snippet (6 lines)
gnu: emacs-lsp-treemacs: Remove unclearly licensed icons.

emacs-lsp-treemacs bundles icons with unclear licenses.
See also <https://github.com/emacs-lsp/lsp-treemacs/issues/123>.

Some icons are still left in the sources, in the 'icons/vscode'
directory' of the source tarball one builds by running `guix build
--source emacs-lsp-treemacs'. I have never used vscode, and am
unfamiliar with the licensing situation of it and its related icons.

In case these icons are also unclearly licensed, I propose we follow the
same strategy as done earlier by Liliana, and remove the vscode icons
entirely. If the icons are actually licensed under an unproblematic
license, it would be nice if they were installed when running `guix
install emacs-lsp-treemacs', and the license property of the package
updated to reflect this fact.

Thanks for any insight,
- Jelle
Liliana Marie Prikler wrote 2 years ago
3c5bf58df07650ebeaf0c9411c0a23a548904e24.camel@gmail.com
Am Dienstag, dem 14.02.2023 um 02:06 +0100 schrieb Jelle Licht:
Toggle quote (22 lines)
> Commit e0d2ec418bb on master removed icons that are unclearly
> licensed
> from the sources of emacs-lsp-treemacs. Quoted here:
>
> --8<---------------cut here---------------start------------->8---
> gnu: emacs-lsp-treemacs: Remove unclearly licensed icons.
>
> emacs-lsp-treemacs bundles icons with unclear licenses.
> See also <https://github.com/emacs-lsp/lsp-treemacs/issues/123>.
> --8<---------------cut here---------------end--------------->8---
>
> Some icons are still left in the sources, in the 'icons/vscode'
> directory' of the source tarball one builds by running `guix build
> --source emacs-lsp-treemacs'. I have never used vscode, and am
> unfamiliar with the licensing situation of it and its related icons.
>
> In case these icons are also unclearly licensed, I propose we follow
> the same strategy as done earlier by Liliana, and remove the vscode
> icons entirely.  If the icons are actually licensed under an
> unproblematic license, it would be nice if they were installed when
> running `guix install emacs-lsp-treemacs', and the license property
> of the package updated to reflect this fact.
From what I could gather, vscode-icons [1] are actually CC-BY, but used
without proper attribution in this package. As for why they're unused,
I mostly forgot to whitelist them.

Cheers

Jelle Licht wrote 2 years ago
87leka0xw2.fsf@fsfe.org
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

Toggle quote (31 lines)
> Am Dienstag, dem 14.02.2023 um 02:06 +0100 schrieb Jelle Licht:
>> Commit e0d2ec418bb on master removed icons that are unclearly
>> licensed
>> from the sources of emacs-lsp-treemacs. Quoted here:
>>
>> --8<---------------cut here---------------start------------->8---
>> gnu: emacs-lsp-treemacs: Remove unclearly licensed icons.
>>
>> emacs-lsp-treemacs bundles icons with unclear licenses.
>> See also <https://github.com/emacs-lsp/lsp-treemacs/issues/123>.
>> --8<---------------cut here---------------end--------------->8---
>>
>> Some icons are still left in the sources, in the 'icons/vscode'
>> directory' of the source tarball one builds by running `guix build
>> --source emacs-lsp-treemacs'. I have never used vscode, and am
>> unfamiliar with the licensing situation of it and its related icons.
>>
>> In case these icons are also unclearly licensed, I propose we follow
>> the same strategy as done earlier by Liliana, and remove the vscode
>> icons entirely.  If the icons are actually licensed under an
>> unproblematic license, it would be nice if they were installed when
>> running `guix install emacs-lsp-treemacs', and the license property
>> of the package updated to reflect this fact.
> From what I could gather, vscode-icons [1] are actually CC-BY, but used
> without proper attribution in this package. As for why they're unused,
> I mostly forgot to whitelist them.
>
> Cheers
>
> [1] https://github.com/microsoft/vscode-icons

Fixed + pushed to master in #61649 / 3f222cd5ad,
closing this issue.

- Jelle
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 61497@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 61497
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help