[PATCH] doc: contributing: Cover push frequency in the Commit Policy.

  • Open
  • quality assurance status badge
Details
2 participants
  • Christopher Baines
  • Simon Tournier
Owner
unassigned
Submitted by
Christopher Baines
Severity
normal
C
C
Christopher Baines wrote on 11 Feb 2023 22:15
(address . guix-patches@gnu.org)
20230211211505.7779-1-mail@cbaines.net
* doc/contributing.texi (Commit Access): Add paragraph about push frequency.
---
doc/contributing.texi | 6 ++++++
1 file changed, 6 insertions(+)

Toggle diff (19 lines)
diff --git a/doc/contributing.texi b/doc/contributing.texi
index c436bc4a31..09b9da3e89 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -1852,6 +1852,12 @@ commits that caused immediate problems. This is subject to being
adjusted, allowing individuals to commit directly on non-controversial
changes on parts they’re familiar with.
+Try to plan ahead and avoid pushing several times in a short time
+window. This reduces the likelyhood that others working on the same
+branch will encounter problems when pushing. It also reduces the load
+on services like @url{https://data.guix.gnu.org,data.guix.gnu.org} that
+process each revision that is pushed.
+
When pushing a commit on behalf of somebody else, please add a
@code{Signed-off-by} line at the end of the commit log message---e.g.,
with @command{git am --signoff}. This improves tracking of who did
--
2.38.1
S
S
Simon Tournier wrote on 14 Feb 2023 14:03
87wn4kz9f7.fsf@gmail.com
Hi,

On sam., 11 févr. 2023 at 21:15, Christopher Baines <mail@cbaines.net> wrote:

Toggle quote (6 lines)
> +Try to plan ahead and avoid pushing several times in a short time
> +window. This reduces the likelyhood that others working on the same
> +branch will encounter problems when pushing. It also reduces the load
> +on services like @url{https://data.guix.gnu.org,data.guix.gnu.org} that
> +process each revision that is pushed.

The point is to push by batch instead of pushing several times in a row,
right?


Cheers,
simon
C
C
Christopher Baines wrote on 17 Feb 2023 19:36
(name . Simon Tournier)(address . zimon.toutoune@gmail.com)(address . 61437@debbugs.gnu.org)
87y1owcf0o.fsf@cbaines.net
Simon Tournier <zimon.toutoune@gmail.com> writes:

Toggle quote (13 lines)
> Hi,
>
> On sam., 11 févr. 2023 at 21:15, Christopher Baines <mail@cbaines.net> wrote:
>
>> +Try to plan ahead and avoid pushing several times in a short time
>> +window. This reduces the likelyhood that others working on the same
>> +branch will encounter problems when pushing. It also reduces the load
>> +on services like @url{https://data.guix.gnu.org,data.guix.gnu.org} that
>> +process each revision that is pushed.
>
> The point is to push by batch instead of pushing several times in a row,
> right?

Pretty much, it's a balance of course as sometimes it'll be worth
pushing without much time between, but as I say there's advantages in
trying to plan ahead to reduce that.
-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmPvyfdfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XcLGQ//cADXfO00iGzioED2SFKPpHIFKVkgfrmH
wQ57kjd3Nsif4+bl9hMEfFwLowQUcavOfb4PsUzTFU9C5QVp7CJpba6049C+nwaI
AMtKzxuISegdYEzThqzO27TvdMB6MC0LptSewxgDcVZxj82CFDK3swRm9TPBJx2z
3HyYIpQ7XXObvVQdTU9UtoaGZMLyHCs5aP2tT04o3kF2x18BIhHje0Euk0dzYm+w
PHw2CmuR6YmeksVUYmflLvS5ndZLNL0upY3Rdf2JrOX2sABtzXCuyaouf2KJf+Rn
CUDaGRo+A9CWn2MVo5UXvYTsoI/j2r0YKbxkAOSw+sRxwKjF82247sAs1UtqhTMs
HCAFc+upidPhnCggGxOPunXYh84QCjDhVKaVqdsdZsL8nv+4rBLYoE138FDq1L6e
/JQxtIBpW0z7ITH6AoDCw8rREmbusT/I0NtEirRUhul/IlTLWYj5rjFUClTRvEBT
kGmC4Z03vZpyz1F2v6Zvp6DSm4D2mDRfcKctB8ZAnz3ZDjnquADrq+g9UKiE/7ks
XmSBACrOLVCSGziy0JKwSYbCCRCV1+N5Kt3INa72SeofEfo0IzDi4ZXYICv6chXR
up3hsflFwp4RwNwwwsMKgGOdz2mOgxSd4/vJA07WAbzkVeAnRbwK87naD7glA4y6
ywCIFiXLx8s=
=8qJ/
-----END PGP SIGNATURE-----

S
S
Simon Tournier wrote on 20 Feb 2023 12:30
(name . Christopher Baines)(address . mail@cbaines.net)(address . 61437@debbugs.gnu.org)
875ybw4lr8.fsf@gmail.com
Hi Chris,

On ven., 17 févr. 2023 at 18:36, Christopher Baines <mail@cbaines.net> wrote:

Toggle quote (13 lines)
>>> +Try to plan ahead and avoid pushing several times in a short time
>>> +window. This reduces the likelyhood that others working on the same
>>> +branch will encounter problems when pushing. It also reduces the load
>>> +on services like @url{https://data.guix.gnu.org,data.guix.gnu.org} that
>>> +process each revision that is pushed.
>>
>> The point is to push by batch instead of pushing several times in a row,
>> right?
>
> Pretty much, it's a balance of course as sometimes it'll be worth
> pushing without much time between, but as I say there's advantages in
> trying to plan ahead to reduce that.

Well, maybe it is only me but I have difficulties to understand what you
mean by “plan ahead”. Instead I would use “Try to push by batch and …”
or something like that.

Note the typo: s/likelyhood/likelihood

Well, LGTM.

Cheers,
simon
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 61437@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 61437
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch