[PATCH] gnu: pwntools: Update to 4.9.0.

  • Open
  • quality assurance status badge
Details
3 participants
  • Andreas Enge
  • c4droid
  • Christopher Baines
Owner
unassigned
Submitted by
c4droid
Severity
normal
C
C
c4droid wrote on 11 Feb 2023 14:05
(address . guix-patches@gnu.org)
tencent_ABACDAC32ED7F248662B5BF46D0E8B450708@qq.com
From 7774159762ddc93d93184a91e601d7abe82380a4 Mon Sep 17 00:00:00 2001
From: c4droid <c4droid@foxmail.com>
Date: Sat, 11 Feb 2023 20:46:56 +0800
Subject: [PATCH] gnu: pwntools: Update to 4.9.0.

---
gnu/packages/cybersecurity.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (23 lines)
diff --git a/gnu/packages/cybersecurity.scm b/gnu/packages/cybersecurity.scm
index 7bca251d06..7e322c2756 100644
--- a/gnu/packages/cybersecurity.scm
+++ b/gnu/packages/cybersecurity.scm
@@ -123,14 +123,14 @@ (define-public ropgadget
(define-public pwntools
(package
(name "pwntools")
- (version "4.4.0")
+ (version "4.9.0")
(source
(origin
(method url-fetch)
(uri (pypi-uri "pwntools" version))
(sha256
(base32
- "1qw7j0wwm1878aia08gyw5xljjr26qsbp45w65n4qff672sha5n5"))))
+ "04p7qzx4axkh0wgm0185724midzb3lprp3crja1lhw4i5wc7v9pf"))))
(build-system python-build-system)
(arguments
'(#:tests? #f)) ;XXX: needs a specific version of unicorn
--
2.39.1
C
C
c4droid wrote on 11 Feb 2023 14:55
Re: bug#61431: Acknowledgement ([PATCH] gnu: pwntools: Update to 4.9.0.)
(address . 61431@debbugs.gnu.org)
tencent_5EB53B52E04A303D92437D910A2BCE70CB06@qq.com
I tried build package locally, same with version 4.4.0, python part
build normally, only building unicorn generate error.
C
C
Christopher Baines wrote on 13 Feb 2023 18:37
Re: [bug#61431] Acknowledgement ([PATCH] gnu: pwntools: Update to 4.9.0.)
(name . c4droid)(address . c4droid@foxmail.com)
87o7px31rd.fsf@cbaines.net
c4droid <c4droid@foxmail.com> writes:

Toggle quote (3 lines)
> I tried build package locally, same with version 4.4.0, python part
> build normally, only building unicorn generate error.

It looks to me like unicorn fails to build, so I think that needs fixing
before we can consider updating pwntools.
-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmPqdVZfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XeQCg/8CZpZ0ulIaeR2SFXF6wBDR+h38m7xT4O6
pOggy+1dv1p0Dbzn6i+rpoZM4VlBLOj//LrFhIWX757+h4Awn5tO7VH2SJICepgu
jbpt8PMcQPZpvLCI8cJJfQ/yYu3ZAnRf+S7zLvvqO4idpW8NrdOCF8UvzguItie+
tgZ8WUhMH6YcN9UAFVFD0C5ImrdvEAY/gNq+bB73guN6cGvDkuormefcBJMHdXuS
m2NXdHPG5mmsIFhQeyhzpHaaKZojWJc5DVnjJVeELdBPP5tYnloVivKIq4XUXDcD
fJmmn1ZHGOEG8undHDBgDbaxTATSUds+Oj5rL/XuKs+xSQoY3KsjokIMz0cZqW7b
htfXwAPvCbetCjfgorAG4Az0Me36PI70qLMQoHQd7M0yxs1hRcY0Wg5iBs6Zl/tn
BBh+0mWez6Et5938MZNle1ZJKlfR0PQpe8EWHkq3RIMHP1rWVP90z4zqYCHz3g9Z
3ldLL1V6sI2P/LH9LhTmWipa/vOYTt/jmknOuCJ0amJtUxXktsW1oXtUk0xYuetR
rRuSSyZ07Rpxjvn3WRakR+mzeH9GMlmcNzTggArj9LaYeR8qYDNz/LufE3Xh0P8o
9fyXv+ayFYjUcIj7Ib4/kdfgH+pWVPFsPVaxiC678wuOxsEXD7HIO9FxKcUAXZ6M
B1r73y+N/do=
=qaD6
-----END PGP SIGNATURE-----

C
C
Christopher Baines wrote on 13 Feb 2023 18:37
tag 61431 moreinfo
(address . control@debbugs.gnu.org)
87mt5hv53z.fsf@cbaines.net
tags 61431 + moreinfo
quit
A
A
Andreas Enge wrote on 12 Mar 2023 00:15
unicorn
(address . 61431@debbugs.gnu.org)
ZA0Le3OFhSf9YFQu@jurong
Notice that there are newer releases of unicorn. I tried 1.0.2 (without
the -rc4) and 1.0.3, but both have the same test failure.

The current version is 2.0.1, but it does not build with the recipe
as it is.

Andreas
C
C
c4droid wrote on 13 Mar 2023 13:05
(name . Andreas Enge)(address . andreas@enge.fr)(address . 61431@debbugs.gnu.org)
tencent_A12199AD04D0BF3AF014BDB1AA0CB75D530A@qq.com
I think if can remove some failed tests, let unicorn can build success.

On Sun, Mar 12, 2023 at 12:15:07AM +0100, Andreas Enge wrote:
Toggle quote (11 lines)
> Notice that there are newer releases of unicorn. I tried 1.0.2 (without
> the -rc4) and 1.0.3, but both have the same test failure.
>
> The current version is 2.0.1, but it does not build with the recipe
> as it is.
>
> Andreas
>
>
>
>
A
A
Andreas Enge wrote on 14 Mar 2023 20:32
(name . c4droid)(address . c4droid@foxmail.com)(address . 61431@debbugs.gnu.org)
ZBDL6j/tAPZi+P37@jurong
Am Mon, Mar 13, 2023 at 08:05:22PM +0800 schrieb c4droid:
Toggle quote (2 lines)
> I think if can remove some failed tests, let unicorn can build success.

Well, that is always a possibility of last resort, but hiding problems
does not make them go away... We try to limit this to cases where it is
justified (tests that need network access and will not work in the Guix
build environment, for instance).

Andreas
C
C
c4droid wrote on 15 Mar 2023 01:49
(name . Andreas Enge)(address . andreas@enge.fr)(address . 61431@debbugs.gnu.org)
tencent_90690588DEDE81AFC883357F58EC5A05A905@qq.com
Agree, not other way to resolve this.
On Tue, Mar 14, 2023 at 08:32:58PM +0100, Andreas Enge wrote:
Toggle quote (10 lines)
> Am Mon, Mar 13, 2023 at 08:05:22PM +0800 schrieb c4droid:
> > I think if can remove some failed tests, let unicorn can build success.
>
> Well, that is always a possibility of last resort, but hiding problems
> does not make them go away... We try to limit this to cases where it is
> justified (tests that need network access and will not work in the Guix
> build environment, for instance).
>
> Andreas
>
C
C
c4droid wrote on 9 May 2023 06:20
unicorn failed test fixed
(address . 61431@debbugs.gnu.org)
tencent_5BF5E1A5EB45A48E95177A0E87F2A23ED607@qq.com
Hi!

I discovered latest unicorn version is fix failed tests, here is snippet for unicorn:

``` scheme
(define-public python-unicorn
(package
(name "python-unicorn")
(version "2.0.1.post1")
(source (origin
(method url-fetch)
(uri (pypi-uri "unicorn" version))
(sha256
(base32
"0mlfs8qfi0clyncfkbxp6in0cpl747510i6bqymwid43xcirbikz"))))
(build-system pyproject-build-system)
(native-inputs (list cmake pkg-config))
(home-page "http://www.unicorn-engine.org")
(synopsis "Unicorn CPU emulator engine")
(description "Unicorn CPU emulator engine")
(license #f)))
```

This snippet is generated from guix import pypi, I build it on my local machine, all test is
passed.
A
A
Andreas Enge wrote on 24 Jul 2023 18:00
More info needed
(address . 61431@debbugs.gnu.org)(name . Jakub K?dzio?ka)(address . kuba@kadziolka.net)
ZL6gFTNu5TkM2KqN@jurong
Hello,

cc to the last person who has worked on the unicorn package, in case they
can help.

The current unicorn package has a lot more code, which may or may not be
needed after updating to a new major version; but it would be nice if
someone familiar with the package and actually using it could do the update
and check that it still works.

Andreas
?