define-public fontconfig vs. fontconfig-minimal as its name

  • Open
  • quality assurance status badge
Details
2 participants
  • Attila Lendvai
  • Maxim Cournoyer
Owner
unassigned
Submitted by
Attila Lendvai
Severity
normal
A
A
Attila Lendvai wrote on 5 Feb 2023 12:43
(name . bug-guix@gnu.org)(address . bug-guix@gnu.org)
SrbV987TU079e3orC1S59uhxgE0VTkSELMNBgushO45ve_KIbjFIWTp8sHU1ArlXApcvkXbPZcK9dTxpBnLV-YauM9vz9NSwWGQna3TBYeg=@lendvai.name
(define-public fontconfig
[...]
(name "fontconfig-minimal")

this tripped me up. is this a mistake?

if not, then please add a comment that explains this anomaly.

--
• attila lendvai
• PGP: 963F 5D5F 45C7 DFCD 0A39
--
“We're all going to die, all of us, what a circus! That alone should make us love each other but it doesn't. We are terrorized and flattened by trivialities, we are eaten up by nothing.”
— Charles Bukowski (1920–1994)
M
M
Maxim Cournoyer wrote on 16 Feb 2023 04:24
(name . Attila Lendvai)(address . attila@lendvai.name)(address . 61292@debbugs.gnu.org)
87o7puwav3.fsf@gmail.com
Hi,

Attila Lendvai <attila@lendvai.name> writes:

Toggle quote (8 lines)
> (define-public fontconfig
> [...]
> (name "fontconfig-minimal")
>
> this tripped me up. is this a mistake?
>
> if not, then please add a comment that explains this anomaly.

There's already a comment above fontconfig-with-documentation that
reads:

This is intentionally named 'fontconfig', as it's intended as the
user-facing fontconfig package

The original fontconfig was renamed fontconfig-minimal but the variable
was not renamed to avoid having to adjust the rest of the code base. It
could be done, and then the fontconfig-with-documentation *variable*
could be renamed to simply fontconfig.

That'd be more conventional.

Would you like to give it a try? It shouldn't cause any rebuild, I
think.

--
Thanks,
Maxim
A
A
Attila Lendvai wrote on 3 Aug 2023 17:32
fontconfig -> fontconfig-minimal
(name . 61292@debbugs.gnu.org)(address . 61292@debbugs.gnu.org)
jdZazPGP1fK7xNvyKaWbJenhAKi4VExnJs1SpXEnjBrUcNa0svslH1QkHLuzgru2fClD4Zsf6SAM78qM9coGCHbvz0KIkS1EdZsLPJZCXCs=@lendvai.name
close 61292
stop

i started doing the rename of the variable, but the change quickly grew extensive, so i gave up. it's probably not worth the trouble.

there are 332 grep matches, and the majority requries a change.

--
• attila lendvai
• PGP: 963F 5D5F 45C7 DFCD 0A39
--
“Beware the stories you read or tell; subtly, at night, beneath the waters of consciousness, they are altering your world.”
— Ben Okri (1959–)
?