emacs-nadvice package do not generate autoload file.

This let emacs --debug-init show the below error:

------------------------------------------------------

Debugger entered--Lisp error: (file-missing "Cannot open load file" "?????????" "/gnu/store/gcvj3grb55ic034b9a56p6m182b2qfdr-emacs-nadvice-0.3/share/emacs/site-lisp/nadvice-0.3/nadvice-autoloads")

load("/gnu/store/gcvj3grb55ic034b9a56p6m182b2qfdr-emacs-nadvice-0.3/share/emacs/site-lisp/nadvice-0.3/nadvice-autoloads" nil t)

package-activate-1(#s(package-desc :name nadvice :version (0 3) :summary "Forward compatibility for Emacs-24.4's nadvice" :reqs nil :kind nil :archive nil :dir "/gnu/store/gcvj3grb55ic034b9a56p6m182b2qfdr-emacs-..." :extras ((:maintainer "Stefan Monnier" . "monnier@iro.umontreal.ca") (:authors ("Stefan Monnier" . "monnier@iro.umontreal.ca"))) :signed nil) nil deps)

package-activate(nadvice)

package-activate-1(#s(package-desc :name compat :version (28 1 2 2) :summary "Emacs Lisp Compatibility Library" :reqs ((emacs (24 3)) (nadvice (0 3))) :kind nil :archive nil :dir "/gnu/store/an425abx04g2hhg11c39h0y63gf6wc3l-emacs-..." :extras ((:url . "https://sr.ht/~pkal/compat")(:keywords "lisp") (:maintainer "Compat Development" . "~pkal/compat-devel@lists.sr.ht") (:authors ("Philip Kaludercic" . "philipk@posteo.net"))) :signed nil) nil deps)

package-activate(compat)

package-activate-1(#s(package-desc :name magit :version (3 3 0 -4) :summary "A Git porcelain inside Emacs." :reqs ((emacs (25 1)) (compat (28 1 1 2)) (dash (20210826)) (git-commit (20220222)) (magit-section (20220325)) (transient (20220325)) (with-editor (20220318))) :kind nil :archive nil :dir "/gnu/store/pg4c1sm7llfh20bxk44z5s2xr525246v-emacs-..." :extras ((:keywords "git" "tools" "vc") (:homepage . "https://magit.vc")) :signed nil) nil deps)

package-activate(magit)

package--activate-all()

package-activate-all()

package-initialize()

(if package--initialized nil (package-initialize))

eval-buffer(#<buffer *load*-797460> nil "/gnu/store/pszj3mq14iv9wknk3yk0qpx440a1hppg-Emacs-..." nil t) ; Reading at buffer position 4608

load-with-code-conversion("/gnu/store/pszj3mq14iv9wknk3yk0qpx440a1hppg-Emacs-..." "/gnu/store/pszj3mq14iv9wknk3yk0qpx440a1hppg-Emacs-..." nil t)

require(eh-basic)

eval-buffer(#<buffer *load*-921378> nil "/gnu/store/pszj3mq14iv9wknk3yk0qpx440a1hppg-Emacs-..." nil t) ; Reading at buffer position 1235

load-with-code-conversion("/gnu/store/pszj3mq14iv9wknk3yk0qpx440a1hppg-Emacs-..." "/gnu/store/pszj3mq14iv9wknk3yk0qpx440a1hppg-Emacs-..." nil t)

require(emacs-helper)

eval-buffer(#<buffer *load*> nil "/home/feng/.emacs" nil t) ; Reading at buffer position 3366

load-with-code-conversion("/home/feng/.emacs" "/home/feng/.emacs" t t)

load("~/.emacs" noerror nomessage)

startup--load-user-init-file(#f(compiled-function () #<bytecode 0x108875929997f362>) #f(compiled-function () #<bytecode -0x1f3c61addc0b8a75>) t)

command-line()

normal-top-level()

--

Hello,

Feng Shu <tumashu@163.com> writes:

This is now mitigated in commit db746d16602f4b22ed678aaaeeb5974398d27874.

To properly fix this, as the next step, I'm leaning towards removing

emacs-nadvice package altogether. It is not useful in Guix since we

provide Emacs 28+.

WDYT?

Regards,

--

Nicolas Goaziou

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

agree :-)

--

Hello,

Feng Shu <tumashu@163.com> writes:

I'm CC'ing Phodina, since he introduced the package.

Phodina: Do you think there is a reason to keep Emacs Nadvice package

around?

Regards,

--

Nicolas Goaziou

Hi,

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

38 weeks later, I think you can proceed with the removal and close this

issue :-)

--

Thanks,

Maxim

Hello,

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

I know, but it seems the issue apparently disappeared when we updated

nadvice from 0.3 to 0.4, so I lazily opted for status quo while waiting

for an answer.

So, nowadays, I think it doesn't matter much if we remove the package or

not. I'll simply close this bug report unless other issues arise.

Thanks for the heads-up!

Regards,

--

Nicolas Goaziou