[PATCH] guix: gexp: Clarify what output can be in gexp module commentary.

  • Done
  • quality assurance status badge
Details
3 participants
  • jgart
  • Ludovic Courtès
  • zimoun
Owner
unassigned
Submitted by
jgart
Severity
normal
J
J
jgart wrote on 15 Dec 2022 01:26
(address . guix-patches@gnu.org)
20221215002600.13838-1-jgart@dismail.de
* guix/gexp.scm (Commentary): Clarify comment.

Hi Ludo et al,

WDYT

all best,

jgart
---
guix/gexp.scm | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)

Toggle diff (22 lines)
diff --git a/guix/gexp.scm b/guix/gexp.scm
index 5f92174a2c..33d0d8487d 100644
--- a/guix/gexp.scm
+++ b/guix/gexp.scm
@@ -139,10 +139,11 @@ (define-module (guix gexp)
;;; This module implements "G-expressions", or "gexps". Gexps are like
;;; S-expressions (sexps), with two differences:
;;;
-;;; 1. References (un-quotations) to derivations or packages in a gexp are
-;;; replaced by the corresponding output file name; in addition, the
-;;; 'ungexp-native' unquote-like form allows code to explicitly refer to
-;;; the native code of a given package, in case of cross-compilation;
+;;; 1. References (un-quotations) to derivations or packages in a gexp
+;;; are replaced by the corresponding output store path or file name;
+;;; in addition, the 'ungexp-native' unquote-like form allows code to
+;;; explicitly refer to the native code of a given package, in case
+;;; of cross-compilation;
;;;
;;; 2. Gexps embed information about the derivations they refer to.
;;;
--
2.38.1
L
L
Ludovic Courtès wrote on 21 Dec 2022 14:31
(name . jgart)(address . jgart@dismail.de)(address . 60079@debbugs.gnu.org)
8735986fy6.fsf@gnu.org
Hi jgart,

jgart <jgart@dismail.de> skribis:

Toggle quote (16 lines)
> --- a/guix/gexp.scm
> +++ b/guix/gexp.scm
> @@ -139,10 +139,11 @@ (define-module (guix gexp)
> ;;; This module implements "G-expressions", or "gexps". Gexps are like
> ;;; S-expressions (sexps), with two differences:
> ;;;
> -;;; 1. References (un-quotations) to derivations or packages in a gexp are
> -;;; replaced by the corresponding output file name; in addition, the
> -;;; 'ungexp-native' unquote-like form allows code to explicitly refer to
> -;;; the native code of a given package, in case of cross-compilation;
> +;;; 1. References (un-quotations) to derivations or packages in a gexp
> +;;; are replaced by the corresponding output store path or file name;
> +;;; in addition, the 'ungexp-native' unquote-like form allows code to
> +;;; explicitly refer to the native code of a given package, in case
> +;;; of cross-compilation;

I prefer not to apply this patch: it worsens indentation and adds the
words “store path”, which AFAICS bring nothing.

Thanks anyway for taking a look,
Ludo’.
L
L
Ludovic Courtès wrote on 21 Dec 2022 14:31
control message for bug #60079
(address . control@debbugs.gnu.org)
871qos6fxx.fsf@gnu.org
tags 60079 wontfix
close 60079
quit
Z
Z
zimoun wrote on 6 Jan 2023 18:31
Re: [bug#60079] [PATCH] guix: gexp: Clarify what output can be in gexp module commentary.
(address . 60079@debbugs.gnu.org)
87cz7rh8mo.fsf@gmail.com
Hi,

On Wed, 21 Dec 2022 at 14:31, Ludovic Courtès <ludo@gnu.org> wrote:

Toggle quote (19 lines)
>> --- a/guix/gexp.scm
>> +++ b/guix/gexp.scm
>> @@ -139,10 +139,11 @@ (define-module (guix gexp)
>> ;;; This module implements "G-expressions", or "gexps". Gexps are like
>> ;;; S-expressions (sexps), with two differences:
>> ;;;
>> -;;; 1. References (un-quotations) to derivations or packages in a gexp are
>> -;;; replaced by the corresponding output file name; in addition, the
>> -;;; 'ungexp-native' unquote-like form allows code to explicitly refer to
>> -;;; the native code of a given package, in case of cross-compilation;
>> +;;; 1. References (un-quotations) to derivations or packages in a gexp
>> +;;; are replaced by the corresponding output store path or file name;
>> +;;; in addition, the 'ungexp-native' unquote-like form allows code to
>> +;;; explicitly refer to the native code of a given package, in case
>> +;;; of cross-compilation;
>
> I prefer not to apply this patch: it worsens indentation and adds the
> words “store path”, which AFAICS bring nothing.

I agree. Closing?

Toggle quote (2 lines)
> Thanks anyway for taking a look,

Thanks.

Cheers,
simon
J
J
jgart wrote on 6 Jan 2023 23:58
(address . 60079@debbugs.gnu.org)
c42b33d34a02023fa8d5db9ec6014ab6@dismail.de
Sure, feel free to close this one. Thanks for the review.

all best,

jgart
?
Your comment

This issue is archived.

To comment on this conversation send an email to 60079@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 60079
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch