[PATCH core-updates] gnu: wlroots: Add propagated input xcb-util-renderutil

  • Done
  • quality assurance status badge
Details
4 participants
  • Andy Tai
  • Andy Tai
  • Maxim Cournoyer
  • zimoun
Owner
unassigned
Submitted by
Andy Tai
Severity
normal

Debbugs page

Andy Tai wrote 2 years ago
(address . guix-patches@gnu.org)
CAJsg1E8R14VGwoy6Lf=MO4BMYtCp44wETku5t8tEgksK_r2PXw@mail.gmail.com

From dc2194ff0b61e0e4b13953189abc2a847240ce1f Mon Sep 17 00:00:00 2001
From: Andy Tai <atai@atai.org>
Date: Sun, 4 Dec 2022 22:31:32 -0800
Subject: [PATCH] gnu: wlroots: Add propagated input xcb-util-renderutil

gnu/packages/wm.scm (wlroots): Add propagated input xcb-util-renderutil
---
gnu/packages/wm.scm | 1 +
1 file changed, 1 insertion(+)

Toggle diff (14 lines)
diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 201c5994d8..890d51b957 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -1566,6 +1566,7 @@ (define-public wlroots
wayland
wayland-protocols
xcb-util-errors
+ xcb-util-renderutil
xcb-util-wm
xorg-server-xwayland))
(native-inputs
--
2.38.1
zimoun wrote 2 years ago
(name . Andy Tai)(address . lichengtai@gmail.com)(address . 59829@debbugs.gnu.org)
87y1qfj2v5.fsf@gmail.com
Hi,

On Sun, 04 Dec 2022 at 22:44, Andy Tai <lichengtai@gmail.com> wrote:

Toggle quote (2 lines)
> gnu/packages/wm.scm (wlroots): Add propagated input xcb-util-renderutil

Could you explain why this propagation is required? Because propagation
should be avoid at first and it should be used when no other option are
possible, IMHO.


Cheers,
simon
Andy Tai wrote 2 years ago
(name . zimoun)(address . zimon.toutoune@gmail.com)(address . 59829@debbugs.gnu.org)
CAJsg1E8qC6F7uVf49R1f=oTJvkTJwyLzXWuYmv9fb2M_XGpdgw@mail.gmail.com
Hi, I thought propagation inputs are for letting dependent packages to be
able to automatically add this input to its dependency list, like, say,
glib as a propagation input for gtk+ as all gtk+ [programs has glib as an
input or dependency. xcb-util-renderutil seems to have a similar role for
wlroots.

If this is not correct, please file a patch to change it, and merge it.

On Fri, Jan 6, 2023 at 4:07 AM zimoun <zimon.toutoune@gmail.com> wrote:

Toggle quote (16 lines)
> Hi,
>
> On Sun, 04 Dec 2022 at 22:44, Andy Tai <lichengtai@gmail.com> wrote:
>
> > gnu/packages/wm.scm (wlroots): Add propagated input xcb-util-renderutil
>
> Could you explain why this propagation is required? Because propagation
> should be avoid at first and it should be used when no other option are
> possible, IMHO.
>
>
> Cheers,
> simon
>


--
Andy Tai, atai@atai.org Skype: licheng.tai, Line.me: andy_tai, WeChat:
andytai1010
Year 2023 民國112年
自動的精神力是信仰與覺悟
自動的行為力是勞動與技能
Attachment: file
Simon Tournier wrote 2 years ago
Re: [bug#59829] [PATCH core-updates] gnu: wlroots: Add propagated input xcb-util-renderutil
(name . Andy Tai)(address . lichengtai@gmail.com)(address . 59829@debbugs.gnu.org)
87o7r8ypo9.fsf@gmail.com
Hi,

On ven., 06 janv. 2023 at 23:13, Andy Tai <lichengtai@gmail.com> wrote:

Toggle quote (6 lines)
> Hi, I thought propagation inputs are for letting dependent packages to be
> able to automatically add this input to its dependency list, like, say,
> glib as a propagation input for gtk+ as all gtk+ [programs has glib as an
> input or dependency. xcb-util-renderutil seems to have a similar role for
> wlroots.

The manual [1] reads for propagated-inputs:

Lastly, propagated-inputs is similar to inputs, but the
specified packages will be automatically installed to profiles
(see the role of profiles in Guix) alongside the package they
belong to (see guix package, for information on how guix package
deals with propagated inputs).

For example this is necessary when packaging a C/C++ library
that needs headers of another library to compile, or when a
pkg-config file refers to another one via its Requires field.

Another example where propagated-inputs is useful is for
languages that lack a facility to record the run-time search
path akin to the RUNPATH of ELF files; this includes Guile,
Python, Perl, and more. When packaging libraries written in
those languages, ensure they can find library code they depend
on at run time by listing run-time dependencies in
propagated-inputs rather than inputs.


Other said, a dependency is added to the propagated-inputs list when
Guix is not able to automatically determine if the package references a
dependency from the inputs list.

My naive question is: is xcb-util-renderutil required by wlroots to
correctly run?



Cheers,
simon
Andy Tai wrote 2 years ago
(name . Simon Tournier)(address . zimon.toutoune@gmail.com)(address . 59829@debbugs.gnu.org)
CAJsg1E-xthOmkP0EkMRR5LWgT+hXiS9Y+G4qvhViB9XGphOsKg@mail.gmail.com
I added it for XWayland, which requires this if XWayland support is
included in wlroots, which I believe shall be there.

On Mon, Jan 9, 2023 at 4:20 AM Simon Tournier <zimon.toutoune@gmail.com> wrote:
Toggle quote (6 lines)
>
>
> My naive question is: is xcb-util-renderutil required by wlroots to
> correctly run?
>
>
Maxim Cournoyer wrote 2 years ago
Re: bug#59829: [PATCH core-updates] gnu: wlroots: Add propagated input xcb-util-renderutil
(name . Andy Tai)(address . lichengtai@gmail.com)
875yd6a5hh.fsf_-_@gmail.com
Hi Andy,

Andy Tai <lichengtai@gmail.com> writes:

Toggle quote (3 lines)
> I added it for XWayland, which requires this if XWayland support is
> included in wlroots, which I believe shall be there.

It's good to know the reason behind the change, but as Simon said for
propagated inputs, we need a clear, exact understanding of why it is so,
as it's otherwise preferred to simple use simple inputs, and sometimes
wrapping.

Valid reasons currently include: references in public headers or
mentioned in Requires* in pkg-config files (those ending in '.pc'), or
for languages such as Python that lack a way to register dependencies in
binaries like C or C++ can (via RUNPATH in elf).

Can you spot which of the above it is?

--
Thanks,
Maxim
Andy Tai wrote 2 years ago
(name . Maxim Cournoyer)(address . maxim.cournoyer@gmail.com)
CAJsg1E-nRrzhbeVrGTdUPg=-+NoE9za5gqEtUa7nFRLKPvPt-w@mail.gmail.com
hi, I will update the patch moving xcb-util-renderutil to inputs....
that will probably be safer.

On Mon, Jan 16, 2023 at 7:01 AM Maxim Cournoyer
<maxim.cournoyer@gmail.com> wrote:
Toggle quote (26 lines)
>
> Hi Andy,
>
> Andy Tai <lichengtai@gmail.com> writes:
>
> > I added it for XWayland, which requires this if XWayland support is
> > included in wlroots, which I believe shall be there.
>
> It's good to know the reason behind the change, but as Simon said for
> propagated inputs, we need a clear, exact understanding of why it is so,
> as it's otherwise preferred to simple use simple inputs, and sometimes
> wrapping.
>
> Valid reasons currently include: references in public headers or
> mentioned in Requires* in pkg-config files (those ending in '.pc'), or
> for languages such as Python that lack a way to register dependencies in
> binaries like C or C++ can (via RUNPATH in elf).
>
> Can you spot which of the above it is?
>
> --
> Thanks,
> Maxim



--
Andy Tai, atai@atai.org Skype: licheng.tai, Line.me: andy_tai,
WeChat: andytai1010
Year 2023 民國112年
自動的精神力是信仰與覺悟
自動的行為力是勞動與技能
Andy Tai wrote 2 years ago
(address . control@debbugs.gnu.org)
CAJsg1E8s7MLO5SUe9Nqp=FcfpuofCE_4MkHpij7o1FtVhBU2TQ@mail.gmail.com
close 59829
?
Your comment

This issue is archived.

To comment on this conversation send an email to 59829@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 59829
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help