[PATCH] grub-configfile

  • Open
  • quality assurance status badge
Details
3 participants
  • Stefan Karrmann
  • Julien Lepiller
  • (
Owner
unassigned
Submitted by
Stefan Karrmann
Severity
normal
S
S
Stefan Karrmann wrote on 26 Nov 2022 22:12
(address . guix-patches@gnu.org)
Y4KBVnUW27vLnYqX@web.de
Dear all,

somehow ~git send-mail~ seems not to work as expected. Therefore, I send
this patch manually.

The patch allows us to use the menuentry configfile for grub. As I'm still
a newbie with regard to guix, I was not able to test it.

My next step will be:
- patch guix, such that grub can work with btrfs subvolumes

Kind regards,
--
Stefan Karrmann
secure communication? GPG: 0x8C3260C01550B612E4C5730D22E42112094CE53F
(
COMJEAE5PIO9.1GQGIB8NC3M33@guix-framework
On Sat Nov 26, 2022 at 9:12 PM GMT, Stefan Karrmann wrote:
Toggle quote (3 lines)
> somehow ~git send-mail~ seems not to work as expected. Therefore, I send
> this patch manually.

What's the error? :)

-- (
-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEE6Vh10NblKE5doNlW7ImHg/nqI20FAmOCgckACgkQ7ImHg/nq
I23xqgwArRIgu0iToEqqDL68fsYh2TaTxokKW/wJlkkwPP165qySeIHFFinUKmYn
pl9709eNwXyZHzRro6zSqGTAO0F9MKvodqi/f8PW3ZqnjaucICiRtPvXl58u948n
YZ3ARXU9AdRaBJWROOFGSxTjrfxGEbwtwlhseLY3P2mfGvUrpmhqi/JgpltvGkRH
BW0+sWCQHQUXNqdvDtH569G4qTrmNmfA55WTGn53F6dgACFJa88vRdj3G15zZjY2
aThFy2NviZly8J4gV+a2V32LKhmqTujTkfN8OwcVn+yugeSBqrwpWLQx96GCZYXF
5tr3uryo95XQ8VUPmCLZpyF2djlJPBNaES77UUjkfFcVF2t1kInDnmHQypenFNu4
7b5fqwi5Vznz0NOZn7fOlaN3Olm0IhVAmS77uLhVZeg4gQMOnws5clrEhcKTg0BZ
vtEt7irZIugmWEVbcL7ZtgFzlpZB/mmvq5Im6gbO86rzFrRKbDrMpliHVQrMMWM+
heXferhb
=zuxX
-----END PGP SIGNATURE-----


S
S
Stefan Karrmann wrote on 26 Nov 2022 22:23
Re: bug#59619: Acknowledgement ([PATCH] grub-configfile)
(address . 59619@debbugs.gnu.org)(address . paren@disroot.org)
Y4KDy74sjNKflTYn@web.de
Dear paren,

all seems to work, but nothing got through to debbugs.gnu.org. Here is the
output:

====================================================================
$ git send-email --subject='grub configfile' --to='guix-patches@gnu.org' patches/0001-grub-configfile.patch --compose
patches/0001-grub-configfile.patch
E-Mail mit Zusammenfassung ist leer, wird ausgelassen
Die folgenden Dateien sind 8-Bit, aber deklarieren kein
Content-Transfer-Encoding.
patches/0001-grub-configfile.patch
Welches 8-Bit-Encoding soll deklariert werden [UTF-8]?
(mbox) Füge cc: hinzu: "S.Karrmann" <S.Karrmann@web.de> von Zeile 'From: "S.Karrmann" <S.Karrmann@web.de>'

From: "S.Karrmann" <S.Karrmann@web.de>
To: guix-patches@gnu.org
Cc: "S.Karrmann" <S.Karrmann@web.de>
Subject: [PATCH] grub-configfile
Date: Sat, 26 Nov 2022 22:02:33 +0100
Message-Id: <20221126210233.84924-1-S.Karrmann@web.de>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Die Cc-Liste oberhalb wurde um zusätzliche Adressen erweitert, die in der
Commit-Beschreibung des Patches gefunden wurden. Wenn dies passiert, werden
Sie von send-email zu einer Eingabe aufgefordert. Dieses Verhalten wird
durch die Konfigurationseinstellung sendemail.confirm gesteuert.

Für weitere Informationen, führen Sie 'git send-email --help' aus.
Um das aktuelle Verhalten beizubehalten, aber diese Meldung zu unterdrücken,
führen Sie 'git config --global sendemail.confirm auto' aus.

Diese E-Mail versenden? (Ja [y]|Nein [n]|Bearbeiten [e]|Beenden [q]|Alle [a]): y
OK. Log enthält:
Sendmail: /usr/sbin/sendmail -i guix-patches@gnu.org S.Karrmann@web.de
From: "S.Karrmann" <S.Karrmann@web.de>
To: guix-patches@gnu.org
Cc: "S.Karrmann" <S.Karrmann@web.de>
Subject: [PATCH] grub-configfile
Date: Sat, 26 Nov 2022 22:02:33 +0100
Message-Id: <20221126210233.84924-1-S.Karrmann@web.de>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Ergebnis: OK
====================================================================

Sorry, for LANG=de

Kind regards,
--
Stefan Karrmann
(
COMJMP88P91I.HB3E96MW1R33@guix-framework
On Sat Nov 26, 2022 at 9:23 PM GMT, Stefan Karrmann wrote:
Toggle quote (3 lines)
> all seems to work, but nothing got through to debbugs.gnu.org. Here is the
> output:

I'm not really sure what the problem is, but you might have more success following
these instructions:


-- (
-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEE6Vh10NblKE5doNlW7ImHg/nqI20FAmOChF0ACgkQ7ImHg/nq
I21R0QwA3LUVFxYVDPjPkgi2NM8O5gNRvnFIF/ffmSE77eyWK8EPMVqVQxE5hpBT
9TjdXwbEWo1pAB4YOW23cDUopGtRpKc/jybQIFrPeMEYa4vwCtIpDS13sXVWPpmZ
nZqYk9hCGY4gSDKrVme+P00Cu+GjmB2Q3mZ6Jx6X6sqSOYdMRh9Bo9qMbqaQdjaU
uuCdVw3TXuL5LzO9UBws6ltK7NkUiY4dyWLqyu9orLqXeXlvjoqLaac5voAAcXhW
z+ojlES226BqTUkOi3q/nVeXn2PpAYTezizPlF+166KoQe7Bs4pkT0saFuyKslZs
JNBvVv1+Tlayd69ROhQizuop/Psd6LlqNJSoMjZv+xGRq6Pwqha/ahsEjviTFNYn
jq3gd4siIr8SEovzvXzMsVfnEYmhlmloGJibpXlzDnxgNtLe1WxROU7EBtQ2sCj4
d5DT1aZbtzX0DKvziezOmA2MO4HmgLC996ceuSEVvHssnqpKB0JM6MTLZwp6Ylnj
fiAWyo1y
=MMbx
-----END PGP SIGNATURE-----


J
J
Julien Lepiller wrote on 26 Nov 2022 22:32
Re: [bug#59619] [PATCH] grub-configfile
4FC721E0-4300-4978-90BA-F960CDDD1F48@lepiller.eu
If it's your first submission, it gets delayed for manual review, which might be what's happening with send-email. However this email should also have been delayed, so not sure what's happening.

Regarding your patch, tomething seems to have gone wrong. I don't have the tool right now to figure it out, but you have quite a few lines that seem to be identical but marked as changed. What happened there?

One way to test it is to use pre-inst-env to use that new version of guix and build a system (you wouldn't be able to use sudo, so you can't boot it, but you can build and inspect). Something like:

guix gc -R $(./pre-inst-env guix system build example.scm) | grep grub.cfg

Will give you the name of the config file. For less builds, you could use -n and build the derivation for grub.cfg only, manually.

HTH!

Le 26 novembre 2022 22:12:54 GMT+01:00, Stefan Karrmann <S.Karrmann@web.de> a écrit :
Toggle quote (15 lines)
>Dear all,
>
>somehow ~git send-mail~ seems not to work as expected. Therefore, I send
>this patch manually.
>
>The patch allows us to use the menuentry configfile for grub. As I'm still
>a newbie with regard to guix, I was not able to test it.
>
>My next step will be:
>- patch guix, such that grub can work with btrfs subvolumes
>
>Kind regards,
>--
>Stefan Karrmann
>secure communication? GPG: 0x8C3260C01550B612E4C5730D22E42112094CE53F
Attachment: file
?