[PATCH 0/2] nheko: Support video calls

  • Done
  • quality assurance status badge
Details
3 participants
  • Christopher Baines
  • Martin Schmidt
  • (
Owner
unassigned
Submitted by
Martin Schmidt
Severity
normal
M
M
Martin Schmidt wrote on 25 Nov 2022 08:11
(address . guix-patches@gnu.org)(name . Martin Schmidt)(address . martin.schmidt13@gmx.de)
20221125071126.2748-1-martin.schmidt13@gmx.de
Hi Guix,
2 patches for enabling video calls in nheko. Special thanks to "unmatched-paren" for the help and patience!

Martin Schmidt (2):
gnu: Add gst-plugins-good-qt.
gnu: nheko: Support video calls.

gnu/packages/gstreamer.scm | 21 +++++++++++++++++++++
gnu/packages/messaging.scm | 2 +-
2 files changed, 22 insertions(+), 1 deletion(-)


base-commit: 8f3e10ae819aabbe8216bfee6cd3e7857bc27293
--
2.38.0
M
M
Martin Schmidt wrote on 25 Nov 2022 12:13
[PATCH 1/2] gnu: Add gst-plugins-good-qt.
(address . 59569@debbugs.gnu.org)(name . Martin Schmidt)(address . martin.schmidt13@gmx.de)
20221125111313.3128-1-martin.schmidt13@gmx.de
* gnu/packages/gstreamer.scm (gst-plugins-good-qt): New variable.
---
gnu/packages/gstreamer.scm | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)

Toggle diff (32 lines)
diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index a92588a9e2..323fdb6f28 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -734,6 +734,27 @@ (define libsoup
(home-page "https://gstreamer.freedesktop.org/")
(license license:lgpl2.0+)))

+(define-public gst-plugins-good-qt
+ (package (inherit gst-plugins-good)
+ (name "gst-plugins-good-qt")
+ (build-system meson-build-system)
+
+ (inputs
+ (modify-inputs (package-inputs gst-plugins-good)
+ (prepend qtbase-5 qtdeclarative-5 qtx11extras qtwayland-5)))
+
+ (arguments
+ (substitute-keyword-arguments (package-arguments gst-plugins-good)
+ ((#:configure-flags flags #~'())
+ #~(list "-Dgst-plugins-good:qt5=enabled" ))
+
+
+))))
+
+
+
+
+
(define-public gst-plugins-bad
(package
(name "gst-plugins-bad")
--
2.38.0
M
M
Martin Schmidt wrote on 25 Nov 2022 12:13
[PATCH 2/2] gnu: nheko: Support video calls.
(address . 59569@debbugs.gnu.org)(name . Martin Schmidt)(address . martin.schmidt13@gmx.de)
20221125111313.3128-2-martin.schmidt13@gmx.de
* gnu/packages/messaging.scm (nheko)[inputs]: Replace
GST-PLUGINS-GOOD with GST-PLUGINS-GOOD-QT to fix video
calls.
---
gnu/packages/messaging.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (13 lines)
diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 9927c7c323..d23118cce8 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -2459,7 +2459,7 @@ (define-public nheko
curl
gst-plugins-base
gst-plugins-bad ; sdp & webrtc for voip
- gst-plugins-good ; rtpmanager for voip
+ gst-plugins-good-qt ; rtpmanager for voip
json-modern-cxx
libevent
libnice ; for voip
--
2.38.0
(
(
( wrote on 25 Nov 2022 16:57
Re: [bug#59569] [PATCH 1/2] gnu: Add gst-plugins-good-qt.
COLI0GWQ9A78.3VV5O457DL34W@guix-framework
On Fri Nov 25, 2022 at 11:13 AM GMT, Martin Schmidt wrote:
Toggle quote (25 lines)
> * gnu/packages/gstreamer.scm (gst-plugins-good-qt): New variable.

> --- a/gnu/packages/gstreamer.scm
> +++ b/gnu/packages/gstreamer.scm

> @@ -734,6 +734,27 @@ (define libsoup

> +(define-public gst-plugins-good-qt
> + (package (inherit gst-plugins-good)
> + (name "gst-plugins-good-qt")
> + (build-system meson-build-system)
> +
> + (inputs
> + (modify-inputs (package-inputs gst-plugins-good)
> + (prepend qtbase-5 qtdeclarative-5 qtx11extras qtwayland-5)))
> +
> + (arguments
> + (substitute-keyword-arguments (package-arguments gst-plugins-good)
> + ((#:configure-flags flags #~'())
> + #~(list "-Dgst-plugins-good:qt5=enabled" ))

> +
> +
> +))))

Indentation is... a wee bit off :) Also, the build-system override is a no-op.

Try this instead:

(define-public gst-plugins-good-qt
(package
(inherit gst-plugins-good)
(arguments
(substitute-keyword-arguments
(package-arguments gst-plugins-good)
((#:configure-flags flags)
#~(cons "-Dgst-plugins-good:qt5=enabled"
flags))))
(inputs
(modify-inputs (package-inputs gst-plugins-good)
(prepend qtbase-5
qtdeclarative-5
qtwayland-5
qtx11extras)))))

-- (
(
(
( wrote on 25 Nov 2022 17:01
Re: [bug#59569] [PATCH 2/2] gnu: nheko: Support video calls.
COLI416LMYEE.1H54D01TQUYX4@guix-framework
On Fri Nov 25, 2022 at 11:13 AM GMT, Martin Schmidt wrote:
Toggle quote (4 lines)
> * gnu/packages/messaging.scm (nheko)[inputs]: Replace
> GST-PLUGINS-GOOD with GST-PLUGINS-GOOD-QT to fix video
> calls.

LGTM :)

-- (
M
M
Martin Schmidt wrote on 26 Nov 2022 18:35
[PATCH v2 1/2] gnu: Add gst-plugins-good-qt.
(address . 59569@debbugs.gnu.org)(name . Martin Schmidt)(address . martin.schmidt13@gmx.de)
20221126173555.7341-1-martin.schmidt13@gmx.de
* gnu/packages/gstreamer.scm (gst-plugins-good-qt): New variable.
---
gnu/packages/gstreamer.scm | 11 +++++++++++
1 file changed, 11 insertions(+)

Toggle diff (24 lines)
diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index a92588a9e2..37e74b706b 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -734,6 +734,17 @@ (define libsoup
(home-page "https://gstreamer.freedesktop.org/")
(license license:lgpl2.0+)))

+(define-public gst-plugins-good-qt
+ (package
+ (inherit gst-plugins-good)
+ (name "gst-plugins-good-qt")
+ (inputs
+ (modify-inputs (package-inputs gst-plugins-good)
+ (prepend qtbase-5
+ qtdeclarative-5
+ qtwayland-5
+ qtx11extras)))))
+
(define-public gst-plugins-bad
(package
(name "gst-plugins-bad")

base-commit: 8f3e10ae819aabbe8216bfee6cd3e7857bc27293
--
2.38.1
M
M
Martin Schmidt wrote on 26 Nov 2022 18:35
[PATCH v2 2/2] gnu: nheko: Support video calls.
(address . 59569@debbugs.gnu.org)(name . Martin Schmidt)(address . martin.schmidt13@gmx.de)
20221126173555.7341-2-martin.schmidt13@gmx.de
* gnu/packages/messaging.scm (nheko)[inputs]: Replace
GST-PLUGINS-GOOD with GST-PLUGINS-GOOD-QT to fix video
calls.
---
gnu/packages/messaging.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (13 lines)
diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 9927c7c323..d23118cce8 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -2459,7 +2459,7 @@ (define-public nheko
curl
gst-plugins-base
gst-plugins-bad ; sdp & webrtc for voip
- gst-plugins-good ; rtpmanager for voip
+ gst-plugins-good-qt ; rtpmanager for voip
json-modern-cxx
libevent
libnice ; for voip
--
2.38.1
C
C
Christopher Baines wrote on 13 Dec 2022 14:45
Re: [bug#59569] [PATCH 0/2] nheko: Support video calls
(name . Martin Schmidt)(address . martin.schmidt13@gmx.de)
877cyvpgc4.fsf@cbaines.net
Martin Schmidt <martin.schmidt13@gmx.de> writes:

Toggle quote (11 lines)
> Hi Guix,
> 2 patches for enabling video calls in nheko. Special thanks to "unmatched-paren" for the help and patience!
>
> Martin Schmidt (2):
> gnu: Add gst-plugins-good-qt.
> gnu: nheko: Support video calls.
>
> gnu/packages/gstreamer.scm | 21 +++++++++++++++++++++
> gnu/packages/messaging.scm | 2 +-
> 2 files changed, 22 insertions(+), 1 deletion(-)

Thanks both, I've pushed these to master as
34cf5e06a9acd021d1233587e140759bba452b35.

Chris
-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmOYggtfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9Xd5VQ/+KcWQ5aVj/m54P3g6Sn4pkpNNTsDn28r3
OuOPyOmlgK4w+N5eVx6BciGWlbzhTSzOHCxM6R6lM6LbRn1rdivRAh0ZHOPIw0+F
+Pdel3ZHgrMScpuR5VzoDnmnVS82i5In+O+VwWxJhjF9GccDMJXOK0exbt7byAlb
hCXAk8rF/tvIThcclrBdw5u1YjiKOf8BTNt2QAR6RsoLyTdkQNAm4hUH+KMzoW6P
/L+lGA7OL/Fglm+4clulAFNBEnU4yxoMiS498YM1TTriXSRhvLyaDi+Rk2eIlzNN
2MW3xk4ov1rOYVDk9b4DNiUPErMipd525zohPDiDfeCBd7nSerP9+9YGm9iRBdgz
Br0QrADS+Lsa1ldUtcg3kfYu6RHwJ755LVhS7TRVrV7umchyxryDynnqhZYvrc94
pf3iaO21On3SjToWllOo1kXlSHx6Bzh2nPYq1YjsZZkEgU839WZI8xjJtPDLYJTf
YQ/H7HQHKV0WgMW2Zp3OeOJqLPwRZx0+mop2aoLL0DO+C+eNtDwZ+cHiKSFU3b/S
1SxZRVz+DgyS7F/QgISkN+gcS8Jf3xj7CCd+UctyaOIQvbN7Tzx1gfsmXnDzPvSp
Iv8KH/NWJtjzyg/OCozNu9UU1maA7AIBJxCoc7PjwiVMHr/UEGOFfcDgWeirDEZs
vXRxeSABaL8=
=ZlWH
-----END PGP SIGNATURE-----

?