[PATCH] gnu: Add mympd.

  • Done
  • quality assurance status badge
Details
3 participants
  • Christopher Baines
  • mirai
  • (
Owner
unassigned
Submitted by
mirai
Severity
normal
M
(address . guix-patches@gnu.org)(name . Bruno Victal)(address . mirai@makinata.eu)
d919bf1bc6a818f1ecb09ee3cf150307beedb1b7.1668990380.git.mirai@makinata.eu
From: Bruno Victal <mirai@makinata.eu>

* gnu/packages/mpd.scm (mympd): New variable.
---
gnu/packages/mpd.scm | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)

Toggle diff (63 lines)
diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm
index 4e9cb0cb37..881065d103 100644
--- a/gnu/packages/mpd.scm
+++ b/gnu/packages/mpd.scm
@@ -55,6 +55,7 @@ (define-module (gnu packages mpd)
#:use-module (gnu packages gtk)
#:use-module (gnu packages icu4c)
#:use-module (gnu packages libusb)
+ #:use-module (gnu packages lua)
#:use-module (gnu packages readline)
#:use-module (gnu packages check)
#:use-module (gnu packages compression)
@@ -66,6 +67,7 @@ (define-module (gnu packages mpd)
#:use-module (gnu packages music)
#:use-module (gnu packages ncurses)
#:use-module (gnu packages pcre)
+ #:use-module (gnu packages perl)
#:use-module (gnu packages pkg-config)
#:use-module (gnu packages pretty-print)
#:use-module (gnu packages python)
@@ -74,7 +76,9 @@ (define-module (gnu packages mpd)
#:use-module (gnu packages qt)
#:use-module (gnu packages sphinx)
#:use-module (gnu packages sqlite)
+ #:use-module (gnu packages tls)
#:use-module (gnu packages video)
+ #:use-module (gnu packages web)
#:use-module (gnu packages xiph))
(define-public libmpdclient
@@ -561,3 +565,28 @@ (define-public mpdevil
Instead of maintaining a client side database of your music library,
mpdevil loads all tags and covers on demand.")
(license license:gpl3+)))
+
+(define-public mympd
+ (package
+ (name "mympd")
+ (version "10.1.1")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/jcorporation/myMPD")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0cw21sz8xyfz7p8yi03mhriqadrm11x1kqw0pw61v1dkbw13q79c"))))
+ (build-system cmake-build-system)
+ (arguments
+ '(#:tests? #f))
+ (native-inputs (list jq perl))
+ (inputs (list flac libid3tag lua openssl pcre2))
+ (home-page "https://jcorporation.github.io/")
+ (synopsis "Web-based MPD client")
+ (description
+ "myMPD is a standalone and mobile friendly web mpd client with
+a tiny footprint and advanced features.")
+ (license license:gpl3+)))

base-commit: 99ba4ddb03b396f56764a25317f40d4501380704
--
2.38.1
(
COI51N3PIFNK.2BPO69PB2A815@guix-framework
Heya,

On Mon Nov 21, 2022 at 12:26 AM GMT, wrote:
Toggle quote (10 lines)
> * gnu/packages/mpd.scm (mympd): New variable.

> --- a/gnu/packages/mpd.scm
> +++ b/gnu/packages/mpd.scm

> @@ -561,3 +565,28 @@ (define-public mpdevil

> + (arguments
> + '(#:tests? #f))

Please explain why tests are disabled in a comment. Also, please use

(list ...)

rather than

'(...)

for arguments.

Toggle quote (4 lines)
> + (description
> + "myMPD is a standalone and mobile friendly web mpd client with
> +a tiny footprint and advanced features.")

This is a bit markety, I think. How about this?

(description
"MyMPD is a mobile-friendly web client for the MPD music
player daemon.")

-- (
M
[PATCH v2] gnu: Add mympd.
(address . 59437@debbugs.gnu.org)(name . Bruno Victal)(address . mirai@makinata.eu)
269c4a25e11d0ecb3f6a8467796f6f4ed728210e.1669053003.git.mirai@makinata.eu
From: Bruno Victal <mirai@makinata.eu>

* gnu/packages/mpd.scm (mympd): New variable.
---
gnu/packages/mpd.scm | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)

Toggle diff (62 lines)
diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm
index 4e9cb0cb37..4a307d7c49 100644
--- a/gnu/packages/mpd.scm
+++ b/gnu/packages/mpd.scm
@@ -55,6 +55,7 @@ (define-module (gnu packages mpd)
#:use-module (gnu packages gtk)
#:use-module (gnu packages icu4c)
#:use-module (gnu packages libusb)
+ #:use-module (gnu packages lua)
#:use-module (gnu packages readline)
#:use-module (gnu packages check)
#:use-module (gnu packages compression)
@@ -66,6 +67,7 @@ (define-module (gnu packages mpd)
#:use-module (gnu packages music)
#:use-module (gnu packages ncurses)
#:use-module (gnu packages pcre)
+ #:use-module (gnu packages perl)
#:use-module (gnu packages pkg-config)
#:use-module (gnu packages pretty-print)
#:use-module (gnu packages python)
@@ -74,7 +76,9 @@ (define-module (gnu packages mpd)
#:use-module (gnu packages qt)
#:use-module (gnu packages sphinx)
#:use-module (gnu packages sqlite)
+ #:use-module (gnu packages tls)
#:use-module (gnu packages video)
+ #:use-module (gnu packages web)
#:use-module (gnu packages xiph))
(define-public libmpdclient
@@ -561,3 +565,27 @@ (define-public mpdevil
Instead of maintaining a client side database of your music library,
mpdevil loads all tags and covers on demand.")
(license license:gpl3+)))
+
+(define-public mympd
+ (package
+ (name "mympd")
+ (version "10.1.1")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/jcorporation/myMPD")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0cw21sz8xyfz7p8yi03mhriqadrm11x1kqw0pw61v1dkbw13q79c"))))
+ (build-system cmake-build-system)
+ (arguments
+ (list #:tests? #f)) ; no test target
+ (native-inputs (list jq perl))
+ (inputs (list flac libid3tag lua openssl pcre2))
+ (home-page "https://jcorporation.github.io/")
+ (synopsis "Web-based MPD client")
+ (description "MyMPD is a mobile-friendly web client for the MPD music
+player daemon.")
+ (license license:gpl3+)))

base-commit: 2c9635cb47b0f52de635e93ebd137f1f7191c5fd
--
2.38.1
(
COIJOYHTR7C1.3LFFXXV45VKAO@guix-framework
On Mon Nov 21, 2022 at 5:50 PM GMT, wrote:
Toggle quote (2 lines)
> * gnu/packages/mpd.scm (mympd): New variable.

This LGTM! :)

-- (
M
[PATCH v3] gnu: Add mympd.
(address . 59437@debbugs.gnu.org)(name . Bruno Victal)(address . mirai@makinata.eu)
3610eb1ba93f0c51acf8d5cc9bb4470d80d516dc.1669133416.git.mirai@makinata.eu
From: Bruno Victal <mirai@makinata.eu>

* gnu/packages/mpd.scm (mympd): New variable.
---
new upstream release (v10.1.2)

gnu/packages/mpd.scm | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)

Toggle diff (62 lines)
diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm
index 0c8dc16cf9..cd37d4682c 100644
--- a/gnu/packages/mpd.scm
+++ b/gnu/packages/mpd.scm
@@ -56,6 +56,7 @@ (define-module (gnu packages mpd)
#:use-module (gnu packages gtk)
#:use-module (gnu packages icu4c)
#:use-module (gnu packages libusb)
+ #:use-module (gnu packages lua)
#:use-module (gnu packages readline)
#:use-module (gnu packages check)
#:use-module (gnu packages compression)
@@ -67,6 +68,7 @@ (define-module (gnu packages mpd)
#:use-module (gnu packages music)
#:use-module (gnu packages ncurses)
#:use-module (gnu packages pcre)
+ #:use-module (gnu packages perl)
#:use-module (gnu packages pkg-config)
#:use-module (gnu packages pretty-print)
#:use-module (gnu packages python)
@@ -76,7 +78,9 @@ (define-module (gnu packages mpd)
#:use-module (gnu packages serialization)
#:use-module (gnu packages sphinx)
#:use-module (gnu packages sqlite)
+ #:use-module (gnu packages tls)
#:use-module (gnu packages video)
+ #:use-module (gnu packages web)
#:use-module (gnu packages xiph))
(define-public libmpdclient
@@ -573,3 +577,27 @@ (define-public mpdevil
Instead of maintaining a client side database of your music library,
mpdevil loads all tags and covers on demand.")
(license license:gpl3+)))
+
+(define-public mympd
+ (package
+ (name "mympd")
+ (version "10.1.2")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/jcorporation/myMPD")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1cqq09j7mi7dz5y6l7i0sa6vi2n5zrndnrxnqsi4vcg99fc2vwv8"))))
+ (build-system cmake-build-system)
+ (arguments
+ (list #:tests? #f)) ; no test target
+ (native-inputs (list jq perl))
+ (inputs (list flac libid3tag lua openssl pcre2))
+ (home-page "https://jcorporation.github.io/")
+ (synopsis "Web-based MPD client")
+ (description "MyMPD is a mobile-friendly web client for the MPD music
+player daemon.")
+ (license license:gpl3+)))

base-commit: b8d4c323f5d089dd800b358143d5bae26c965404
--
2.38.1
C
C
Christopher Baines wrote on 24 Nov 2022 10:51
(address . mirai@makinata.eu)
87sfi8znl8.fsf@cbaines.net
mirai@makinata.eu writes:

Toggle quote (9 lines)
> From: Bruno Victal <mirai@makinata.eu>
>
> * gnu/packages/mpd.scm (mympd): New variable.
> ---
> new upstream release (v10.1.2)
>
> gnu/packages/mpd.scm | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)

Thanks both! I've pushed this to master as
42898ae8ca25347a4b889bd44203ee7675f0c407.

Chris
-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmN/PtNfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XfBiA//akc3XQ/2QiJhk/xiWvDRUi0jMwPHLeAO
61OqXjfNcfqliO10fEgS2whZd/tosnCACKg9M7XlksqMA7zT1W0Wb1JH12t8p2f0
zeV+aTPFFVOZ5mhxiHucC/V8HnpmRqozuVqBtxpC2yIqT+zjd11VD6oK8cB9f/1c
D9uLGy2lpFqIVRGBXzU04/3qcoMNxUXNnjlwluXOD6aeUYvVS9tSNNA68Tl4crX4
LJroTAMofIgPlJWmO0DQiqNwnP0lbnn3xqJH97FNEjeWeHQz+D1v41/XWU1iT89o
eHUekjqBiDn+K8ToLv8AsHPgx2bKO1ue2045l06sp3jgiYWYPIYDGiQW1Dsh2rFg
41j+NT1HedLO/999phF7Lf6r3RY8Cnx2RoB4Tr5w+1j5BP1qSnKoevX7Qzhp5wxC
ixBoxE5+sM3fyzqO2ozmDWTeN6+2pwZQceJzYJNDfX7t1Zwyf4QlAJ9m+/verIza
PpuuPaUn4WOHnDvOMMuvecRYjwg+ugAKWZPJIrb0pPbYHHhbcUHv3RcLq06qP1/Q
Shl6yE1F+wMqPjyn56hSDDg1u20WAxvFF6w56VD/GejBetXgUtL1nn23EWF4o6NA
jw7V0wU1YzRJWpYVeGPOe+DFLs6K+HPOHD+6MFcI3QCSe8uvuN0RH60Azz1svpot
TM5mo3J+LgM=
=kUlu
-----END PGP SIGNATURE-----

?