[PATCH] gnu: pd: Update to 0.53-0, unbundle oss and portaudio

  • Done
  • quality assurance status badge
Details
3 participants
  • Sughosha
  • 宋文武
  • Christopher Baines
Owner
unassigned
Submitted by
Sughosha
Severity
normal
S
S
Sughosha wrote on 2 Nov 2022 02:28
(name . guix-patches@gnu.org)(address . guix-patches@gnu.org)
1iy1gGLmq4QENuFNQ_0_KrSIcwZ6VL1WHMIRlmbaDs-1OAU8vbTqD139NyBUZaka27bxvFSBERpMqV_imzqOgMWsRFqWvOaMaC_Xs6Vva4k=@proton.me
* gnu/packages/music.scm (pd): Update to 0.53-0.
[arguments]: Unbundle oss and portaudio.
[inputs]: Add portaudio.
---
gnu/packages/music.scm | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

Toggle diff (42 lines)
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index ca400e8..b018c8e 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -2693,24 +2693,26 @@ export.")
(define-public pd
(package
(name "pd")
- (version "0.52-2")
+ (version "0.53-0")
(source (origin
(method url-fetch)
(uri
(string-append "http://msp.ucsd.edu/Software/pd-"
version ".src.tar.gz"))
(sha256
(base32
- "04fcsfgnv2r7g7p8vk9s9n3wba1bx4xgqw5mhwv09xbw9s3gapg9"))))
+ "01zcgw4bg4r422ikqa0d4s7vpgjjz76scnm4l1msnm35y7pzknns"))))
(build-system gnu-build-system)
(arguments
(let ((wish (string-append "wish" (version-major+minor
(package-version tk)))))
(list
#:tests? #f ; no "check" target
#:configure-flags
#~(list
+ "--disable-oss"
"--enable-jack"
+ "--without-local-portaudio"
(string-append "--with-wish="
(search-input-file %build-inputs
(string-append "/bin/" #$wish))))
@@ -2724,7 +2726,7 @@ export.")
(native-inputs
(list autoconf automake libtool gettext-minimal pkg-config))
(inputs
- (list tk alsa-lib jack-1))
+ (list tk alsa-lib jack-1 portaudio))
(home-page "https://puredata.info")
(synopsis "Visual programming language for artistic performances")
(description
--
libgit2 1.4.3
C
C
Christopher Baines wrote on 3 Nov 2022 18:27
(name . Sughosha)(address . Sughosha@proton.me)
87tu3gkktj.fsf@cbaines.net
Sughosha via Guix-patches via <guix-patches@gnu.org> writes:

Toggle quote (7 lines)
> * gnu/packages/music.scm (pd): Update to 0.53-0.
> [arguments]: Unbundle oss and portaudio.
> [inputs]: Add portaudio.
> ---
> gnu/packages/music.scm | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)

Hey Sughosha,

I'm having a bit of trouble matching up the commit message with the
changes being made.

From the diff, it looks like oss is being disabled, rather than
unbundled. What's the reasoning behind disabling it?

Adding portaudio as an input seems fine I guess, but it might be good to
remove the portaudio files from the source (through a snippet) if there
are some there.

Thanks,

Chris
-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmNj+phfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XepLQ//bRL6CniQiTICBenRwGUJ/k0Glexv3P+7
TNS4dn4toAMBGUb3nDNHKGkfzOoh/VbKZ0IRFJfjDEZ1fCQs8s0CDWrntTS3XlFA
ZGNb6ryD8b60s9moE9/Si2SiqrDsPmaKvn7/g9N9G+CFcJpuwMU5U6pgnnN5/2kI
dwoasf12CV8BT6YapzLOMBbfmZ+obNJ6Vjyw7PT7UgZQm4A7GRd928owrFpSv/x3
fv2/S2Fb2eOOJQEn/exmO9hYPebHiEMAb4EgVuw+cHLw5b1ZYwCMyUQAG+jD7cbd
gLVDp1yJJxqhRh6ve/yPP88OVO7dAkRNXFL78+fgSCXjTEy4kY64kKcYMMRNYgeI
/ZZFPD2tph+ie13vev1foSKZMZOa6b03+vH7Sg4oLOayPcAcVLywzLMpeC3C9emR
0zSfdDk5U/y0a/FgUc0THE2qPo8Vrb+u0snmabjRPbrETGASF4gz6zYFEx7Wz4Xk
EznTF7KMJ3NVJJ7L6dDLgtLDiNuCLD7kWy8SmEu6jKLBwWS4uwTSECGWj0NqfE1N
3J++uCPtzFdijcSeeC+IUt/u5GlvxdjA9MNRkYmGV+UgdZhSDOAy6iIWFk1ViVTE
AxS5e+ykivi+0OzJCY9WyTFGs5XgAyQnxoan/7Q55CFPaTlPLhbEInJmS9M/JzqJ
0R53PSXlSp0=
=g/EP
-----END PGP SIGNATURE-----

C
C
Christopher Baines wrote on 3 Nov 2022 18:30
tag 58955 moreinfo
(address . control@debbugs.gnu.org)
87y1ssj68v.fsf@cbaines.net
tags 58955 + moreinfo
quit
S
S
Sughosha wrote on 4 Nov 2022 14:29
Re: [bug#58955] [PATCH] gnu: pd: Update to 0.53-0, unbundle oss and portaudio
(name . Christopher Baines)(address . mail@cbaines.net)
LOSJ7r7IzVOyd74oZrqwpUSIN9ssFcv2s9-PPTZc8v5mL4X5H8EA09VdzLYoatR3mLf9hD3bouU_9isjwp5hCE-jP4U8pL9pB7BjCdWACUA=@proton.me
Hi Christopher,

Thanks for reviewing the patch.

Toggle quote (2 lines)
> From the diff, it looks like oss is being disabled, rather than
> unbundled. What's the reasoning behind disabling it?
OSS is not needed since it was superseded by ALSA and it does the job.
I disabled it because it's not at all used in Guix and also not needed
as we have ALSA. Sorry for not being accurate in the message.
Toggle quote (4 lines)
>
> Adding portaudio as an input seems fine I guess, but it might be good to
> remove the portaudio files from the source (through a snippet) if there
> are some there.
I tried it but autoconf or automake looks for it and gives error, before
starting building.
宋文武 wrote 2 days ago
Re: bug#58955: [PATCH] gnu: pd: Update to 0.53-0, unbundle oss and portaudio
(name . Sughosha)(address . Sughosha@proton.me)
878rhlj0au.fsf_-_@envs.net
Sughosha <Sughosha@proton.me> writes:

Toggle quote (16 lines)
> Hi Christopher,
>
> Thanks for reviewing the patch.
>
>> From the diff, it looks like oss is being disabled, rather than
>> unbundled. What's the reasoning behind disabling it?
> OSS is not needed since it was superseded by ALSA and it does the job.
> I disabled it because it's not at all used in Guix and also not needed
> as we have ALSA. Sorry for not being accurate in the message.
>>
>> Adding portaudio as an input seems fine I guess, but it might be good to
>> remove the portaudio files from the source (through a snippet) if there
>> are some there.
> I tried it but autoconf or automake looks for it and gives error, before
> starting building.

Pushed with adjusted commit message, thank you!
Closed
?