[PATCH] gnu: rust-generic-array-0.14: Fix build.

  • Done
  • quality assurance status badge
Details
3 participants
  • Christopher Baines
  • Maxim Cournoyer
  • Michael Rohleder
Owner
unassigned
Submitted by
Michael Rohleder
Severity
normal
M
M
Michael Rohleder wrote on 18 Oct 2022 16:59
(address . guix-patches@gnu.org)(name . Michael Rohleder)(address . mike@rohleder.de)
20221018145943.16919-1-mike@rohleder.de
* gnu/packages/crates-io.scm (rust-generic-array-0.14)[arguments]: Add #:tests? #false.
---
gnu/packages/crates-io.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Toggle diff (16 lines)
diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 502972ffc5..afd1305018 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -24886,7 +24886,8 @@ (define-public rust-generic-array-0.14
"05qqwm9v5asbil9z28wjkmpfvs1c5c99n8n9gwxis3d3r3n6c52h"))))
(build-system cargo-build-system)
(arguments
- `(#:cargo-inputs
+ `(#:tests? #false ;doc test fails
+ #:cargo-inputs
(("rust-serde" ,rust-serde-1)
("rust-typenum" ,rust-typenum-1)
("rust-version-check" ,rust-version-check-0.9))
--
2.38.0
C
C
Christopher Baines wrote on 21 Oct 2022 18:18
(name . Michael Rohleder)(address . mike@rohleder.de)(address . 58610@debbugs.gnu.org)
87czali1ve.fsf@cbaines.net
Michael Rohleder <mike@rohleder.de> writes:

Toggle quote (5 lines)
> * gnu/packages/crates-io.scm (rust-generic-array-0.14)[arguments]: Add #:tests? #false.
> ---
> gnu/packages/crates-io.scm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

This may fix the build, but instead we'd just be shipping software where
the test suite fails.

If we do want to go that way of disabling the test suite, I think it
would be good to make sure the issue is reported upstream, and link to
that bug report in the package definition, does that make sense?

Thanks,

Chris
-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmNSxwVfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XfI1g/+NrwW6iLVQORXpXUekm0rm3ZlEsWsl26U
Obvu7gv3vQAWMqRz/ra9s2NSxo1xXnXeG8/F4v7EektHiPi2L/1gOWqlMOfCh6wC
HoKP6tkYRolvW/hiE7VLvacKY5yXdonOKxR0sCRQUS15DGjZ3n3xmE+LmOR+btkH
bZvzwGxipyjthZyocftxlGRdDX873u83nFS4tTezzlaFbw3e7LynoHOc/i7VuZC9
REh+ll7uM49E6CivET4koQtZ14O7XZwK7a0piqZgPWwbIOpE1q7DdAe9GsAQlhzL
cDCD2/Hogxp6T5dsICithYbnf13zrlubK+Pm8vvoDkiX8K/0RXy0PbUQluVIaEvh
DA9jIRqZtmFcDpQR6xGO5eirLuWnFEcZfXeRCDGKCQQIPeZVI2UQvlUznhnTDQLL
yjPL7IxZTLTXm0Dl8/IeS8K4hlmGsn58H8WDt6ZARg606nP+u5XuPvufvvrNDiBf
NtxqL8gy1to+n9AcVwnnq5GGVV3wl709qL6SHQ8BQWuYdkhiQU35MF+T7/JjxyVd
k/ntAbEttgb92ISrOIf6udTAt35MF5WKls8q0RhMIPN9PwZFnDWMBZhUB4n2fBhL
j+XNvPDGt7igzKxN34aCP4bts6hSE6jXEBhkOOF780cHVnZKCmFaR4QnRORuNCw9
ZXeqx7dLQmg=
=Akpa
-----END PGP SIGNATURE-----

C
C
Christopher Baines wrote on 3 Nov 2022 17:10
tag 58610 moreinfo
(address . control@debbugs.gnu.org)
87o7to10jf.fsf@cbaines.net
tags 58610 + moreinfo
quit
M
M
Maxim Cournoyer wrote on 3 Jan 2023 23:02
Re: bug#58610: [PATCH] gnu: rust-generic-array-0.14: Fix build.
(name . Christopher Baines)(address . mail@cbaines.net)
87o7rfz37h.fsf_-_@gmail.com
Hello Michael,

Christopher Baines <mail@cbaines.net> writes:

Toggle quote (14 lines)
> Michael Rohleder <mike@rohleder.de> writes:
>
>> * gnu/packages/crates-io.scm (rust-generic-array-0.14)[arguments]: Add #:tests? #false.
>> ---
>> gnu/packages/crates-io.scm | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> This may fix the build, but instead we'd just be shipping software where
> the test suite fails.
>
> If we do want to go that way of disabling the test suite, I think it
> would be good to make sure the issue is reported upstream, and link to
> that bug report in the package definition, does that make sense?

Friendly ping.

--
Thanks,
Maxim
M
M
Michael Rohleder wrote on 7 Jan 2023 00:15
(name . Christopher Baines)(address . mail@cbaines.net)(address . 58610-done@debbugs.gnu.org)
87y1qfgsqf.fsf_-_@rohleder.de
Hello Christopher!

Thank you for reviewing and sorry for the delay!

Christopher Baines <mail@cbaines.net> writes:
Toggle quote (7 lines)
> This may fix the build, but instead we'd just be shipping software where
> the test suite fails.
>
> If we do want to go that way of disabling the test suite, I think it
> would be good to make sure the issue is reported upstream, and link to
> that bug report in the package definition, does that make sense?

I guess this make a lot of sense, but I can't do this, because I don't
have any rust/cargo knowledge, no gh account etc.

This patch was just a quick hack to get synapse working. I should have
thought about fixing it better than just disabling a test.

Sorry for the waste of time and the noise -> closing.

--
There are two types of hard drives: those that have failed, and those that will.
-----BEGIN PGP SIGNATURE-----

iQFFBAEBCAAvFiEEdV4t5dDVhcUueCgwfHr/vv7yyyUFAmO4q4gRHG1pa2VAcm9o
bGVkZXIuZGUACgkQfHr/vv7yyyXZbwf8DFqpVvvs0GbSnzIqCA8jtmvWCrmk9WfE
lsnye91R4OghkIJrGtlCWjEu3HdBXDK+FoDUFP6xKc5LQx2sT+r1FNvS2pmIJ1ki
r5fLd8lxHCUZgzNmpUepYkhh9kQdnf7Y9kgcGfXcjYZOsNvNXRUWEODNw9CIlJT7
IrbDKW1lMi/wVkO+ICQqPp3qglgIhOCiRfVN5Jnf0OJYId8+oDYH+fux1TixQ8wp
N4v//cbnUEhU6D2C3qqOfre8mhwIZ89ptTTqjRyBBWvYDmn0P/643UXPOSJxtOVK
hDGY2nFryyD0PUlz3OgSkbENelV6rJC5De9CvEy7Cw6oT2ARNZwCjQ==
=cUT3
-----END PGP SIGNATURE-----

Closed
?