bash-completion completion functions not loaded when using guix home

Done

Details

3 participants

Andrew Tropin
Maze
wolf

Owner: unassigned

Submitted by: Maze

Severity: normal

Maze wrote on 31 Aug 2022 09:35

Recipients:(address . bug-guix@gnu.org)

Message-ID:20220831073502.ru6dye2wbgc6vrbu@ubik.pkbd.org

I don't install bash-completion into my system profile and I use only

guix home to install user packages. I typically don't guix install any

packages.

While I do include the bash-completion package in my home configuration

file, the completion bash functions do not get loaded as needed, the

resulting user experience is as if bash-completion wasn't installed,

although .bashrc is edited in the typical way to load the main file

bash_completion. But, the shell code in bash_completion cannot find and

load the individual files containing the completion functions for

individual commands.

The reason is that I don't have a ~/.guix-profile folder, my current

user profile is linked in ~/.guix-home/profile. The relevant path (in

my case) is not included in the search path for completion bash functions.

In guix this completion functions search path is defined by the patch found at

gnu/packages/patches/bash-completion-directories.patch, where you can

see the path to the guix home user profile is missing.

The patch below is a patch to the patch file I mention above from the

guix dource tree. It just adds 2 folders to the search path.

I verified that it works for me.

---

bash-completion: fix loading of completion functions with guix home

* gnu/packages/patches/bash-completion-directories.patch: modified

---

gnu/packages/patches/bash-completion-directories.patch | 4 +++-

1 file changed, 3 insertions(+), 1 deletion(-)

Toggle diff (26 lines)diff --git a/gnu/packages/patches/bash-completion-directories.patch b/gnu/packages/patches/bash-completion-directories.patch
index 021e34653b..3c6b3082ea 100644
--- a/gnu/packages/patches/bash-completion-directories.patch
+++ b/gnu/packages/patches/bash-completion-directories.patch
@@ -10,7 +10,7 @@ This is what this patch does.
 
 --- a/bash_completion
 +++ b/bash_completion
-@@ -2016,7 +2016,13 @@ complete -F _minimal ''
+@@ -2016,7 +2016,15 @@ complete -F _minimal ''
  
  __load_completion()
  {
@@ -19,6 +19,8 @@ This is what this patch does.
 +        ${BASH_COMPLETION_USER_DIR:-${XDG_DATA_HOME:-$HOME/.local/share}/bash-completion}/completions
 +        "$HOME/.guix-profile/share/bash-completion/completions/$base"
 +        "$HOME/.guix-profile/etc/bash_completion.d/$base"
++        "$HOME/.guix-home/profile/share/bash-completion/completions/$base"
++        "$HOME/.guix-home/profile/etc/bash_completion.d/$base"
 +        "/run/current-system/profile/share/bash-completion/completions/$base"
 +        "/run/current-system/profile/etc/bash_completion.d/$base" )
 +

base-commit: 47c11772dfe840a536ed7ec438fe832878f51054
-- 
2.36.1

Andrew Tropin wrote on 31 Aug 2022 13:55

Recipients:

Message-ID:87wnaok4ol.fsf@trop.in

On 2022-08-31 15:35, maze@pkbd.org wrote:

Toggle quote (25 lines)> I don't install bash-completion into my system profile and I use only
> guix home to install user packages. I typically don't guix install any
> packages.
>
> While I do include the bash-completion package in my home configuration
> file, the completion bash functions do not get loaded as needed, the
> resulting user experience is as if bash-completion wasn't installed,
> although .bashrc is edited in the typical way to load the main file
> bash_completion. But, the shell code in bash_completion cannot find and
> load the individual files containing the completion functions for
> individual commands.
>
> The reason is that I don't have a ~/.guix-profile folder, my current
> user profile is linked in ~/.guix-home/profile. The relevant path (in
> my case) is not included in the search path for completion bash functions.
>
> In guix this completion functions search path is defined by the patch found at
> gnu/packages/patches/bash-completion-directories.patch, where you can
> see the path to the guix home user profile is missing.
>
> The patch below is a patch to the patch file I mention above from the
> guix dource tree. It just adds 2 folders to the search path. 
>
> I verified that it works for me.

Hi Maze!

That's right, the similiar fix is already applied on core-updates branch

675c5c9bbd28e5e666903aa81efaec25b1573811, unfortunately bash-completion

package update affects a lot of packages that's why it's not on master

branch yet. Thank you for the patch, anyway!

For now, while 1.4 is not released yet, as a temporary fix I can suggest

to install the package providing bash-completion to ~/.guix-profile or

system profile. There are other workarounds, but this one seems to be

the easiest.

Toggle quote (26 lines)>
> ---
>    bash-completion: fix loading of completion functions with guix home
>
>    * gnu/packages/patches/bash-completion-directories.patch: modified
> ---
>  gnu/packages/patches/bash-completion-directories.patch | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/patches/bash-completion-directories.patch b/gnu/packages/patches/bash-completion-directories.patch
> index 021e34653b..3c6b3082ea 100644
> --- a/gnu/packages/patches/bash-completion-directories.patch
> +++ b/gnu/packages/patches/bash-completion-directories.patch
> @@ -10,7 +10,7 @@ This is what this patch does.
>  
>  --- a/bash_completion
>  +++ b/bash_completion
> -@@ -2016,7 +2016,13 @@ complete -F _minimal ''
> +@@ -2016,7 +2016,15 @@ complete -F _minimal ''
>   
>   __load_completion()
>   {
> @@ -19,6 +19,8 @@ This is what this patch does.
>  +        ${BASH_COMPLETION_USER_DIR:-${XDG_DATA_HOME:-$HOME/.local/share}/bash-completion}/completions
>  +        "$HOME/.guix-profile/share/bash-completion/completions/$base"

It seems $base not needed anymore, it's a rudiment from an old version

of the patch. I'll remove it.

Toggle quote (10 lines)

> + "$HOME/.guix-profile/etc/bash_completion.d/$base"

> ++ "$HOME/.guix-home/profile/share/bash-completion/completions/$base"

> ++ "$HOME/.guix-home/profile/etc/bash_completion.d/$base"

> + "/run/current-system/profile/share/bash-completion/completions/$base"

> + "/run/current-system/profile/etc/bash_completion.d/$base" )

> +

> base-commit: 47c11772dfe840a536ed7ec438fe832878f51054

-- 
Best regards,
Andrew Tropin

Andrew Tropin wrote on 31 Aug 2022 13:58

Already fixed on core-updates

Recipients:(address . control@debbugs.gnu.org)

Message-ID:87tu5sk4kg.fsf@trop.in

close 57498

Maze wrote on 31 Aug 2022 14:21

Re: bug#57498: bash-completion completion functions not loaded when using guix home

Recipients:(name . Andrew Tropin)(address . andrew@trop.in)

Message-ID:20220831122122.wsyvyxm56tdt7zkm@ubik.pkbd.org

Thanks for the information and right, it is easy to workaround once

figured out. Next time I find a little thing of this sort I'll be sure to

check on the core-updates branch.

On Wednesday 31 August 2022 at 02:55:54PM, Andrew Tropin has written:

Toggle quote (84 lines)> On 2022-08-31 15:35, maze@pkbd.org wrote:
> 
> > I don't install bash-completion into my system profile and I use only
> > guix home to install user packages. I typically don't guix install any
> > packages.
> >
> > While I do include the bash-completion package in my home configuration
> > file, the completion bash functions do not get loaded as needed, the
> > resulting user experience is as if bash-completion wasn't installed,
> > although .bashrc is edited in the typical way to load the main file
> > bash_completion. But, the shell code in bash_completion cannot find and
> > load the individual files containing the completion functions for
> > individual commands.
> >
> > The reason is that I don't have a ~/.guix-profile folder, my current
> > user profile is linked in ~/.guix-home/profile. The relevant path (in
> > my case) is not included in the search path for completion bash functions.
> >
> > In guix this completion functions search path is defined by the patch found at
> > gnu/packages/patches/bash-completion-directories.patch, where you can
> > see the path to the guix home user profile is missing.
> >
> > The patch below is a patch to the patch file I mention above from the
> > guix dource tree. It just adds 2 folders to the search path. 
> >
> > I verified that it works for me.
> 
> Hi Maze!
> 
> That's right, the similiar fix is already applied on core-updates branch
> 675c5c9bbd28e5e666903aa81efaec25b1573811, unfortunately bash-completion
> package update affects a lot of packages that's why it's not on master
> branch yet.  Thank you for the patch, anyway!
> 
> For now, while 1.4 is not released yet, as a temporary fix I can suggest
> to install the package providing bash-completion to ~/.guix-profile or
> system profile.  There are other workarounds, but this one seems to be
> the easiest.
> 
> >
> > ---
> >    bash-completion: fix loading of completion functions with guix home
> >
> >    * gnu/packages/patches/bash-completion-directories.patch: modified
> > ---
> >  gnu/packages/patches/bash-completion-directories.patch | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/gnu/packages/patches/bash-completion-directories.patch b/gnu/packages/patches/bash-completion-directories.patch
> > index 021e34653b..3c6b3082ea 100644
> > --- a/gnu/packages/patches/bash-completion-directories.patch
> > +++ b/gnu/packages/patches/bash-completion-directories.patch
> > @@ -10,7 +10,7 @@ This is what this patch does.
> >  
> >  --- a/bash_completion
> >  +++ b/bash_completion
> > -@@ -2016,7 +2016,13 @@ complete -F _minimal ''
> > +@@ -2016,7 +2016,15 @@ complete -F _minimal ''
> >   
> >   __load_completion()
> >   {
> > @@ -19,6 +19,8 @@ This is what this patch does.
> >  +        ${BASH_COMPLETION_USER_DIR:-${XDG_DATA_HOME:-$HOME/.local/share}/bash-completion}/completions
> >  +        "$HOME/.guix-profile/share/bash-completion/completions/$base"
> 
> It seems $base not needed anymore, it's a rudiment from an old version
> of the patch. I'll remove it.
> 
> >  +        "$HOME/.guix-profile/etc/bash_completion.d/$base"
> > ++        "$HOME/.guix-home/profile/share/bash-completion/completions/$base"
> > ++        "$HOME/.guix-home/profile/etc/bash_completion.d/$base"
> >  +        "/run/current-system/profile/share/bash-completion/completions/$base"
> >  +        "/run/current-system/profile/etc/bash_completion.d/$base" )
> >  +
> >
> > base-commit: 47c11772dfe840a536ed7ec438fe832878f51054
> 
> 
> -- 
> Best regards,
> Andrew Tropin

Maze

wolf wrote on 18 Mar 2023 12:33

unarchive 57498

Recipients:(address . control@debbugs.gnu.org)

Message-ID:ZBWhoq5MdUKNvMsP@ws

unarchive 57498

wolf wrote on 18 Mar 2023 12:19

Re: bug#57498: bash-completion completion functions not loaded when using guix home

Recipients:(address . 57498@debbugs.gnu.org)

Message-ID:ZBWeNy7yD5N+/m/F@ws

Hi,

if anyone else runs into this before the core-updates merge happens, reasonably

simple solution without installing packages into other profiles (or system-wide)

seems to be to add following into services in home definition:

;; TODO: https://issues.guix.gnu.org/57498,should not be necessary after

;; core-updates merge

(simple-service 'guix-home-bash-completion home-bash-service-type

(home-bash-extension

(bashrc (list (plain-file "load-guix-home-bash-completion" "

for f in ~/.guix-home/profile/etc/bash_completion.d/* ~/.guix-home/profile/share/bash-completion/completions/*; do

[ -r \"$f\" ] && . \"$f\"

done")))))

Leaving it here since it might be useful to someone.

There are only two hard things in Computer Science:

cache invalidation, naming things and off-by-one errors.

Your comment

This issue is archived.

To comment on this conversation send an email to 57498@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 57498

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date