[PATCH 0/7] gnu: Add hydroxide.

I packaged Hydroxide to let you know that I packaged Hydroxide. ?

Here's the list of packages in this patchset:

- go-github-com-emersion-go-imap (required version update)

- go-github-com-boltdb-bolt

- go-github-com-emersion-go-bcrypt

- go-github-com-emersion-go-mbox

- go-github-com-emersion-go-vcard

- go-github-com-emersion-go-webdav

- hydroxide

None of of the dependencies rely on each other, so commit order is irrelevant as long as Hydroxide is last. Several of these patches rely on the Aerc patchset however:

`go-github-com-protonmail-go-crypto`, `go-github-com-emersion-go-message`, `go-github-com-emersion-go-smtp` and their dependencies are already packaged for use with Aerc, so this patchset shouldn't be accepted before Aerc is accepted.

Also, some of Hydroxide's dependencies were already included in Guix.

`go-github-com-emersion-go-imap` was already packaged, but I needed to bump the version so the `go-imap-move`[1] and `go-imap-specialuse`[2] extensions were merged. I sent PR #224[3] to avoid having to package those extensions separately.

`go-golang-org-x-crypto`, `go-golang-org-x-sys` and `go-golang-org-x-term` were also already packaged, and only the latter is directly required by Hydroxide.

Finally, about revision numbers, I'm using the latest Hydroxide commit in order to access my PR and to avoid requiring `go-github-com-mattn-go-isatty` (removed in commit 482bf89). I've also used the latest version for `go-github-com-emersion-go-webdav`, since most recent tagged version is behind enough to cause the Hydroxide build to fail.

[1]: https://github.com/emersion/go-imap-move

[2]: https://github.com/emersion/go-imap-specialuse

[3]: https://github.com/emersion/hydroxide/pull/224

Cairn (7):

gnu: go-github-com-emersion-go-imap: Update to 1.2.1.

gnu: Add go-github-com-boltdb-bolt.

gnu: Add go-github-com-emersion-go-bcrypt.

gnu: Add go-github-com-emersion-go-mbox.

gnu: Add go-github-com-emersion-go-vcard.

gnu: Add go-github-com-emersion-go-webdav.

gnu: Add hydroxide.

gnu/packages/golang.scm | 125 +++++++++++++++++++++++++++++++++++++++-

gnu/packages/mail.scm | 36 ++++++++++++

2 files changed, 159 insertions(+), 2 deletions(-)

--

2.37.2

---

gnu/packages/golang.scm | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)

---

gnu/packages/golang.scm | 25 +++++++++++++++++++++++++

1 file changed, 25 insertions(+)

---

gnu/packages/golang.scm | 26 ++++++++++++++++++++++++++

1 file changed, 26 insertions(+)

---

gnu/packages/golang.scm | 22 ++++++++++++++++++++++

1 file changed, 22 insertions(+)

---

gnu/packages/golang.scm | 24 ++++++++++++++++++++++++

1 file changed, 24 insertions(+)

---

gnu/packages/golang.scm | 24 ++++++++++++++++++++++++

1 file changed, 24 insertions(+)

---

gnu/packages/mail.scm | 36 ++++++++++++++++++++++++++++++++++++

1 file changed, 36 insertions(+)

On Sun, 21 Aug 2022, Cairn via Guix-patches via <guix-patches@gnu.org> wrote:

I was going to start working on this today. Thanks for this

contribution!

--

Olivier Dion

oldiob.dev

Glad to know someone else finds this useful! =)

On Mon Aug 22, 2022 at 12:42 AM BST, Cairn via Guix-patches via wrote:

LGTM

-- (

On Mon Aug 22, 2022 at 12:42 AM BST, Cairn via Guix-patches via wrote:

fail -> failure. Also, might be better as:

(arguments

(list #:import-path "github.com/boltdb/bolt"

;; undefined test flag causes test failure

#:tests? #f))

And a slight formatting nit,

(description

"yadda yadda")

is preferred over

(description "yadda yadda")

-- (

On Mon Aug 22, 2022 at 12:43 AM BST, Cairn via Guix-patches via wrote:

^

wonky indentation here

(arguments

(list #:import-path "github.com/emersion/go-bcrypt"))

inputs -> propagated-inputs (sadly necessary due to the way the

go-build-system works)

possibly better as:

(description

"This package provides an implementation of the @code{bcrypt} password

hash algorithm. This fork adds the @code{GenerateFromPasswordAndSalt}

function."

-- (

On Mon Aug 22, 2022 at 12:43 AM BST, Cairn via Guix-patches via wrote:

Convert this to list style.

(description

"yadda yadda")

-- (

On Mon Aug 22, 2022 at 12:43 AM BST, Cairn via Guix-patches via wrote:

Again, list style.

No need for this field.

Description formatting here, too. Also, IMO "parse and format vCard" sounds

a little weird.

-- (

On Mon Aug 22, 2022 at 12:44 AM BST, Cairn via Guix-patches via wrote:

Change to "0", since it's the first version of this package in Guix.

Arguments -> list-style :)

Do description formatting here, too.

-- (

On Mon Aug 22, 2022 at 12:44 AM BST, Cairn via Guix-patches via wrote:

Change to revision 0.

Use list style.

Convert to something like:

(inputs

(list go-github-com-protonmail-go-crypto

...))

(description

"This package provides an alternative client for the ProtonMail

Bridge. It allows you to use SMTP and IMAP email clients with a

ProtonMail account.")

-- (

On Mon Aug 22, 2022 at 12:44 AM BST, Cairn via Guix-patches via wrote:

Please add a comment explaining why you're using the latest commit.

^ Wonky indentation.

-- (

Thanks for all the feedback (. I'll implement it all soon and send the set again. I have just a couple questions:

Could you explain why this is necessary? It doesn't seem to require it to build or run, at least for me. And do you mean for every package, or just this particular case?

Sounds fine to me. Also, I'm just borrowing the description from the GitHub page. If you do think it should be changed though, what would be a good change?

On Mon, 29 Aug 2022, Cairn via Guix-patches via <guix-patches@gnu.org> wrote:

While thing are getting fixed. Did you manage to configure a proton

mail account to hydroxide correctly? If so, I would use your current

patch locally for setting up my mail account.

--

Olivier Dion

oldiob.dev

Hi Cairn, sorry for the delay!

On Mon Aug 29, 2022 at 1:23 AM BST, Cairn wrote:

This is because Go libraries (though not programs) are stored as source code in the

output directory and later fetched and rebuilt when you build one of their dependents.

So, if go-foo requires go-bar requires go-baz, go-bar will be rebuilt whenever go-foo

is built. But if go-bar doesn't use propagated-inputs, the go-baz dependency of go-bar

will be absent from the build environment.

In this case, we're talking about go-github-com-emersion-go-bcrypt depending on the

go-golang-org-x-crypto package; since x-crypto is probably already propagated in the

hydroxide build environment, as it's quite a common package, you don't see any issues;

but were you to write a package that solely depended on go-bcrypt, it'd fail to build

because x-crypto wasn't in the build environment.

IMO, the use of `vCard' as the object of that phrase without any further explanation

of what `vCard' is sounds a wee bit strange, so maybe something like:

parse and format the vCard file format

Assuming vCard is a file format.

-- (

Thanks for the responses (. They both make sense. I'll start implementing these changes.

Yep! The SMTP server worked at least; I don't have a use case for IMAP. You can either try this or podiki's Peroxide (which you can ask about on the IRC I think). I'm gonna be working on V2 of Hydroxide in order to make it more compatible with Peroxide for whenever it gets sent as a patchset.

I need to wait to send V2 until this issue is resolved:

Otherwise the program's useless.

This issue appears to be fixable with the following: https://github.com/emersion/hydroxide/issues/179#issuecomment-1236208357

Is there a way to create a build with this fix? (maybe a fork will have to be used) It should work.

On Sun Nov 27, 2022 at 4:31 PM GMT, Tyler Wolf via Guix-patches via wrote:

You'd use the ``patches'' field of ``origin'' and the ``search-patches'' procedure,

after turning that fix into a Git patch.

-- (

Hi,

The issue got a fix and has been merged

https://github.com/emersion/hydroxide/pull/232.

--

Olivier Dion

oldiob.dev