[PATCH] gnu: xdg-desktop-portal-wlr: Change elogind to basu for sd-bus.

  • Open
  • quality assurance status badge
Details
3 participants
  • muradm
  • Maxime Devos
  • (
Owner
unassigned
Submitted by
muradm
Severity
normal
M
M
muradm wrote on 31 Jul 2022 17:50
(address . guix-patches@gnu.org)
20220731155038.30945-1-mail@muradm.net
* gnu/packages/freedesktop.scm (xdg-desktop-portal-wlr):
[inputs]: Change elogind to basu.
[arguments]: Specify "-Dsd-bus-provider=basu" explicitly.
---
gnu/packages/freedesktop.scm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Toggle diff (26 lines)
diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index cde7156383..1a30091da0 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -2408,7 +2408,7 @@ (define-public xdg-desktop-portal-wlr
(arguments
`(#:configure-flags
'("-Dsystemd=disabled"
- "-Dsd-bus-provider=libelogind")
+ "-Dsd-bus-provider=basu")
#:phases
(modify-phases %standard-phases
(add-after 'unpack 'hardcode-binaries
@@ -2426,8 +2426,8 @@ (define-public xdg-desktop-portal-wlr
(string-append "execvp(\"" sh)))))))))
(native-inputs
(list cmake pkg-config))
- (inputs (list elogind
- bash-minimal
+ (inputs (list bash-minimal
+ basu
grim
iniparser
libinih
--
2.37.1
M
M
Maxime Devos wrote on 31 Jul 2022 19:38
736a81a6-8f31-1d48-9772-f73ca5bb698c@telenet.be
On 31-07-2022 17:50, muradm wrote:
Toggle quote (3 lines)
> * gnu/packages/freedesktop.scm (xdg-desktop-portal-wlr):
> [inputs]: Change elogind to basu.
> [arguments]: Specify "-Dsd-bus-provider=basu" explicitly.
What's the reason for the switch?
Greetings,
Maxime
Attachment: OpenPGP_0x49E3EE22191725EE.asc
Attachment: OpenPGP_signature
(
(
( wrote on 31 Jul 2022 23:45
CLU65BQO1IBU.2P89UAVO6ITXE@guix-aspire
On Sun Jul 31, 2022 at 6:38 PM BST, Maxime Devos wrote:
Toggle quote (1 lines)
> What's the reason for the switch?
Fewer dependencies (we include only the sd-bus library without the whole
of elogind), and it means eventually desktop users won't ever need elogind
to even exist in their store. (I think this is the reason. I'm not certain,
and there may be something more important, like some incompatibility with
seatd.)

-- (
M
M
Maxime Devos wrote on 1 Aug 2022 01:13
d2847cba-f3a0-d2b6-3d1d-05dd6a1e0048@telenet.be
On 31-07-2022 23:45, ( wrote:
Toggle quote (9 lines)
> On Sun Jul 31, 2022 at 6:38 PM BST, Maxime Devos wrote:
>> What's the reason for the switch?
> Fewer dependencies (we include only the sd-bus library without the whole
> of elogind), and it means eventually desktop users won't ever need elogind
> to even exist in their store. (I think this is the reason. I'm not certain,
> and there may be something more important, like some incompatibility with
> seatd.)
>
> -- (
That's interesting but sounds very non-specific to
xdg-desktop-portal-wlr; I think this would be better to propose on
guix-devel@ to switch elogind->basu for _all_ dependents, not only
xdg-desktop-portal-wlr -- the latter would increate the closure, not
reduce it, because other installed packages would still use elogind.
Greetings,
Maxime.
Attachment: OpenPGP_0x49E3EE22191725EE.asc
Attachment: OpenPGP_signature
M
M
Maxime Devos wrote on 1 Aug 2022 01:32
b2ad3318-d919-6794-fa2f-3f582d97137e@telenet.be
On 01-08-2022 01:13, Maxime Devos wrote:
Toggle quote (20 lines)
>
> On 31-07-2022 23:45, ( wrote:
>> On Sun Jul 31, 2022 at 6:38 PM BST, Maxime Devos wrote:
>>> What's the reason for the switch?
>> Fewer dependencies (we include only the sd-bus library without the whole
>> of elogind), and it means eventually desktop users won't ever need
>> elogind
>> to even exist in their store. (I think this is the reason. I'm not
>> certain,
>> and there may be something more important, like some incompatibility
>> with
>> seatd.)
>>
>>      -- (
>
> That's interesting but sounds very non-specific to
> xdg-desktop-portal-wlr; I think this would be better to propose on
> guix-devel@ to switch elogind->basu for _all_ dependents, not only
> xdg-desktop-portal-wlr -- the latter would increate the closure, not
> reduce it, because other installed packages would still use elogind.
Additionally, the reason should have been mentioned in the commit message.
Greetings,
Maxime.
Attachment: OpenPGP_0x49E3EE22191725EE.asc
Attachment: OpenPGP_signature
M
M
muradm wrote on 1 Aug 2022 06:55
(name . Maxime Devos)(address . maximedevos@telenet.be)
87wnbspm1n.fsf@muradm.net
Hi,

Regarding switching, I don't think it is very straight forward
to switch elogind with basu. Issue is that elogind "also" includes
sd-bus. Dependents may require either sd-bus and/or other parts
of elogind. Those who require sd-bus only to interface with bus
could be switched to basu gradually. Most likely this will be
suitable for "minimalist" applications.

I.e. basu is a drop-in replacement for those require sd-bus only,
but not whole elogind.

Thanks in advance,
muradm

Maxime Devos <maximedevos@telenet.be> writes:

Toggle quote (41 lines)
> [[PGP Signed Part:Undecided]]
>
> On 01-08-2022 01:13, Maxime Devos wrote:
>>
>> On 31-07-2022 23:45, ( wrote:
>>> On Sun Jul 31, 2022 at 6:38 PM BST, Maxime Devos wrote:
>>>> What's the reason for the switch?
>>> Fewer dependencies (we include only the sd-bus library without
>>> the whole
>>> of elogind), and it means eventually desktop users won't ever
>>> need
>>> elogind
>>> to even exist in their store. (I think this is the reason. I'm
>>> not
>>> certain,
>>> and there may be something more important, like some
>>> incompatibility with
>>> seatd.)
>>>
>>>      -- (
>>
>> That's interesting but sounds very non-specific to
>> xdg-desktop-portal-wlr; I think this would be better to propose
>> on
>> guix-devel@ to switch elogind->basu for _all_ dependents, not
>> only
>> xdg-desktop-portal-wlr -- the latter would increate the
>> closure, not
>> reduce it, because other installed packages would still use
>> elogind.
>
> Additionally, the reason should have been mentioned in the
> commit message.
>
> Greetings,
> Maxime.
>
> [2. OpenPGP public key --- application/pgp-keys;
> OpenPGP_0x49E3EE22191725EE.asc]...
>
> [[End of PGP Signed Part]]
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEESPY5lma9A9l5HGLP6M7O0mLOBeIFAmLnZSQACgkQ6M7O0mLO
BeLphhAAly2xWsAo/v3eCytkRbetlExuAhKOU9kdsNdxJcdAANyUEguHtv2Fo9GF
97c6fNJZPoJELTmv9cExj0xXD85yr5gL2G3+HSvPkc8/yloIMU+PYPlJPc+fuIWO
YxdAjyPAW18GosGuZqj31Da43hXA9pdUoHdSjLscF+lLkFYKM3v7Dcr7aGGiJRQv
1UTVdr3m91/7Ou5akq4D1Eyt7wDZZj8yRRMEgXldJYI2k6CeGQ8+nIqMM6glyrBv
w0OdrEVvGkLvCpbkMin9rLxgPLjm/OX4blINmga5YBWEFi7YNRs+ff43d+Q41XDx
6iJNCMICz42j3UYtOLsIee0MAUP8qJ6xZqV3ubUtsZtGJ9MWRe/YbXb/anohUUwo
PanJZ6ZfFn8U/w+BGTbVYbsAN9xOJTFXTmfwyq5DVV1iZwxtxMc47sG4oGmK8q7t
5btamm7/owjyn3I762YHRmEBjKf2ueZqWJGxRU6pXG9eBf81j9MTO+UCSwf8fKQT
Az2yeyRro4OMAlTetST2NAObwh0w0HX/N6PoZongSgQQm/30KTx6TJ2iurlGI/W5
vD4NChuY0nHLsLMjFsFx7KbKaKzZwW24brTPjgrEue5s+6l8qxjbRydWumuu6B4i
hNRWpotISp+6SQMitCfxf2vlLG7+yMLfNHZxyu3kciiZF5/oeuQ=
=Lr/i
-----END PGP SIGNATURE-----

M
M
muradm wrote on 1 Aug 2022 07:35
[PATCH v2] gnu: xdg-desktop-portal-wlr: Change elogind to basu for sd-bus.
(address . 56859@debbugs.gnu.org)
20220801053520.2449-1-mail@muradm.net
* gnu/packages/freedesktop.scm (xdg-desktop-portal-wlr):
[inputs]: Change elogind to basu.
[arguments]: Specify "-Dsd-bus-provider=basu" explicitly.

xdg-desktop-portal-wlr requires only sd-bus which is now
available via basu as standalone.
---
gnu/packages/freedesktop.scm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Toggle diff (26 lines)
diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index cde7156383..1a30091da0 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -2408,7 +2408,7 @@ (define-public xdg-desktop-portal-wlr
(arguments
`(#:configure-flags
'("-Dsystemd=disabled"
- "-Dsd-bus-provider=libelogind")
+ "-Dsd-bus-provider=basu")
#:phases
(modify-phases %standard-phases
(add-after 'unpack 'hardcode-binaries
@@ -2426,8 +2426,8 @@ (define-public xdg-desktop-portal-wlr
(string-append "execvp(\"" sh)))))))))
(native-inputs
(list cmake pkg-config))
- (inputs (list elogind
- bash-minimal
+ (inputs (list bash-minimal
+ basu
grim
iniparser
libinih
--
2.37.1
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 56859@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 56859
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch