[PATCH] FeatherNotes package

DoneSubmitted by Pavel Shlyak.
Details
2 participants
  • 宋文武
  • Pavel Shlyak
Owner
unassigned
Severity
normal
P
P
Pavel Shlyak wrote on 31 Jul 00:50 +0200
[PATCH] FeatherNotes package
(address . guix-patches@gnu.org)
02AE39B2-C363-4254-A390-B6B3FD81F12E@pantherx.org
Hello!

Here is my patch to add FeatherNotes package to guix. I upstream it from PantherX channel, hence 3 copyright lines.
I build it against Qt5 as Qt6 support in FeatherNotes is experimental and is not recommended for daily usage yet.

Thank you in advance for your feedback.
Have a nice day!
P
P
Pavel Shlyak wrote on 2 Aug 00:11 +0200
[PATCH] FeatherNotes package
(address . 56846@debbugs.gnu.org)
C3B8B091-94C5-45F4-A903-D7924474215E@pantherx.org
I updated the patch as qt5 packages were renamed.
宋文武 wrote on 3 Aug 03:28 +0200
Re: bug#56846: [PATCH] FeatherNotes package
(name . Pavel Shlyak)(address . p.shlyak@pantherx.org)(address . 56846@debbugs.gnu.org)
87sfmeqfmw.fsf_-_@envs.net
Pavel Shlyak <p.shlyak@pantherx.org> writes:

Toggle quote (2 lines)
> I updated the patch as qt5 packages were renamed.

Hello, I'm not a native English speaker, well some comments about
wording follow:
Toggle quote (7 lines)
>
> From 17daab0381b5d69d6be59c5aa415b3f1fefeaba7 Mon Sep 17 00:00:00 2001
> From: Pavel Shlyak <p.shlyak@pantherx.org>
> Date: Sun, 31 Jul 2022 01:19:07 +0300
> Subject: [PATCH] gnu: feathernotes: new package.
>
> * gnu/packages/task-management.scm (feathernotes): new package.
When adding a new package, the "tradition" is:

gnu: Add feathernotes.

* gnu/packages/task-management.scm (feathernotes): New package.


Toggle quote (18 lines)
> ---
> gnu/packages/task-management.scm | 35 +++++++++++++++++++++++++++++++-
> 1 file changed, 34 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/task-management.scm b/gnu/packages/task-management.scm
> index f8f52a8ccd..93e784da18 100644
> --- a/gnu/packages/task-management.scm
> +++ b/gnu/packages/task-management.scm
> @@ -1,10 +1,13 @@
> ;;; GNU Guix --- Functional package management for GNU
> ;;; Copyright © 2015 Tomáš Čech <sleep_walker@suse.cz>
> ;;; Copyright © 2020 Vinicius Monego <monego@posteo.net>
> +;;; Copyright © 2020 Hamzeh Nasajpour <h.nasajpour@pantherx.org>
> ;;; Copyright © 2021 Eric Bavier <bavier@posteo.net>
> ;;; Copyright © 2021 Stefan Reichör <stefan@xsteve.at>
> ;;; Copyright © 2021 LibreMiami <packaging-guix@libremiami.org>
> +;;; Copyright © 2021 Reza Alizadeh Majd <r.majd@pantherx.org>

Why here are 2020 and 2021 changes?

Toggle quote (55 lines)
> ;;; Copyright © 2022 Foo Chuan Wei <chuanwei.foo@hotmail.com>
> +;;; Copyright © 2022 Pavel Shlyak <p.shlyak@pantherx.org>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -32,6 +35,7 @@ (define-module (gnu packages task-management)
> #:use-module (gnu packages gnome)
> #:use-module (gnu packages gstreamer)
> #:use-module (gnu packages gtk)
> + #:use-module (gnu packages libreoffice) ;for hunspell
> #:use-module (gnu packages linux)
> #:use-module (gnu packages lua)
> #:use-module (gnu packages ncurses)
> @@ -39,6 +43,7 @@ (define-module (gnu packages task-management)
> #:use-module (gnu packages python)
> #:use-module (gnu packages python-build)
> #:use-module (gnu packages python-xyz)
> + #:use-module (gnu packages qt)
> #:use-module (gnu packages time)
> #:use-module (gnu packages tls)
> #:use-module (guix download)
> @@ -49,7 +54,8 @@ (define-module (gnu packages task-management)
> #:use-module (guix build-system gnu)
> #:use-module (guix build-system go)
> #:use-module (guix build-system meson)
> - #:use-module (guix build-system python))
> + #:use-module (guix build-system python)
> + #:use-module (guix build-system qt))
>
> (define-public clikan
> (let ((commit "55ab29e68263c6fed2844aef96fbebacda3eba9b")
> @@ -281,6 +287,33 @@ (define-public blanket
> You can also use it to fall asleep in a noisy environment.")
> (license license:gpl3+)))
>
> +(define-public feathernotes
> + (package
> + (name "feathernotes")
> + (version "0.10.0")
> + (home-page "https://github.com/tsujan/FeatherNotes")
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url home-page)
> + (commit (string-append "V" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "122pbbxvi0mmhbz8m8far71vm72090r5cafss4hvrsjmq52a0y4k"))))
> + (build-system qt-build-system)
> + (arguments (list #:tests? #f)) ; no upstream tests
> + (native-inputs (list pkg-config qttools-5)) ; for lrelease
> + (inputs (list hunspell qtsvg-5 qtx11extras qtbase-5))
> + (synopsis "GUI hierarchical notes-manager")

Maybe "notes manager" is better than "notes-manager"?
Toggle quote (3 lines)
> + (description "FeatherNotes is a GUI hierarchical notes-manager for Linux.
> +It is independent of any desktop environment and has
> +rich text formatting, image embedding and inserting editable tables
Seem missing a "," after "editable tables".

Toggle quote (9 lines)
> +spell checking, searchable tags, drag and drop support, tray icon,
> +node icons, hyperlinks, pdf and html export, password protection
> +and auto-saving.")
> + (license license:gpl3+)))
> +
> (define-public wtime
> (package
> (name "wtime")

Otherwise it looks good to me, thank you!
P
P
Pavel Shlyak wrote on 3 Aug 10:16 +0200
(name . 宋文武)(address . iyzsong@envs.net)(address . 56846@debbugs.gnu.org)
7A70BCBD-7221-4F47-8C52-1C96E1A6154E@pantherx.org
Toggle quote (2 lines)
> Maybe "notes manager" is better than "notes-manager"?

I copied the this from the original README (https://github.com/tsujan/FeatherNotes/blob/master/README.md)

Toggle quote (2 lines)
> Why here are 2020 and 2021 changes?

Because I upstream this package from another repo where it was packaged long time ago.

Toggle quote (2 lines)
> Seem missing a "," after "editable tables».

Yes

Toggle quote (2 lines)
> When adding a new package, the "tradition" is:

I would be happy if it was edited during merge.
宋文武 wrote on 4 Aug 03:23 +0200
(name . Pavel Shlyak)(address . p.shlyak@pantherx.org)(address . 56846-done@debbugs.gnu.org)
87edxw2453.fsf_-_@envs.net
Pavel Shlyak <p.shlyak@pantherx.org> writes:

Toggle quote (16 lines)
>> Maybe "notes manager" is better than "notes-manager"?
>
> I copied the this from the original README (https://github.com/tsujan/FeatherNotes/blob/master/README.md)
>
>> Why here are 2020 and 2021 changes?
>
> Because I upstream this package from another repo where it was packaged long time ago.
>
>> Seem missing a "," after "editable tables».
>
> Yes
>
>> When adding a new package, the "tradition" is:
>
> I would be happy if it was edited during merge.

Done, thank you!
Closed
?
Your comment

This issue is archived.

To comment on this conversation send email to 56846@debbugs.gnu.org