[PATCH 0/2] gnu: Add python-i3ipc and python-autotiling.

Hi Guix,

These patches add autotiling (a tool to automatically switch the

horizontal/vertical window split orientation in i3 and sway) and its

dependency i3ipc.

Since I do not have a working X environment, their tests are currently

disabled.

Thanks!

Hilton Chain (2):

gnu: Add python-i3ipc

gnu: Add python-autotiling.

gnu/packages/python-xyz.scm | 50 +++++++++++++++++++++++++++++++++++++

1 file changed, 50 insertions(+)

base-commit: 32a00363435ac8c1bc93ef1281b2c2afc28a8877

--

2.36.1

---

gnu/packages/python-xyz.scm | 23 +++++++++++++++++++++++

1 file changed, 23 insertions(+)

---

gnu/packages/python-xyz.scm | 27 +++++++++++++++++++++++++++

1 file changed, 27 insertions(+)

Hello!

On Sat Jul 23, 2022 at 7:31 AM BST, Hilton Chain via Guix-patches via wrote:

Could you add an explanation of why the test fails in a comment, if

possible? Also, (arguments (list ...)) is now generally preferred to

(arguments '(...)) :)

-- (

On Sat Jul 23, 2022 at 7:31 AM BST, Hilton Chain via Guix-patches via wrote:

You'll want to propagate this input, as is usually done for Python

libraries.

-- (

On Sat Jul 23, 2022 at 7:33 AM BST, Hilton Chain via Guix-patches via wrote:

I think this should be changed to `i3-autotiling`, since it's a Python

program, not a library.

Same here.

Can you add an explanation and change to (list ...) style here too,

please?

I think python-wheel only needs to be a native-input, and python-xlib

can be removed if you propagate it in python-i3ipc.

-- (

v1 -> v2:

Thank you, ( !

Hilton Chain (2):

gnu: Add python-i3ipc.

gnu: Add i3-autotiling.

gnu/packages/python-xyz.scm | 48 +++++++++++++++++++++++++++++++++++++

1 file changed, 48 insertions(+)

base-commit: 32a00363435ac8c1bc93ef1281b2c2afc28a8877

--

2.36.1

---

gnu/packages/python-xyz.scm | 22 ++++++++++++++++++++++

1 file changed, 22 insertions(+)

--

2.36.1

---

gnu/packages/python-xyz.scm | 26 ++++++++++++++++++++++++++

1 file changed, 26 insertions(+)

--

2.36.1

Almost LGTM :)

On Sat Jul 23, 2022 at 11:31 AM BST, Hilton Chain wrote:

i3wm -> i3 and sway -> Sway maybe?

Maybe better as:

(description

"This package provides a Python library for controlling the i3 and Sway

window managers.")

Also, have you run `guix lint python-i3ipc i3-autotiling`? Make sure to

do that and resolve any issues it raises :)

-- (

On Sat Jul 23, 2022 at 11:31 AM BST, Hilton Chain wrote:

I think a synopsis that spills onto multiple lines is probably too long.

How about simply:

(synopsis "Automatically tile windows in i3 and Sway")

Maybe something like:

(description

"This package provides a script that automatically switches the layout

of an i3 or Sway desktop based on the dimensions of the focused window.")

(By the way, that's the standard formatting for a description: the

string is on a new line.)

-- (

On 23-07-2022 12:31, Hilton Chain via Guix-patches via wrote:

You can make a working X environment with "xvfb-run -- the-test-command"

or with (IIRC) "Xvfb :1&" + (sleep 1) (preferably the former, as the

latter is racy) -- search with "git grep -F xvfb-run" or "git grep -F

Xvfb" for examples.

Greetings,

Maxime.

Thanks!

xvfb-run works well, however some "Fontconfig error: No writable cache directories"

occurs. I don't know what to do with this, do you have any ideas?

---

/gnu/store/65i3nhcwmz0p8rqbg48gaavyky4g4hwk-python-3.9.9/lib/python3.9/selectors.py:469: Failed

---------------------------- Captured stderr setup -----------------------------

Fontconfig error: No writable cache directories

Fontconfig error: No writable cache directories

----------------------------- Captured stderr call -----------------------------

Fontconfig error: No writable cache directories

Fontconfig error: No writable cache directories

------------------------------ Captured log call -------------------------------

ERROR asyncio:base_events.py:1738 Task exception was never retrieved

future: <Task finished name='Task-82' coro=<Connection.command() done, defined at /gnu/store/gwsda4lb70rzazfh0kzx9z3wx5i4z43b-python-i3ipc-2.2.1/lib/python3.9/site-packages/i3ipc/aio/connection.py:503> exception=OSError(107, 'Transport endpoint is not connected')>

Traceback (most recent call last):

File "/gnu/store/gwsda4lb70rzazfh0kzx9z3wx5i4z43b-python-i3ipc-2.2.1/lib/python3.9/site-packages/i3ipc/aio/connection.py", line 514, in command

data = await self._message(MessageType.COMMAND, cmd)

File "/gnu/store/gwsda4lb70rzazfh0kzx9z3wx5i4z43b-python-i3ipc-2.2.1/lib/python3.9/site-packages/i3ipc/aio/connection.py", line 407, in _message

await self._loop.sock_sendall(self._cmd_socket, _pack(message_type, payload))

File "/gnu/store/65i3nhcwmz0p8rqbg48gaavyky4g4hwk-python-3.9.9/lib/python3.9/asyncio/selector_events.py", line 446, in sock_sendall

n = sock.send(data)

OSError: [Errno 107] Transport endpoint is not connected

ERROR asyncio:base_events.py:1738 Future exception was never retrieved

future: <Future finished exception=FileNotFoundError(2, 'No such file or directory')>

Traceback (most recent call last):

File "/gnu/store/gwsda4lb70rzazfh0kzx9z3wx5i4z43b-python-i3ipc-2.2.1/lib/python3.9/site-packages/i3ipc/aio/connection.py", line 383, in do_reconnect

await self.connect()

File "/gnu/store/gwsda4lb70rzazfh0kzx9z3wx5i4z43b-python-i3ipc-2.2.1/lib/python3.9/site-packages/i3ipc/aio/connection.py", line 359, in connect

self._cmd_socket.connect(self.socket_path)

FileNotFoundError: [Errno 2] No such file or directory

On 23-07-2022 13:38, Hilton Chain wrote:

For these kind of things, creating the relevant directory and setting an

environment variable tends to work. Maybe try (setenv "HOME"

(getcwd)))?  However, IIUC, these fontconfig errors can usually be

ignored (probably because it's just a cache?), likely the "Transport

endpoint is not connected" test failure is independent.

My guess is that it tries to connect to the WM i3, but that WM is not

running in the build environment fails.

You could give starting the WM before running the test a try, but maybe

it's not worth the effort.

Greetings,

Maxime.

On Sat Jul 23, 2022 at 1:17 PM BST, Maxime Devos wrote:

We got this working on IRC :)

Looks like the tests do a popen on i3 themselves:

-- (

v2 -> v3: synopsis and description changes suggested by (

Hilton Chain (2):

gnu: Add python-i3ipc.

gnu: Add i3-autotiling.

gnu/packages/python-xyz.scm | 49 +++++++++++++++++++++++++++++++++++++

1 file changed, 49 insertions(+)

base-commit: 32a00363435ac8c1bc93ef1281b2c2afc28a8877

--

2.36.1

---

gnu/packages/python-xyz.scm | 24 ++++++++++++++++++++++++

1 file changed, 24 insertions(+)

---

gnu/packages/python-xyz.scm | 25 +++++++++++++++++++++++++

1 file changed, 25 insertions(+)

On Sat Jul 23, 2022 at 1:48 PM BST, Hilton Chain wrote:

I think you should probably change this one, too. 'splith'/'splitv'

doesn't make much sense as there's no mention of sway or i3 until the

end. Also, sway -> Sway :)

-- (

v3 -> v4: description change for i3-autotiling.

Hilton Chain (2):

gnu: Add python-i3ipc.

gnu: Add i3-autotiling.

gnu/packages/python-xyz.scm | 48 +++++++++++++++++++++++++++++++++++++

1 file changed, 48 insertions(+)

base-commit: 32a00363435ac8c1bc93ef1281b2c2afc28a8877

--

2.36.1

---

gnu/packages/python-xyz.scm | 24 ++++++++++++++++++++++++

1 file changed, 24 insertions(+)

--

2.36.1

---

gnu/packages/python-xyz.scm | 24 ++++++++++++++++++++++++

1 file changed, 24 insertions(+)

--

2.36.1

Hi,

Hilton Chain <hako@ultrarare.space> skribis:

Applied, thank you, and thanks to the reviewers!

Ludo’.

On Sat Aug 6, 2022 at 10:14 PM BST, Ludovic Courtès wrote:

Thanks Ludo! :D

-- (