‘tests/services/telephony.scm’ fails to run

  • Done
  • quality assurance status badge
Details
3 participants
  • Lars-Dominik Braun
  • Ludovic Courtès
  • Maxim Cournoyer
Owner
unassigned
Submitted by
Ludovic Courtès
Severity
normal
L
L
Ludovic Courtès wrote on 1 Jul 2022 23:34
(address . bug-guix@gnu.org)
87czeo34b6.fsf@inria.fr
Hi,

The ‘tests/services/telephony.scm’ file exercises procedures that were
removed from (gnu build jami-service) in
85b4dabd94d53f8179f31a42046cd83fc3a352fc, which prevents ‘make check’
from proceeding:

Toggle snippet (17 lines)
$ make check -j5

[...]

PASS: tests/services/file-sharing.scm
PASS: tests/services.scm
PASS: tests/services/linux.scm
make[4]: *** [Makefile:6079: tests/services/telephony.log] Error 1
make[4]: *** Waiting for unfinished jobs....
PASS: tests/sets.scm
PASS: tests/packages.scm
PASS: tests/pack.scm
PASS: tests/lint.scm
make[4]: Leaving directory '/home/ludo/src/guix'
make[3]: *** [Makefile:6061: check-TESTS] Error 2

Should we keep some of the tests in this file, or has it become obsolete
entirely?

Thanks,
Ludo’.
M
M
Maxim Cournoyer wrote on 2 Jul 2022 09:35
Re: bug#56343: ‘tests/service s/telephony.scm’ fails to run
4F922EF9-673A-4EFA-A6C1-54A3140B008F@gmail.com
On July 1, 2022 5:34:37 PM EDT, "Ludovic Courtès" <ludo@gnu.org> wrote:
Toggle quote (28 lines)
>Hi,
>
>The ‘tests/services/telephony.scm’ file exercises procedures that were
>removed from (gnu build jami-service) in
>85b4dabd94d53f8179f31a42046cd83fc3a352fc, which prevents ‘make check’
>from proceeding:
>
>--8<---------------cut here---------------start------------->8---
>$ make check -j5
>
>[...]
>
>PASS: tests/services/file-sharing.scm
>PASS: tests/services.scm
>PASS: tests/services/linux.scm
>make[4]: *** [Makefile:6079: tests/services/telephony.log] Error 1
>make[4]: *** Waiting for unfinished jobs....
>PASS: tests/sets.scm
>PASS: tests/packages.scm
>PASS: tests/pack.scm
>PASS: tests/lint.scm
>make[4]: Leaving directory '/home/ludo/src/guix'
>make[3]: *** [Makefile:6061: check-TESTS] Error 2
>--8<---------------cut here---------------end--------------->8---
>
>Should we keep some of the tests in this file, or has it become obsolete
>entirely?

It isn't obsolete, but I had forgotten there were both unit and functional (system) tests for our Jami seevice. It's probably easy to adjust, I can look into it when I'm back from travels in a few days.

Cheers,

Maxim




Hi,
L
L
Lars-Dominik Braun wrote on 5 Jul 2022 11:27
Re: bug#56343: ‘tests/ser vices/telephony.scm’ fails to run
(name . Maxim Cournoyer)(address . maxim.cournoyer@gmail.com)
YsQECy/c+HFsyXQW@noor.fritz.box
Hi Maxim,

Toggle quote (1 lines)
> It isn't obsolete, but I had forgotten there were both unit and functional (system) tests for our Jami seevice. It's probably easy to adjust, I can look into it when I'm back from travels in a few days.
I had to remove tests/services/telephony.scm from Makefile.am, so
we could update the guix package to fix other issues. Please revert
c23e0aa65d511a29f31da876f905594c0f8bce00 once you’ve fixed the tests.

Thanks,
Lars
M
M
Maxim Cournoyer wrote on 7 Jul 2022 16:45
Re: bug#56343: ‘tests/services/telephony. scm’ fails to run
(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 56343-done@debbugs.gnu.org)
87a69l0ynv.fsf@gmail.com
Hi,

Ludovic Courtès <ludo@gnu.org> writes:

Toggle quote (26 lines)
> Hi,
>
> The ‘tests/services/telephony.scm’ file exercises procedures that were
> removed from (gnu build jami-service) in
> 85b4dabd94d53f8179f31a42046cd83fc3a352fc, which prevents ‘make check’
> from proceeding:
>
> $ make check -j5
>
> [...]
>
> PASS: tests/services/file-sharing.scm
> PASS: tests/services.scm
> PASS: tests/services/linux.scm
> make[4]: *** [Makefile:6079: tests/services/telephony.log] Error 1
> make[4]: *** Waiting for unfinished jobs....
> PASS: tests/sets.scm
> PASS: tests/packages.scm
> PASS: tests/pack.scm
> PASS: tests/lint.scm
> make[4]: Leaving directory '/home/ludo/src/guix'
> make[3]: *** [Makefile:6061: check-TESTS] Error 2
>
> Should we keep some of the tests in this file, or has it become obsolete
> entirely?

I've remove all the parsing tests and kept the others; see
258bc4c4e668e9817471d04d052bc0a8e2d43fa0.

Thanks for the heads-up!

Closing.

Maxim
Closed
L
L
Ludovic Courtès wrote on 8 Jul 2022 10:38
(name . Maxim Cournoyer)(address . maxim.cournoyer@gmail.com)(address . 56343-done@debbugs.gnu.org)
87let4xamt.fsf@gnu.org
Hi,

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

Toggle quote (3 lines)
> I've remove all the parsing tests and kept the others; see
> 258bc4c4e668e9817471d04d052bc0a8e2d43fa0.

Great, thank you!

Ludo’.
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 56343@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 56343
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch