[PATCH] gnu: Add snafu.

  • Done
  • quality assurance status badge
Details
3 participants
  • Efraim Flashner
  • jgart
  • Maxim Cournoyer
Owner
unassigned
Submitted by
jgart
Severity
normal
J
J
jgart wrote on 16 Jun 2022 04:19
(address . guix-patches@gnu.org)(name . jgart)(address . jgart@dismail.de)
20220616021931.19816-1-jgart@dismail.de
* gnu/packages/suckless.scm (snafu): New variable.
---
gnu/packages/suckless.scm | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)

Toggle diff (66 lines)
diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
index 5aa37657b9..e05ae022df 100644
--- a/gnu/packages/suckless.scm
+++ b/gnu/packages/suckless.scm
@@ -12,6 +12,7 @@
;;; Copyright © 2021 Alexandru-Sergiu Marton <brown121407@posteo.ro>
;;; Copyright © 2021 Nikolay Korotkiy <sikmir@disroot.org>
;;; Copyright © 2022 Jai Vetrivelan <jaivetrivelan@gmail.com>
+;;; Copyright © 2022 jgart <jgart@dismail.de>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -32,6 +33,7 @@ (define-module (gnu packages suckless)
#:use-module (gnu packages)
#:use-module (gnu packages base)
#:use-module (gnu packages compression)
+ #:use-module (gnu packages crates-io)
#:use-module (gnu packages cups)
#:use-module (gnu packages fonts)
#:use-module (gnu packages fontutils)
@@ -46,6 +48,7 @@ (define-module (gnu packages suckless)
#:use-module (gnu packages pkg-config)
#:use-module (gnu packages webkit)
#:use-module (gnu packages xorg)
+ #:use-module (guix build-system cargo)
#:use-module (guix build-system glib-or-gtk)
#:use-module (guix build-system gnu)
#:use-module (guix download)
@@ -189,6 +192,35 @@ (define-public slstatus
@end itemize")
(license license:isc))))
+(define-public snafu
+ (let ((commit "da0a5eea31e35aef75c698d1c01f559858c17b0d")
+ (revision "0"))
+ (package
+ (name "snafu")
+ (version commit)
+ (source
+ (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url "https://github.com/jsbmg/snafu")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "1wi857rdqmg4731wzgry06ndfxk8c40yyrf0whk1wlq7p0n6bd3b"))))
+ (arguments
+ `(#:cargo-inputs
+ (("rust-chrono" ,rust-chrono-0.4))
+ #:tests? #f)) ; There are no tests.
+ (build-system cargo-build-system)
+ (home-page "https://github.com/jsbmg/snafu")
+ (synopsis "Status text for dwm window manager")
+ (description
+"@code{snafu} provides status text for dwm's builtin bar on Linux. It
+shows battery status, battery capacity, current WIFI connection, and
+the time in a nice format.")
+ (license license:isc))))
+
(define-public blind
(package
(name "blind")
--
2.36.1
M
M
Maxim Cournoyer wrote on 7 Jul 2022 22:52
(name . jgart)(address . jgart@dismail.de)(address . 56004@debbugs.gnu.org)
87bku0wspi.fsf@gmail.com
Hello,

jgart <jgart@dismail.de> writes:

Toggle quote (44 lines)
> * gnu/packages/suckless.scm (snafu): New variable.
> ---
> gnu/packages/suckless.scm | 32 ++++++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
> diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
> index 5aa37657b9..e05ae022df 100644
> --- a/gnu/packages/suckless.scm
> +++ b/gnu/packages/suckless.scm
> @@ -12,6 +12,7 @@
> ;;; Copyright © 2021 Alexandru-Sergiu Marton <brown121407@posteo.ro>
> ;;; Copyright © 2021 Nikolay Korotkiy <sikmir@disroot.org>
> ;;; Copyright © 2022 Jai Vetrivelan <jaivetrivelan@gmail.com>
> +;;; Copyright © 2022 jgart <jgart@dismail.de>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -32,6 +33,7 @@ (define-module (gnu packages suckless)
> #:use-module (gnu packages)
> #:use-module (gnu packages base)
> #:use-module (gnu packages compression)
> + #:use-module (gnu packages crates-io)
> #:use-module (gnu packages cups)
> #:use-module (gnu packages fonts)
> #:use-module (gnu packages fontutils)
> @@ -46,6 +48,7 @@ (define-module (gnu packages suckless)
> #:use-module (gnu packages pkg-config)
> #:use-module (gnu packages webkit)
> #:use-module (gnu packages xorg)
> + #:use-module (guix build-system cargo)
> #:use-module (guix build-system glib-or-gtk)
> #:use-module (guix build-system gnu)
> #:use-module (guix download)
> @@ -189,6 +192,35 @@ (define-public slstatus
> @end itemize")
> (license license:isc))))
>
> +(define-public snafu
> + (let ((commit "da0a5eea31e35aef75c698d1c01f559858c17b0d")
> + (revision "0"))
> + (package
> + (name "snafu")
> + (version commit)

You'd need write a proper monotonically increasing version via
'git-version', as hinted in info '(guix) Version Numbers'.

Toggle quote (18 lines)
> + (source
> + (origin
> + (method git-fetch)
> + (uri
> + (git-reference
> + (url "https://github.com/jsbmg/snafu")
> + (commit commit)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "1wi857rdqmg4731wzgry06ndfxk8c40yyrf0whk1wlq7p0n6bd3b"))))
> + (arguments
> + `(#:cargo-inputs
> + (("rust-chrono" ,rust-chrono-0.4))
> + #:tests? #f)) ; There are no tests.
> + (build-system cargo-build-system)
> + (home-page "https://github.com/jsbmg/snafu")
> + (synopsis "Status text for dwm window manager")

Fully capitalize DWM.

Toggle quote (3 lines)
> + (description
> +"@code{snafu} provides status text for dwm's builtin bar on Linux. It

Remove "on Linux", extraneous information on GNU Guix.

Toggle quote (2 lines)
> +shows battery status, battery capacity, current WIFI connection, and

The proper "acronym" capitalization is WiFi.

Could you send a revised patch?

Thanks,

Maxim
M
M
Maxim Cournoyer wrote on 7 Jul 2022 22:53
control message for bug #56004
(address . control@debbugs.gnu.org)
87a69kwsp4.fsf@gmail.com
tags 56004 + moreinfo
quit
J
J
jgart wrote on 27 Aug 2022 17:53
[PATCH v2] gnu: Add snafu.
(address . 56004@debbugs.gnu.org)
20220827155326.26026-1-jgart@dismail.de
* gnu/packages/suckless.scm (snafu): New variable.

Here's v2 with your suggestions added. Thanks!
---
gnu/packages/suckless.scm | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)

Toggle diff (58 lines)
diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
index dbc3537ac6..d971de10f0 100644
--- a/gnu/packages/suckless.scm
+++ b/gnu/packages/suckless.scm
@@ -33,6 +33,7 @@
(define-module (gnu packages suckless)
#:use-module (gnu packages)
#:use-module (gnu packages base)
+ #:use-module (gnu packages crates-io)
#:use-module (gnu packages compression)
#:use-module (gnu packages cups)
#:use-module (gnu packages fonts)
@@ -49,6 +50,7 @@ (define-module (gnu packages suckless)
#:use-module (gnu packages pkg-config)
#:use-module (gnu packages webkit)
#:use-module (gnu packages xorg)
+ #:use-module (guix build-system cargo)
#:use-module (guix build-system glib-or-gtk)
#:use-module (guix build-system gnu)
#:use-module (guix download)
@@ -1182,6 +1184,35 @@ (define-public farbfeld
(home-page "https://git.suckless.org/farbfeld/")
(license license:isc))))
+(define-public snafu
+ (let ((commit "e436fb4f61ca93a4ec85122506b2c2d4fec30eb6")
+ (revision "0"))
+ (package
+ (name "snafu")
+ (version (git-version "0.0.0" revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url "https://github.com/jsbmg/snafu")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "1c6ahxw0qz0703my28k2z0kgi0am5bp5d02l4rgyphgvjk1jfv8h"))))
+ (arguments
+ `(#:cargo-inputs
+ (("rust-chrono" ,rust-chrono-0.4))
+ #:tests? #f)) ; There are no tests.
+ (build-system cargo-build-system)
+ (home-page "https://github.com/jsbmg/snafu")
+ (synopsis "Status text for DWM window manager")
+ (description
+"@code{snafu} provides status text for DWM's builtin bar. It
+shows battery status, battery capacity, current WiFi connection, and
+the time in a nice format.")
+ (license license:isc))))
+
(define-public svkbd
(package
(name "svkbd")
--
2.37.2
E
E
Efraim Flashner wrote on 1 Sep 2022 10:18
(name . jgart)(address . jgart@dismail.de)
YxBqyeTKQsFL5aqc@3900XT
Thanks. Patch pushed!

--
Efraim Flashner <efraim@flashner.co.il> ????? ?????
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmMQasgACgkQQarn3Mo9
g1HI1BAAt0Lq4SrkVq/MeSNGNdzAhzBo1BRNC/SXNX8oElsfeY7vHLRwUl4nV8gR
i8cqVXSELbTlPUOAZEEsiotFJ8Yuj4sH5td/2+tTzQ6m1sd6YZTjphF6IVl8m8WK
LJzBdsbIoltW5/jxu5FbMhHd+l7U1TaVXEIK/TVLr18tke/oDmppCd8hLrv9nLI1
ZP4ntL7Fs3U2q4SgOjb2/jZJ1xwtuCGpHdtMzxWpyYL++a3FZSbpW919qU3eXZPE
3jae2qtNyF6bnTH+IgXTkMqdF1xsaEhbvfia3W+bVQDrBusNsAvjHI7CEldbwy3y
+o5LeXIsIAmTxKQcAulZOOfpjtkbkXfC5ZWUSfyWqdhFh5s73ql9p5Sm7RjUwz4a
QhD1NbFLzXYXHP1qZbGrQz6y43HVvofpnX2gGL/0yNdRpZp3q37IQ4Tp0QSgzby4
GqYqfTHQHDdKvtpBAeBiJi0Sbe0A4Q3CzNaGT6QiDgJtUH+WbHddf13celOOLiSA
upK9WX53Rudix5Yxyo9mWVBaFF1hUko6ePu/zIclvNJTPWQfvKS+P9ZZ+Rght9Kf
N60jnLjkURnBoz2ESU52Qer1DaeVeXyXqg/PplGMhIMKNft90oDGmOQvDsNdNwe4
7UhNOvNyvu1WFZ3FmH+3yALBdIehaCIFNs26/SOLvrtSGvZqQ50=
=nOkb
-----END PGP SIGNATURE-----


Closed
?